[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=321233=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321233
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 01/Oct/19 12:54
Start Date: 01/Oct/19 12:54
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-537022606
Thanks, LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 321233)
Time Spent: 4h 40m (was: 4.5h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=321235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321235
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 01/Oct/19 12:54
Start Date: 01/Oct/19 12:54
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9640:
[BEAM-8300]: KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 321235)
Time Spent: 4h 50m (was: 4h 40m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=320670=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320670
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 30/Sep/19 16:59
Start Date: 30/Sep/19 16:59
Worklog Time Spent: 10m
Work Description: jhalaria commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-536653666
@aromanenko-dev - Updated the commit message. Sorry I was out for a couple
of days, otherwise would have done it sooner.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 320670)
Time Spent: 4.5h (was: 4h 20m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319428
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 27/Sep/19 09:11
Start Date: 27/Sep/19 09:11
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535860288
@jhalaria Thanks! Just one small thing - please, add a prefix `[BEAM-8300] `
to your commit message (this is common Beam rule for commits naming) and I'l
merge it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319428)
Time Spent: 4h 20m (was: 4h 10m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319207=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319207
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 20:48
Start Date: 26/Sep/19 20:48
Worklog Time Spent: 10m
Work Description: jhalaria commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535680190
Thanks @aromanenko-dev . Build is happy now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319207)
Time Spent: 4h 10m (was: 4h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319064=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319064
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:21
Start Date: 26/Sep/19 16:21
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fix failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() throws Exception {
if (producer != null && producer.getOutstandingRecordsCount() > 0) {
producer.flushSync();
}
producer = null;
}
```
and change `new UnsupportedOperationException` in
`KinesisProducerMock.flushSync()` to just `flush()` call.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319064)
Time Spent: 4h (was: 3h 50m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319063=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319063
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:21
Start Date: 26/Sep/19 16:21
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fix failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() throws Exception {
if (producer != null && producer.getOutstandingRecordsCount() > 0) {
producer.flushSync();
}
producer = null;
}
```
and change `UnsupportedOperationException` from
`KinesisProducerMock.flushSync()` to just `flush()` call
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319063)
Time Spent: 3h 50m (was: 3h 40m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319062=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319062
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:19
Start Date: 26/Sep/19 16:19
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fix failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() throws Exception {
if (producer != null && producer.getOutstandingRecordsCount() > 0) {
producer.flushSync();
}
producer = null;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319062)
Time Spent: 3h 40m (was: 3.5h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319061=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319061
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:18
Start Date: 26/Sep/19 16:18
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fix failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() throws Exception {
if (producer != null) {
if (producer.getOutstandingRecordsCount() > 0) {
producer.flushSync();
}
producer = null;
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319061)
Time Spent: 3.5h (was: 3h 20m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319060=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319060
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:16
Start Date: 26/Sep/19 16:16
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fix failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() throws Exception {
if (producer != null) {
producer.flushSync();
producer = null;
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319060)
Time Spent: 3h 20m (was: 3h 10m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319053=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319053
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:07
Start Date: 26/Sep/19 16:07
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fox failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() throws Exception {
producer = null;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319053)
Time Spent: 2h 50m (was: 2h 40m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319055=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319055
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:07
Start Date: 26/Sep/19 16:07
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fix failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() {
producer = null;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319055)
Time Spent: 3h 10m (was: 3h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=319054=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319054
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 26/Sep/19 16:07
Start Date: 26/Sep/19 16:07
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535574848
@jhalaria To fix failed test, I think you need to add `tearDown` method into
`KinesisWriterFn`, like:
```
@Teardown
public void teardown() throws Exception {
producer = null;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 319054)
Time Spent: 3h (was: 2h 50m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=318491=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318491
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 25/Sep/19 17:56
Start Date: 25/Sep/19 17:56
Worklog Time Spent: 10m
Work Description: jhalaria commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535138239
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318491)
Time Spent: 2h 40m (was: 2.5h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=318467=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318467
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 25/Sep/19 17:24
Start Date: 25/Sep/19 17:24
Worklog Time Spent: 10m
Work Description: jhalaria commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535125867
Run Java_Examples_Dataflow PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318467)
Time Spent: 2h 20m (was: 2h 10m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=318468=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318468
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 25/Sep/19 17:24
Start Date: 25/Sep/19 17:24
Worklog Time Spent: 10m
Work Description: jhalaria commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535125867
Run Java_Examples_Dataflow PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318468)
Time Spent: 2.5h (was: 2h 20m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=318450=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318450
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 25/Sep/19 16:44
Start Date: 25/Sep/19 16:44
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-535109989
Run Java_Examples_Dataflow PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318450)
Time Spent: 2h 10m (was: 2h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=318358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318358
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 25/Sep/19 14:23
Start Date: 25/Sep/19 14:23
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9640:
[BEAM-8300]: KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r328100901
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
Thanks, though I see that the test
`org.apache.beam.sdk.io.kinesis.KinesisMockWriteTest.testWriteFailed` started
to fail (see [Java PreCommit
check](https://builds.apache.org/job/beam_PreCommit_Java_Commit/7864/testReport/junit/org.apache.beam.sdk.io.kinesis/KinesisMockWriteTest/testWriteFailed/))
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318358)
Time Spent: 2h (was: 1h 50m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=318302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318302
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 25/Sep/19 12:47
Start Date: 25/Sep/19 12:47
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9640:
[BEAM-8300]: KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r328100901
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
Thanks, though I see that the test
`org.apache.beam.sdk.io.kinesis.KinesisMockWriteTest.testWriteFailed` started
failing (see Java PreCommit check)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318302)
Time Spent: 1h 50m (was: 1h 40m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317856=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317856
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 21:20
Start Date: 24/Sep/19 21:20
Worklog Time Spent: 10m
Work Description: jhalaria commented on pull request #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r327839729
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
@aromanenko-dev - Please look at the changes one more time. Thank you.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317856)
Time Spent: 1h 40m (was: 1.5h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317664=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317664
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 17:03
Start Date: 24/Sep/19 17:03
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9640:
[BEAM-8300]: KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r327729793
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
To avoid code duplication, I suggest to move this `if (producer ==
null){...}` block into `initKinesisProducer()`, so it will be lazy producer
initialisation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317664)
Time Spent: 1.5h (was: 1h 20m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317657=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317657
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 16:59
Start Date: 24/Sep/19 16:59
Worklog Time Spent: 10m
Work Description: jhalaria commented on pull request #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r327728185
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
I will add the check in startBundle and verify that it does the same thing
as readObject. Yeah, I think this wouldn't be caught in a unit test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317657)
Time Spent: 1h 20m (was: 1h 10m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317552
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 14:51
Start Date: 24/Sep/19 14:51
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9640:
[BEAM-8300]: KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r327662059
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
I meant just to add this check:
```
if (producer == null) {
initKinesisProducer();
}
```
directly into `KinesisWriterFn.startBundle()`. Beam will guarantee that the
whole bundle will be processed on the same worker and the object won't be
serialised/deserialised until
this bundle will be finished. Though, I think `readObject` should do the
same job. Wdyt?
Regarding the test, I believe that all Kinesis.Write tests are in
`KinesisMockWriteTest`, but now I started to doubt if it's possible to test
such regression in unit tests. Wdyt?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317552)
Time Spent: 1h 10m (was: 1h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317529=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317529
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 14:19
Start Date: 24/Sep/19 14:19
Worklog Time Spent: 10m
Work Description: jhalaria commented on pull request #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r327642672
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
Thank you for looking into this. Do you mean add this check in startBundle()
and then call initKinesisProducer directly in readObject? And for the
regression test, may I get a pointer to the class where that would be
appropriate to add?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317529)
Time Spent: 1h (was: 50m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317513=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317513
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 14:13
Start Date: 24/Sep/19 14:13
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9640:
[BEAM-8300]: KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r327636475
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
Don't you think that it would be better to do this check in `startBundle()`
since the whole bundle will be processed entirely on one worker?
Also, it would be great to have a regression test for this case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317513)
Time Spent: 50m (was: 40m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317508=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317508
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 14:11
Start Date: 24/Sep/19 14:11
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9640:
[BEAM-8300]: KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#discussion_r327636475
##
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##
@@ -633,6 +634,13 @@ private synchronized void initKinesisProducer() {
producer = spec.getAWSClientsProvider().createKinesisProducer(config);
}
+ private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
+is.defaultReadObject();
+if (producer == null) {
Review comment:
Don't you think that it would be better to do this check in `startBundle()`?
Also, it would be great to have a regression test for this case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317508)
Time Spent: 40m (was: 0.5h)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=317254=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317254
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 24/Sep/19 08:17
Start Date: 24/Sep/19 08:17
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-534447675
Passing the review to @aromanenko-dev
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 317254)
Time Spent: 0.5h (was: 20m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[
https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=316875=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316875
]
ASF GitHub Bot logged work on BEAM-8300:
Author: ASF GitHub Bot
Created on: 23/Sep/19 17:56
Start Date: 23/Sep/19 17:56
Worklog Time Spent: 10m
Work Description: jhalaria commented on issue #9640: [BEAM-8300]:
KinesisIO.write throws NPE because producer is null
URL: https://github.com/apache/beam/pull/9640#issuecomment-534212637
@iemejia - Please review.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 316875)
Time Spent: 20m (was: 10m)
> KinesisIO.write causes NPE as the producer is null
> --
>
> Key: BEAM-8300
> URL: https://issues.apache.org/jira/browse/BEAM-8300
> Project: Beam
> Issue Type: Bug
> Components: io-java-kinesis
>Affects Versions: 2.15.0
>Reporter: Ankit Jhalaria
>Assignee: Ankit Jhalaria
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While using KinesisIO.write(), we encountered a NPE with the following stack
> trace
> {code:java}
> org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:297)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:93)\n\tat
>
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:57)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.SourceStreamTask.run(SourceStreamTask.java:97)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StoppableSourceStreamTask.run(StoppableSourceStreamTask.java:45)\n\tat
>
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:300)\n\tat
> org.apache.flink.runtime.taskmanager.Task.run(Task.java:711)\n\tat
> java.lang.Thread.run(Thread.java:748)\nCaused by:
> java.lang.NullPointerException: null\n\tat
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.flushBundle(KinesisIO.java:685)\n\tat
>
> org.apache.beam.sdk.io.kinesis.KinesisIO$Write$KinesisWriterFn.finishBundle(KinesisIO.java:669){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8300) KinesisIO.write causes NPE as the producer is null
[ https://issues.apache.org/jira/browse/BEAM-8300?focusedWorklogId=316871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316871 ] ASF GitHub Bot logged work on BEAM-8300: Author: ASF GitHub Bot Created on: 23/Sep/19 17:49 Start Date: 23/Sep/19 17:49 Worklog Time Spent: 10m Work Description: jhalaria commented on pull request #9640: [BEAM-8300]: KinesisIO.write throws NPE because producer is null URL: https://github.com/apache/beam/pull/9640 Added a readObject method to initialize the transient producer Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[