[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=362750=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362750 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 23/Dec/19 21:30 Start Date: 23/Dec/19 21:30 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10432: [BEAM-9005] Setting environment ID for ParDo and Combine transforms URL: https://github.com/apache/beam/pull/10432#issuecomment-568586219 https://github.com/apache/beam/pull/10453 should fix Flink and Spark VR tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 362750) Time Spent: 1h 40m (was: 1.5h) > Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183 > - > > Key: BEAM-9005 > URL: https://issues.apache.org/jira/browse/BEAM-9005 > Project: Beam > Issue Type: Bug > Components: sdk-go >Reporter: Chamikara Madhusanka Jayalath >Assignee: Chamikara Madhusanka Jayalath >Priority: Critical > Fix For: Not applicable > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Looking into this. > > cc: [~bhulette] [~lostluck] [~danoliveira] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361949 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 20/Dec/19 23:05 Start Date: 20/Dec/19 23:05 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10443: [BEAM-9005] Fixes Go formatting URL: https://github.com/apache/beam/pull/10443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361949) Time Spent: 1.5h (was: 1h 20m) > Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183 > - > > Key: BEAM-9005 > URL: https://issues.apache.org/jira/browse/BEAM-9005 > Project: Beam > Issue Type: Bug > Components: sdk-go >Reporter: Chamikara Madhusanka Jayalath >Assignee: Chamikara Madhusanka Jayalath >Priority: Critical > Time Spent: 1.5h > Remaining Estimate: 0h > > Looking into this. > > cc: [~bhulette] [~lostluck] [~danoliveira] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361948=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361948 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 20/Dec/19 23:05 Start Date: 20/Dec/19 23:05 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10443: [BEAM-9005] Fixes Go formatting URL: https://github.com/apache/beam/pull/10443#issuecomment-568119545 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361948) Time Spent: 1h 20m (was: 1h 10m) > Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183 > - > > Key: BEAM-9005 > URL: https://issues.apache.org/jira/browse/BEAM-9005 > Project: Beam > Issue Type: Bug > Components: sdk-go >Reporter: Chamikara Madhusanka Jayalath >Assignee: Chamikara Madhusanka Jayalath >Priority: Critical > Time Spent: 1h 20m > Remaining Estimate: 0h > > Looking into this. > > cc: [~bhulette] [~lostluck] [~danoliveira] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[
https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361887=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361887
]
ASF GitHub Bot logged work on BEAM-9005:
Author: ASF GitHub Bot
Created on: 20/Dec/19 21:49
Start Date: 20/Dec/19 21:49
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #10432:
[BEAM-9005] Setting environment ID for ParDo and Combine transforms
URL: https://github.com/apache/beam/pull/10432#discussion_r360586766
##
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##
@@ -268,6 +269,7 @@ func (m *marshaller) addMultiEdge(edge NamedEdge) []string
{
},
SideInputs: si,
}
+transformEnvID = m.addDefaultEnv()
Review comment:
Sent out https://github.com/apache/beam/pull/10443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 361887)
Time Spent: 1h 10m (was: 1h)
> Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
> -
>
> Key: BEAM-9005
> URL: https://issues.apache.org/jira/browse/BEAM-9005
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
>Reporter: Chamikara Madhusanka Jayalath
>Assignee: Chamikara Madhusanka Jayalath
>Priority: Critical
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Looking into this.
>
> cc: [~bhulette] [~lostluck] [~danoliveira]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361886=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361886 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 20/Dec/19 21:49 Start Date: 20/Dec/19 21:49 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10443: [BEAM-9005] Fixes Go formatting URL: https://github.com/apache/beam/pull/10443#issuecomment-568100417 R: @lostluck or @youngoli This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361886) Time Spent: 1h (was: 50m) > Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183 > - > > Key: BEAM-9005 > URL: https://issues.apache.org/jira/browse/BEAM-9005 > Project: Beam > Issue Type: Bug > Components: sdk-go >Reporter: Chamikara Madhusanka Jayalath >Assignee: Chamikara Madhusanka Jayalath >Priority: Critical > Time Spent: 1h > Remaining Estimate: 0h > > Looking into this. > > cc: [~bhulette] [~lostluck] [~danoliveira] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361885=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361885 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 20/Dec/19 21:49 Start Date: 20/Dec/19 21:49 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10443: [BEAM-9005] Fixes Go formatting URL: https://github.com/apache/beam/pull/10443 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[![Build
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[
https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361869=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361869
]
ASF GitHub Bot logged work on BEAM-9005:
Author: ASF GitHub Bot
Created on: 20/Dec/19 21:22
Start Date: 20/Dec/19 21:22
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #10432: [BEAM-9005]
Setting environment ID for ParDo and Combine transforms
URL: https://github.com/apache/beam/pull/10432#discussion_r360235448
##
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##
@@ -268,6 +269,7 @@ func (m *marshaller) addMultiEdge(edge NamedEdge) []string
{
},
SideInputs: si,
}
+transformEnvID = m.addDefaultEnv()
Review comment:
Please run gofmt. This is using be spaces but it should be tabs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 361869)
Time Spent: 40m (was: 0.5h)
> Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
> -
>
> Key: BEAM-9005
> URL: https://issues.apache.org/jira/browse/BEAM-9005
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
>Reporter: Chamikara Madhusanka Jayalath
>Assignee: Chamikara Madhusanka Jayalath
>Priority: Critical
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Looking into this.
>
> cc: [~bhulette] [~lostluck] [~danoliveira]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361853=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361853 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 20/Dec/19 20:49 Start Date: 20/Dec/19 20:49 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10432: [BEAM-9005] Setting environment ID for ParDo and Combine transforms URL: https://github.com/apache/beam/pull/10432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361853) Time Spent: 0.5h (was: 20m) > Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183 > - > > Key: BEAM-9005 > URL: https://issues.apache.org/jira/browse/BEAM-9005 > Project: Beam > Issue Type: Bug > Components: sdk-go >Reporter: Chamikara Madhusanka Jayalath >Assignee: Chamikara Madhusanka Jayalath >Priority: Critical > Time Spent: 0.5h > Remaining Estimate: 0h > > Looking into this. > > cc: [~bhulette] [~lostluck] [~danoliveira] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361852=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361852 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 20/Dec/19 20:49 Start Date: 20/Dec/19 20:49 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10432: [BEAM-9005] Setting environment ID for ParDo and Combine transforms URL: https://github.com/apache/beam/pull/10432#issuecomment-568082121 Thanks. Yeah, will look into the Flink VR Postcommit failure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361852) Time Spent: 20m (was: 10m) > Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183 > - > > Key: BEAM-9005 > URL: https://issues.apache.org/jira/browse/BEAM-9005 > Project: Beam > Issue Type: Bug > Components: sdk-go >Reporter: Chamikara Madhusanka Jayalath >Assignee: Chamikara Madhusanka Jayalath >Priority: Critical > Time Spent: 20m > Remaining Estimate: 0h > > Looking into this. > > cc: [~bhulette] [~lostluck] [~danoliveira] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9005) Go SDK post-commit failures due to https://github.com/apache/beam/pull/10183
[ https://issues.apache.org/jira/browse/BEAM-9005?focusedWorklogId=361515=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361515 ] ASF GitHub Bot logged work on BEAM-9005: Author: ASF GitHub Bot Created on: 20/Dec/19 04:55 Start Date: 20/Dec/19 04:55 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10432: [BEAM-9005] Setting environment ID for ParDo and Combine transforms URL: https://github.com/apache/beam/pull/10432 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[