[jira] [Work logged] (BEAM-9431) test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not supported with streaming engine
[ https://issues.apache.org/jira/browse/BEAM-9431?focusedWorklogId=401539=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401539 ] ASF GitHub Bot logged work on BEAM-9431: Author: ASF GitHub Bot Created on: 11/Mar/20 16:00 Start Date: 11/Mar/20 16:00 Worklog Time Spent: 10m Work Description: Ardagan commented on pull request #11033: [BEAM-9431] Remove ReadFromPubSub/Read-out0-ElementCount from the met… URL: https://github.com/apache/beam/pull/11033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 401539) Time Spent: 1h 10m (was: 1h) > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not > supported with streaming engine > - > > Key: BEAM-9431 > URL: https://issues.apache.org/jira/browse/BEAM-9431 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, testing >Reporter: Ankur Goenka >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is failing on > Dataflow V2 as ReadFromPubSub/Read-out0-ElementCount is not implemented in > with streaming engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9431) test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not supported with streaming engine
[ https://issues.apache.org/jira/browse/BEAM-9431?focusedWorklogId=400507=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400507 ] ASF GitHub Bot logged work on BEAM-9431: Author: ASF GitHub Bot Created on: 10/Mar/20 01:55 Start Date: 10/Mar/20 01:55 Worklog Time Spent: 10m Work Description: angoenka commented on issue #11033: [BEAM-9431] Remove ReadFromPubSub/Read-out0-ElementCount from the met… URL: https://github.com/apache/beam/pull/11033#issuecomment-596861410 @Ardagan Friendly ping. Do the change look good? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 400507) Time Spent: 1h (was: 50m) > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not > supported with streaming engine > - > > Key: BEAM-9431 > URL: https://issues.apache.org/jira/browse/BEAM-9431 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, testing >Reporter: Ankur Goenka >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is failing on > Dataflow V2 as ReadFromPubSub/Read-out0-ElementCount is not implemented in > with streaming engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9431) test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not supported with streaming engine
[ https://issues.apache.org/jira/browse/BEAM-9431?focusedWorklogId=399345=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399345 ] ASF GitHub Bot logged work on BEAM-9431: Author: ASF GitHub Bot Created on: 06/Mar/20 20:10 Start Date: 06/Mar/20 20:10 Worklog Time Spent: 10m Work Description: angoenka commented on issue #11033: [BEAM-9431] Remove ReadFromPubSub/Read-out0-ElementCount from the met… URL: https://github.com/apache/beam/pull/11033#issuecomment-595945428 I think the counters are not available on streaming engine and only published with streaming appliance so it will not be a valid test to have them. cc/ @ananvay This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 399345) Time Spent: 50m (was: 40m) > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not > supported with streaming engine > - > > Key: BEAM-9431 > URL: https://issues.apache.org/jira/browse/BEAM-9431 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, testing >Reporter: Ankur Goenka >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is failing on > Dataflow V2 as ReadFromPubSub/Read-out0-ElementCount is not implemented in > with streaming engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9431) test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not supported with streaming engine
[ https://issues.apache.org/jira/browse/BEAM-9431?focusedWorklogId=397097=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397097 ] ASF GitHub Bot logged work on BEAM-9431: Author: ASF GitHub Bot Created on: 03/Mar/20 22:49 Start Date: 03/Mar/20 22:49 Worklog Time Spent: 10m Work Description: Ardagan commented on issue #11033: [BEAM-9431] Remove ReadFromPubSub/Read-out0-ElementCount from the met… URL: https://github.com/apache/beam/pull/11033#issuecomment-594211677 Can you elaborate a bit more on why we remove counter validation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 397097) Time Spent: 40m (was: 0.5h) > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not > supported with streaming engine > - > > Key: BEAM-9431 > URL: https://issues.apache.org/jira/browse/BEAM-9431 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, testing >Reporter: Ankur Goenka >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is failing on > Dataflow V2 as ReadFromPubSub/Read-out0-ElementCount is not implemented in > with streaming engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9431) test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not supported with streaming engine
[ https://issues.apache.org/jira/browse/BEAM-9431?focusedWorklogId=397043=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397043 ] ASF GitHub Bot logged work on BEAM-9431: Author: ASF GitHub Bot Created on: 03/Mar/20 21:07 Start Date: 03/Mar/20 21:07 Worklog Time Spent: 10m Work Description: ananvay commented on issue #11033: [BEAM-9431] Remove ReadFromPubSub/Read-out0-ElementCount from the met… URL: https://github.com/apache/beam/pull/11033#issuecomment-594168837 LGTM. Thanks Ankur! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 397043) Time Spent: 0.5h (was: 20m) > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not > supported with streaming engine > - > > Key: BEAM-9431 > URL: https://issues.apache.org/jira/browse/BEAM-9431 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, testing >Reporter: Ankur Goenka >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is failing on > Dataflow V2 as ReadFromPubSub/Read-out0-ElementCount is not implemented in > with streaming engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9431) test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not supported with streaming engine
[ https://issues.apache.org/jira/browse/BEAM-9431?focusedWorklogId=397042=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397042 ] ASF GitHub Bot logged work on BEAM-9431: Author: ASF GitHub Bot Created on: 03/Mar/20 21:06 Start Date: 03/Mar/20 21:06 Worklog Time Spent: 10m Work Description: angoenka commented on issue #11033: [BEAM-9431] Remove ReadFromPubSub/Read-out0-ElementCount from the met… URL: https://github.com/apache/beam/pull/11033#issuecomment-594168585 R: @Ardagan @ananvay @acrites This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 397042) Time Spent: 20m (was: 10m) > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not > supported with streaming engine > - > > Key: BEAM-9431 > URL: https://issues.apache.org/jira/browse/BEAM-9431 > Project: Beam > Issue Type: Bug > Components: runner-dataflow, testing >Reporter: Ankur Goenka >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is failing on > Dataflow V2 as ReadFromPubSub/Read-out0-ElementCount is not implemented in > with streaming engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9431) test_streaming_pipeline_returns_expected_user_metrics_fnapi_it is not supported with streaming engine
[ https://issues.apache.org/jira/browse/BEAM-9431?focusedWorklogId=397040=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397040 ] ASF GitHub Bot logged work on BEAM-9431: Author: ASF GitHub Bot Created on: 03/Mar/20 21:06 Start Date: 03/Mar/20 21:06 Worklog Time Spent: 10m Work Description: angoenka commented on pull request #11033: [BEAM-9431] Remove ReadFromPubSub/Read-out0-ElementCount from the met… URL: https://github.com/apache/beam/pull/11033 …rics validation **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[