[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=443924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443924 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 10/Jun/20 18:43 Start Date: 10/Jun/20 18:43 Worklog Time Spent: 10m Work Description: aromanenko-dev merged pull request #11396: URL: https://github.com/apache/beam/pull/11396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 443924) Time Spent: 5h 40m (was: 5.5h) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 5h 40m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=443812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443812 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 10/Jun/20 15:47 Start Date: 10/Jun/20 15:47 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-642096389 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 443812) Time Spent: 5.5h (was: 5h 20m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 5.5h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=443613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443613 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 10/Jun/20 08:52 Start Date: 10/Jun/20 08:52 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-641853251 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 443613) Time Spent: 5h 20m (was: 5h 10m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 5h 20m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=443231&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443231 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 09/Jun/20 16:44 Start Date: 09/Jun/20 16:44 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-640562379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 443231) Time Spent: 5h 10m (was: 5h) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 5h 10m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=443149&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443149 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 09/Jun/20 16:36 Start Date: 09/Jun/20 16:36 Worklog Time Spent: 10m Work Description: Akshay-Iyangar commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-640828807 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 443149) Time Spent: 5h (was: 4h 50m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 5h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=442684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442684 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 09/Jun/20 15:47 Start Date: 09/Jun/20 15:47 Worklog Time Spent: 10m Work Description: aromanenko-dev removed a comment on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-640562379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442684) Time Spent: 4h 50m (was: 4h 40m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 4h 50m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=442611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442611 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 08/Jun/20 08:56 Start Date: 08/Jun/20 08:56 Worklog Time Spent: 10m Work Description: Akshay-Iyangar commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-640467446 @aromanenko-dev - Addressed the feedback !! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442611) Time Spent: 4h 40m (was: 4.5h) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 4h 40m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=441418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441418 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 04/Jun/20 17:04 Start Date: 04/Jun/20 17:04 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638984333 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441418) Time Spent: 4h 20m (was: 4h 10m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 4h 20m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=441419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441419 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 04/Jun/20 17:04 Start Date: 04/Jun/20 17:04 Worklog Time Spent: 10m Work Description: aromanenko-dev removed a comment on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441419) Time Spent: 4.5h (was: 4h 20m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 4.5h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=441417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441417 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 04/Jun/20 17:04 Start Date: 04/Jun/20 17:04 Worklog Time Spent: 10m Work Description: aromanenko-dev removed a comment on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441417) Time Spent: 4h 10m (was: 4h) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 4h 10m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=441416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441416 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 04/Jun/20 17:04 Start Date: 04/Jun/20 17:04 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441416) Time Spent: 4h (was: 3h 50m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 4h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=441413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441413
]
ASF GitHub Bot logged work on BEAM-9742:
Author: ASF GitHub Bot
Created on: 04/Jun/20 17:03
Start Date: 04/Jun/20 17:03
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r435399974
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -1217,6 +1297,16 @@ void set(
return toBuilder().setRetryStrategy(retryStrategy).build();
}
+/**
+ * When a SQL exception occurs, {@link Write} uses this {@link
RetryConfiguration} to
+ * exponentially back off and retry the statements based on the {@link
RetryConfiguration}
+ * mentioned.
Review comment:
It would helpful to provide a simple example of using - here or in
`JdbcIO` class Javadoc.
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -903,6 +907,72 @@ public void teardown() throws Exception {
}
}
+ /**
+ * Builder used to help with retry configuration for {@link JdbcIO}. The
retry configuration
+ * accepts maxAttempts and maxDuration for {@link FluentBackoff}.
+ */
+ @AutoValue
+ public abstract static class RetryConfiguration implements Serializable {
+
+abstract int getMaxAttempts();
+
+@Nullable
+abstract Duration getMaxDuration();
+
+@Nullable
+abstract Duration getInitialDuration();
+
+abstract RetryConfiguration.Builder builder();
+
+@AutoValue.Builder
+abstract static class Builder {
+ abstract Builder setMaxAttempts(int maxAttempts);
+
+ abstract Builder setMaxDuration(Duration maxDuration);
+
+ abstract Builder setInitialDuration(Duration initialDuration);
+
+ abstract RetryConfiguration build();
+}
+
+public static RetryConfiguration create(int maxAttempts) {
+ checkArgument(maxAttempts > 0, "maxAttempts must be greater than 0");
+ return create(maxAttempts, DEFAULT_MAX_CUMULATIVE_BACKOFF,
DEFAULT_INITIAL_BACKOFF);
+}
+
+public static RetryConfiguration create(int maxAttempts, Duration
maxDuration) {
+ checkArgument(maxAttempts > 0, "maxAttempts must be greater than 0");
+ checkArgument(
+ maxDuration != null && maxDuration.isLongerThan(Duration.ZERO),
+ "maxDuration must be greater than 0");
+ return create(maxAttempts, maxDuration, DEFAULT_INITIAL_BACKOFF);
+}
+
+public static RetryConfiguration create(Duration initialDuration, int
maxAttempts) {
Review comment:
It's a bit confusing for user to have the overloaded methods where the
same argument (eg, `maxAttempts`) changes its positions. I'd prefer to leave
only one method `create()` with all three arguments to provide - `create(int
maxAttempts, Duration maxDuration, Duration initialDuration)`.
Also, make `DEFAULT_INITIAL_BACKOFF ` and `DEFAULT_MAX_CUMULATIVE_BACKOFF`
as the constants of `RetryConfiguration` and make them public.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441413)
Time Spent: 3.5h (was: 3h 20m)
> Add ability to pass FluentBackoff to JdbcIo.Write
> -
>
> Key: BEAM-9742
> URL: https://issues.apache.org/jira/browse/BEAM-9742
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
>Reporter: Akshay Iyangar
>Assignee: Akshay Iyangar
>Priority: P3
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=441414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441414
]
ASF GitHub Bot logged work on BEAM-9742:
Author: ASF GitHub Bot
Created on: 04/Jun/20 17:03
Start Date: 04/Jun/20 17:03
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r435399974
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -1217,6 +1297,16 @@ void set(
return toBuilder().setRetryStrategy(retryStrategy).build();
}
+/**
+ * When a SQL exception occurs, {@link Write} uses this {@link
RetryConfiguration} to
+ * exponentially back off and retry the statements based on the {@link
RetryConfiguration}
+ * mentioned.
Review comment:
It would be helpful to provide a simple example of usage - here or in
`JdbcIO` class Javadoc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441414)
Time Spent: 3h 40m (was: 3.5h)
> Add ability to pass FluentBackoff to JdbcIo.Write
> -
>
> Key: BEAM-9742
> URL: https://issues.apache.org/jira/browse/BEAM-9742
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
>Reporter: Akshay Iyangar
>Assignee: Akshay Iyangar
>Priority: P3
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=441415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441415 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 04/Jun/20 17:03 Start Date: 04/Jun/20 17:03 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441415) Time Spent: 3h 50m (was: 3h 40m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 3h 50m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=440477&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440477 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 02/Jun/20 21:59 Start Date: 02/Jun/20 21:59 Worklog Time Spent: 10m Work Description: Akshay-Iyangar commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-637828525 @aromanenko-dev @lukecwik could you'll please have a look? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440477) Time Spent: 3h 20m (was: 3h 10m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 3h 20m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=439934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439934 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 02/Jun/20 06:43 Start Date: 02/Jun/20 06:43 Worklog Time Spent: 10m Work Description: Akshay-Iyangar opened a new pull request #11396: URL: https://github.com/apache/beam/pull/11396 Add Configurable FluentBackoff to JdbcIO Write [Jira ticket](https://issues.apache.org/jira/browse/BEAM-9742) Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRu
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=439933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439933 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 02/Jun/20 06:42 Start Date: 02/Jun/20 06:42 Worklog Time Spent: 10m Work Description: Varsha-Maurya commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-637312666 reopen the pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439933) Time Spent: 3h (was: 2h 50m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Labels: stale-assigned > Time Spent: 3h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=439932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439932 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 02/Jun/20 06:42 Start Date: 02/Jun/20 06:42 Worklog Time Spent: 10m Work Description: Varsha-Maurya removed a comment on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-637312666 reopen the pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439932) Time Spent: 2h 50m (was: 2h 40m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Labels: stale-assigned > Time Spent: 2h 50m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=439923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439923 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 02/Jun/20 06:32 Start Date: 02/Jun/20 06:32 Worklog Time Spent: 10m Work Description: Akshay-Iyangar closed pull request #11396: URL: https://github.com/apache/beam/pull/11396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439923) Time Spent: 2h 40m (was: 2.5h) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Labels: stale-assigned > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=437432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437432 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 27/May/20 03:49 Start Date: 27/May/20 03:49 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-633894816 Hi @Akshay-Iyangar, kind ping regarding this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 437432) Time Spent: 2.5h (was: 2h 20m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 2.5h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=437306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437306 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 27/May/20 03:32 Start Date: 27/May/20 03:32 Worklog Time Spent: 10m Work Description: Akshay-Iyangar commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-634262185 @aromanenko-dev - Sorry for a little busy, will make the changes today. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 437306) Time Spent: 2h 20m (was: 2h 10m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: P3 > Time Spent: 2h 20m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=432738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432738
]
ASF GitHub Bot logged work on BEAM-9742:
Author: ASF GitHub Bot
Created on: 11/May/20 11:42
Start Date: 11/May/20 11:42
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r422977908
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to
retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements
FluentBackoffConfiguration {
Review comment:
I agree with @lukecwik - we should stay consistent with that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 432738)
Time Spent: 2h 10m (was: 2h)
> Add ability to pass FluentBackoff to JdbcIo.Write
> -
>
> Key: BEAM-9742
> URL: https://issues.apache.org/jira/browse/BEAM-9742
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
>Reporter: Akshay Iyangar
>Assignee: Akshay Iyangar
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=432729&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432729 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 11/May/20 11:22 Start Date: 11/May/20 11:22 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-626642453 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 432729) Time Spent: 2h (was: 1h 50m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=432728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432728 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 11/May/20 11:21 Start Date: 11/May/20 11:21 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-626641582 @udim no problem, I can take over of this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 432728) Time Spent: 1h 50m (was: 1h 40m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=432231&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432231 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 08/May/20 19:47 Start Date: 08/May/20 19:47 Worklog Time Spent: 10m Work Description: udim commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-625987559 Hi, Cham requested that I take a look but I'm overloaded. Will attempt to look next week This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 432231) Time Spent: 1h 40m (was: 1.5h) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=431895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431895
]
ASF GitHub Bot logged work on BEAM-9742:
Author: ASF GitHub Bot
Created on: 07/May/20 21:08
Start Date: 07/May/20 21:08
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r421795105
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to
retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements
FluentBackoffConfiguration {
Review comment:
It looks like we should stick with the pattern other IO authors have
taken in the mean time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 431895)
Time Spent: 1.5h (was: 1h 20m)
> Add ability to pass FluentBackoff to JdbcIo.Write
> -
>
> Key: BEAM-9742
> URL: https://issues.apache.org/jira/browse/BEAM-9742
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
>Reporter: Akshay Iyangar
>Assignee: Akshay Iyangar
>Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=431894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431894 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 07/May/20 21:07 Start Date: 07/May/20 21:07 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-625498060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 431894) Time Spent: 1h 20m (was: 1h 10m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=431806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431806 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 07/May/20 16:12 Start Date: 07/May/20 16:12 Worklog Time Spent: 10m Work Description: aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-625351289 Well, I didn't see any principal "against" to make FluentBackoff public but I'm not sure that it will be moved to another package or `util` will become public soon. So for now, I'd rather keep the same strategy as we did for other IOs by creating a custom RetryConfiguration for certain IO. @lukecwik wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 431806) Time Spent: 1h 10m (was: 1h) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=431443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431443 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 06/May/20 21:31 Start Date: 06/May/20 21:31 Worklog Time Spent: 10m Work Description: Akshay-Iyangar commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-624902109 @lukecwik @aromanenko-dev @jfarr @timrobertson100 Let me know what you guys think needs to be done. Seems like people are ok with making FluentBackOff public? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 431443) Time Spent: 1h (was: 50m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=423743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423743
]
ASF GitHub Bot logged work on BEAM-9742:
Author: ASF GitHub Bot
Created on: 16/Apr/20 20:57
Start Date: 16/Apr/20 20:57
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11396: [BEAM-9742]
Add Configurable FluentBackoff to JdbcIO Write
URL: https://github.com/apache/beam/pull/11396#discussion_r409843690
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to
retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements
FluentBackoffConfiguration {
Review comment:
Waiting on updates on ML thread:
https://lists.apache.org/thread.html/r7fde7b5c87c6008689a013fc113d869d3ac15cbc7a35e4534469b9ab%40%3Cdev.beam.apache.org%3E
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 423743)
Time Spent: 50m (was: 40m)
> Add ability to pass FluentBackoff to JdbcIo.Write
> -
>
> Key: BEAM-9742
> URL: https://issues.apache.org/jira/browse/BEAM-9742
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
>Reporter: Akshay Iyangar
>Assignee: Akshay Iyangar
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=422988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422988
]
ASF GitHub Bot logged work on BEAM-9742:
Author: ASF GitHub Bot
Created on: 15/Apr/20 18:53
Start Date: 15/Apr/20 18:53
Worklog Time Spent: 10m
Work Description: Akshay-Iyangar commented on pull request #11396:
[BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write
URL: https://github.com/apache/beam/pull/11396#discussion_r409062570
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to
retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements
FluentBackoffConfiguration {
Review comment:
@lukecwik - cool! I will mail the dev group.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 422988)
Time Spent: 40m (was: 0.5h)
> Add ability to pass FluentBackoff to JdbcIo.Write
> -
>
> Key: BEAM-9742
> URL: https://issues.apache.org/jira/browse/BEAM-9742
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
>Reporter: Akshay Iyangar
>Assignee: Akshay Iyangar
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[
https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=422875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422875
]
ASF GitHub Bot logged work on BEAM-9742:
Author: ASF GitHub Bot
Created on: 15/Apr/20 17:29
Start Date: 15/Apr/20 17:29
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11396: [BEAM-9742]
Add Configurable FluentBackoff to JdbcIO Write
URL: https://github.com/apache/beam/pull/11396#discussion_r409007908
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to
retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements
FluentBackoffConfiguration {
Review comment:
We can't make FluentBackoff part of the public API surface since it is in
the `util` package. It looks like other IO connectors have been creating their
own `RetryConfiguration` class such as:
SnsIO:
https://github.com/apache/beam/blob/da9e17288e8473925674a4691d9e86252e67d7d7/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sns/SnsIO.java#L262
SolrIO:
https://github.com/apache/beam/blob/da9e17288e8473925674a4691d9e86252e67d7d7/sdks/java/io/solr/src/main/java/org/apache/beam/sdk/io/solr/SolrIO.java#L225
and then converting them to any internal implementation that makes sense.
Making FluentBackoff or a RetryConfiguration public and shared across
implementation might make sense but warrants a discussion on the dev@ mailing
list to see what the community thinks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 422875)
Time Spent: 0.5h (was: 20m)
> Add ability to pass FluentBackoff to JdbcIo.Write
> -
>
> Key: BEAM-9742
> URL: https://issues.apache.org/jira/browse/BEAM-9742
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
>Reporter: Akshay Iyangar
>Assignee: Akshay Iyangar
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, the FluentBackoff is hardcoded with `maxRetries` and
> `initialBackoff` .
> It would be helpful if the client were able to pass these values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=420699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420699 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 11/Apr/20 06:15 Start Date: 11/Apr/20 06:15 Worklog Time Spent: 10m Work Description: Akshay-Iyangar commented on issue #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write URL: https://github.com/apache/beam/pull/11396#issuecomment-612341803 @aromanenko-dev @iemejia @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 420699) Time Spent: 20m (was: 10m) > Add ability to pass FluentBackoff to JdbcIo.Write > - > > Key: BEAM-9742 > URL: https://issues.apache.org/jira/browse/BEAM-9742 > Project: Beam > Issue Type: Improvement > Components: io-java-jdbc >Reporter: Akshay Iyangar >Assignee: Akshay Iyangar >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Currently, the FluentBackoff is hardcoded with `maxRetries` and > `initialBackoff` . > It would be helpful if the client were able to pass these values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9742) Add ability to pass FluentBackoff to JdbcIo.Write
[ https://issues.apache.org/jira/browse/BEAM-9742?focusedWorklogId=420698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420698 ] ASF GitHub Bot logged work on BEAM-9742: Author: ASF GitHub Bot Created on: 11/Apr/20 06:14 Start Date: 11/Apr/20 06:14 Worklog Time Spent: 10m Work Description: Akshay-Iyangar commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write URL: https://github.com/apache/beam/pull/11396 Add Configurable FluentBackoff to JdbcIO Write [Jira ticket](https://issues.apache.org/jira/browse/BEAM-9742) Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](
