[GitHub] sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues

[GitBox]

sijie commented on a change in pull request #658: Fail earlier when 
encountering DNS issues
URL: https://github.com/apache/bookkeeper/pull/658#discussion_r146712866
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
 ##
 @@ -131,7 +131,7 @@ public void reloadCachedMappings() {
 for (int i = 0; i < rNames.size(); ++i) {
 if (rNames.get(i) == null) {
 LOG.warn("Failed to resolve network location for {}, 
using default rack for it : {}.",
-rNames.get(i), defaultRack);
+names.get(i), defaultRack);
 
 Review comment:
   nice catch!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues

[GitBox]

sijie commented on a change in pull request #658: Fail earlier when 
encountering DNS issues
URL: https://github.com/apache/bookkeeper/pull/658#discussion_r146712921
 
 

 ##
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.java
 ##
 @@ -65,7 +65,7 @@ static void updateMyRack(String rack) throws Exception {
 
StaticDNSResolver.addNodeToRack(InetAddress.getLocalHost().getHostAddress(), 
rack);
 
StaticDNSResolver.addNodeToRack(InetAddress.getLocalHost().getHostName(), rack);
 StaticDNSResolver.addNodeToRack("127.0.0.1", rack);
-StaticDNSResolver.addNodeToRack("localhost", rack);
+StaticDNSResolver.addNodeToRack("localhost", rack);
 
 Review comment:
   it would be good to remove trailing spaces.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services