[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173843#comment-16173843 ] Julian Hyde commented on CALCITE-1940: -- I've just pushed commit https://github.com/julianhyde/calcite/commit/b17a2aa068d07f5a3483099e9efcc2252e348a55 to my branch https://github.com/julianhyde/calcite/tree/1940-dialect-sequence and I think the process of creating SqlDialect with sequence support is in good shape. In particular I replaced SequenceSupportResolver, which was frankly difficult to understand, with OptionalSequenceSupport, which is more concrete and only need to be implemented for one dialect (SQL Server). I don't intend to look into the JdbcConvention issues any time soon. But anyway, commit b17a2aa0 would be a good point to start when you next start work. > Implement dialect specific support for sequences > > > Key: CALCITE-1940 > URL: https://issues.apache.org/jira/browse/CALCITE-1940 > Project: Calcite > Issue Type: Improvement >Reporter: Christian Beikov >Assignee: Julian Hyde > > The Calcite parser and validator already supports sequences but the push down > to the JDBC level is currently limited. SInce sequences are not supported on > all DBMS every sql dialect should have the possibility to render it's own way > of extracting sequence information or incrementing the value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172813#comment-16172813 ] Christian Beikov commented on CALCITE-1940: --- I looked through your changes and they look good to me so far, but as I mentioned a few times, the sequence PR isn't ready yet :D I am still struggling with getting the sequence call being executed with the JdbcConvention because of (wrong?) planning, but maybe you have some time to take a look and find a solution for this. I'm a bit busy with other stuff now until the weekend anyway, so just tell me when you are ready so that I can pick up work from that point. > Implement dialect specific support for sequences > > > Key: CALCITE-1940 > URL: https://issues.apache.org/jira/browse/CALCITE-1940 > Project: Calcite > Issue Type: Improvement >Reporter: Christian Beikov >Assignee: Julian Hyde > > The Calcite parser and validator already supports sequences but the push down > to the JDBC level is currently limited. SInce sequences are not supported on > all DBMS every sql dialect should have the possibility to render it's own way > of extracting sequence information or incrementing the value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
