[jira] [Commented] (CALCITE-1938) First Apache release for Avatica Go
[ https://issues.apache.org/jira/browse/CALCITE-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438556#comment-16438556 ] Francis Chuang commented on CALCITE-1938: - Thanks [~risdenk]. INFRA-16360 opened to track travis integration. > First Apache release for Avatica Go > --- > > Key: CALCITE-1938 > URL: https://issues.apache.org/jira/browse/CALCITE-1938 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Reporter: Julian Hyde >Assignee: Francis Chuang >Priority: Major > > Make a release for Avatica Go. > Release number is TBD. > This will be the first Apache release for Avatica Go, so expect more > diligence / issues than usual. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1938) First Apache release for Avatica Go
[ https://issues.apache.org/jira/browse/CALCITE-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438465#comment-16438465 ] Kevin Risden commented on CALCITE-1938: --- [~francischuang] - I think this would be a ticket to INFRA. Here are two examples: INFRA-13792 and INFRA-11616 > First Apache release for Avatica Go > --- > > Key: CALCITE-1938 > URL: https://issues.apache.org/jira/browse/CALCITE-1938 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Reporter: Julian Hyde >Assignee: Francis Chuang >Priority: Major > > Make a release for Avatica Go. > Release number is TBD. > This will be the first Apache release for Avatica Go, so expect more > diligence / issues than usual. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2253:
--
Affects Version/s: 1.17.0
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
>Affects Versions: 1.17.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2253:
--
Component/s: jdbc-adapter
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
>Affects Versions: 1.17.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2253:
--
Fix Version/s: 1.17.0
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438464#comment-16438464
]
Kevin Risden commented on CALCITE-2253:
---
I can confirm this fixes the test failures.
This now passes
mvn clean test -Dtest=JdbcAdapterTest -DfailIfNoTests=false -pl core -am
As well as `mvn clean test` for the entire test suite.
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2254) Test against IBM Java
[ https://issues.apache.org/jira/browse/CALCITE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438456#comment-16438456 ] Kevin Risden commented on CALCITE-2254: --- PR https://github.com/apache/calcite/pull/665 > Test against IBM Java > - > > Key: CALCITE-2254 > URL: https://issues.apache.org/jira/browse/CALCITE-2254 > Project: Calcite > Issue Type: Improvement >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 1.17.0 > > > IBM Java is open sourced and capable of being tested against with Travis CI > and Docker. We should test against IBM Java as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2206) JDBC adapter incorrectly pushes windowed aggregates down to HSQLDB
[
https://issues.apache.org/jira/browse/CALCITE-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438445#comment-16438445
]
Julian Hyde commented on CALCITE-2206:
--
Sorry I broke the build. Not sure how it happened. I'm pretty sure I ran the
tests on 3 JDK versions.
> JDBC adapter incorrectly pushes windowed aggregates down to HSQLDB
> --
>
> Key: CALCITE-2206
> URL: https://issues.apache.org/jira/browse/CALCITE-2206
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
>Affects Versions: 1.15.0
>Reporter: Pavel Gubin
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> JDBC adapter incorrectly pushes windowed aggregates down to HSQLDB. Queries
> containing window functions fail when using HSQLDB (or any other DB that does
> not support window functions) because the optimizer converts them to native
> SQL with window functions which are not supported by HSQLDB. For example:
> {code:sql}
> select "store_id", "product_id", sum("unit_sales") unit_sales, row_number()
> over (
> partition by "store_id" order by sum("unit_sales") desc
> ) row_num
> from "sales_fact_1998"
> group by "store_id", "product_id"
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2063) Add JDK 10 to CI
[ https://issues.apache.org/jira/browse/CALCITE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-2063: -- Fix Version/s: 1.17.0 > Add JDK 10 to CI > > > Key: CALCITE-2063 > URL: https://issues.apache.org/jira/browse/CALCITE-2063 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Fix For: 1.17.0 > > > In CALCITE-2058 we added support for JDK 10 (early access build), and we test > using a cron job on Julian's server but currently Apache's Jenkins does not > support JDK 10. This task is to enable JDK 10 tests when Jenkins supports it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2063) Add JDK 10 to CI
[ https://issues.apache.org/jira/browse/CALCITE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438431#comment-16438431 ] Kevin Risden commented on CALCITE-2063: --- Opened CALCITE-2254 to add to Travis CI testing against IBM Java. Will open a specific Jira to address the IBM Java error message parsing. > Add JDK 10 to CI > > > Key: CALCITE-2063 > URL: https://issues.apache.org/jira/browse/CALCITE-2063 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > > In CALCITE-2058 we added support for JDK 10 (early access build), and we test > using a cron job on Julian's server but currently Apache's Jenkins does not > support JDK 10. This task is to enable JDK 10 tests when Jenkins supports it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2255) Test against JDK 11
[
https://issues.apache.org/jira/browse/CALCITE-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438430#comment-16438430
]
Kevin Risden commented on CALCITE-2255:
---
{noformat}
[INFO] --- forbiddenapis:2.3:check (default) @ calcite-example-function ---
[WARNING] Bundled version of ASM cannot parse bytecode of java.lang.Object
class; marking runtime as not suppported.
[WARNING] Your Java runtime (OpenJDK Runtime Environment 11+8-Debian-1) is not
supported by the forbiddenapis MOJO. Please run the checks with a supported JDK!
[INFO]
[INFO] --- forbiddenapis:2.3:testCheck (default) @ calcite-example-function ---
[WARNING] Bundled version of ASM cannot parse bytecode of java.lang.Object
class; marking runtime as not suppported.
[WARNING] Your Java runtime (OpenJDK Runtime Environment 11+8-Debian-1) is not
supported by the forbiddenapis MOJO. Please run the checks with a supported
JDK!{noformat}
Doesn't fail the build but this warning is printed currently.
> Test against JDK 11
> ---
>
> Key: CALCITE-2255
> URL: https://issues.apache.org/jira/browse/CALCITE-2255
> Project: Calcite
> Issue Type: Improvement
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.17.0
>
>
> JDK 11 ([http://jdk.java.net/11/)] is in early release and we can start
> testing against it. With the improvements from CALCITE-2063, we should be
> able to test against JDK 11 without much effort.
> I opened [https://github.com/docker-library/openjdk/pull/186] and
> [https://github.com/carlossg/docker-maven/issues/79] to try to get JDK 11
> support for the docker images we are trying to use.
> I am working on testing locally as well to see if there is anything broken.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2255) Test against JDK 11
[ https://issues.apache.org/jira/browse/CALCITE-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438427#comment-16438427 ] Kevin Risden commented on CALCITE-2255: --- Depends upon the work from CALCITE-2063 > Test against JDK 11 > --- > > Key: CALCITE-2255 > URL: https://issues.apache.org/jira/browse/CALCITE-2255 > Project: Calcite > Issue Type: Improvement >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 1.17.0 > > > JDK 11 ([http://jdk.java.net/11/)] is in early release and we can start > testing against it. With the improvements from CALCITE-2063, we should be > able to test against JDK 11 without much effort. > I opened [https://github.com/docker-library/openjdk/pull/186] and > [https://github.com/carlossg/docker-maven/issues/79] to try to get JDK 11 > support for the docker images we are trying to use. > I am working on testing locally as well to see if there is anything broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CALCITE-2255) Test against JDK 11
Kevin Risden created CALCITE-2255: - Summary: Test against JDK 11 Key: CALCITE-2255 URL: https://issues.apache.org/jira/browse/CALCITE-2255 Project: Calcite Issue Type: Improvement Reporter: Kevin Risden Assignee: Kevin Risden Fix For: 1.17.0 JDK 11 ([http://jdk.java.net/11/)] is in early release and we can start testing against it. With the improvements from CALCITE-2063, we should be able to test against JDK 11 without much effort. I opened [https://github.com/docker-library/openjdk/pull/186] and [https://github.com/carlossg/docker-maven/issues/79] to try to get JDK 11 support for the docker images we are trying to use. I am working on testing locally as well to see if there is anything broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2254) Test against IBM Java
[ https://issues.apache.org/jira/browse/CALCITE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438426#comment-16438426 ] Kevin Risden commented on CALCITE-2254: --- Linking to CALCITE-2063 since this builds on that. > Test against IBM Java > - > > Key: CALCITE-2254 > URL: https://issues.apache.org/jira/browse/CALCITE-2254 > Project: Calcite > Issue Type: Improvement >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 1.17.0 > > > IBM Java is open sourced and capable of being tested against with Travis CI > and Docker. We should test against IBM Java as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CALCITE-2254) Test against IBM Java
Kevin Risden created CALCITE-2254: - Summary: Test against IBM Java Key: CALCITE-2254 URL: https://issues.apache.org/jira/browse/CALCITE-2254 Project: Calcite Issue Type: Improvement Reporter: Kevin Risden Assignee: Kevin Risden Fix For: 1.17.0 IBM Java is open sourced and capable of being tested against with Travis CI and Docker. We should test against IBM Java as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2063) Add JDK 10 to CI
[ https://issues.apache.org/jira/browse/CALCITE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438420#comment-16438420 ] Kevin Risden commented on CALCITE-2063: --- Looks like just waiting on CALCITE-2253 to be fixed and then can update PR [https://github.com/apache/calcite/pull/649]. [~elserj] - Minus the failures from CALCITE-2253 I'm pretty sure that JDK 10 builds are working now. > Add JDK 10 to CI > > > Key: CALCITE-2063 > URL: https://issues.apache.org/jira/browse/CALCITE-2063 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > > In CALCITE-2058 we added support for JDK 10 (early access build), and we test > using a cron job on Julian's server but currently Apache's Jenkins does not > support JDK 10. This task is to enable JDK 10 tests when Jenkins supports it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438407#comment-16438407
]
Volodymyr Vysotskyi commented on CALCITE-2253:
--
I have created a pull request with the fix:
https://github.com/apache/calcite/pull/664. Could someone please take a look?
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Vysotskyi updated CALCITE-2253:
-
Description:
In CALCITE-2206 was prevented pushing windowed aggregates down for the
{{SqlDialect}} s which do not support windowed functions.
After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
{{SqlDialect}} supports windowed functions and project contains windowed
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
It causes unit tests failures seen on the master.
was:
In CALCITE-2206 was prevented pushing windowed aggregates down for the
{{SqlDialect}} s which do not support windowed functions.
After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
{{SqlDialect}} supports windowed functions and project contains windowed
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
It causes unti tests
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2206) JDBC adapter incorrectly pushes windowed aggregates down to HSQLDB
[
https://issues.apache.org/jira/browse/CALCITE-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438330#comment-16438330
]
Volodymyr Vysotskyi commented on CALCITE-2206:
--
Looks like the problem in the {{JdbcProjectRule}}. I suppose the bug is in the
predicate:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
Disjunction should be used instead of conjunction, so if
{{supportsWindowFunctions}} is true or project does not contain over, a rule
can be applied.
Created CALCITE-2253 to fix it.
> JDBC adapter incorrectly pushes windowed aggregates down to HSQLDB
> --
>
> Key: CALCITE-2206
> URL: https://issues.apache.org/jira/browse/CALCITE-2206
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
>Affects Versions: 1.15.0
>Reporter: Pavel Gubin
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> JDBC adapter incorrectly pushes windowed aggregates down to HSQLDB. Queries
> containing window functions fail when using HSQLDB (or any other DB that does
> not support window functions) because the optimizer converts them to native
> SQL with window functions which are not supported by HSQLDB. For example:
> {code:sql}
> select "store_id", "product_id", sum("unit_sales") unit_sales, row_number()
> over (
> partition by "store_id" order by sum("unit_sales") desc
> ) row_num
> from "sales_fact_1998"
> group by "store_id", "product_id"
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Vysotskyi updated CALCITE-2253:
-
Description:
In CALCITE-2206 was prevented pushing windowed aggregates down for the
{{SqlDialect}} s which do not support windowed functions.
After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
{{SqlDialect}} supports windowed functions and project contains windowed
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
It causes unti tests
was:
In CALCITE-2206 was prevented pushing windowed aggregates down for the
{{SqlDialect}} s which do not support windowed functions.
After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
{{SqlDialect}} supports windowed functions and project contains windowed
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unti tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
[
https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Vysotskyi updated CALCITE-2253:
-
Description:
In CALCITE-2206 was prevented pushing windowed aggregates down for the
{{SqlDialect}} s which do not support windowed functions.
After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
{{SqlDialect}} supports windowed functions and project contains windowed
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
was:
In CALCITE-2206 was prevented pushing windowed aggregates down for the
{{SqlDialect}}s which do not support windowed functions.
After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
{{SqlDialect}} supports windowed functions and project contains windowed
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
> Fix matching predicate for JdbcProjectRule rule
> ---
>
> Key: CALCITE-2253
> URL: https://issues.apache.org/jira/browse/CALCITE-2253
> Project: Calcite
> Issue Type: Bug
>Reporter: Volodymyr Vysotskyi
>Assignee: Julian Hyde
>Priority: Major
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the
> {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
> {{SqlDialect}} supports windowed functions and project contains windowed
> functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
> && !RexOver.containsOver(project.getProjects(), null);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule
Volodymyr Vysotskyi created CALCITE-2253:
Summary: Fix matching predicate for JdbcProjectRule rule
Key: CALCITE-2253
URL: https://issues.apache.org/jira/browse/CALCITE-2253
Project: Calcite
Issue Type: Bug
Reporter: Volodymyr Vysotskyi
Assignee: Julian Hyde
In CALCITE-2206 was prevented pushing windowed aggregates down for the
{{SqlDialect}}s which do not support windowed functions.
After these changes, {{JdbcProjectRule}} is matched *only* for the cases when
{{SqlDialect}} supports windowed functions and project contains windowed
functions:
{code:java}
return out.dialect.supportsWindowFunctions()
&& !RexOver.containsOver(project.getProjects(), null);
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
