[jira] [Resolved] (CALCITE-6360) Add .asf.yaml to calcite-avatica-go repository
[ https://issues.apache.org/jira/browse/CALCITE-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6360. - Resolution: Fixed > Add .asf.yaml to calcite-avatica-go repository > -- > > Key: CALCITE-6360 > URL: https://issues.apache.org/jira/browse/CALCITE-6360 > Project: Calcite > Issue Type: Task > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6360) Add .asf.yaml to calcite-avatica-go repository
Francis Chuang created CALCITE-6360: --- Summary: Add .asf.yaml to calcite-avatica-go repository Key: CALCITE-6360 URL: https://issues.apache.org/jira/browse/CALCITE-6360 Project: Calcite Issue Type: Task Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6359) Update GitHub Actions workflows to use docker compose v2
[ https://issues.apache.org/jira/browse/CALCITE-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6359. - Resolution: Fixed > Update GitHub Actions workflows to use docker compose v2 > > > Key: CALCITE-6359 > URL: https://issues.apache.org/jira/browse/CALCITE-6359 > Project: Calcite > Issue Type: Task > Components: avatica, avatica-go, core >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Labels: pull-request-available > Fix For: 1.37.0, avatica-go-5.4.0, avatica-1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6359) Update GitHub Actions workflows to use docker compose v2
Francis Chuang created CALCITE-6359: --- Summary: Update GitHub Actions workflows to use docker compose v2 Key: CALCITE-6359 URL: https://issues.apache.org/jira/browse/CALCITE-6359 Project: Calcite Issue Type: Task Components: avatica, avatica-go, core Reporter: Francis Chuang Assignee: Francis Chuang Fix For: 1.37.0, avatica-go-5.4.0, avatica-1.26.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6354) Use gradle docker image when running tests using docker-compose
[ https://issues.apache.org/jira/browse/CALCITE-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6354. - Resolution: Fixed > Use gradle docker image when running tests using docker-compose > --- > > Key: CALCITE-6354 > URL: https://issues.apache.org/jira/browse/CALCITE-6354 > Project: Calcite > Issue Type: Task >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > > This allows users to run tests using docker-compose when testing releases. > The gradle wrapper is not present in released artifacts, so trying to run > tests using ./gradlew will fail. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6351) Update LICENSE for Jekyll website template
[ https://issues.apache.org/jira/browse/CALCITE-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6351. - Resolution: Fixed > Update LICENSE for Jekyll website template > -- > > Key: CALCITE-6351 > URL: https://issues.apache.org/jira/browse/CALCITE-6351 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > > We should port the changes for > [CALCITE-6098|https://issues.apache.org/jira/browse/CALCITE-6098] over. > Reference commit in the Calcite repo: > https://github.com/apache/calcite/commit/58edb0e85f01580961f9fb07f171686166a0da34 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6351) Update LICENSE for Jekyll website template
[ https://issues.apache.org/jira/browse/CALCITE-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6351: Summary: Update LICENSE for Jekyll website template (was: Update LICENSE and NOTICE for Jekyll website template) > Update LICENSE for Jekyll website template > -- > > Key: CALCITE-6351 > URL: https://issues.apache.org/jira/browse/CALCITE-6351 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > > We should port the changes for > [CALCITE-6098|https://issues.apache.org/jira/browse/CALCITE-6098] over. > Reference commit in the Calcite repo: > https://github.com/apache/calcite/commit/58edb0e85f01580961f9fb07f171686166a0da34 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6334) Release Avatica 1.25.0
[ https://issues.apache.org/jira/browse/CALCITE-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6334. - Resolution: Fixed > Release Avatica 1.25.0 > -- > > Key: CALCITE-6334 > URL: https://issues.apache.org/jira/browse/CALCITE-6334 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.25.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6354) Use gradle docker image when running tests using docker-compose
[ https://issues.apache.org/jira/browse/CALCITE-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6354: Description: This allows users to run tests using docker-compose when testing releases. The gradle wrapper is not present in released artifacts, so trying to run tests using ./gradlew will fail. (was: This allows users to run tests using docker-compose) > Use gradle docker image when running tests using docker-compose > --- > > Key: CALCITE-6354 > URL: https://issues.apache.org/jira/browse/CALCITE-6354 > Project: Calcite > Issue Type: Task >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > > This allows users to run tests using docker-compose when testing releases. > The gradle wrapper is not present in released artifacts, so trying to run > tests using ./gradlew will fail. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6354) Use gradle docker image when running tests using docker compose
[ https://issues.apache.org/jira/browse/CALCITE-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6354: Description: This allows users to run tests using docker-compose > Use gradle docker image when running tests using docker compose > --- > > Key: CALCITE-6354 > URL: https://issues.apache.org/jira/browse/CALCITE-6354 > Project: Calcite > Issue Type: Task >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > > This allows users to run tests using docker-compose -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6354) Use gradle docker image when running tests using docker-compose
[ https://issues.apache.org/jira/browse/CALCITE-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6354: Summary: Use gradle docker image when running tests using docker-compose (was: Use gradle docker image when running tests using docker compose) > Use gradle docker image when running tests using docker-compose > --- > > Key: CALCITE-6354 > URL: https://issues.apache.org/jira/browse/CALCITE-6354 > Project: Calcite > Issue Type: Task >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > > This allows users to run tests using docker-compose -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6354) Use gradle docker image when running tests using docker compose
[ https://issues.apache.org/jira/browse/CALCITE-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6354: Summary: Use gradle docker image when running tests using docker compose (was: Use gradle docker container directly when running tests using docker compose) > Use gradle docker image when running tests using docker compose > --- > > Key: CALCITE-6354 > URL: https://issues.apache.org/jira/browse/CALCITE-6354 > Project: Calcite > Issue Type: Task >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6354) Use gradle docker container directly when running tests using docker compose
Francis Chuang created CALCITE-6354: --- Summary: Use gradle docker container directly when running tests using docker compose Key: CALCITE-6354 URL: https://issues.apache.org/jira/browse/CALCITE-6354 Project: Calcite Issue Type: Task Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-1.26.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6334) Release Avatica 1.25.0
[ https://issues.apache.org/jira/browse/CALCITE-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6334: Component/s: avatica > Release Avatica 1.25.0 > -- > > Key: CALCITE-6334 > URL: https://issues.apache.org/jira/browse/CALCITE-6334 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.25.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6351) Update LICENSE and NOTICE for Jekyll website template
[ https://issues.apache.org/jira/browse/CALCITE-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6351: Description: We should port the changes for [CALCITE-6098|https://issues.apache.org/jira/browse/CALCITE-6098] over. Reference commit in the Calcite repo: https://github.com/apache/calcite/commit/58edb0e85f01580961f9fb07f171686166a0da34 > Update LICENSE and NOTICE for Jekyll website template > - > > Key: CALCITE-6351 > URL: https://issues.apache.org/jira/browse/CALCITE-6351 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.26.0 > > > We should port the changes for > [CALCITE-6098|https://issues.apache.org/jira/browse/CALCITE-6098] over. > Reference commit in the Calcite repo: > https://github.com/apache/calcite/commit/58edb0e85f01580961f9fb07f171686166a0da34 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6351) Update LICENSE and NOTICE for Jekyll website template
Francis Chuang created CALCITE-6351: --- Summary: Update LICENSE and NOTICE for Jekyll website template Key: CALCITE-6351 URL: https://issues.apache.org/jira/browse/CALCITE-6351 Project: Calcite Issue Type: Task Components: avatica Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-1.26.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6282) Avatica ignores time precision when returning TIME results
[
https://issues.apache.org/jira/browse/CALCITE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-6282.
-
Resolution: Fixed
> Avatica ignores time precision when returning TIME results
> --
>
> Key: CALCITE-6282
> URL: https://issues.apache.org/jira/browse/CALCITE-6282
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.25.0
>Reporter: Mihai Budiu
>Assignee: Mihai Budiu
>Priority: Minor
> Labels: pull-request-available
> Fix For: avatica-1.25.0
>
>
> SqlOperatorTest contains the following disabled test:
> {code:java}
> f.checkScalar("cast(TIME '12:42:25.34' as TIME(2))",
> "12:42:25.34", "TIME(2) NOT NULL");
> {code}
> This test is disabled based on the following condition;
> {code:java}
> /**
>* Whether http://issues.eigenbase.org/browse/FRG-282;>issue
>* FRG-282: Support precision in TIME and TIMESTAMP data types is fixed.
>*/
> public static final boolean FRG282_FIXED = true;
> {code}
> However, the result is computed correctly. The precision is lost in the JDBC
> layer, which creates a TimeFromNumberAccessor which does not depend on the
> precision of the target type: it always returns the time with a precision of
> 0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-6248) Illegal dates are accepted by casts
[
https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-6248.
-
Resolution: Fixed
> Illegal dates are accepted by casts
> ---
>
> Key: CALCITE-6248
> URL: https://issues.apache.org/jira/browse/CALCITE-6248
> Project: Calcite
> Issue Type: Bug
> Components: avatica, core
>Affects Versions: 1.36.0
>Reporter: Mihai Budiu
>Assignee: Mihai Budiu
>Priority: Minor
> Labels: pull-request-available
> Fix For: avatica-1.25.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following test passes in SqlOperatorTest:
> {code:java}
> @Test public void testIllegalDate() {
> final SqlOperatorFixture f = fixture();
> f.checkScalar("cast('1945-02-32' as DATE)",
> "1945-03-04", "DATE NOT NULL");
> }
> {code}
> There is no February 32, I suspect that this expression should produce an
> error.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (CALCITE-6248) Illegal dates are accepted by casts
[
https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang reassigned CALCITE-6248:
---
Assignee: Mihai Budiu
> Illegal dates are accepted by casts
> ---
>
> Key: CALCITE-6248
> URL: https://issues.apache.org/jira/browse/CALCITE-6248
> Project: Calcite
> Issue Type: Bug
> Components: avatica, core
>Affects Versions: 1.36.0
>Reporter: Mihai Budiu
>Assignee: Mihai Budiu
>Priority: Minor
> Labels: pull-request-available
> Fix For: avatica-1.25.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following test passes in SqlOperatorTest:
> {code:java}
> @Test public void testIllegalDate() {
> final SqlOperatorFixture f = fixture();
> f.checkScalar("cast('1945-02-32' as DATE)",
> "1945-03-04", "DATE NOT NULL");
> }
> {code}
> There is no February 32, I suspect that this expression should produce an
> error.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6248) Illegal dates are accepted by casts
[
https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang updated CALCITE-6248:
Fix Version/s: avatica-1.25.0
> Illegal dates are accepted by casts
> ---
>
> Key: CALCITE-6248
> URL: https://issues.apache.org/jira/browse/CALCITE-6248
> Project: Calcite
> Issue Type: Bug
> Components: avatica, core
>Affects Versions: 1.36.0
>Reporter: Mihai Budiu
>Priority: Minor
> Labels: pull-request-available
> Fix For: avatica-1.25.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following test passes in SqlOperatorTest:
> {code:java}
> @Test public void testIllegalDate() {
> final SqlOperatorFixture f = fixture();
> f.checkScalar("cast('1945-02-32' as DATE)",
> "1945-03-04", "DATE NOT NULL");
> }
> {code}
> There is no February 32, I suspect that this expression should produce an
> error.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6280) Jetty version number leaked by Avatica http server
[
https://issues.apache.org/jira/browse/CALCITE-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang updated CALCITE-6280:
Fix Version/s: avatica-1.25.0
(was: 1.25.0)
> Jetty version number leaked by Avatica http server
> --
>
> Key: CALCITE-6280
> URL: https://issues.apache.org/jira/browse/CALCITE-6280
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.24.0
>Reporter: Vaibhav Joshi
>Assignee: Vaibhav Joshi
>Priority: Minor
> Labels: pull-request-available
> Fix For: avatica-1.25.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Unauthorised access to HTTP server using curl returns the Jerry server
> version. See sample response below
> {code:java}
>
>
>
> Error 401 Unauthorized
>
> HTTP ERROR 401 Unauthorized
>
> URI:/
> STATUS:401
> MESSAGE:Unauthorized
> SERVLET:-
>
> https://eclipse.org/jetty;>Powered by Jetty://
> 9.4.44.v20210927
>
> {code}
>
> For security reason, it's not advisable to return server version in the
> response.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6282) Avatica ignores time precision when returning TIME results
[
https://issues.apache.org/jira/browse/CALCITE-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang updated CALCITE-6282:
Fix Version/s: avatica-1.25.0
(was: 1.25.0)
> Avatica ignores time precision when returning TIME results
> --
>
> Key: CALCITE-6282
> URL: https://issues.apache.org/jira/browse/CALCITE-6282
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.25.0
>Reporter: Mihai Budiu
>Assignee: Mihai Budiu
>Priority: Minor
> Labels: pull-request-available
> Fix For: avatica-1.25.0
>
>
> SqlOperatorTest contains the following disabled test:
> {code:java}
> f.checkScalar("cast(TIME '12:42:25.34' as TIME(2))",
> "12:42:25.34", "TIME(2) NOT NULL");
> {code}
> This test is disabled based on the following condition;
> {code:java}
> /**
>* Whether http://issues.eigenbase.org/browse/FRG-282;>issue
>* FRG-282: Support precision in TIME and TIMESTAMP data types is fixed.
>*/
> public static final boolean FRG282_FIXED = true;
> {code}
> However, the result is computed correctly. The precision is lost in the JDBC
> layer, which creates a TimeFromNumberAccessor which does not depend on the
> precision of the target type: it always returns the time with a precision of
> 0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6334) Release Avatica 1.25.0
[ https://issues.apache.org/jira/browse/CALCITE-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6334: Fix Version/s: avatica-1.25.0 > Release Avatica 1.25.0 > -- > > Key: CALCITE-6334 > URL: https://issues.apache.org/jira/browse/CALCITE-6334 > Project: Calcite > Issue Type: Task >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.25.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6339) Replace hashicorp/go-uuid with google/uuid
[ https://issues.apache.org/jira/browse/CALCITE-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6339. - Resolution: Fixed > Replace hashicorp/go-uuid with google/uuid > -- > > Key: CALCITE-6339 > URL: https://issues.apache.org/jira/browse/CALCITE-6339 > Project: Calcite > Issue Type: Task > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Minor > Fix For: avatica-go-5.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The hashicorp/uuid library generates strings that look like uuids but are > purely random. It is also not as popular or as active as the google/uuid > library. > The google/uuid library generates real uuids that are RFC compliant. The > library is also more popular and actively maintained. > These ids are used to generate connection ids, so whether they are RFC > compliant or not is inconsequential, however, it is a good idea to generate > compliant uuids if downstream users behind avatica expects correct and > compliant uuids. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6339) Replace hashicorp/go-uuid with google/uuid
Francis Chuang created CALCITE-6339: --- Summary: Replace hashicorp/go-uuid with google/uuid Key: CALCITE-6339 URL: https://issues.apache.org/jira/browse/CALCITE-6339 Project: Calcite Issue Type: Task Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.4.0 The hashicorp/uuid library generates strings that look like uuids but are purely random. It is also not as popular or as active as the google/uuid library. The google/uuid library generates real uuids that are RFC compliant. The library is also more popular and actively maintained. These ids are used to generate connection ids, so whether they are RFC compliant or not is inconsequential, however, it is a good idea to generate compliant uuids if downstream users behind avatica expects correct and compliant uuids. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6334) Release Avatica 1.25.0
Francis Chuang created CALCITE-6334: --- Summary: Release Avatica 1.25.0 Key: CALCITE-6334 URL: https://issues.apache.org/jira/browse/CALCITE-6334 Project: Calcite Issue Type: Task Reporter: Francis Chuang Assignee: Francis Chuang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-6170) DruidException: Illegal use of dynamic parameter with 'LOWER(?)'
[
https://issues.apache.org/jira/browse/CALCITE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798725#comment-17798725
]
Francis Chuang commented on CALCITE-6170:
-
Can you run the query from the [Druid
console|https://druid.apache.org/docs/latest/operations/web-console/#query] and
see if it also produces the same error?
> DruidException: Illegal use of dynamic parameter with 'LOWER(?)'
> -
>
> Key: CALCITE-6170
> URL: https://issues.apache.org/jira/browse/CALCITE-6170
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: 1.23.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
>
> Apache Druid with Calcite and Avatica-Protobuf integration doesn't correctly
> validate 'LOWER(?)'
> The current workaround: 'LOWER(CAST(? AS VARCHAR))'
> Versions:
> {code:java}
> 1.35.0
> 1.23.0 {code}
>
> The following Go code will produce an exception:
> {code:java}
> package main
> import (
> "context"
> "database/sql"
> "fmt"
> _ "github.com/apache/calcite-avatica-go/v5"
> )
> func main() {
> jdbcUrl := "http://localhost:8082/druid/v2/sql/avatica-protobuf;
> db, err := sql.Open("avatica", jdbcUrl)
> if err != nil {
> panic(err)
> }
> defer func() {
> err = db.Close()
> if err != nil {
> fmt.Println(err)
> panic(err)
> }
> }()
> sql := "select any_value(browser) from test where (lower(browser) like
> lower(?)) limit 10"
> rows, err := db.QueryContext(context.Background(), sql, "%a%")
> if err != nil {
> panic(err)
> }
> rows.Close()
> }{code}
> {code:java}
> panic: An error was encountered while processing your request:
> QueryInterruptedException: Illegal use of dynamic parameter (line [1], column
> [73]) -> DruidException: Illegal use of dynamic parameter (line [1], column
> [73]) -> ValidationException:
> org.apache.calcite.runtime.CalciteContextException: At line 1, column 73:
> Illegal use of dynamic parameter -> CalciteContextException: At line 1,
> column 73: Illegal use of dynamic parameter -> SqlValidatorException: Illegal
> use of dynamic parameter {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-6158) Add instructions for building/testing the project in README file
[ https://issues.apache.org/jira/browse/CALCITE-6158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6158. - Resolution: Fixed > Add instructions for building/testing the project in README file > > > Key: CALCITE-6158 > URL: https://issues.apache.org/jira/browse/CALCITE-6158 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Affects Versions: avatica-go-5.2.0 >Reporter: Stamatis Zampetakis >Assignee: Francis Chuang >Priority: Minor > Fix For: avatica-go-5.4.0 > > > The [avatica-go repository|https://github.com/apache/calcite-avatica-go] and > subsequently the source distribution do not contain instructions (or links to > the appropriate place in the documentation) to build and test the project in > the README file at the root of the project. > Someone who downloads the released sources and its not familiar with the > project may have a hard time using it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6158) Add instructions for building/testing the project in README file
[ https://issues.apache.org/jira/browse/CALCITE-6158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6158: Summary: Add instructions for building/testing the project in README file (was: No instructions for building/testing the project in README file) > Add instructions for building/testing the project in README file > > > Key: CALCITE-6158 > URL: https://issues.apache.org/jira/browse/CALCITE-6158 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Affects Versions: avatica-go-5.2.0 >Reporter: Stamatis Zampetakis >Assignee: Francis Chuang >Priority: Minor > > The [avatica-go repository|https://github.com/apache/calcite-avatica-go] and > subsequently the source distribution do not contain instructions (or links to > the appropriate place in the documentation) to build and test the project in > the README file at the root of the project. > Someone who downloads the released sources and its not familiar with the > project may have a hard time using it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6158) Add instructions for building/testing the project in README file
[ https://issues.apache.org/jira/browse/CALCITE-6158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6158: Fix Version/s: avatica-go-5.4.0 > Add instructions for building/testing the project in README file > > > Key: CALCITE-6158 > URL: https://issues.apache.org/jira/browse/CALCITE-6158 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Affects Versions: avatica-go-5.2.0 >Reporter: Stamatis Zampetakis >Assignee: Francis Chuang >Priority: Minor > Fix For: avatica-go-5.4.0 > > > The [avatica-go repository|https://github.com/apache/calcite-avatica-go] and > subsequently the source distribution do not contain instructions (or links to > the appropriate place in the documentation) to build and test the project in > the README file at the root of the project. > Someone who downloads the released sources and its not familiar with the > project may have a hard time using it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6110) Release Avatica-Go 5.3.0
[ https://issues.apache.org/jira/browse/CALCITE-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6110. - Resolution: Fixed > Release Avatica-Go 5.3.0 > > > Key: CALCITE-6110 > URL: https://issues.apache.org/jira/browse/CALCITE-6110 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6153) Recompile protobuf messages to Avatica 1.24.0
[ https://issues.apache.org/jira/browse/CALCITE-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6153: Summary: Recompile protobuf messages to Avatica 1.24.0 (was: Recompile protobuf messages to Avatica 1.24) > Recompile protobuf messages to Avatica 1.24.0 > - > > Key: CALCITE-6153 > URL: https://issues.apache.org/jira/browse/CALCITE-6153 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6155) Add additional rel/ tag to avatica-go release script
[ https://issues.apache.org/jira/browse/CALCITE-6155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6155. - Resolution: Fixed > Add additional rel/ tag to avatica-go release script > > > Key: CALCITE-6155 > URL: https://issues.apache.org/jira/browse/CALCITE-6155 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6155) Add additional rel/ tag to avatica-go release script
Francis Chuang created CALCITE-6155: --- Summary: Add additional rel/ tag to avatica-go release script Key: CALCITE-6155 URL: https://issues.apache.org/jira/browse/CALCITE-6155 Project: Calcite Issue Type: New Feature Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6154) Upgrade protobuf library to 1.31.0
[ https://issues.apache.org/jira/browse/CALCITE-6154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6154. - Resolution: Fixed > Upgrade protobuf library to 1.31.0 > -- > > Key: CALCITE-6154 > URL: https://issues.apache.org/jira/browse/CALCITE-6154 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6154) Upgrade protobuf library to 1.31.0
Francis Chuang created CALCITE-6154: --- Summary: Upgrade protobuf library to 1.31.0 Key: CALCITE-6154 URL: https://issues.apache.org/jira/browse/CALCITE-6154 Project: Calcite Issue Type: New Feature Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6153) Recompile protobuf messages to Avatica 1.24
[ https://issues.apache.org/jira/browse/CALCITE-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6153. - Resolution: Fixed > Recompile protobuf messages to Avatica 1.24 > --- > > Key: CALCITE-6153 > URL: https://issues.apache.org/jira/browse/CALCITE-6153 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6153) Recompile protobuf messages to Avatica 1.24
[ https://issues.apache.org/jira/browse/CALCITE-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6153: Fix Version/s: avatica-go-5.3.0 > Recompile protobuf messages to Avatica 1.24 > --- > > Key: CALCITE-6153 > URL: https://issues.apache.org/jira/browse/CALCITE-6153 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Affects Versions: avatica-go-5.3.0 >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6153) Recompile protobuf messages to Avatica 1.24
[ https://issues.apache.org/jira/browse/CALCITE-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6153: Affects Version/s: (was: avatica-go-5.3.0) > Recompile protobuf messages to Avatica 1.24 > --- > > Key: CALCITE-6153 > URL: https://issues.apache.org/jira/browse/CALCITE-6153 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6152) Test against Avatica 1.24.0
[ https://issues.apache.org/jira/browse/CALCITE-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6152: Component/s: avatica-go > Test against Avatica 1.24.0 > --- > > Key: CALCITE-6152 > URL: https://issues.apache.org/jira/browse/CALCITE-6152 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6153) Recompile protobuf messages to Avatica 1.24
Francis Chuang created CALCITE-6153: --- Summary: Recompile protobuf messages to Avatica 1.24 Key: CALCITE-6153 URL: https://issues.apache.org/jira/browse/CALCITE-6153 Project: Calcite Issue Type: New Feature Components: avatica-go Affects Versions: avatica-go-5.3.0 Reporter: Francis Chuang Assignee: Francis Chuang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6152) Test against Avatica 1.24.0
[ https://issues.apache.org/jira/browse/CALCITE-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6152. - Resolution: Fixed > Test against Avatica 1.24.0 > --- > > Key: CALCITE-6152 > URL: https://issues.apache.org/jira/browse/CALCITE-6152 > Project: Calcite > Issue Type: New Feature >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6151) Test against Go 1.20 and 1.21
[ https://issues.apache.org/jira/browse/CALCITE-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6151. - Resolution: Fixed > Test against Go 1.20 and 1.21 > - > > Key: CALCITE-6151 > URL: https://issues.apache.org/jira/browse/CALCITE-6151 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6152) Test against Avatica 1.24.0
Francis Chuang created CALCITE-6152: --- Summary: Test against Avatica 1.24.0 Key: CALCITE-6152 URL: https://issues.apache.org/jira/browse/CALCITE-6152 Project: Calcite Issue Type: New Feature Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6151) Test against Go 1.20 and 1.21
Francis Chuang created CALCITE-6151: --- Summary: Test against Go 1.20 and 1.21 Key: CALCITE-6151 URL: https://issues.apache.org/jira/browse/CALCITE-6151 Project: Calcite Issue Type: New Feature Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5957) Valid DATE '1945-2-2' is not accepted due to regression
[ https://issues.apache.org/jira/browse/CALCITE-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-5957: Fix Version/s: (was: avatica-1.24.0) > Valid DATE '1945-2-2' is not accepted due to regression > --- > > Key: CALCITE-5957 > URL: https://issues.apache.org/jira/browse/CALCITE-5957 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.35.0 >Reporter: Runkang He >Assignee: Guillaume Massé >Priority: Blocker > Labels: pull-request-available > Attachments: image-2023-08-27-19-09-33-284.png > > Time Spent: 40m > Remaining Estimate: 0h > > DATE '1945-2-2' is a valid date. In CALCITE-5923 when we turn on the result > check of `testCastStringToDateTime`, we find that Calcite accepted DATE > '1945-2-2' before CALCITE-5678 but not afterwards, so this is a regression > that we need to fix. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6057) Release Avatica 1.24.0
[ https://issues.apache.org/jira/browse/CALCITE-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6057. - Resolution: Fixed > Release Avatica 1.24.0 > -- > > Key: CALCITE-6057 > URL: https://issues.apache.org/jira/browse/CALCITE-6057 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Julian Hyde >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.24.0 > > > Release Avatica 1.24.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-4870) ping phoenix encounter EOF issue
[
https://issues.apache.org/jira/browse/CALCITE-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-4870.
-
Resolution: Invalid
> ping phoenix encounter EOF issue
>
>
> Key: CALCITE-4870
> URL: https://issues.apache.org/jira/browse/CALCITE-4870
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Reporter: yspursy
>Assignee: Francis Chuang
>Priority: Major
>
> {code:java}
> {code}
> *my code is:*
> {code:java}
> package main
> import (
>"database/sql"
>"fmt"
> _ "github.com/apache/calcite-avatica-go/v5"
> )
> func main() {
>db, err := sql.Open("avatica", "http://10.120.100.134:2181/bi;)
>fmt.Println("Come in please")
>if err != nil {
> fmt.Printf("The error is %v\n", err)
>}
>if err := db.Ping(); err != nil{
> fmt.Printf("opon database fail, %+v", err)
> return
>}
>fmt.Println("connnect success")
> }
> {code}
>
> i encounter the issue:
> {code:java}
> // code placeholder
> opon database fail, error executing http request:
> github.com/apache/calcite-avatica-go/v5.(*httpClient).post
>
> /Users/yangyang/.gvm/pkgsets/system/global/pkg/mod/github.com/apache/calcite-avatica-go/v5@v5.0.0/http_client.go:131
> - Post "http://10.120.100.134:2181/bi": EOF[bi@ip-10-120-12-23 ~]$ telnet
> 10.120.100.134 2181
> {code}
>
> I have test phoenix port is ok
> {code:java}
> // code placeholder
> telnet 10.120.100.134 2181
>
> Trying 10.120.100.134...
> Connected to 10.120.100.134.
> Escape character is '^]'.{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-5719) Issues with connection and authentication with Apache Druid
[
https://issues.apache.org/jira/browse/CALCITE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-5719.
-
Resolution: Duplicate
Closing as the underlying Jira issues have been resolved.
> Issues with connection and authentication with Apache Druid
> ---
>
> Key: CALCITE-5719
> URL: https://issues.apache.org/jira/browse/CALCITE-5719
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Reporter: Parag Jain
>Assignee: Francis Chuang
>Priority: Major
> Labels: avatica
>
> We are using calcite-avatica-go driver to connect to Apache Druid and facing
> few issues -
> # In Go sql package when an idle connection is picked from the pool,
> *ResetSession* method is called on the connection. In the drivers
> implementation of this method
> [here|https://github.com/apache/calcite-avatica-go/blob/main/connection.go#L236],
> *registerConn* method is called which actually does an
> *OpenConnectionRequest* with the existing connectionId. On the Druid side it
> actually throws an exception
> [here|https://github.com/apache/druid/blob/master/sql/src/main/java/org/apache/druid/sql/avatica/DruidMeta.java#L823]
> saying the connection is already open. I checked other driver
> implementations like
> [postgres|https://github.com/jackc/pgx/blob/master/stdlib/sql.go#L307] and
> [mysql|https://github.com/go-sql-driver/mysql/blob/master/connection.go#L638]
> for ResetSession method and they actually don't open a new connection. So not
> sure about the reason for doing this here. Any thoughts on this ? Example
> exception stack trace -
> {code:java}
> 2023-05-22T19:24:47,357 ERROR [qtp44562-140]
> org.apache.druid.sql.avatica.DruidMeta - Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> org.apache.druid.java.util.common.ISE: Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> at
> org.apache.druid.sql.avatica.DruidMeta.openDruidConnection(DruidMeta.java:823)
> ~[classes/:?]
> at
> org.apache.druid.sql.avatica.DruidMeta.openConnection(DruidMeta.java:208)
> ~[classes/:?]
> at
> org.apache.calcite.avatica.remote.LocalService.apply(LocalService.java:285)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1770)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1750)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.AbstractHandler.apply(AbstractHandler.java:94)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.ProtobufHandler.apply(ProtobufHandler.java:46)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.server.AvaticaProtobufHandler.handle(AvaticaProtobufHandler.java:126)
> ~[avatica-server-1.17.0.jar:1.17.0]
> at
> org.apache.druid.sql.avatica.DruidAvaticaProtobufHandler.handle(DruidAvaticaProtobufHandler.java:61)
> ~[classes/:?] {code}
> 2. Username and pwd not being propagated in the JDBC context. Had to add
> the following code in the
> [Connect|https://github.com/apache/calcite-avatica-go/blob/main/driver.go#L64]
> method of driver.go to make it work
> {code:java}
> if config.avaticaUser != "" {
> c.Info["user"] = config.avaticaUser
> }
> if config.avaticaPassword != "" {
> c.Info["password"] = config.avaticaPassword
> } {code}
> 3. My colleague (Benjamin) found open statement leak as well, fixed
> [here|https://github.com/apache/calcite-avatica-go/commit/9c0eba2fbe15b3f877ee276b889cbd39e1a8ce2d]
> We plan to contribute all back once the issues are fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-6139) Avatica-Go sends the same offset for the FetchRequest
[
https://issues.apache.org/jira/browse/CALCITE-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-6139.
-
Resolution: Fixed
> Avatica-Go sends the same offset for the FetchRequest
> -
>
> Key: CALCITE-6139
> URL: https://issues.apache.org/jira/browse/CALCITE-6139
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: avatica-go-5.2.0
>Reporter: Egor Ryashin
>Assignee: Egor Ryashin
>Priority: Major
> Fix For: avatica-go-5.3.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This exception happens when *Apache Druid Avatica* protobuf endpoint is used:
> {_}"Druid can only fetch forward. Requested offset”{_}.
> I tried to debug that and saw that any simple query fails if it triggers
> fetching of multiple frames. I speculate that when the first *ExucuteRequest*
> is sent
> {code:java}
> msg := {
> StatementHandle: s.handle,
> ParameterValues: s.parametersToTypedValues(args),
> FirstFrameMaxSize: s.conn.config.frameMaxSize,
> HasParameterValues: true,
> }{code}
> and the result set is created after
> {code:java}
> rsets = append(rsets, {
> columns: columns,
> done: frame.Done,
> offset: frame.Offset,
> data: data,
> }){code}
> then for the next frame *FetchRequest* is sent but it uses the same 0 offset
> (the data for that offset was returned with the {*}ExecuteRequest{*})
> res, err := r.conn.httpClient.post(context.Background(),
> {
> {code:java}
> ConnectionId: r.conn.connectionId,
> StatementId: r.statementID,
> Offset: resultSet.offset,
> FrameMaxSize: r.conn.config.frameMaxSize,
> }){code}
> So, in short, I think *Avatica-Go* sends 2 requests with the same offset that
> makes Druid to fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6139) Avatica-Go sends the same offset for the FetchRequest
[
https://issues.apache.org/jira/browse/CALCITE-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang updated CALCITE-6139:
Fix Version/s: avatica-go-5.3.0
> Avatica-Go sends the same offset for the FetchRequest
> -
>
> Key: CALCITE-6139
> URL: https://issues.apache.org/jira/browse/CALCITE-6139
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: avatica-go-5.2.0
>Reporter: Egor Ryashin
>Assignee: Egor Ryashin
>Priority: Major
> Fix For: avatica-go-5.3.0
>
>
> This exception happens when *Apache Druid Avatica* protobuf endpoint is used:
> {_}"Druid can only fetch forward. Requested offset”{_}.
> I tried to debug that and saw that any simple query fails if it triggers
> fetching of multiple frames. I speculate that when the first *ExucuteRequest*
> is sent
> {code:java}
> msg := {
> StatementHandle: s.handle,
> ParameterValues: s.parametersToTypedValues(args),
> FirstFrameMaxSize: s.conn.config.frameMaxSize,
> HasParameterValues: true,
> }{code}
> and the result set is created after
> {code:java}
> rsets = append(rsets, {
> columns: columns,
> done: frame.Done,
> offset: frame.Offset,
> data: data,
> }){code}
> then for the next frame *FetchRequest* is sent but it uses the same 0 offset
> (the data for that offset was returned with the {*}ExecuteRequest{*})
> res, err := r.conn.httpClient.post(context.Background(),
> {
> {code:java}
> ConnectionId: r.conn.connectionId,
> StatementId: r.statementID,
> Offset: resultSet.offset,
> FrameMaxSize: r.conn.config.frameMaxSize,
> }){code}
> So, in short, I think *Avatica-Go* sends 2 requests with the same offset that
> makes Druid to fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (CALCITE-6139) Avatica-Go sends the same offset for the FetchRequest
[
https://issues.apache.org/jira/browse/CALCITE-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang reassigned CALCITE-6139:
---
Assignee: Egor Ryashin (was: Francis Chuang)
> Avatica-Go sends the same offset for the FetchRequest
> -
>
> Key: CALCITE-6139
> URL: https://issues.apache.org/jira/browse/CALCITE-6139
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: avatica-go-5.2.0
>Reporter: Egor Ryashin
>Assignee: Egor Ryashin
>Priority: Major
>
> This exception happens when *Apache Druid Avatica* protobuf endpoint is used:
> {_}"Druid can only fetch forward. Requested offset”{_}.
> I tried to debug that and saw that any simple query fails if it triggers
> fetching of multiple frames. I speculate that when the first *ExucuteRequest*
> is sent
> {code:java}
> msg := {
> StatementHandle: s.handle,
> ParameterValues: s.parametersToTypedValues(args),
> FirstFrameMaxSize: s.conn.config.frameMaxSize,
> HasParameterValues: true,
> }{code}
> and the result set is created after
> {code:java}
> rsets = append(rsets, {
> columns: columns,
> done: frame.Done,
> offset: frame.Offset,
> data: data,
> }){code}
> then for the next frame *FetchRequest* is sent but it uses the same 0 offset
> (the data for that offset was returned with the {*}ExecuteRequest{*})
> res, err := r.conn.httpClient.post(context.Background(),
> {
> {code:java}
> ConnectionId: r.conn.connectionId,
> StatementId: r.statementID,
> Offset: resultSet.offset,
> FrameMaxSize: r.conn.config.frameMaxSize,
> }){code}
> So, in short, I think *Avatica-Go* sends 2 requests with the same offset that
> makes Druid to fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6141) Add a dedicated gradle property for the checkstyle version to be used with jdk8
[ https://issues.apache.org/jira/browse/CALCITE-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6141: Fix Version/s: avatica-1.24.0 > Add a dedicated gradle property for the checkstyle version to be used with > jdk8 > --- > > Key: CALCITE-6141 > URL: https://issues.apache.org/jira/browse/CALCITE-6141 > Project: Calcite > Issue Type: Improvement > Components: avatica >Affects Versions: avatica-1.23.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The issue is that in case of jdk8 in order to compile it with jdk8 there > should be specified checkstyle version. > Since current java version could be detected during compilation it could also > detect which checkstyle version should be used. > This issue was also mentioned in ML > https://lists.apache.org/thread/r27kdvvhr0222nqlog7xzn5y3yjvz6jp -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6141) Add a dedicated gradle property for the checkstyle version to be used with jdk8
[ https://issues.apache.org/jira/browse/CALCITE-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6141. - Resolution: Fixed > Add a dedicated gradle property for the checkstyle version to be used with > jdk8 > --- > > Key: CALCITE-6141 > URL: https://issues.apache.org/jira/browse/CALCITE-6141 > Project: Calcite > Issue Type: Improvement > Components: avatica >Affects Versions: avatica-1.23.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The issue is that in case of jdk8 in order to compile it with jdk8 there > should be specified checkstyle version. > Since current java version could be detected during compilation it could also > detect which checkstyle version should be used. > This issue was also mentioned in ML > https://lists.apache.org/thread/r27kdvvhr0222nqlog7xzn5y3yjvz6jp -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-6139) Avatica-Go sends the same offset for the FetchRequest
[
https://issues.apache.org/jira/browse/CALCITE-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790507#comment-17790507
]
Francis Chuang commented on CALCITE-6139:
-
Can you edit row.go per my previous comment so that we can see if the server is
sending back the correct offset?
> Avatica-Go sends the same offset for the FetchRequest
> -
>
> Key: CALCITE-6139
> URL: https://issues.apache.org/jira/browse/CALCITE-6139
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: avatica-go-5.2.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
>
> This exception happens when *Apache Druid Avatica* protobuf endpoint is used:
> {_}"Druid can only fetch forward. Requested offset”{_}.
> I tried to debug that and saw that any simple query fails if it triggers
> fetching of multiple frames. I speculate that when the first *ExucuteRequest*
> is sent
> {code:java}
> msg := {
> StatementHandle: s.handle,
> ParameterValues: s.parametersToTypedValues(args),
> FirstFrameMaxSize: s.conn.config.frameMaxSize,
> HasParameterValues: true,
> }{code}
> and the result set is created after
> {code:java}
> rsets = append(rsets, {
> columns: columns,
> done: frame.Done,
> offset: frame.Offset,
> data: data,
> }){code}
> then for the next frame *FetchRequest* is sent but it uses the same 0 offset
> (the data for that offset was returned with the {*}ExecuteRequest{*})
> res, err := r.conn.httpClient.post(context.Background(),
> {
> {code:java}
> ConnectionId: r.conn.connectionId,
> StatementId: r.statementID,
> Offset: resultSet.offset,
> FrameMaxSize: r.conn.config.frameMaxSize,
> }){code}
> So, in short, I think *Avatica-Go* sends 2 requests with the same offset that
> makes Druid to fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CALCITE-6139) Avatica-Go sends the same offset for the FetchRequest
[
https://issues.apache.org/jira/browse/CALCITE-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790504#comment-17790504
]
Francis Chuang commented on CALCITE-6139:
-
Please run `go mod vendor` in your project to use vendoring and edit `row.go`
to add `fmt.Println(frame)` here:
[https://github.com/apache/calcite-avatica-go/blob/main/rows.go#L111]
When you do that, is offset populated in the frame returned from the server?
> Avatica-Go sends the same offset for the FetchRequest
> -
>
> Key: CALCITE-6139
> URL: https://issues.apache.org/jira/browse/CALCITE-6139
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: avatica-go-5.2.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
>
> This exception happens when *Apache Druid Avatica* protobuf endpoint is used:
> {_}"Druid can only fetch forward. Requested offset”{_}.
> I tried to debug that and saw that any simple query fails if it triggers
> fetching of multiple frames. I speculate that when the first *ExucuteRequest*
> is sent
> {code:java}
> msg := {
> StatementHandle: s.handle,
> ParameterValues: s.parametersToTypedValues(args),
> FirstFrameMaxSize: s.conn.config.frameMaxSize,
> HasParameterValues: true,
> }{code}
> and the result set is created after
> {code:java}
> rsets = append(rsets, {
> columns: columns,
> done: frame.Done,
> offset: frame.Offset,
> data: data,
> }){code}
> then for the next frame *FetchRequest* is sent but it uses the same 0 offset
> (the data for that offset was returned with the {*}ExecuteRequest{*})
> res, err := r.conn.httpClient.post(context.Background(),
> {
> {code:java}
> ConnectionId: r.conn.connectionId,
> StatementId: r.statementID,
> Offset: resultSet.offset,
> FrameMaxSize: r.conn.config.frameMaxSize,
> }){code}
> So, in short, I think *Avatica-Go* sends 2 requests with the same offset that
> makes Druid to fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-6108) SQL request to Avatica-Go returns 0s for float types
[
https://issues.apache.org/jira/browse/CALCITE-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-6108.
-
Resolution: Invalid
> SQL request to Avatica-Go returns 0s for float types
>
>
> Key: CALCITE-6108
> URL: https://issues.apache.org/jira/browse/CALCITE-6108
> Project: Calcite
> Issue Type: Bug
> Components: avatica, avatica-go, druid-adapter
>Affects Versions: 1.35.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
> Attachments: image-2023-11-11-20-42-55-846.png,
> image-2023-11-11-20-43-33-198.png, image-2023-11-11-20-43-49-485.png,
> image-2023-11-12-10-56-10-382.png, image-2023-11-13-12-03-43-954.png
>
>
> I have zeros for float types in Go client result set with Calcite 1.35 update
> in Apache Druid. It worked with an older version. From what I see in the
> debugger TypedValue.NumberValue = 0 but DoubleValue = 1. Not sure where's the
> bug exactly - Druid/Avatica.
> This is how it can be reproduced:
> {code:java}
> package main
> import (
> "database/sql"
> "fmt"
> _ "github.com/apache/calcite-avatica-go/v5"
> )
> func main() {
> jdbcUrl := "https://localhost/druid/v2/sql/avatica-protobuf;
> db, err := sql.Open("avatica", jdbcUrl)
> if err != nil {
> panic(err)
> }
> defer db.Close()
> sql4 := `
> SELECT
> cast(1.0 as double) m3
> `
> rows, err := db.Query(sql4)
> if err != nil {
> panic(err)
> }
> defer rows.Close()
> var m1 float32
> for rows.Next() {
> err := rows.Scan()
> if err != nil {
> panic(err)
> }
> fmt.Println(m1)
> }
> } {code}
> What I see in the debugger right now:
> !image-2023-11-11-20-43-49-485.png!
> This is what I see in the Druid debugger:
> !image-2023-11-11-20-42-55-846.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CALCITE-6108) SQL request to Avatica-Go returns 0s for float types
[
https://issues.apache.org/jira/browse/CALCITE-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789865#comment-17789865
]
Francis Chuang commented on CALCITE-6108:
-
I am going to close this as the bug seems to be in Druid and not avatica or
avatica-go.
> SQL request to Avatica-Go returns 0s for float types
>
>
> Key: CALCITE-6108
> URL: https://issues.apache.org/jira/browse/CALCITE-6108
> Project: Calcite
> Issue Type: Bug
> Components: avatica, avatica-go, druid-adapter
>Affects Versions: 1.35.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
> Attachments: image-2023-11-11-20-42-55-846.png,
> image-2023-11-11-20-43-33-198.png, image-2023-11-11-20-43-49-485.png,
> image-2023-11-12-10-56-10-382.png, image-2023-11-13-12-03-43-954.png
>
>
> I have zeros for float types in Go client result set with Calcite 1.35 update
> in Apache Druid. It worked with an older version. From what I see in the
> debugger TypedValue.NumberValue = 0 but DoubleValue = 1. Not sure where's the
> bug exactly - Druid/Avatica.
> This is how it can be reproduced:
> {code:java}
> package main
> import (
> "database/sql"
> "fmt"
> _ "github.com/apache/calcite-avatica-go/v5"
> )
> func main() {
> jdbcUrl := "https://localhost/druid/v2/sql/avatica-protobuf;
> db, err := sql.Open("avatica", jdbcUrl)
> if err != nil {
> panic(err)
> }
> defer db.Close()
> sql4 := `
> SELECT
> cast(1.0 as double) m3
> `
> rows, err := db.Query(sql4)
> if err != nil {
> panic(err)
> }
> defer rows.Close()
> var m1 float32
> for rows.Next() {
> err := rows.Scan()
> if err != nil {
> panic(err)
> }
> fmt.Println(m1)
> }
> } {code}
> What I see in the debugger right now:
> !image-2023-11-11-20-43-49-485.png!
> This is what I see in the Druid debugger:
> !image-2023-11-11-20-42-55-846.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-5981) TIMESTAMPDIFF function returns incorrect result
[
https://issues.apache.org/jira/browse/CALCITE-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang updated CALCITE-5981:
Fix Version/s: avatica-1.24.0
(was: 1.24.0)
> TIMESTAMPDIFF function returns incorrect result
>
>
> Key: CALCITE-5981
> URL: https://issues.apache.org/jira/browse/CALCITE-5981
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.23.0
>Reporter: Mihai Budiu
>Assignee: Mihai Budiu
>Priority: Minor
> Labels: pull-request-available
> Fix For: avatica-1.24.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following test fails, when added to SqlOperatorTest:
> {code:java}
> f.checkScalar("timestampdiff(month, DATE '2004-02-29', DATE '2005-02-28')",
> "11", "INTEGER NOT NULL");
> {code}
> The result returned by the expression is 12. However, MySQL returns 11.
> The semantics of this function is not described clearly in the documentation,
> but according to several prior issues [1] [2] [3] the intended semantics
> should be the same as in MySQL.
> A corresponding MySQL test: [4]
> The implementation seems to be in
> StandardConvertletTable.TimestampDiffConvertlet.
> [1] https://issues.apache.org/jira/browse/CALCITE-1827,
> [2] https://issues.apache.org/jira/browse/CALCITE-3529,
> [3] https://issues.apache.org/jira/browse/CALCITE-1124.
> [4]
> [https://github.com/mysql/mysql-server/blob/ea1efa9822d81044b726aab20c857d5e1b7e046a/mysql-test/r/func_time.result#L1151]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-5748) Support Guava 32.1.1-jre
[
https://issues.apache.org/jira/browse/CALCITE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-5748.
-
Resolution: Fixed
> Support Guava 32.1.1-jre
>
>
> Key: CALCITE-5748
> URL: https://issues.apache.org/jira/browse/CALCITE-5748
> Project: Calcite
> Issue Type: Bug
>Affects Versions: avatica-1.24.0, 1.35.0
>Reporter: Sergey Nuyanzin
>Assignee: Sergey Nuyanzin
>Priority: Major
> Labels: pull-request-available
> Fix For: avatica-1.24.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> There is guava 32.1.1 available.
> Besides version change there are a couple of issues:
> 1. Some methods start failing on {{CheckReturnValue}}
> -2. RedisTests start failing with NPE on Windows- (this should not be an
> issue anymore with 32.0.1)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6107) Upgrade vlsi-release-plugins to 1.90
[ https://issues.apache.org/jira/browse/CALCITE-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6107: Fix Version/s: avatica-1.24.0 > Upgrade vlsi-release-plugins to 1.90 > > > Key: CALCITE-6107 > URL: https://issues.apache.org/jira/browse/CALCITE-6107 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.24.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6106) Switch from gradle to eclipse-temurin image for avatica docker-compose release commands
[ https://issues.apache.org/jira/browse/CALCITE-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6106: Fix Version/s: avatica-1.24.0 > Switch from gradle to eclipse-temurin image for avatica docker-compose > release commands > --- > > Key: CALCITE-6106 > URL: https://issues.apache.org/jira/browse/CALCITE-6106 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Switch to the eclipse-temurin image and call ./gradlew instead of gradle, so > the gradle version used is never out of sync. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (CALCITE-6112) Use indelible release tags
[ https://issues.apache.org/jira/browse/CALCITE-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785440#comment-17785440 ] Francis Chuang edited comment on CALCITE-6112 at 11/13/23 8:50 PM: --- Avatica-go is a Go project and its release tags must be in the form vX.Y.Z in order to be discoverable by the modules/dependency system that is used by Go. What's the advice for this? Should we keep tagging as vX.Y.Z, supplement it with a rel/vX.Y.Z tag, or eschew the vX.Y.Z tag completely, leaving the rel/vX.Y.Z tag only (which will break go modules)? was (Author: francischuang): Avatica-go is a Go project and it's release tags must be in the form vX.Y.Z in order to be discoverable by the modules/dependency system that is used by Go. What's the advice for this? Should we keep tagging as vX.Y.Z, supplement it with a rel/vX.Y.Z tag, or eschew the vX.Y.Z tag completely, leaving the rel/vX.Y.Z tag only (which will break go modules)? > Use indelible release tags > -- > > Key: CALCITE-6112 > URL: https://issues.apache.org/jira/browse/CALCITE-6112 > Project: Calcite > Issue Type: Improvement >Reporter: Vladimir Sitnikov >Priority: Major > > The ASF has recommended using indelible Git tags (rel/...) since 2016: > [https://lists.apache.org/thread/szbtzk0048ppx1zvzljbrq7by2mt1zvs] > It turns out that has broken in Calcite since 2020: > [https://github.com/apache/calcite/commit/2e30293af7373b6c5fbcc5fa6505b49df2fba000] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-6112) Use inedible release tags
[ https://issues.apache.org/jira/browse/CALCITE-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785440#comment-17785440 ] Francis Chuang commented on CALCITE-6112: - Avatica-go is a Go project and it's release tags must be in the form vX.Y.Z in order to be discoverable by the modules/dependency system that is used by Go. What's the advice for this? Should we keep tagging as vX.Y.Z, supplement it with a rel/vX.Y.Z tag, or eschew the vX.Y.Z tag completely, leaving the rel/vX.Y.Z tag only (which will break go modules)? > Use inedible release tags > - > > Key: CALCITE-6112 > URL: https://issues.apache.org/jira/browse/CALCITE-6112 > Project: Calcite > Issue Type: Improvement >Reporter: Vladimir Sitnikov >Priority: Major > > The ASF has recommended using inedible Git tags (rel/...) since 2016: > https://lists.apache.org/thread/szbtzk0048ppx1zvzljbrq7by2mt1zvs > It turns out that has broken in Calcite since 2020: > https://github.com/apache/calcite/commit/2e30293af7373b6c5fbcc5fa6505b49df2fba000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6110) Release Avatica-Go 5.3.0
Francis Chuang created CALCITE-6110: --- Summary: Release Avatica-Go 5.3.0 Key: CALCITE-6110 URL: https://issues.apache.org/jira/browse/CALCITE-6110 Project: Calcite Issue Type: New Feature Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-6108) SQL request to Avatica-Go returns 0s for float types
[
https://issues.apache.org/jira/browse/CALCITE-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785343#comment-17785343
]
Francis Chuang commented on CALCITE-6108:
-
Avatica-Go v5 was released more than a year ago. Was this a problem before
then? Can you try downgrading druid, so that we can verify if the issue is in
Avatica-Go?
> SQL request to Avatica-Go returns 0s for float types
>
>
> Key: CALCITE-6108
> URL: https://issues.apache.org/jira/browse/CALCITE-6108
> Project: Calcite
> Issue Type: Bug
> Components: avatica, avatica-go, druid-adapter
>Affects Versions: 1.35.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
> Attachments: image-2023-11-11-20-42-55-846.png,
> image-2023-11-11-20-43-33-198.png, image-2023-11-11-20-43-49-485.png,
> image-2023-11-12-10-56-10-382.png
>
>
> I have zeros for float types in Go client result set with Calcite 1.35 update
> in Apache Druid. It worked with an older version. From what I see in the
> debugger TypedValue.NumberValue = 0 but DoubleValue = 1. Not sure where's the
> bug exactly - Druid/Avatica.
> This is how it can be reproduced:
> {code:java}
> package main
> import (
> "database/sql"
> "fmt"
> _ "github.com/apache/calcite-avatica-go/v5"
> )
> func main() {
> jdbcUrl := "https://localhost/druid/v2/sql/avatica-protobuf;
> db, err := sql.Open("avatica", jdbcUrl)
> if err != nil {
> panic(err)
> }
> defer db.Close()
> sql4 := `
> SELECT
> cast(1.0 as double) m3
> `
> rows, err := db.Query(sql4)
> if err != nil {
> panic(err)
> }
> defer rows.Close()
> var m1 float32
> for rows.Next() {
> err := rows.Scan()
> if err != nil {
> panic(err)
> }
> fmt.Println(m1)
> }
> } {code}
> What I see in the debugger right now:
> !image-2023-11-11-20-43-49-485.png!
> This is what I see in the Druid debugger:
> !image-2023-11-11-20-42-55-846.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-6107) Upgrade vlsi-release-plugins to 1.90
[ https://issues.apache.org/jira/browse/CALCITE-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6107. - Resolution: Fixed > Upgrade vlsi-release-plugins to 1.90 > > > Key: CALCITE-6107 > URL: https://issues.apache.org/jira/browse/CALCITE-6107 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6107) Upgrade vlsi-release-plugins to 1.90
[ https://issues.apache.org/jira/browse/CALCITE-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6107: Component/s: (was: core) > Upgrade vlsi-release-plugins to 1.90 > > > Key: CALCITE-6107 > URL: https://issues.apache.org/jira/browse/CALCITE-6107 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6107) Upgrade vlsi-release-plugins to 1.90
Francis Chuang created CALCITE-6107: --- Summary: Upgrade vlsi-release-plugins to 1.90 Key: CALCITE-6107 URL: https://issues.apache.org/jira/browse/CALCITE-6107 Project: Calcite Issue Type: New Feature Components: avatica, core Reporter: Francis Chuang Assignee: Francis Chuang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6106) Switch from gradle to eclipse-temurin image for avatica docker-compose release commands
[ https://issues.apache.org/jira/browse/CALCITE-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6106. - Resolution: Fixed > Switch from gradle to eclipse-temurin image for avatica docker-compose > release commands > --- > > Key: CALCITE-6106 > URL: https://issues.apache.org/jira/browse/CALCITE-6106 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Switch to the eclipse-temurin image and call ./gradlew instead of gradle, so > the gradle version used is never out of sync. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6103) Use eclipse-temurin image to build and publish javadocs for the website
[
https://issues.apache.org/jira/browse/CALCITE-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-6103.
-
Resolution: Fixed
> Use eclipse-temurin image to build and publish javadocs for the website
> ---
>
> Key: CALCITE-6103
> URL: https://issues.apache.org/jira/browse/CALCITE-6103
> Project: Calcite
> Issue Type: New Feature
> Components: core, site
>Reporter: Francis Chuang
>Assignee: Francis Chuang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.37.0
>
>
> Javadoc builds currently fail in GitHub Actions:
> {code:java}
> Run docker-compose run generate-javadoc
>
> Pulling generate-javadoc (openjdk:17)...
> 17: Pulling from library/openjdk
> Digest:
> sha256:528707081fdb9562eb819128a9f85ae7fe000e2fbaeaf9f87662e7b3f38cb7d8
> Status: Downloaded newer image for openjdk:17
> Creating site_generate-javadoc_run ...
> Creating site_generate-javadoc_run ... done
> xargs is not available
> mv: cannot stat 'build/docs/javadocAggregate': No such file or directory
> 1
> Error: Process completed with exit code 1.
> {code}
> There was probably a change in the openjdk:17 image, which has since been
> deprecated. As a fix, we should move to the eclipse-temurin, which is a
> direct replacement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (CALCITE-6106) Switch from gradle to eclipse-temurin image for avatica docker-compose release commands
Francis Chuang created CALCITE-6106: --- Summary: Switch from gradle to eclipse-temurin image for avatica docker-compose release commands Key: CALCITE-6106 URL: https://issues.apache.org/jira/browse/CALCITE-6106 Project: Calcite Issue Type: New Feature Components: avatica Reporter: Francis Chuang Assignee: Francis Chuang Switch to the eclipse-temurin image and call ./gradlew instead of gradle, so the gradle version used is never out of sync. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6103) Use eclipse-temurin image to build and publish javadocs for the website
[
https://issues.apache.org/jira/browse/CALCITE-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang updated CALCITE-6103:
Summary: Use eclipse-temurin image to build and publish javadocs for the
website (was: Use eclipse-temurin to build and publish javadocs for the
website)
> Use eclipse-temurin image to build and publish javadocs for the website
> ---
>
> Key: CALCITE-6103
> URL: https://issues.apache.org/jira/browse/CALCITE-6103
> Project: Calcite
> Issue Type: New Feature
> Components: core, site
>Reporter: Francis Chuang
>Assignee: Francis Chuang
>Priority: Major
> Fix For: 1.37.0
>
>
> Javadoc builds currently fail in GitHub Actions:
> {code:java}
> Run docker-compose run generate-javadoc
>
> Pulling generate-javadoc (openjdk:17)...
> 17: Pulling from library/openjdk
> Digest:
> sha256:528707081fdb9562eb819128a9f85ae7fe000e2fbaeaf9f87662e7b3f38cb7d8
> Status: Downloaded newer image for openjdk:17
> Creating site_generate-javadoc_run ...
> Creating site_generate-javadoc_run ... done
> xargs is not available
> mv: cannot stat 'build/docs/javadocAggregate': No such file or directory
> 1
> Error: Process completed with exit code 1.
> {code}
> There was probably a change in the openjdk:17 image, which has since been
> deprecated. As a fix, we should move to the eclipse-temurin, which is a
> direct replacement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6103) Use eclipse-temurin to build and publish javadocs for the website
[
https://issues.apache.org/jira/browse/CALCITE-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang updated CALCITE-6103:
Component/s: (was: avatica)
> Use eclipse-temurin to build and publish javadocs for the website
> -
>
> Key: CALCITE-6103
> URL: https://issues.apache.org/jira/browse/CALCITE-6103
> Project: Calcite
> Issue Type: New Feature
> Components: core, site
>Reporter: Francis Chuang
>Assignee: Francis Chuang
>Priority: Major
> Fix For: 1.37.0
>
>
> Javadoc builds currently fail in GitHub Actions:
> {code:java}
> Run docker-compose run generate-javadoc
>
> Pulling generate-javadoc (openjdk:17)...
> 17: Pulling from library/openjdk
> Digest:
> sha256:528707081fdb9562eb819128a9f85ae7fe000e2fbaeaf9f87662e7b3f38cb7d8
> Status: Downloaded newer image for openjdk:17
> Creating site_generate-javadoc_run ...
> Creating site_generate-javadoc_run ... done
> xargs is not available
> mv: cannot stat 'build/docs/javadocAggregate': No such file or directory
> 1
> Error: Process completed with exit code 1.
> {code}
> There was probably a change in the openjdk:17 image, which has since been
> deprecated. As a fix, we should move to the eclipse-temurin, which is a
> direct replacement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (CALCITE-6103) Use eclipse-temurin to build and publish javadocs for the website
Francis Chuang created CALCITE-6103:
---
Summary: Use eclipse-temurin to build and publish javadocs for the
website
Key: CALCITE-6103
URL: https://issues.apache.org/jira/browse/CALCITE-6103
Project: Calcite
Issue Type: New Feature
Components: avatica, core, site
Reporter: Francis Chuang
Assignee: Francis Chuang
Fix For: 1.37.0
Javadoc builds currently fail in GitHub Actions:
{code:java}
Run docker-compose run generate-javadoc
Pulling generate-javadoc (openjdk:17)...
17: Pulling from library/openjdk
Digest: sha256:528707081fdb9562eb819128a9f85ae7fe000e2fbaeaf9f87662e7b3f38cb7d8
Status: Downloaded newer image for openjdk:17
Creating site_generate-javadoc_run ...
Creating site_generate-javadoc_run ... done
xargs is not available
mv: cannot stat 'build/docs/javadocAggregate': No such file or directory
1
Error: Process completed with exit code 1.
{code}
There was probably a change in the openjdk:17 image, which has since been
deprecated. As a fix, we should move to the eclipse-temurin, which is a direct
replacement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (CALCITE-6057) Release Avatica 1.24.0
[ https://issues.apache.org/jira/browse/CALCITE-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang reassigned CALCITE-6057: --- Assignee: Francis Chuang > Release Avatica 1.24.0 > -- > > Key: CALCITE-6057 > URL: https://issues.apache.org/jira/browse/CALCITE-6057 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Julian Hyde >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-1.24.0 > > > Release Avatica 1.24.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5854) Test against Go 1.19 and 1.20
[ https://issues.apache.org/jira/browse/CALCITE-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-5854. - Resolution: Fixed > Test against Go 1.19 and 1.20 > - > > Key: CALCITE-5854 > URL: https://issues.apache.org/jira/browse/CALCITE-5854 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5854) Test against Go 1.19 and 1.20
Francis Chuang created CALCITE-5854: --- Summary: Test against Go 1.19 and 1.20 Key: CALCITE-5854 URL: https://issues.apache.org/jira/browse/CALCITE-5854 Project: Calcite Issue Type: New Feature Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5853) Use HBase Phoenix images from GitHub container registry
[ https://issues.apache.org/jira/browse/CALCITE-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-5853. - Resolution: Fixed > Use HBase Phoenix images from GitHub container registry > --- > > Key: CALCITE-5853 > URL: https://issues.apache.org/jira/browse/CALCITE-5853 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Trivial > Fix For: avatica-go-5.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5853) Use HBase Phoenix images from GitHub container registry
Francis Chuang created CALCITE-5853: --- Summary: Use HBase Phoenix images from GitHub container registry Key: CALCITE-5853 URL: https://issues.apache.org/jira/browse/CALCITE-5853 Project: Calcite Issue Type: New Feature Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5792) Update dependencies to latest version
[ https://issues.apache.org/jira/browse/CALCITE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-5792. - Resolution: Fixed > Update dependencies to latest version > - > > Key: CALCITE-5792 > URL: https://issues.apache.org/jira/browse/CALCITE-5792 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Reporter: Parag Jain >Assignee: Parag Jain >Priority: Major > Fix For: avatica-go-5.3.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Update dependencies to latest version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (CALCITE-5792) Update dependencies to latest version
[ https://issues.apache.org/jira/browse/CALCITE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang reassigned CALCITE-5792: --- Assignee: Parag Jain (was: Francis Chuang) > Update dependencies to latest version > - > > Key: CALCITE-5792 > URL: https://issues.apache.org/jira/browse/CALCITE-5792 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Reporter: Parag Jain >Assignee: Parag Jain >Priority: Major > Fix For: avatica-go-5.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update dependencies to latest version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5792) Update dependencies to latest version
[ https://issues.apache.org/jira/browse/CALCITE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-5792: Fix Version/s: avatica-go-5.3.0 > Update dependencies to latest version > - > > Key: CALCITE-5792 > URL: https://issues.apache.org/jira/browse/CALCITE-5792 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Reporter: Parag Jain >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update dependencies to latest version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5758) Initialize connector info map to prevent panic
[ https://issues.apache.org/jira/browse/CALCITE-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-5758: Issue Type: Bug (was: New Feature) > Initialize connector info map to prevent panic > -- > > Key: CALCITE-5758 > URL: https://issues.apache.org/jira/browse/CALCITE-5758 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5758) Initialize connector info map to prevent panic
[ https://issues.apache.org/jira/browse/CALCITE-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-5758. - Resolution: Fixed > Initialize connector info map to prevent panic > -- > > Key: CALCITE-5758 > URL: https://issues.apache.org/jira/browse/CALCITE-5758 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5758) Initialize connector info map to prevent panic
[ https://issues.apache.org/jira/browse/CALCITE-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-5758: Summary: Initialize connector info map to prevent panic (was: Initialize connector info map) > Initialize connector info map to prevent panic > -- > > Key: CALCITE-5758 > URL: https://issues.apache.org/jira/browse/CALCITE-5758 > Project: Calcite > Issue Type: New Feature > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5758) Initialize connector info map
Francis Chuang created CALCITE-5758: --- Summary: Initialize connector info map Key: CALCITE-5758 URL: https://issues.apache.org/jira/browse/CALCITE-5758 Project: Calcite Issue Type: New Feature Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5752) Error during session reset in avatica go driver
[
https://issues.apache.org/jira/browse/CALCITE-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-5752.
-
Fix Version/s: avatica-go-5.3.0
Resolution: Fixed
> Error during session reset in avatica go driver
> ---
>
> Key: CALCITE-5752
> URL: https://issues.apache.org/jira/browse/CALCITE-5752
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: 1.34.0
>Reporter: Parag Jain
>Assignee: Francis Chuang
>Priority: Major
> Fix For: avatica-go-5.3.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In Go sql package when an idle connection is picked from the pool,
> *ResetSession* method is called on the connection. In the drivers
> implementation of this method
> [here|https://github.com/apache/calcite-avatica-go/blob/main/connection.go#L236],
> *registerConn* method is called which actually does an
> *OpenConnectionRequest* with the existing connectionId. On the Druid side it
> actually throws an exception
> [here|https://github.com/apache/druid/blob/master/sql/src/main/java/org/apache/druid/sql/avatica/DruidMeta.java#L823]
> saying the connection is already open. I checked other driver
> implementations like
> [postgres|https://github.com/jackc/pgx/blob/master/stdlib/sql.go#L307] and
> [mysql|https://github.com/go-sql-driver/mysql/blob/master/connection.go#L638]
> for ResetSession method and they actually don't open a new connection. So not
> sure about the reason for doing this here. Any thoughts on this ? Example
> exception stack trace -
> {code:java}
> 2023-05-22T19:24:47,357 ERROR [qtp44562-140]
> org.apache.druid.sql.avatica.DruidMeta - Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> org.apache.druid.java.util.common.ISE: Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> at
> org.apache.druid.sql.avatica.DruidMeta.openDruidConnection(DruidMeta.java:823)
> ~[classes/:?]
> at
> org.apache.druid.sql.avatica.DruidMeta.openConnection(DruidMeta.java:208)
> ~[classes/:?]
> at
> org.apache.calcite.avatica.remote.LocalService.apply(LocalService.java:285)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1770)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1750)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.AbstractHandler.apply(AbstractHandler.java:94)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.ProtobufHandler.apply(ProtobufHandler.java:46)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.server.AvaticaProtobufHandler.handle(AvaticaProtobufHandler.java:126)
> ~[avatica-server-1.17.0.jar:1.17.0]
> at
> org.apache.druid.sql.avatica.DruidAvaticaProtobufHandler.handle(DruidAvaticaProtobufHandler.java:61)
> ~[classes/:?] {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-5754) Open statement leak in avatica go driver
[ https://issues.apache.org/jira/browse/CALCITE-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-5754. - Fix Version/s: avatica-go-5.3.0 Resolution: Fixed > Open statement leak in avatica go driver > > > Key: CALCITE-5754 > URL: https://issues.apache.org/jira/browse/CALCITE-5754 > Project: Calcite > Issue Type: Bug > Components: avatica-go >Affects Versions: 1.34.0 >Reporter: Parag Jain >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > My colleague (Benjamin) found open statement leak in the code where > statement close request is not sent to the database after query is executed > in exec and query methods in connection.go -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5753) User and pwd not being propagated to JDBC context from go driver
[
https://issues.apache.org/jira/browse/CALCITE-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-5753.
-
Fix Version/s: avatica-go-5.3.0
Resolution: Fixed
> User and pwd not being propagated to JDBC context from go driver
>
>
> Key: CALCITE-5753
> URL: https://issues.apache.org/jira/browse/CALCITE-5753
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Affects Versions: 1.34.0
>Reporter: Parag Jain
>Assignee: Francis Chuang
>Priority: Major
> Fix For: avatica-go-5.3.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Username and pwd not being propagated in the JDBC context. Had to add the
> following code in the
> [Connect|https://github.com/apache/calcite-avatica-go/blob/main/driver.go#L64]
> method of driver.go to make it work
> {code:java}
> if config.avaticaUser != "" {
> c.Info["user"] = config.avaticaUser
> }
> if config.avaticaPassword != "" {
> c.Info["password"] = config.avaticaPassword
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (CALCITE-5719) Issues with connection and authentication with Apache Druid
[
https://issues.apache.org/jira/browse/CALCITE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727014#comment-17727014
]
Francis Chuang edited comment on CALCITE-5719 at 5/29/23 5:49 AM:
--
[~pjain16] Appologies for not responding earlier, I totally missed the
notification in my inbox.
Addressing the issue per your points (for brevity):
1. Looking at the the interface definition for SessionResetter
(https://pkg.go.dev/database/sql/driver#SessionResetter), it should only return
ErrBadConn if the connection is bad and do nothing more. The current
implementation of reopening a new connection is incorrect and problematic. I
think the solution would be to remove the code that opens a new connection.
2. I agree, the omission of the avatica username and password should be
propagated to the connection info.
3. Great catch! Would certainly love to get this in.
Since these points all touch on orthogonal issues, I think the next course of
action would be to open an issue for each point and their respective PRs.
was (Author: francischuang):
[~pjain16] Appologies for not responding earlier, I totally missed the
notification in my inbox.
Addressing the issue per your points (for brevity):
1. Looking at the the interface definition for SessionResetter
(https://pkg.go.dev/database/sql/driver#SessionResetter), it should only return
ErrBadConn if the connection is bad and do nothing more. The current
implementation of reopening a new connection is incorrect and problematic. I
think the solution would be to remove the code that opens a new connection.
2. I agree, the omission of the avatica username and password should be
propagated to the connection info.
3. Great catch! Would certainly love to get this in.
> Issues with connection and authentication with Apache Druid
> ---
>
> Key: CALCITE-5719
> URL: https://issues.apache.org/jira/browse/CALCITE-5719
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Reporter: Parag Jain
>Assignee: Francis Chuang
>Priority: Major
> Labels: avatica
>
> We are using calcite-avatica-go driver to connect to Apache Druid and facing
> few issues -
> # In Go sql package when an idle connection is picked from the pool,
> *ResetSession* method is called on the connection. In the drivers
> implementation of this method
> [here|https://github.com/apache/calcite-avatica-go/blob/main/connection.go#L236],
> *registerConn* method is called which actually does an
> *OpenConnectionRequest* with the existing connectionId. On the Druid side it
> actually throws an exception
> [here|https://github.com/apache/druid/blob/master/sql/src/main/java/org/apache/druid/sql/avatica/DruidMeta.java#L823]
> saying the connection is already open. I checked other driver
> implementations like
> [postgres|https://github.com/jackc/pgx/blob/master/stdlib/sql.go#L307] and
> [mysql|https://github.com/go-sql-driver/mysql/blob/master/connection.go#L638]
> for ResetSession method and they actually don't open a new connection. So not
> sure about the reason for doing this here. Any thoughts on this ? Example
> exception stack trace -
> {code:java}
> 2023-05-22T19:24:47,357 ERROR [qtp44562-140]
> org.apache.druid.sql.avatica.DruidMeta - Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> org.apache.druid.java.util.common.ISE: Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> at
> org.apache.druid.sql.avatica.DruidMeta.openDruidConnection(DruidMeta.java:823)
> ~[classes/:?]
> at
> org.apache.druid.sql.avatica.DruidMeta.openConnection(DruidMeta.java:208)
> ~[classes/:?]
> at
> org.apache.calcite.avatica.remote.LocalService.apply(LocalService.java:285)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1770)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1750)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.AbstractHandler.apply(AbstractHandler.java:94)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.ProtobufHandler.apply(ProtobufHandler.java:46)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.server.AvaticaProtobufHandler.handle(AvaticaProtobufHandler.java:126)
> ~[avatica-server-1.17.0.jar:1.17.0]
> at
> org.apache.druid.sql.avatica.DruidAvaticaProtobufHandler.handle(DruidAvaticaProtobufHandler.java:61)
> ~[classes/:?] {code}
> 2. Username and pwd not being propagated in the JDBC context. Had to add
> the following code in the
>
[jira] [Commented] (CALCITE-5719) Issues with connection and authentication with Apache Druid
[
https://issues.apache.org/jira/browse/CALCITE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727014#comment-17727014
]
Francis Chuang commented on CALCITE-5719:
-
[~pjain16] Appologies for not responding earlier, I totally missed the
notification in my inbox.
Addressing the issue per your points (for brevity):
1. Looking at the the interface definition for SessionResetter
(https://pkg.go.dev/database/sql/driver#SessionResetter), it should only return
ErrBadConn if the connection is bad and do nothing more. The current
implementation of reopening a new connection is incorrect and problematic. I
think the solution would be to remove the code that opens a new connection.
2. I agree, the omission of the avatica username and password should be
propagated to the connection info.
3. Great catch! Would certainly love to get this in.
> Issues with connection and authentication with Apache Druid
> ---
>
> Key: CALCITE-5719
> URL: https://issues.apache.org/jira/browse/CALCITE-5719
> Project: Calcite
> Issue Type: Bug
> Components: avatica-go
>Reporter: Parag Jain
>Assignee: Francis Chuang
>Priority: Major
> Labels: avatica
>
> We are using calcite-avatica-go driver to connect to Apache Druid and facing
> few issues -
> # In Go sql package when an idle connection is picked from the pool,
> *ResetSession* method is called on the connection. In the drivers
> implementation of this method
> [here|https://github.com/apache/calcite-avatica-go/blob/main/connection.go#L236],
> *registerConn* method is called which actually does an
> *OpenConnectionRequest* with the existing connectionId. On the Druid side it
> actually throws an exception
> [here|https://github.com/apache/druid/blob/master/sql/src/main/java/org/apache/druid/sql/avatica/DruidMeta.java#L823]
> saying the connection is already open. I checked other driver
> implementations like
> [postgres|https://github.com/jackc/pgx/blob/master/stdlib/sql.go#L307] and
> [mysql|https://github.com/go-sql-driver/mysql/blob/master/connection.go#L638]
> for ResetSession method and they actually don't open a new connection. So not
> sure about the reason for doing this here. Any thoughts on this ? Example
> exception stack trace -
> {code:java}
> 2023-05-22T19:24:47,357 ERROR [qtp44562-140]
> org.apache.druid.sql.avatica.DruidMeta - Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> org.apache.druid.java.util.common.ISE: Connection
> [fcf73260-cb72-b867-154b-e39a19569c5e] already open.
> at
> org.apache.druid.sql.avatica.DruidMeta.openDruidConnection(DruidMeta.java:823)
> ~[classes/:?]
> at
> org.apache.druid.sql.avatica.DruidMeta.openConnection(DruidMeta.java:208)
> ~[classes/:?]
> at
> org.apache.calcite.avatica.remote.LocalService.apply(LocalService.java:285)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1770)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.Service$OpenConnectionRequest.accept(Service.java:1750)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.AbstractHandler.apply(AbstractHandler.java:94)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.remote.ProtobufHandler.apply(ProtobufHandler.java:46)
> ~[avatica-core-1.17.0.jar:1.17.0]
> at
> org.apache.calcite.avatica.server.AvaticaProtobufHandler.handle(AvaticaProtobufHandler.java:126)
> ~[avatica-server-1.17.0.jar:1.17.0]
> at
> org.apache.druid.sql.avatica.DruidAvaticaProtobufHandler.handle(DruidAvaticaProtobufHandler.java:61)
> ~[classes/:?] {code}
> 2. Username and pwd not being propagated in the JDBC context. Had to add
> the following code in the
> [Connect|https://github.com/apache/calcite-avatica-go/blob/main/driver.go#L64]
> method of driver.go to make it work
> {code:java}
> if config.avaticaUser != "" {
> c.Info["user"] = config.avaticaUser
> }
> if config.avaticaPassword != "" {
> c.Info["password"] = config.avaticaPassword
> } {code}
> 3. My colleague (Benjamin) found open statement leak as well, fixed
> [here|https://github.com/apache/calcite-avatica-go/commit/9c0eba2fbe15b3f877ee276b889cbd39e1a8ce2d]
> We plan to contribute all back once the issues are fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CALCITE-5586) Replace boostport/hbase-phoenix-all-in-one docker image with f21global/hbase-phoenix-all-in-one
[ https://issues.apache.org/jira/browse/CALCITE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701482#comment-17701482 ] Francis Chuang commented on CALCITE-5586: - Great idea [~julianhyde]! Last time I tried to start a discussion on their list regarding publishing docker images, there wasn't too much interest, but who knows, maybe there might be interest this time round :) > Replace boostport/hbase-phoenix-all-in-one docker image with > f21global/hbase-phoenix-all-in-one > --- > > Key: CALCITE-5586 > URL: https://issues.apache.org/jira/browse/CALCITE-5586 > Project: Calcite > Issue Type: Task > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > > Due to docker discontinuing free team plans, the boostport docker > organization and its repositories will be deleted in about a month. This will > break the build for Avatica go. > As a temporary measure, I have created an identical copy of the > hbase-phoenix-all-in-one repository under my personal account: f21global > In the long term, I hope the Apache Phoenix team will be able to produce > testing docker images with their releases and publish them to the apache > docker organization. > Discussions: > https://lists.apache.org/thread/g8dg46lpbrdt47svw8kk4zkbhwog5hh9 > https://lists.apache.org/thread/f1l4g51jj6xh3qhovtmlzffzk7rrm3xo > Docker FAQ: > https://web.docker.com/rs/790-SSB-375/images/privatereposfaq.pdf -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5586) Replace boostport/hbase-phoenix-all-in-one docker image with f21global/hbase-phoenix-all-in-one
[ https://issues.apache.org/jira/browse/CALCITE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-5586: Description: Due to docker discontinuing free team plans, the boostport docker organization and its repositories will be deleted in about a month. This will break the build for Avatica go. As a temporary measure, I have created an identical copy of the hbase-phoenix-all-in-one repository under my personal account: f21global In the long term, I hope the Apache Phoenix team will be able to produce testing docker images with their releases and publish them to the apache docker organization. Discussions: https://lists.apache.org/thread/g8dg46lpbrdt47svw8kk4zkbhwog5hh9 https://lists.apache.org/thread/f1l4g51jj6xh3qhovtmlzffzk7rrm3xo Docker FAQ: https://web.docker.com/rs/790-SSB-375/images/privatereposfaq.pdf was: Due to docker discontinuing free team plans, the boostport docker organization and its repositories will be deleted in about a month. This will break the build for Avatica go. As a temporary measure, I have created an identical copy of the hbase-phoenix-all-in-one repository under my personal account: f21global In the long term, I hope the Apache Phoenix team will be able to produce testing docker images with their releases and publish them to the apache docker organization. Discussions: https://lists.apache.org/thread/g8dg46lpbrdt47svw8kk4zkbhwog5hh9 https://lists.apache.org/thread/f1l4g51jj6xh3qhovtmlzffzk7rrm3xo > Replace boostport/hbase-phoenix-all-in-one docker image with > f21global/hbase-phoenix-all-in-one > --- > > Key: CALCITE-5586 > URL: https://issues.apache.org/jira/browse/CALCITE-5586 > Project: Calcite > Issue Type: Task > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > > Due to docker discontinuing free team plans, the boostport docker > organization and its repositories will be deleted in about a month. This will > break the build for Avatica go. > As a temporary measure, I have created an identical copy of the > hbase-phoenix-all-in-one repository under my personal account: f21global > In the long term, I hope the Apache Phoenix team will be able to produce > testing docker images with their releases and publish them to the apache > docker organization. > Discussions: > https://lists.apache.org/thread/g8dg46lpbrdt47svw8kk4zkbhwog5hh9 > https://lists.apache.org/thread/f1l4g51jj6xh3qhovtmlzffzk7rrm3xo > Docker FAQ: > https://web.docker.com/rs/790-SSB-375/images/privatereposfaq.pdf -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5586) Replace boostport/hbase-phoenix-all-in-one docker image with f21global/hbase-phoenix-all-in-one
[ https://issues.apache.org/jira/browse/CALCITE-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-5586. - Resolution: Fixed > Replace boostport/hbase-phoenix-all-in-one docker image with > f21global/hbase-phoenix-all-in-one > --- > > Key: CALCITE-5586 > URL: https://issues.apache.org/jira/browse/CALCITE-5586 > Project: Calcite > Issue Type: Task > Components: avatica-go >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: avatica-go-5.3.0 > > > Due to docker discontinuing free team plans, the boostport docker > organization and its repositories will be deleted in about a month. This will > break the build for Avatica go. > As a temporary measure, I have created an identical copy of the > hbase-phoenix-all-in-one repository under my personal account: f21global > In the long term, I hope the Apache Phoenix team will be able to produce > testing docker images with their releases and publish them to the apache > docker organization. > Discussions: > https://lists.apache.org/thread/g8dg46lpbrdt47svw8kk4zkbhwog5hh9 > https://lists.apache.org/thread/f1l4g51jj6xh3qhovtmlzffzk7rrm3xo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5586) Replace boostport/hbase-phoenix-all-in-one docker image with f21global/hbase-phoenix-all-in-one
Francis Chuang created CALCITE-5586: --- Summary: Replace boostport/hbase-phoenix-all-in-one docker image with f21global/hbase-phoenix-all-in-one Key: CALCITE-5586 URL: https://issues.apache.org/jira/browse/CALCITE-5586 Project: Calcite Issue Type: Task Components: avatica-go Reporter: Francis Chuang Assignee: Francis Chuang Fix For: avatica-go-5.3.0 Due to docker discontinuing free team plans, the boostport docker organization and its repositories will be deleted in about a month. This will break the build for Avatica go. As a temporary measure, I have created an identical copy of the hbase-phoenix-all-in-one repository under my personal account: f21global In the long term, I hope the Apache Phoenix team will be able to produce testing docker images with their releases and publish them to the apache docker organization. Discussions: https://lists.apache.org/thread/g8dg46lpbrdt47svw8kk4zkbhwog5hh9 https://lists.apache.org/thread/f1l4g51jj6xh3qhovtmlzffzk7rrm3xo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5555) Remove obsolete instructions for processing requests for new JIRA accounts
[ https://issues.apache.org/jira/browse/CALCITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-. - Resolution: Fixed > Remove obsolete instructions for processing requests for new JIRA accounts > -- > > Key: CALCITE- > URL: https://issues.apache.org/jira/browse/CALCITE- > Project: Calcite > Issue Type: Task > Components: site >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Fix For: 1.34.0 > > > With the new self-serve jira account request facitility from the ASF, we no > longer have visibility of the requestor's email address, so those > instructions can be removed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5555) Remove obsolete instructions for processing requests for new JIRA accounts
Francis Chuang created CALCITE-: --- Summary: Remove obsolete instructions for processing requests for new JIRA accounts Key: CALCITE- URL: https://issues.apache.org/jira/browse/CALCITE- Project: Calcite Issue Type: Task Components: site Reporter: Francis Chuang Assignee: Francis Chuang Fix For: 1.34.0 With the new self-serve jira account request facitility from the ASF, we no longer have visibility of the requestor's email address, so those instructions can be removed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-5550) Update instructions for requesting Jira account to use self-serve facility
[ https://issues.apache.org/jira/browse/CALCITE-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-5550. - Resolution: Fixed > Update instructions for requesting Jira account to use self-serve facility > -- > > Key: CALCITE-5550 > URL: https://issues.apache.org/jira/browse/CALCITE-5550 > Project: Calcite > Issue Type: Task > Components: site >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Trivial > Labels: pull-request-available > Fix For: 1.34.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Annoucement: https://lists.apache.org/thread/k2p68qhd4whopjbhvj62xtbh55qg2blm -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5550) Update instructions for requesting Jira account to use self-serve facility
[ https://issues.apache.org/jira/browse/CALCITE-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-5550: Priority: Trivial (was: Major) > Update instructions for requesting Jira account to use self-serve facility > -- > > Key: CALCITE-5550 > URL: https://issues.apache.org/jira/browse/CALCITE-5550 > Project: Calcite > Issue Type: Task > Components: site >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Trivial > Fix For: 1.34.0 > > > Annoucement: https://lists.apache.org/thread/k2p68qhd4whopjbhvj62xtbh55qg2blm -- This message was sent by Atlassian Jira (v8.20.10#820010)
