[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:30 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:30 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:31 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:31 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore The Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:32 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml and readme.md, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore The Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore The Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:33 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml and readme.md, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore The Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build Go libraries into a binary. The library should be add into a project using dep, which will checkout the source to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml and readme.md, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore The Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build Go libraries into a binary. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:33 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml and readme.md, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore The Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build Go libraries into a binary. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml and readme.md, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore The Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory is a standard go-specific folder that contains dependencies used by the go projects. See https://golang.org/cmd/go/#hdr-Vendor_Directories When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095516#comment-16095516 ] Francis Chuang edited comment on CALCITE-1240 at 7/20/17 11:03 PM: --- For the dependencies: Other than Go's standard library, the project also imports the following dependencies directly: https://github.com/Boostport/avatica/blob/master/Gopkg.toml The imported dependencies also import further dependencies of their own. The list of ALL dependencies used are in here: https://github.com/Boostport/avatica/blob/master/Gopkg.lock Dependencies under the golang.org/x/ namespace are part of the Go project but are considered to be experimental. was (Author: francischuang): For the dependencies: Other than Go's standard library, the project also imports the following dependencies directly: https://github.com/Boostport/avatica/blob/master/Gopkg.toml The imported dependencies also imports further dependencies of their own. The list of ALL dependencies used are in here: https://github.com/Boostport/avatica/blob/master/Gopkg.lock Dependencies under the golang.org/x/ namespace are part of the Go project but are considered to be experimental. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[
https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105381#comment-16105381
]
Josh Elser edited comment on CALCITE-1240 at 7/28/17 5:59 PM:
--
bq. AFAICT, /repos/asf/incubator/donations doesn't exist. Is this a typo in the
template? What did you do when you handled previous IP clearance?
Hrm, that's interesting. I don't think I committed the granted codebase to SVN
before. Pulling up the old thread, I just hosted it in my ~elserj space on
people.a.o ("https://github.com/apache/incubator-slider/pull/3 or
http://people.apache.org/~elserj/KOYA-grant.patch"; is specifically what I put
in the IP clearance XML form). I would say what you've done is sufficient --
someone can correct us during the lazy-consensus period if that is incorrect.
Here's the form I filled out last time if helpful:
https://svn.apache.org/repos/asf/incubator/public/trunk/content/ip-clearance/slider-koya.xml
was (Author: elserj):
bq. AFAICT, /repos/asf/incubator/donations doesn't exist. Is this a typo in the
template? What did you do when you handled previous IP clearance?
Hrm, that's interesting. I don't think I committed the granted codebase to SVN
before. Pulling up the old thread, I just hosted it in my ~elserj space on
people.a.o ("https://github.com/apache/incubator-slider/pull/3 or
http://people.apache.org/~elserj/KOYA-grant.patch"; is specifically what I put
in the IP clearance XML form). I would say what you've done is sufficient --
someone can correct us during the lazy-consensus period if that is incorrect.
> Avatica client written in Golang
>
>
> Key: CALCITE-1240
> URL: https://issues.apache.org/jira/browse/CALCITE-1240
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>
> Add a client for Avatica written in the Go language (aka "Golang").
> There is one at https://github.com/Boostport/avatica and the author has
> offered to contribute it.
> The driver is currently somewhat specialized for Phoenix but our goal should
> be to allow it to work against any Avatica provider (without diminishing its
> value to Phoenix users).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118054#comment-16118054 ] Francis Chuang edited comment on CALCITE-1240 at 8/8/17 8:54 AM: - Ok, the repo is now on Github, but I ran into a snag as I am not allowed to push directly to apache/calcite-avatica-go on github. - The repo is currently empty, so I cannot fork it on GH and use a fork. - I created a F21/calcite-avatica-go repo and pushed the initial commit there, but it won't let me open a PR against apache/calcite-avatica-go. was (Author: francischuang): Ok, the repo is now on Github, but I ran into a snag as I am not allowed to push directly to apache/calcite-avatica-go. - The repo is currently empty, so I cannot fork it on GH and use a fork. - I created a F21/calcite-avatica-go repo and pushed the initial commit there, but it won't let me open a PR against apache/calcite-avatica-go. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118054#comment-16118054 ] Francis Chuang edited comment on CALCITE-1240 at 8/8/17 8:57 AM: - Ok, the repo is now on Github, but I ran into a snag as I am not allowed to push directly to apache/calcite-avatica-go on github. - The repo is currently empty, so I cannot fork it on GH and use a fork. - I created a F21/calcite-avatica-go repo and pushed the initial commit there, but it won't let me open a PR against apache/calcite-avatica-go. A few other issues: - I currently use Wercker for CI. Can wercker be used on Apache repos? - I use goveralls for code coverage reports. Can it be used on Apache repos? was (Author: francischuang): Ok, the repo is now on Github, but I ran into a snag as I am not allowed to push directly to apache/calcite-avatica-go on github. - The repo is currently empty, so I cannot fork it on GH and use a fork. - I created a F21/calcite-avatica-go repo and pushed the initial commit there, but it won't let me open a PR against apache/calcite-avatica-go. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119260#comment-16119260 ] Francis Chuang edited comment on CALCITE-1240 at 8/9/17 1:00 AM: - [~elserj]Thanks for sorting that out! [~elserj][~julianhyde] A PR has been opened on the GH repo to rack the initial commit. There are still a few things to do before it can be merged. Regarding tags, should tags from the original repo be pushed? Or should be start a new versioning scheme? was (Author: francischuang): [~elserj]Thanks for sorting that out! [~elserj][~julianhyde] A PR has been opened on the GH repo to rack the initial commit. There are still a few things to do before it can be merged. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119358#comment-16119358 ] Francis Chuang edited comment on CALCITE-1240 at 8/9/17 3:30 AM: - I did some research regarding using Apache's infrastructure for CI and the ASF buildbot. I have some questions regarding how to set this up: - What needs to be done to set up CI for the project? - Can Apache's Jenkins build PRs submitted on github as well? - Jenkins uses a jenkinsfile which is stored in the project repo, but I do not see the jenkinsfile in the calcite or kafka repos. How are builds configured? There is a sonarqube instance: https://wiki.apache.org/general/SonarInstance Maybe it can provide code coverage, but I think the Go plugin needs to be installed: https://github.com/uartois/sonar-golang Ideally, there should be build status and coverage status images that can be embedded in the README.md file. Regarding github pushes, I think it may be possible if the repo is hosted on Gitbox: https://gitbox.apache.org was (Author: francischuang): I did some research regarding using Apache's infrastructure for CI and the ASF buildbot. I have some questions regarding how to set this up: - What needs to be done to set up CI for the project? - Can Apache's Jenkins build PRs submitted on github as well? - Jenkins uses a jenkinsfile which is stored in the project repo, but I do not see the jenkinsfile in the calcite or kafka repos. How are builds configured? There is a sonarqube instance: https://wiki.apache.org/general/SonarInstance Maybe it can provide code coverage, but I think the Go plugin needs to be installed: https://github.com/uartois/sonar-golang Ideally, there should be build status and coverage status images that can be embedded in the README.md file. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:20 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to README.md and .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/README and https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to README.md and .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/README and https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects to not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:22 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to README.md and .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/README and https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects do not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CALCITE-1240) Avatica client written in Golang
[ https://issues.apache.org/jira/browse/CALCITE-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120990#comment-16120990 ] Francis Chuang edited comment on CALCITE-1240 at 8/10/17 3:20 AM: -- Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to README.md and .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/README and https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints, for example, use the minor versions of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects to not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. was (Author: francischuang): Hey [~julianhyde] Thanks for the comments. I added the header to wercker.yml, but I am not sure how to add the header to README.md and .gitignore. See the following in the calcite repo: https://github.com/apache/calcite/blob/master/README and https://github.com/apache/calcite/blob/master/.gitignore Gopkg.lock is a file generated by dep (https://github.com/golang/dep). It is poised to become the official package manager for Go. This file must be committed as it contains the exact commit hashes of the dependencies installed. The Gopkg.toml file only contains the constraints for example the minor version of a dependency that is versioned at 1.2.1. Therefore, the lock file is required for reproducible builds. It is equivalent to the lock file used by NPM 5. The vendor directory contains dependencies used by the calcite-avatica-go library. When running tests, libraries and projects to not run tests in the vendor directory. The vendored dependencies should have their own tests and the owner of the dependencies should be testing them. It does not make any sense to build the library. The library should be add into a project using dep, which will copy it to the project's vendor directory. On compilation, Go will build a single static binary for the project. I've pushed updated the PR with changes to the readme and a license header to wercker.yml. > Avatica client written in Golang > > > Key: CALCITE-1240 > URL: https://issues.apache.org/jira/browse/CALCITE-1240 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Julian Hyde >Assignee: Julian Hyde > > Add a client for Avatica written in the Go language (aka "Golang"). > There is one at https://github.com/Boostport/avatica and the author has > offered to contribute it. > The driver is currently somewhat specialized for Phoenix but our goal should > be to allow it to work against any Avatica provider (without diminishing its > value to Phoenix users). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
