[jira] [Comment Edited] (CALCITE-4424) Complete non-deterministic function in SqlFunction
[
https://issues.apache.org/jira/browse/CALCITE-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252300#comment-17252300
]
Jiatao Tao edited comment on CALCITE-4424 at 12/24/20, 3:13 AM:
Hi [~julianhyde], what I mean is that I think they are
orthogonal(isDeterministic/isDynamicFunction).
{code:java}
* Returns whether it is unsafe to cache query plans referencing this
* operator; false is assumed by default
{code}
The isDynamicFunction's def is pretty clear, where to use is clear, it's an
independent interface, I think they have no relationship, so this Jira will not
care about isDynamicFunction.
was (Author: aron.tao):
Hi [~julianhyde], what I mean is that I think they are
orthogonal(isDeterministic/isDynamicFunction).
{code:java}
* Returns whether it is unsafe to cache query plans referencing this
* operator; false is assumed by default
{code}
The isDynamicFunction's def is pretty clear, where to use is clear, I think
they have no relationship, so this Jira will not care about isDynamicFunction.
> Complete non-deterministic function in SqlFunction
> --
>
> Key: CALCITE-4424
> URL: https://issues.apache.org/jira/browse/CALCITE-4424
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Jiatao Tao
>Assignee: Jiatao Tao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current only SqlSequenceValueOperator override isDeterministic, func like
> RAND doesn't override isDeterministic
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4424) Complete non-deterministic function in SqlFunction
[
https://issues.apache.org/jira/browse/CALCITE-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252300#comment-17252300
]
Jiatao Tao edited comment on CALCITE-4424 at 12/20/20, 3:30 AM:
Hi [~julianhyde], what I mean is that I think they are
orthogonal(isDeterministic/isDynamicFunction).
{code:java}
* Returns whether it is unsafe to cache query plans referencing this
* operator; false is assumed by default
{code}
The isDynamicFunction's def is pretty clear, where to use is clear, I think
they have no relationship, so this Jira will not care about isDynamicFunction.
was (Author: aron.tao):
Hi [~julianhyde], what I mean is that I think they are
orthogonal(isDeterministic/isDynamicFunction).
{code:java}
* Returns whether it is unsafe to cache query plans referencing this
* operator; false is assumed by default
{code}
The isDynamicFunction's def is pretty clear, I think they have no relationship,
so this Jira will not care about isDynamicFunction.
> Complete non-deterministic function in SqlFunction
> --
>
> Key: CALCITE-4424
> URL: https://issues.apache.org/jira/browse/CALCITE-4424
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Jiatao Tao
>Assignee: Jiatao Tao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current only SqlSequenceValueOperator override isDeterministic, func like
> RAND doesn't override isDeterministic
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4424) Complete non-deterministic function in SqlFunction
[
https://issues.apache.org/jira/browse/CALCITE-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252300#comment-17252300
]
Jiatao Tao edited comment on CALCITE-4424 at 12/20/20, 3:28 AM:
Hi [~julianhyde], what I mean is that I think they are
orthogonal(isDeterministic/isDynamicFunction).
{code:java}
* Returns whether it is unsafe to cache query plans referencing this
* operator; false is assumed by default
{code}
The isDynamicFunction's def is pretty clear, I think they have no relationship,
so this Jira will not care about isDynamicFunction.
was (Author: aron.tao):
Hi [~julianhyde], what I mean is that I think they are
orthogonal(isDeterministic/isDynamicFunction), so this Jira will not care about
isDynamicFunction. They have no relationship.
> Complete non-deterministic function in SqlFunction
> --
>
> Key: CALCITE-4424
> URL: https://issues.apache.org/jira/browse/CALCITE-4424
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Jiatao Tao
>Assignee: Jiatao Tao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current only SqlSequenceValueOperator override isDeterministic, func like
> RAND doesn't override isDeterministic
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4424) Complete non-deterministic function in SqlFunction
[ https://issues.apache.org/jira/browse/CALCITE-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250986#comment-17250986 ] Jiatao Tao edited comment on CALCITE-4424 at 12/20/20, 3:24 AM: Hi [~julianhyde], I think they are orthogonal, so answer point2, I would not change that. Func like CURRENT_DATE/CURRENT_TIMESTAMPE, I think it doesn't matter to determine them deterministic or non-deterministic, cuz current we do not observe that they will affect the optimized result(but rand will). So we just defined by our own standards, IMO we can define them as deterministic. was (Author: aron.tao): Hi [~julianhyde], in fact, I'm also confused about the concept of dynamic functions. But I think they are orthogonal, so answer point2, I would not change that. Func like CURRENT_DATE/CURRENT_TIMESTAMPE, I think it doesn't matter to determine them deterministic or non-deterministic, cuz current we do not observe that they will affect the optimized result(but rand will). So we just defined by our own standards, IMO we can define them as deterministic. > Complete non-deterministic function in SqlFunction > -- > > Key: CALCITE-4424 > URL: https://issues.apache.org/jira/browse/CALCITE-4424 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: Jiatao Tao >Assignee: Jiatao Tao >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Current only SqlSequenceValueOperator override isDeterministic, func like > RAND doesn't override isDeterministic > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
