[jira] [Comment Edited] (CALCITE-4787) Move core to use Immutables instead of ImmutableBeans
[ https://issues.apache.org/jira/browse/CALCITE-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424038#comment-17424038 ] Jacques Nadeau edited comment on CALCITE-4787 at 10/4/21, 6:21 PM: --- Resolved in [511eecdf5a0c68632f99c6b3e07ebbdd964c281d|https://github.com/apache/calcite/commit/511eecdf5a0c68632f99c6b3e07ebbdd964c281d] was (Author: jnadeau): Resolved in [d70583c4a8013f878457f82df6dffddd71875900|https://github.com/apache/calcite/commit/d70583c4a8013f878457f82df6dffddd71875900] > Move core to use Immutables instead of ImmutableBeans > - > > Key: CALCITE-4787 > URL: https://issues.apache.org/jira/browse/CALCITE-4787 > Project: Calcite > Issue Type: Improvement >Reporter: Jacques Nadeau >Assignee: Jacques Nadeau >Priority: Major > Labels: pull-request-available > Fix For: 1.28.0 > > Time Spent: 10h 40m > Remaining Estimate: 0h > > In the creation of CALCITE-3328, [Immutables|https://immutables.github.io/] > was discussed as an alternative to a custom implementation. This ticket is to > evaluate the impact to the codebase of changing. Ideally, introduction of > immutables would both add flexibility and reduce the amount of code > associated with these classes. > Immutables works via annotation processor which means that it is should be > relatively seamless to build systems and IDEs. > The switch would also make it easier to work with these objects types in the > context of aot compilation tools like GraalVM. > > This initial task covers key classes in the core module. Will open up > follow-on tickets for other locations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4787) Move core to use Immutables instead of ImmutableBeans
[ https://issues.apache.org/jira/browse/CALCITE-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424038#comment-17424038 ] Jacques Nadeau edited comment on CALCITE-4787 at 10/4/21, 5:27 PM: --- Resolved in [d70583c4a8013f878457f82df6dffddd71875900|https://github.com/apache/calcite/commit/d70583c4a8013f878457f82df6dffddd71875900] was (Author: jnadeau): Resolved in d70583c4a8013f878457f82df6dffddd71875900 > Move core to use Immutables instead of ImmutableBeans > - > > Key: CALCITE-4787 > URL: https://issues.apache.org/jira/browse/CALCITE-4787 > Project: Calcite > Issue Type: Improvement >Reporter: Jacques Nadeau >Assignee: Jacques Nadeau >Priority: Major > Labels: pull-request-available > Time Spent: 10h 40m > Remaining Estimate: 0h > > In the creation of CALCITE-3328, [Immutables|https://immutables.github.io/] > was discussed as an alternative to a custom implementation. This ticket is to > evaluate the impact to the codebase of changing. Ideally, introduction of > immutables would both add flexibility and reduce the amount of code > associated with these classes. > Immutables works via annotation processor which means that it is should be > relatively seamless to build systems and IDEs. > The switch would also make it easier to work with these objects types in the > context of aot compilation tools like GraalVM. > > This initial task covers key classes in the core module. Will open up > follow-on tickets for other locations. -- This message was sent by Atlassian Jira (v8.3.4#803005)