[
https://issues.apache.org/jira/browse/CALCITE-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815157#comment-17815157
]
Ruben Q L edited comment on CALCITE-5647 at 2/7/24 8:33 AM:
------------------------------------------------------------
Done in
[{{f7069cc}}|https://github.com/apache/calcite/commit/f7069cc5245c22f816c565669f52b4f30b046f4d]
Thanks [~adamkennedy77] and [~jduong] for working on this!
was (Author: rubenql):
Done in
[{{f7069cc}}|https://github.com/apache/calcite/commit/f7069cc5245c22f816c565669f52b4f30b046f4d]
> RelMdPopulationSize should use mq.getRowCount(rel) instead of
> rel.estimateRowCount(mq)
> --------------------------------------------------------------------------------------
>
> Key: CALCITE-5647
> URL: https://issues.apache.org/jira/browse/CALCITE-5647
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.34.0
> Reporter: Adam Kennedy
> Assignee: Adam Kennedy
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.37.0
>
> Original Estimate: 1h
> Time Spent: 20m
> Remaining Estimate: 40m
>
> A few locations in Calcite call rel.estimateRowCount(mq) when they should
> instead call mq.getRowCount(red).
> We detected this because we implemented row count estimation entirely within
> an alternative handle instead of RelMdRowCount, and then override
> estimateRowCount to ensure the custom handler is user, by throwing an
> unreachable code exception.
> A few places in Calcite trigger these unreachable exceptions because they do
> not use mq.getRowCount.
> The most easily triggered on is in RelMdPopulationSize for the Values
> parameter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
