[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404658#comment-15404658 ] MinJi Kim commented on CALCITE-1342: I made a small change to use rel factories in ProjectPusher. Thanks! https://github.com/apache/calcite/pull/265 > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451034#comment-15451034 ] Julian Hyde commented on CALCITE-1342: -- [~minjikim], As of https://github.com/apache/calcite/pull/265/commits/e354a214f1e78c90d3147dce53b54f3f1090fbf0 I see lots of factory arguments to ProjectFilterTransposeRule. Can you convert those arguments to a single RelBuilder? It would be good to get this done in time for 1.9. Do you think that is achievable? > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451045#comment-15451045 ] MinJi Kim commented on CALCITE-1342: Will do! I am sorry for the delay. I got caught in something, and have been meaning to get back to this for a while. I will try to get to this this week (or this weekend!). > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454350#comment-15454350 ] MinJi Kim commented on CALCITE-1342: [~julianhyde] I uploaded an updated patch. Please let me know if there is anything that I should address. Thanks! > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468885#comment-15468885
]
Julian Hyde commented on CALCITE-1342:
--
[~minjikim], I saw you modified the arguments to
{{RelOptUtil.createProject(RelNode, List, List, boolean, ProjectFactory)}} and
was going to suggest that retain a deprecated copy of that method. But then I
saw that [~jcamachorodriguez] only recently created the method, in CALCITE-826.
So we're good.
I believe that {{RelOptUtil.createProject(RelNode, List, boolean,
ProjectFactory)}} is not used, and it has not been released. Can you remove it?
After that, +1. Can you please commit and push to Apache master?
* Be sure to add a 'Close apache/calcite#NNN' line, to automatically close the
PR.
* Don't add ' (MinJi Kim)' at the end of the message - we only do that for
non-committers.
* Please mark this case resolved, and fixed in 1.9.0, after you commit.
> ProjectPusher should use rel factories when creating new rels, e.g.
> project/filter
> --
>
> Key: CALCITE-1342
> URL: https://issues.apache.org/jira/browse/CALCITE-1342
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: MinJi Kim
>Assignee: Julian Hyde
>
> I was playing around with some new ideas in drill, and wanted to use
> ProjectPusher, which has a lot of useful utility functions. ProjectPusher
> returns new nodes, but they are LogicalProjects/LogicalFilters. It would be
> more useful if the user of ProjectPusher could specify the rel factories to
> use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468909#comment-15468909 ] MinJi Kim commented on CALCITE-1342: Okay, sure. I will make the changes. I will give it a try at my first commit! :) > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471217#comment-15471217 ] Julian Hyde commented on CALCITE-1342: -- [~minjikim], When you mark a bug resolved, can you please also add a "Fixed in ..." comment so we can tie back to the source code change. It makes it much easier for others to review. I usually paste in the commit URL from the email sent by ASF's git-hook. See CALCITE-1334 for an example. > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > Fix For: 1.9.0 > > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471264#comment-15471264 ] MinJi Kim commented on CALCITE-1342: Okay, will remember from now on! Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/cb356d8a > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > Fix For: 1.9.0 > > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527320#comment-15527320
]
Julian Hyde commented on CALCITE-1342:
--
FYI, this commit broke QuidemTest, viz, it changed some plans in {{misc.iq}}.
(I'm not sure how we missed it, but at least the plan changes were
improvements!) Fixed the test in
http://git-wip-us.apache.org/repos/asf/calcite/commit/b5b9e53a.
> ProjectPusher should use rel factories when creating new rels, e.g.
> project/filter
> --
>
> Key: CALCITE-1342
> URL: https://issues.apache.org/jira/browse/CALCITE-1342
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: MinJi Kim
>Assignee: Julian Hyde
> Fix For: 1.9.0
>
>
> I was playing around with some new ideas in drill, and wanted to use
> ProjectPusher, which has a lot of useful utility functions. ProjectPusher
> returns new nodes, but they are LogicalProjects/LogicalFilters. It would be
> more useful if the user of ProjectPusher could specify the rel factories to
> use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1342) ProjectPusher should use rel factories when creating new rels, e.g. project/filter
[ https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527354#comment-15527354 ] MinJi Kim commented on CALCITE-1342: Oh, that's weird. I do a full build (mvn clean install, just to be sure), and I thought that would run all tests including Quidem. I will keep an eye out for it next time. > ProjectPusher should use rel factories when creating new rels, e.g. > project/filter > -- > > Key: CALCITE-1342 > URL: https://issues.apache.org/jira/browse/CALCITE-1342 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: MinJi Kim >Assignee: Julian Hyde > Fix For: 1.9.0 > > > I was playing around with some new ideas in drill, and wanted to use > ProjectPusher, which has a lot of useful utility functions. ProjectPusher > returns new nodes, but they are LogicalProjects/LogicalFilters. It would be > more useful if the user of ProjectPusher could specify the rel factories to > use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
