[jira] [Commented] (CALCITE-1954) SqlValidator need to maintain forceNullable across joins and renaming

2017-08-17 Thread MinJi Kim (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131439#comment-16131439
 ] 

MinJi Kim commented on CALCITE-1954:


A small patch, but would appreciate another set of eyes to review this.  Thank 
you!

https://github.com/apache/calcite/pull/522

> SqlValidator need to maintain forceNullable across joins and renaming
> -
>
> Key: CALCITE-1954
> URL: https://issues.apache.org/jira/browse/CALCITE-1954
> Project: Calcite
>  Issue Type: Bug
>Reporter: MinJi Kim
>Assignee: Julian Hyde
>
> In the following query below, SqlValidator return rowtype with the second 
> column as NOT NULL.  Since this is a left outer join, it should be nullable.
> {code}
> select * from
>   (select row_number() over (order by sal) from emp) as emp1(r1) 
>   left outer join 
>   (select  dense_rank() over(order by sal) from emp) as emp2(r2) 
>   on (emp1.r1 = emp2.r2)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-1954) SqlValidator need to maintain forceNullable across joins and renaming

2017-08-21 Thread Julian Hyde (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135977#comment-16135977
 ] 

Julian Hyde commented on CALCITE-1954:
--

Reviewing and testing now.

> SqlValidator need to maintain forceNullable across joins and renaming
> -
>
> Key: CALCITE-1954
> URL: https://issues.apache.org/jira/browse/CALCITE-1954
> Project: Calcite
>  Issue Type: Bug
>Reporter: MinJi Kim
>Assignee: Julian Hyde
>
> In the following query below, SqlValidator return rowtype with the second 
> column as NOT NULL.  Since this is a left outer join, it should be nullable.
> {code}
> select * from
>   (select row_number() over (order by sal) from emp) as emp1(r1) 
>   left outer join 
>   (select  dense_rank() over(order by sal) from emp) as emp2(r2) 
>   on (emp1.r1 = emp2.r2)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)