[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543844#comment-16543844
]
Julian Hyde commented on CALCITE-2259:
--
A follow-up in commit
[f5cef160|http://git-wip-us.apache.org/repos/asf/calcite/commit/f5cef160].
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530217#comment-16530217
]
Kevin Risden commented on CALCITE-2259:
---
Yes you can. I had a few life things come up. Earliest I can make time is next
week. Sorry.
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528912#comment-16528912
]
Julian Hyde commented on CALCITE-2259:
--
[~risdenk], Can I take this one back?
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528911#comment-16528911
]
Julian Hyde commented on CALCITE-2259:
--
Here's a [thoughtful discussion about which Guava features are obsolete in Java
8|https://www.reddit.com/r/java/comments/217rnf/what_is_obsolete_in_guava_since_java_8/].
I agree with most of it, including that Guava's {{Lists.transform}} is not
replaced by {{list.stream().map(...).collect()}}.
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520704#comment-16520704
]
Julian Hyde commented on CALCITE-2259:
--
CALCITE-2280 is blocked on this.
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504642#comment-16504642
]
Volodymyr Vysotskyi commented on CALCITE-2259:
--
[~risdenk], it would be fine to include these changes into 1.17. Please let me
know if I can help somehow with this.
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476624#comment-16476624
]
Julian Hyde commented on CALCITE-2259:
--
Thanks for the update - take your time - there's no hurry!
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476601#comment-16476601
]
Kevin Risden commented on CALCITE-2259:
---
Added my changes to [https://github.com/risdenk/calcite/tree/CALCITE-2259]
based on your branch. So far just added the Preconditions.checkNotNull to
Objects.requireNonNull. I still need to spend some more time looking at it.
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
> Fix For: 1.17.0
>
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459172#comment-16459172
]
Julian Hyde commented on CALCITE-2259:
--
[~risdenk], I've completed a first pass, and committed it to my branch
[https://github.com/julianhyde/calcite/tree/2259-lambda.] The commit comments
have a long list of work done and work still to do. Would you like to pick this
up and continue work? If you're working on it I'll cease making changes.
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457320#comment-16457320
]
Kevin Risden commented on CALCITE-2259:
---
Mailing list about replacing Guava with JDK 8 methods where possible:
http://mail-archives.apache.org/mod_mbox/calcite-dev/201804.mbox/%3CCAJU9nmgutFs1kYo7CGUVac6iaai__Cwj-4SwvCuMz9P95XjDaA%40mail.gmail.com%3E
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457321#comment-16457321
]
Kevin Risden commented on CALCITE-2259:
---
Guava: Replace Preconditions.checkNotNull(obj); with
Objects.requireNonNull(obj);
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2259) Allow Java 8 syntax in source files
[
https://issues.apache.org/jira/browse/CALCITE-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447659#comment-16447659
]
Julian Hyde commented on CALCITE-2259:
--
Some features that we can use when we're on JDK 8 (copied from CALCITE-2027):
* Migrate sub-classes of {{ThreadLocal}} to use {{ThreadLocal.withSupplier}}.
* Resource references; change {{try (Closeable ignore = foo())}} to {{try
(foo())}}, especially uses of {{TryThreadLocal}} and {{Hook.Closeable}}.
* Change uses of SAM interfaces to lambdas:
** Calcite: Bindable, Node, SqlTypeTransform, SqlOperandTypeInference,
SqlReturnTypeInference, UnboundMetadata, RelRunner, Handler.ResultSink,
Frameworks.PlannerAction, Invokable, SqlParserImplFactory;
** Guava: Function, Predicate and Supplier;
** Linq4j: Function0, Function1, Predicate1, Predicate2;
** Java: Iterable, Callable, InvocationHandler, Closeable, Comparator.
* Calls to Iterables.transform "pseudo-functional style" can be converted to
streams
> Allow Java 8 syntax in source files
> ---
>
> Key: CALCITE-2259
> URL: https://issues.apache.org/jira/browse/CALCITE-2259
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
>
> Allow Java 8 syntax in source files.
> In core/pom.xml, I tried changing {{source=1.7 target=1.8}} to {{source=8
> target=8}} but I ran into [Janino issue
> 47|https://github.com/janino-compiler/janino/issues/47]. (Thanks,
> [~vvysotskyi], for logging that issue.)
> When this is fixed, we will be able to use lambdas ({{->}}).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
