[jira] [Commented] (CALCITE-2342) use of assert with side-effect in Schemas
[
https://issues.apache.org/jira/browse/CALCITE-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496750#comment-16496750
]
Julian Hyde commented on CALCITE-2342:
--
I saw some javadoc failures under JDK 11. While you're in the code, can you fix
those also.
> use of assert with side-effect in Schemas
> -
>
> Key: CALCITE-2342
> URL: https://issues.apache.org/jira/browse/CALCITE-2342
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
>
> {{Schemas#path(CalciteSchema,Iterable)}} method has the following
> code:
> {code:java}
> if (!rootSchema.name.isEmpty()) {
> assert rootSchema.name.equals(iterator.next());
> }
> {code}
> Depending if assertions are enabled or not, iterator state might be different
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2342) use of assert with side-effect in Schemas
[
https://issues.apache.org/jira/browse/CALCITE-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496111#comment-16496111
]
Laurent Goujon commented on CALCITE-2342:
-
Also run all tests with assertions disabled, and it's the only one I found
triggering test failures...
> use of assert with side-effect in Schemas
> -
>
> Key: CALCITE-2342
> URL: https://issues.apache.org/jira/browse/CALCITE-2342
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
>
> {{Schemas#path(CalciteSchema,Iterable)}} method has the following
> code:
> {code:java}
> if (!rootSchema.name.isEmpty()) {
> assert rootSchema.name.equals(iterator.next());
> }
> {code}
> Depending if assertions are enabled or not, iterator state might be different
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2342) use of assert with side-effect in Schemas
[
https://issues.apache.org/jira/browse/CALCITE-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496109#comment-16496109
]
Laurent Goujon commented on CALCITE-2342:
-
I posted a github PR (actually for multiple JIRAs) but I don't see it linked.
Did I mess up my comment message and cause the integration not to work?
https://github.com/apache/calcite/pull/712
> use of assert with side-effect in Schemas
> -
>
> Key: CALCITE-2342
> URL: https://issues.apache.org/jira/browse/CALCITE-2342
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
>
> {{Schemas#path(CalciteSchema,Iterable)}} method has the following
> code:
> {code:java}
> if (!rootSchema.name.isEmpty()) {
> assert rootSchema.name.equals(iterator.next());
> }
> {code}
> Depending if assertions are enabled or not, iterator state might be different
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2342) use of assert with side-effect in Schemas
[
https://issues.apache.org/jira/browse/CALCITE-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496091#comment-16496091
]
Julian Hyde commented on CALCITE-2342:
--
Nice catch.
> use of assert with side-effect in Schemas
> -
>
> Key: CALCITE-2342
> URL: https://issues.apache.org/jira/browse/CALCITE-2342
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
>
> {{Schemas#path(CalciteSchema,Iterable)}} method has the following
> code:
> {code:java}
> if (!rootSchema.name.isEmpty()) {
> assert rootSchema.name.equals(iterator.next());
> }
> {code}
> Depending if assertions are enabled or not, iterator state might be different
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
