[jira] [Commented] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-27 Thread Laurent Goujon (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779974#comment-16779974
 ] 

Laurent Goujon commented on CALCITE-2827:
-

Didn't I answer it? Our planner has a planning phase when there's no convention 
change, but we are looking for a cost-based solution when applying different 
rules. Because NONE convention has always infinite cost, by default 
VolcanoPlanner cannot answer it. Note that if nodes were using a different 
convention, it would not be issue. I interpret this as VolcanoPlanner has an 
optimization to not compute cost for nodes with NONE convention since in most 
cases we are interested in finding the best solution in a different convention. 
But maybe that optimization could be generalized, and the optimization would be 
to not compute cost for the source convention, and make the optimization 
optional.

If you think I merged the change too soon (but from [~michaelmior] PR comment, 
I didn't think it was too much controversial), I don't mind reverting.

> Allow CONVENTION.NONE planning with VolcanoPlanner
> --
>
> Key: CALCITE-2827
> URL: https://issues.apache.org/jira/browse/CALCITE-2827
> Project: Calcite
>  Issue Type: Task
>Reporter: Siddharth Teotia
>Assignee: Juhwan Kim
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.19.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-27 Thread Vladimir Sitnikov (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779782#comment-16779782
 ] 

Vladimir Sitnikov commented on CALCITE-2827:


I agree with [~michaelmior]. It would be great to hear the intention behind the 
change. Otherwise we get yet another configuration option to test and support 
for unknown reason.

> Allow CONVENTION.NONE planning with VolcanoPlanner
> --
>
> Key: CALCITE-2827
> URL: https://issues.apache.org/jira/browse/CALCITE-2827
> Project: Calcite
>  Issue Type: Task
>Reporter: Siddharth Teotia
>Assignee: Juhwan Kim
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.19.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-27 Thread Laurent Goujon (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779769#comment-16779769
 ] 

Laurent Goujon commented on CALCITE-2827:
-

Use case is to use volcano planner for doing cost based optimization without 
changing convention.

> Allow CONVENTION.NONE planning with VolcanoPlanner
> --
>
> Key: CALCITE-2827
> URL: https://issues.apache.org/jira/browse/CALCITE-2827
> Project: Calcite
>  Issue Type: Task
>Reporter: Siddharth Teotia
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-21 Thread Michael Mior (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774633#comment-16774633
 ] 

Michael Mior commented on CALCITE-2827:
---

Could you explain the use case for this?

> Allow CONVENTION.NONE planning with VolcanoPlanner
> --
>
> Key: CALCITE-2827
> URL: https://issues.apache.org/jira/browse/CALCITE-2827
> Project: Calcite
>  Issue Type: Task
>Reporter: Siddharth Teotia
>Assignee: Julian Hyde
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)