[jira] [Commented] (CALCITE-2945) use equals in Boolean object compare

2019-04-04 Thread Josh Elser (JIRA) 


[ 
https://issues.apache.org/jira/browse/CALCITE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810353#comment-16810353
 ] 

Josh Elser commented on CALCITE-2945:
-

Ok, thanks Francis!

> use equals in Boolean object compare
> 
>
> Key: CALCITE-2945
> URL: https://issues.apache.org/jira/browse/CALCITE-2945
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.16.0, 1.17.0, 1.18.0
>Reporter: leesf
>Assignee: leesf
>Priority: Minor
>  Labels: pull-request-available
> Fix For: avatica-1.14.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In ConnectionPropertiesImpl#merge funciton,  we could use equals method in 
> Boolean object compare.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CALCITE-2945) use equals in Boolean object compare

2019-04-04 Thread Francis Chuang (JIRA) 


[ 
https://issues.apache.org/jira/browse/CALCITE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810350#comment-16810350
 ] 

Francis Chuang commented on CALCITE-2945:
-

[~elserj], I will go through all the commits and check/set the Fix Version 
field for all the issues that were resolved for the release. In general, I 
think next should not be used as Jira may consider "next" to be a release (not 
100% sure). I've gone and updated it to `avatica-1.14.0` and I'll delete the 
"next" release from the list of releases.

> use equals in Boolean object compare
> 
>
> Key: CALCITE-2945
> URL: https://issues.apache.org/jira/browse/CALCITE-2945
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.16.0, 1.17.0, 1.18.0
>Reporter: leesf
>Assignee: leesf
>Priority: Minor
>  Labels: pull-request-available
> Fix For: avatica-1.14.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In ConnectionPropertiesImpl#merge funciton,  we could use equals method in 
> Boolean object compare.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CALCITE-2945) use equals in Boolean object compare

2019-04-04 Thread Josh Elser (JIRA) 


[ 
https://issues.apache.org/jira/browse/CALCITE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810348#comment-16810348
 ] 

Josh Elser commented on CALCITE-2945:
-

[~francischuang], how have you been handling the fixVersion? Do you leave it as 
{{next}} until you cut the next release?

> use equals in Boolean object compare
> 
>
> Key: CALCITE-2945
> URL: https://issues.apache.org/jira/browse/CALCITE-2945
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.16.0, 1.17.0, 1.18.0
>Reporter: leesf
>Assignee: leesf
>Priority: Minor
>  Labels: pull-request-available
> Fix For: next
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In ConnectionPropertiesImpl#merge funciton,  we could use equals method in 
> Boolean object compare.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)