[ https://issues.apache.org/jira/browse/CALCITE-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912759#comment-16912759 ]
Julian Hyde commented on CALCITE-3247: -------------------------------------- Can you rework the description and commit message to be consistent with CALCITE-3220. > wrong sql format when transforming function SUBSTRING to hive sql > ----------------------------------------------------------------- > > Key: CALCITE-3247 > URL: https://issues.apache.org/jira/browse/CALCITE-3247 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.19.0 > Reporter: Jacky Woo > Priority: Minor > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Let's assume sql = SELECT SUBSTRING('ABC', 2) > When we use HiveSqlDialect and transform "sql", we expect SUBSTRING(' abc', > 2),but get SUBSTRING(' abc' FROM 2) which is incorrect sql format in hive. > So maybe HiveSqlDialect behavior should be changed when transform function > SUBSTRING: > # {{SELECT SUBSTRING('ABC', 2) => SELECT SUBSTRING('ABC', 2)}} > # {{SELECT SUBSTRING('ABC', 2, 3) => SELECT SUBSTRING('ABC', 2, 3) }} > # {{SELECT SUBSTRING('ABC' FROM 2) => SELECT SUBSTRING('ABC', 2) }} > # {{SELECT SUBSTRING('ABC' FROM 2 FOR 3) => SELECT SUBSTRING('ABC', 2, 3) }} > -- This message was sent by Atlassian Jira (v8.3.2#803003)