[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias
[
https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181497#comment-17181497
]
Julian Hyde commented on CALCITE-4025:
--
I don’t know. What does the standard say?
> DelegatingScope#fullyQualify may exit too soon when resolving table alias
> -
>
> Key: CALCITE-4025
> URL: https://issues.apache.org/jira/browse/CALCITE-4025
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When fully qualifing an id with {{DelegatingScope#fullyQualify()}} method,
> there's a look going over all the possible sub prefixes and trying to resolve
> them, until one succeed. But if not, the same lookup is done using a liberal
> name matcher. If that one resolves, then the method exit early with an
> exception message instead of going over the whole loop or trying for a fully
> qualified table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias
[
https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181450#comment-17181450
]
Laurent Goujon commented on CALCITE-4025:
-
Thinking more about it (and before changing the issue's title), I wonder if
there's not a second issue at hand which is the case where both the alias and
the column have the exact same case, and it would be ambiguous to resolve but
currently it does not fail?
> DelegatingScope#fullyQualify may exit too soon when resolving table alias
> -
>
> Key: CALCITE-4025
> URL: https://issues.apache.org/jira/browse/CALCITE-4025
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When fully qualifing an id with {{DelegatingScope#fullyQualify()}} method,
> there's a look going over all the possible sub prefixes and trying to resolve
> them, until one succeed. But if not, the same lookup is done using a liberal
> name matcher. If that one resolves, then the method exit early with an
> exception message instead of going over the whole loop or trying for a fully
> qualified table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias
[
https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181443#comment-17181443
]
Laurent Goujon commented on CALCITE-4025:
-
Sure. Does the test case look valid at least?
> DelegatingScope#fullyQualify may exit too soon when resolving table alias
> -
>
> Key: CALCITE-4025
> URL: https://issues.apache.org/jira/browse/CALCITE-4025
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When fully qualifing an id with {{DelegatingScope#fullyQualify()}} method,
> there's a look going over all the possible sub prefixes and trying to resolve
> them, until one succeed. But if not, the same lookup is done using a liberal
> name matcher. If that one resolves, then the method exit early with an
> exception message instead of going over the whole loop or trying for a fully
> qualified table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias
[
https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180785#comment-17180785
]
Julian Hyde commented on CALCITE-4025:
--
I see you know have a test case. Can you re-title the issue and the commit
based on that test case? DelegatingScope is an implementation detail and
shouldn't even be mentioned.
> DelegatingScope#fullyQualify may exit too soon when resolving table alias
> -
>
> Key: CALCITE-4025
> URL: https://issues.apache.org/jira/browse/CALCITE-4025
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Assignee: Laurent Goujon
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When fully qualifing an id with {{DelegatingScope#fullyQualify()}} method,
> there's a look going over all the possible sub prefixes and trying to resolve
> them, until one succeed. But if not, the same lookup is done using a liberal
> name matcher. If that one resolves, then the method exit early with an
> exception message instead of going over the whole loop or trying for a fully
> qualified table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias
[
https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117160#comment-17117160
]
Laurent Goujon commented on CALCITE-4025:
-
Thanks for helping me on the the test case, I'll try to implement your
suggestion.
> DelegatingScope#fullyQualify may exit too soon when resolving table alias
> -
>
> Key: CALCITE-4025
> URL: https://issues.apache.org/jira/browse/CALCITE-4025
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Priority: Major
>
> When fully qualifing an id with {{DelegatingScope#fullyQualify()}} method,
> there's a look going over all the possible sub prefixes and trying to resolve
> them, until one succeed. But if not, the same lookup is done using a liberal
> name matcher. If that one resolves, then the method exit early with an
> exception message instead of going over the whole loop or trying for a fully
> qualified table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias
[
https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117157#comment-17117157
]
Julian Hyde commented on CALCITE-4025:
--
I'd like to see a test case. Looking up qualified names is complicated, because
if you have "FROM x.y.z" as a table then later you are allowed to use the
fully-qualified table name as if it were a table alias, e.g. "SELECT x.y.z.c"
and "SELECT z.c" are both valid.
> DelegatingScope#fullyQualify may exit too soon when resolving table alias
> -
>
> Key: CALCITE-4025
> URL: https://issues.apache.org/jira/browse/CALCITE-4025
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Laurent Goujon
>Priority: Major
>
> When fully qualifing an id with {{DelegatingScope#fullyQualify()}} method,
> there's a look going over all the possible sub prefixes and trying to resolve
> them, until one succeed. But if not, the same lookup is done using a liberal
> name matcher. If that one resolves, then the method exit early with an
> exception message instead of going over the whole loop or trying for a fully
> qualified table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias
[
https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117149#comment-17117149
]
Laurent Goujon commented on CALCITE-4025:
-
I mentioned it as a possible issue on the Calcite mailing list but didn't get
any feedback on it:
https://mail-archives.apache.org/mod_mbox/calcite-dev/202005.mbox/%3CCAGQXjMwWr%2Bot_-rjTzo6dG1are3DM%3DWp3vQYNsB640JTSGgLbQ%40mail.gmail.com%3E
> DelegatingScope#fullyQualify may exit too soon when resolving table alias
> -
>
> Key: CALCITE-4025
> URL: https://issues.apache.org/jira/browse/CALCITE-4025
> Project: Calcite
> Issue Type: Improvement
> Components: core
>Reporter: Laurent Goujon
>Priority: Major
>
> When fully qualifing an id with {{DelegatingScope#fullyQualify()}} method,
> there's a look going over all the possible sub prefixes and trying to resolve
> them, until one succeed. But if not, the same lookup is done using a liberal
> name matcher. If that one resolves, then the method exit early with an
> exception message instead of going over the whole loop or trying for a fully
> qualified table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
