[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-15 Thread Jiatao Tao (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136262#comment-17136262
 ] 

Jiatao Tao commented on CALCITE-4059:
-

Hi [~danny0405], Could you possibly review this pr?

[https://github.com/apache/calcite/pull/2019]

> SqlTypeUtil#equalSansNullability doesn't consider Array/Map
> ---
>
> Key: CALCITE-4059
> URL: https://issues.apache.org/jira/browse/CALCITE-4059
> Project: Calcite
>  Issue Type: Bug
>Reporter: Jiatao Tao
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Current equalSansNullability only considers the atomic type, not support 
> Array/Map(struct type can be supported by equalAsStructSansNullability).
> This Jira mainly supports Array/Map type in 
> SqlTypeUtil#equalSansNullabilityI, the nullability of the type or the element 
> of the type will be discarded, the case is in testEqualSansNullability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-12 Thread Jiatao Tao (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134059#comment-17134059
 ] 

Jiatao Tao commented on CALCITE-4059:
-

[~danny0405] equalAsStructSansNullability handles struct type, the case I added 
handle array/map.

> SqlTypeUtil#equalSansNullability doesn't consider Array/Map
> ---
>
> Key: CALCITE-4059
> URL: https://issues.apache.org/jira/browse/CALCITE-4059
> Project: Calcite
>  Issue Type: Bug
>Reporter: Jiatao Tao
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Danny Chen (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133877#comment-17133877
 ] 

Danny Chen commented on CALCITE-4059:
-

Thanks [~Aron.tao], did you try SqlTypeUtil#equalAsStructSansNullability ?

> SqlTypeUtil#equalSansNullability doesn't consider Array/Map
> ---
>
> Key: CALCITE-4059
> URL: https://issues.apache.org/jira/browse/CALCITE-4059
> Project: Calcite
>  Issue Type: Bug
>Reporter: Jiatao Tao
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Jiatao Tao (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133842#comment-17133842
 ] 

Jiatao Tao commented on CALCITE-4059:
-

[~amaliujia] 

> SqlTypeUtil#equalSansNullability doesn't consider Array/Map
> ---
>
> Key: CALCITE-4059
> URL: https://issues.apache.org/jira/browse/CALCITE-4059
> Project: Calcite
>  Issue Type: Bug
>Reporter: Jiatao Tao
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Rui Wang (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133759#comment-17133759
 ] 

Rui Wang commented on CALCITE-4059:
---

[~Aron.tao] could you improve this bug by adding some examples in the 
description?

> SqlTypeUtil#equalSansNullability doesn't consider Array/Map
> ---
>
> Key: CALCITE-4059
> URL: https://issues.apache.org/jira/browse/CALCITE-4059
> Project: Calcite
>  Issue Type: Bug
>Reporter: Jiatao Tao
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Jiatao Tao (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133247#comment-17133247
 ] 

Jiatao Tao commented on CALCITE-4059:
-

Origin SqlTypeUtil#equalSansNullability only consider atomic type.

mr: [https://github.com/apache/calcite/pull/2019]

> SqlTypeUtil#equalSansNullability doesn't consider Array/Map
> ---
>
> Key: CALCITE-4059
> URL: https://issues.apache.org/jira/browse/CALCITE-4059
> Project: Calcite
>  Issue Type: Bug
>Reporter: Jiatao Tao
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)