[jira] [Commented] (CALCITE-4061) Build should fail if Calcite code uses deprecated APIs
[ https://issues.apache.org/jira/browse/CALCITE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134579#comment-17134579 ] Julian Hyde commented on CALCITE-4061: -- Thanks for fixing, [~vlsi]! (Thanks for also fixing the bit-rot.) > Build should fail if Calcite code uses deprecated APIs > --- > > Key: CALCITE-4061 > URL: https://issues.apache.org/jira/browse/CALCITE-4061 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Vladimir Sitnikov >Priority: Major > Fix For: 1.24.0 > > > Calcite build should fail if Calcite code uses deprecated APIs. This includes > external APIs (e.g. Guava methods) and internal APIs (e.g. a deprecated class > in the org.apache.calcite.util package). > This used to occur when the build was powered by Maven. > Compared to a policy where code is allowed to use deprecated APIs for a > 'grace period', this policy has a number of advantages. One is that Calcite > devs (or users) can upgrade dependencies at short notice, with no code > changes. > Another is that it forces people who are doing internal refactoring > (replacing one internal Calcite API with another) to finish the job. > [~vlsi] Can you take this please? I can't figure out how to set javac's > '-Xlint:deprecated -Werror' from Gradle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4061) Build should fail if Calcite code uses deprecated APIs
[ https://issues.apache.org/jira/browse/CALCITE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134175#comment-17134175 ] Vladimir Sitnikov commented on CALCITE-4061: Fixed in https://github.com/apache/calcite/commit/f09991959dea41b8805d8cdd18572803d42e3738 > Build should fail if Calcite code uses deprecated APIs > --- > > Key: CALCITE-4061 > URL: https://issues.apache.org/jira/browse/CALCITE-4061 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Vladimir Sitnikov >Priority: Major > > Calcite build should fail if Calcite code uses deprecated APIs. This includes > external APIs (e.g. Guava methods) and internal APIs (e.g. a deprecated class > in the org.apache.calcite.util package). > This used to occur when the build was powered by Maven. > Compared to a policy where code is allowed to use deprecated APIs for a > 'grace period', this policy has a number of advantages. One is that Calcite > devs (or users) can upgrade dependencies at short notice, with no code > changes. > Another is that it forces people who are doing internal refactoring > (replacing one internal Calcite API with another) to finish the job. > [~vlsi] Can you take this please? I can't figure out how to set javac's > '-Xlint:deprecated -Werror' from Gradle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4061) Build should fail if Calcite code uses deprecated APIs
[
https://issues.apache.org/jira/browse/CALCITE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134086#comment-17134086
]
Vladimir Sitnikov commented on CALCITE-4061:
Here's a way to configure it:
{noformat}
diff --git a/build.gradle.kts b/build.gradle.kts
index af8e0ab45..751278328 100644
--- a/build.gradle.kts
+++ b/build.gradle.kts
@@ -523,6 +523,7 @@ allprojects {
configureEach {
options.encoding = "UTF-8"
+options.compilerArgs.addAll(listOf("-Xlint:deprecation",
"-Werror"))
}
configureEach {
useJUnitPlatform
{noformat}
> Build should fail if Calcite code uses deprecated APIs
> ---
>
> Key: CALCITE-4061
> URL: https://issues.apache.org/jira/browse/CALCITE-4061
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Vladimir Sitnikov
>Priority: Major
>
> Calcite build should fail if Calcite code uses deprecated APIs. This includes
> external APIs (e.g. Guava methods) and internal APIs (e.g. a deprecated class
> in the org.apache.calcite.util package).
> This used to occur when the build was powered by Maven.
> Compared to a policy where code is allowed to use deprecated APIs for a
> 'grace period', this policy has a number of advantages. One is that Calcite
> devs (or users) can upgrade dependencies at short notice, with no code
> changes.
> Another is that it forces people who are doing internal refactoring
> (replacing one internal Calcite API with another) to finish the job.
> [~vlsi] Can you take this please? I can't figure out how to set javac's
> '-Xlint:deprecated -Werror' from Gradle.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
