[jira] [Commented] (CALCITE-4547) Support Java 16 and 17
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464003#comment-17464003 ] Gregory Sartucci commented on CALCITE-4547: --- So I' currently trying to work with a java 16+ project using Gradle, in Netbeans, and I'm getting this error: A problem occurred evaluating root project 'architectury-example-mod'. > Failed to apply plugin 'dev.architectury.loom'. > You are using an outdated version of Java (11). Java 16 or higher is required. The JAVA_HOME environment variable is currently set to (/usr/lib/jvm/graalvm-ce-java17-21.3.0). I've set my Netbeans to use Java 17 anywhere and everywhere I can. I don;t see any option for setting the JDK version used for Gradle, the way there is for Maven. Is that the problem? And, if so, is there a way for me to fix it? :/ > Support Java 16 and 17 > -- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Fix For: 1.29.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will not support Java 16. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (CALCITE-4547) Support Java 16 and 17
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463564#comment-17463564 ] Julian Hyde commented on CALCITE-4547: -- [~VAE], The patch looks good. Thanks! Also, because the patch is just documentation and testing, even if the patch is applied just after release 1.29 it is still valid to mark the bug fixed in 1.29. > Support Java 16 and 17 > -- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Fix For: 1.29.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will not support Java 16. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (CALCITE-4547) Support Java 16 and 17
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463536#comment-17463536 ] ZheHu commented on CALCITE-4547: Hi, [~julianhyde] . I've submit a [patch|https://github.com/apache/calcite/pull/2656] for what you mentioned on dev list. I'll update the release notes of 1.29 RC 0 after it's merged. > Support Java 16 and 17 > -- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Fix For: 1.29.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will not support Java 16. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (CALCITE-4547) Support Java 16
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424380#comment-17424380 ] Vladimir Sitnikov commented on CALCITE-4547: I reverted the subject > Support Java 16 > --- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will not support Java 16. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4547) Support Java 16
[
https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308924#comment-17308924
]
Vladimir Sitnikov commented on CALCITE-4547:
I've filed CALCITE-4553 for toolchains.
{quote} testRuntime{quote}
Indeed. We need to do something with it. Either apply yet another workaround to
keep test jars afloat for a while, or just drop them and move to test-like
artifacts.
> Support Java 16
> ---
>
> Key: CALCITE-4547
> URL: https://issues.apache.org/jira/browse/CALCITE-4547
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK
> 16).
> This will require an [upgrade to Gradle
> 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6
> will not support Java 16.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4547) Support Java 16
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308921#comment-17308921 ] Julian Hyde commented on CALCITE-4547: -- The toolchain idea sounds fine. Can you log a separate JIRA? Which means the main problem to be resolved in this JIRA is to remove out use of "testRuntime", so we can upgrade to Gradle 7, so that we can use JDK 16. > Support Java 16 > --- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will not support Java 16. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4547) Support Java 16
[
https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308589#comment-17308589
]
Vladimir Sitnikov commented on CALCITE-4547:
{quote} the problem with "testRuntime" still exists.{quote}
testRuntime will be dropped in Gradle 7, and it has to be adjusted before
migration to 7.
One of the approaches is to stop publishing the test jars, and move the
relevant classes to the relevant modules (e.g. core-testkit, etc, etc).
{quote} So, if we use Gradle toolchains we'd have to invent another forcing
function{quote}
It could be like "JAVA_HOME_FOR_CALCITE=..." build property (e.g. by default
use the current JVM for the build, however, allow users to configure custom JVM
for build and test).
That would be more-or-less transparent for the end-users.
> Support Java 16
> ---
>
> Key: CALCITE-4547
> URL: https://issues.apache.org/jira/browse/CALCITE-4547
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK
> 16).
> This will require an [upgrade to Gradle
> 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6
> will not support Java 16.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4547) Support Java 16
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308279#comment-17308279 ] Julian Hyde commented on CALCITE-4547: -- I just pushed an upgrade to 7.0-rc-1; the problem with "testRuntime" still exists. > Support Java 16 > --- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will not support Java 16. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4547) Support Java 16
[
https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308265#comment-17308265
]
Julian Hyde commented on CALCITE-4547:
--
{quote}It might be time to use
https://docs.gradle.org/6.8.3/userguide/toolchains.html to decouple java which
is used to launch Gradle from java which is used to build and execute
tests{quote}.
Well, maybe. But I don't think it's good to build Calcite on only one JDK
version. I think it's good that Calcite should build on ANY supported JDK
version. So, if we use Gradle toolchains we'd have to invent another forcing
function to force us to get the code compiling under JDK 16.
> Support Java 16
> ---
>
> Key: CALCITE-4547
> URL: https://issues.apache.org/jira/browse/CALCITE-4547
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK
> 16).
> This will require an [upgrade to Gradle
> 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6
> will not support Java 16.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-4547) Support Java 16
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307598#comment-17307598 ] Vladimir Sitnikov commented on CALCITE-4547: 1) 7.0-rc-1 is never than 7.0-milestone-3 (see https://services.gradle.org/versions/all) 2) It might be time to use https://docs.gradle.org/6.8.3/userguide/toolchains.html to decouple java which is used to launch Gradle from java which is used to build and execute tests > Support Java 16 > --- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will not support Java 16. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4547) Support Java 16
[ https://issues.apache.org/jira/browse/CALCITE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307459#comment-17307459 ] Julian Hyde commented on CALCITE-4547: -- I have created a draft [pull request|https://github.com/apache/calcite/pull/2380]. It is not ready to merge. Gradle complains about a missing "testRuntime" configuration, and it depends on a milestone release of Gradle 7; we should wait until Gradle 7 is officially released. > Support Java 16 > --- > > Key: CALCITE-4547 > URL: https://issues.apache.org/jira/browse/CALCITE-4547 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Support building and running on [Java 16|https://jdk.java.net/16/] (OpenJDK > 16). > This will require an [upgrade to Gradle > 7|https://melix.github.io/blog/2021/03/gradle-java16.html], because Gradle 6 > will support Java 16. -- This message was sent by Atlassian Jira (v8.3.4#803005)
