[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730498#comment-17730498 ] Evgeny Stanilovsky commented on CALCITE-5708: - As i can see mentioned functions _not using untyped NULL_ in tests, but without cast (pure null literals) they work exactly the same as with cast besides SUBSTRING. Or you want additional tests (with cast) will be appended? > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738262#comment-17738262 ] Julian Hyde commented on CALCITE-5708: -- [~Runking] and [~zstan], This is marked 'fixVersion = 1.35.0' and the release is rapidly approaching. In the next 24 hours, can we agree criteria so that this can be finished? > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738392#comment-17738392 ] Evgeny Stanilovsky commented on CALCITE-5708: - i read on dev-list that ready issues need to be marked with this version, so i marked it, but still no progress on review, if no volunteers will be found seems need to clear this label .. > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738675#comment-17738675 ] Julian Hyde commented on CALCITE-5708: -- It seems to me that [~Runking] has reviewed. But you and Runkang have not agreed next steps. > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738874#comment-17738874 ] Evgeny Stanilovsky commented on CALCITE-5708: - thanks, yes he leave 2 comments, i fixed them, and .. silence ) > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739231#comment-17739231 ] Gian Merlino commented on CALCITE-5708: --- I wrote a review as well. Hope this helps. There is a question about whether a similar problem exists for other functions. I haven't tested it myself, but from reading the code, it seems like when {{typeCoercion}} is {{true}} (which is the default), the {{FamilyOperandTypeChecker}} allows {{NULL}} literals. So, hopefully, this problem is limited to {{SUBSTRING}} because it has some custom checking logic that specifically didn't allow for {{NULL}} literals. > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739504#comment-17739504 ] Evgeny Stanilovsky commented on CALCITE-5708: - [~gian] thanks for review ! i change all your comments > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal
[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739943#comment-17739943 ] Runkang He commented on CALCITE-5708: - [~zstan] Looks good to me for the latest commit. [~gian] Thanks for reviewing. > Change SUBSTRING result if either of parameters is NULL literal > --- > > Key: CALCITE-5708 > URL: https://issues.apache.org/jira/browse/CALCITE-5708 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.34.0 >Reporter: Evgeny Stanilovsky >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: patch-available, pull-request-available > Fix For: 1.35.0 > > > According to standard: > {noformat} > 6.18 > ... > 3)If is specified, then: > ... > c) If either C, S, or L is the null value, then the result of the substring function> is > the null value. > {noformat} > calcite not follow this rule for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)