[jira] [Commented] (CALCITE-6002) CONTAINS_SUBSTR does not unparse correctly

2024-01-08 Thread Mihai Budiu (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804532#comment-17804532
 ] 

Mihai Budiu commented on CALCITE-6002:
--

[~tanclary] The bug arises because the CONTAINS_SUBSTR is an instance of 
SqlBasicFunction, which is always unparsed in a standard way.
However, a custom class should be defined to unparse the json_scope argument in 
a special way.
Note that there is already a disabled test for this case in 
SqlOperatorUnparseTest.

> CONTAINS_SUBSTR does not unparse correctly
> --
>
> Key: CALCITE-6002
> URL: https://issues.apache.org/jira/browse/CALCITE-6002
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Mihai Budiu
>Assignee: Tanner Clary
>Priority: Minor
>
> There are in fact two bugs related to CONTAINS_SUBSTR.
> The first one is that the documentation does not render in the md file, there 
> must be something wrong with the html escape sequences.
> The second one is that it does not unparse into a correct form.
> [~tanclary] I think you added this code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6002) CONTAINS_SUBSTR does not unparse correctly

2023-09-12 Thread Tanner Clary (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764429#comment-17764429
 ] 

Tanner Clary commented on CALCITE-6002:
---

Thanks for opening this ticket. I will get to it when I can.

> CONTAINS_SUBSTR does not unparse correctly
> --
>
> Key: CALCITE-6002
> URL: https://issues.apache.org/jira/browse/CALCITE-6002
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Mihai Budiu
>Assignee: Tanner Clary
>Priority: Minor
>
> There are in fact two bugs related to CONTAINS_SUBSTR.
> The first one is that the documentation does not render in the md file, there 
> must be something wrong with the html escape sequences.
> The second one is that it does not unparse into a correct form.
> [~tanclary] I think you added this code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6002) CONTAINS_SUBSTR does not unparse correctly

2023-09-12 Thread Mihai Budiu (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764427#comment-17764427
 ] 

Mihai Budiu commented on CALCITE-6002:
--

In particular, this query:
{code:sql}
SELECT CONTAINS_SUBSTR('{"foo":"bar"}', 'bar', json_scope=>'JSON_KEYS')
{code}

is unparsed as:

{code;sql}
SELECT CONTAINS_SUBSTR("P2", "P1", "P0")
FROM (VALUES ROW('JSON_KEYS', 'bar', '{"foo":"bar"}')) AS "T" ("P0", "P1", "P2")
{code}



> CONTAINS_SUBSTR does not unparse correctly
> --
>
> Key: CALCITE-6002
> URL: https://issues.apache.org/jira/browse/CALCITE-6002
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Mihai Budiu
>Assignee: Tanner Clary
>Priority: Minor
>
> There are in fact two bugs related to CONTAINS_SUBSTR.
> The first one is that the documentation does not render in the md file, there 
> must be something wrong with the html escape sequences.
> The second one is that it does not unparse into a correct form.
> [~tanclary] I think you added this code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)