[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-04-24 Thread Sergey Nuyanzin (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840415#comment-17840415
 ] 

Sergey Nuyanzin commented on CALCITE-6222:
--

Removed fix version since it was reverted

> Mysql does not have to_char function
> 
>
> Key: CALCITE-6222
> URL: https://issues.apache.org/jira/browse/CALCITE-6222
> Project: Calcite
>  Issue Type: Bug
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Minor
>  Labels: pull-request-available
>
> {code:java}
> mysql> select to_char(timestamp '2002-04-20 17:31:12.66', 'HH12:MI:SS')
>     -> ;
> ERROR 1305 (42000): FUNCTION test.to_char does not exist
>  {code}
> mysql does not seem to have a to_char function
>  
> link：https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Caican Cai (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811454#comment-17811454
 ] 

Caican Cai commented on CALCITE-6222:
-

thank everyone

> Mysql does not have to_char function
> 
>
> Key: CALCITE-6222
> URL: https://issues.apache.org/jira/browse/CALCITE-6222
> Project: Calcite
>  Issue Type: Bug
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.37.0
>
>
> {code:java}
> mysql> select to_char(timestamp '2002-04-20 17:31:12.66', 'HH12:MI:SS')
>     -> ;
> ERROR 1305 (42000): FUNCTION test.to_char does not exist
>  {code}
> mysql does not seem to have a to_char function
>  
> link：https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Julian Hyde (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811389#comment-17811389
 ] 

Julian Hyde commented on CALCITE-6222:
--

The first step in this case should have been to contact the author of 
CALCITE-5619 and ask why they added 'm' to the list of supported dialects. I 
find [~jiajunbernoulli]'s hypothesis - that MariaDB supports {{TO_CHAR}} - to 
be compelling.

See .[Chesterton's fence|https://en.wiktionary.org/wiki/Chesterton%27s_fence]. 

Given that MariaDB has {{TO_CHAR}}, and one of the goals of the MYSQL library 
({{fun=mysql}}) is to make Calcite look like MariaDB, it seems that Calcite's 
behavior was correct before this bug was fixed.

It is much more harmful that {{TO_CHAR}} is missing for someone who expects 
MariaDB compatibility than for it to be present for someone who expects MySQL 
compatibility. Let's choose the lesser harm.

Reverted in commit 
[523bbf37|https://github.com/apache/calcite/commit/523bbf3730ac1670928ee4e0f54745cc337eefb0];
 now, the MYSQL library does support the {{TO_CHAR}} function.

> Mysql does not have to_char function
> 
>
> Key: CALCITE-6222
> URL: https://issues.apache.org/jira/browse/CALCITE-6222
> Project: Calcite
>  Issue Type: Bug
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.37.0
>
>
> {code:java}
> mysql> select to_char(timestamp '2002-04-20 17:31:12.66', 'HH12:MI:SS')
>     -> ;
> ERROR 1305 (42000): FUNCTION test.to_char does not exist
>  {code}
> mysql does not seem to have a to_char function
>  
> link：https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Jiajun Xie (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811250#comment-17811250
 ] 

Jiajun Xie commented on CALCITE-6222:
-

Calcite has many users, and any compatibility changes should be handled with 
caution.

 

Although it's difficult, I don't want to burden users with upgrading calcite.

> Mysql does not have to_char function
> 
>
> Key: CALCITE-6222
> URL: https://issues.apache.org/jira/browse/CALCITE-6222
> Project: Calcite
>  Issue Type: Bug
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.37.0
>
>
> {code:java}
> mysql> select to_char(timestamp '2002-04-20 17:31:12.66', 'HH12:MI:SS')
>     -> ;
> ERROR 1305 (42000): FUNCTION test.to_char does not exist
>  {code}
> mysql does not seem to have a to_char function
>  
> link：https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Jiajun Xie (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811245#comment-17811245
 ] 

Jiajun Xie commented on CALCITE-6222:
-

MariaDB have it: [https://mariadb.com/kb/en/to_char/]

If someone uses it as MySQL, the function will failed.

This change needs to be declared in the Release Notes.

> Mysql does not have to_char function
> 
>
> Key: CALCITE-6222
> URL: https://issues.apache.org/jira/browse/CALCITE-6222
> Project: Calcite
>  Issue Type: Bug
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.37.0
>
>
> {code:java}
> mysql> select to_char(timestamp '2002-04-20 17:31:12.66', 'HH12:MI:SS')
>     -> ;
> ERROR 1305 (42000): FUNCTION test.to_char does not exist
>  {code}
> mysql does not seem to have a to_char function
>  
> link：https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-24 Thread Julian Hyde (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810571#comment-17810571
 ] 

Julian Hyde commented on CALCITE-6222:
--

This is not minor. This is a functionality change.

I've linked to CALCITE-5619, which introduced the issue. (And apparently did 
not test the functionality introduced.)

> Mysql does not have to_char function
> 
>
> Key: CALCITE-6222
> URL: https://issues.apache.org/jira/browse/CALCITE-6222
> Project: Calcite
>  Issue Type: Bug
>  Components: site
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.37.0
>
>
> {code:java}
> mysql> select to_char(timestamp '2002-04-20 17:31:12.66', 'HH12:MI:SS')
>     -> ;
> ERROR 1305 (42000): FUNCTION test.to_char does not exist
>  {code}
> mysql does not seem to have a to_char function
>  
> link：https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-format



--
This message was sent by Atlassian Jira
(v8.20.10#820010)