[jira] [Commented] (CALCITE-6249) RelNode::estimatedRowCount should not be used in computeSelfCost

2024-02-07 Thread Ulrich Kramer (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815163#comment-17815163
 ] 

Ulrich Kramer commented on CALCITE-6249:


Yes, I will create a PR for this issue.

> RelNode::estimatedRowCount should not be used in computeSelfCost
> 
>
> Key: CALCITE-6249
> URL: https://issues.apache.org/jira/browse/CALCITE-6249
> Project: Calcite
>  Issue Type: Bug
>Reporter: Ulrich Kramer
>Priority: Minor
>
> {{RelNode::estimatedRowCount}} is still used in many place inside 
> {{computeSelfCost}}
> If it should be possible to implement the estimation of the row count 
> completely outside Calcite, these calls should be replaced by 
> {{mq.getRowCount(rel)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6249) RelNode::estimatedRowCount should not be used in computeSelfCost

2024-02-07 Thread Ruben Q L (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815152#comment-17815152
 ] 

Ruben Q L commented on CALCITE-6249:


[~kramerul] I think the current ticket is related to CALCITE-5647, but not a 
duplicate of it (I have updated the link between both accordingly).
I think the commit that you propose seems reasonable, could you create the 
corresponding PR?

> RelNode::estimatedRowCount should not be used in computeSelfCost
> 
>
> Key: CALCITE-6249
> URL: https://issues.apache.org/jira/browse/CALCITE-6249
> Project: Calcite
>  Issue Type: Bug
>Reporter: Ulrich Kramer
>Priority: Minor
>
> {{RelNode::estimatedRowCount}} is still used in many place inside 
> {{computeSelfCost}}
> If it should be possible to implement the estimation of the row count 
> completely outside Calcite, these calls should be replaced by 
> {{mq.getRowCount(rel)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6249) RelNode::estimatedRowCount should not be used in computeSelfCost

2024-02-06 Thread Ulrich Kramer (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815135#comment-17815135
 ] 

Ulrich Kramer commented on CALCITE-6249:


See also [this 
commit|https://github.com/sap-contributions/calcite/commit/4b05e056a60c95f55bea51b4fc6ed82ee0f8b228]

> RelNode::estimatedRowCount should not be used in computeSelfCost
> 
>
> Key: CALCITE-6249
> URL: https://issues.apache.org/jira/browse/CALCITE-6249
> Project: Calcite
>  Issue Type: Bug
>Reporter: Ulrich Kramer
>Priority: Minor
>
> {{RelNode::estimatedRowCount}} is still used in many place inside 
> {{computeSelfCost}}
> If it should be possible to implement the estimation of the row count 
> completely outside Calcite, these calls should be replaced by 
> {{mq.getRowCount(rel)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)