[jira] [Commented] (CALCITE-6273) Add sqrt negative test in SqlOperatorTest

2024-02-19 Thread Jiajun Xie (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818608#comment-17818608
 ] 

Jiajun Xie commented on CALCITE-6273:
-

Fixed in 
[31d66e7.|https://github.com/apache/calcite/commit/31d66e797d3ca66d154262b15ee35876804df963]

Thanks [~caicancai] 

> Add sqrt negative test in SqlOperatorTest
> -
>
> Key: CALCITE-6273
> URL: https://issues.apache.org/jira/browse/CALCITE-6273
> Project: Calcite
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.37.0
>
>
> sqrt currently lacks some negatvie tests, such as sqrt(-1), sqrt(0), 
> sqrt(0.5), etc. The idea is mainly because of the log function



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (CALCITE-6273) Add sqrt negative test in SqlOperatorTest

2024-02-18 Thread Caican Cai (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818302#comment-17818302
 ] 

Caican Cai commented on CALCITE-6273:
-

I saw in the arrow-datafusion community that the sqrt function may have similar 
problems with the log function, so I added a test.

> Add sqrt negative test in SqlOperatorTest
> -
>
> Key: CALCITE-6273
> URL: https://issues.apache.org/jira/browse/CALCITE-6273
> Project: Calcite
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.36.0
>Reporter: Caican Cai
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.37.0
>
>
> sqrt currently lacks some negatvie tests, such as sqrt(-1), sqrt(0), 
> sqrt(0.5), etc. The idea is mainly because of the log function



--
This message was sent by Atlassian Jira
(v8.20.10#820010)