[jira] [Commented] (CAMEL-10671) camel-example-celyon
[ https://issues.apache.org/jira/browse/CAMEL-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463387#comment-16463387 ] ASF GitHub Bot commented on CAMEL-10671: WillemJiang commented on issue #2303: CAMEL-10671: Adding Camel example project for the Ceylon JVM language URL: https://github.com/apache/camel/pull/2303#issuecomment-386509507 I just found import maven dependencies as ceylon modules is a solution. I will commit a quick fix for it in a min. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > camel-example-celyon > > > Key: CAMEL-10671 > URL: https://issues.apache.org/jira/browse/CAMEL-10671 > Project: Camel > Issue Type: New Feature > Components: examples >Reporter: Claus Ibsen >Assignee: Willem Jiang >Priority: Minor > Fix For: 2.22.0 > > > We should have a little example of using camel with celyon. Its just to have > a maven project with celyon dependencies and compiler setup and some basic > celyon code that can run standalone with a camel route. > Take a look at the groovy or kotlin example which would be similar. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-10671) camel-example-celyon
[ https://issues.apache.org/jira/browse/CAMEL-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463367#comment-16463367 ] ASF GitHub Bot commented on CAMEL-10671: dimitrisli commented on issue #2303: CAMEL-10671: Adding Camel example project for the Ceylon JVM language URL: https://github.com/apache/camel/pull/2303#issuecomment-386506362 sorry I had a brief look last night and will have more time this afternoon and w/e. In the meantime if this is holding off the whole build please revert the commit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > camel-example-celyon > > > Key: CAMEL-10671 > URL: https://issues.apache.org/jira/browse/CAMEL-10671 > Project: Camel > Issue Type: New Feature > Components: examples >Reporter: Claus Ibsen >Assignee: Willem Jiang >Priority: Minor > Fix For: 2.22.0 > > > We should have a little example of using camel with celyon. Its just to have > a maven project with celyon dependencies and compiler setup and some basic > celyon code that can run standalone with a camel route. > Take a look at the groovy or kotlin example which would be similar. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463050#comment-16463050 ] ASF GitHub Bot commented on CAMEL-12383: davidkarlsen commented on issue #2315: CAMEL-12383 - changes regarding SB 2.0 upgrade URL: https://github.com/apache/camel/pull/2315#issuecomment-386435914 @davsclaus Would it be helpful to add https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide for a while - in order to detect any badly named properties? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-10671) camel-example-celyon
[ https://issues.apache.org/jira/browse/CAMEL-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462938#comment-16462938 ] ASF GitHub Bot commented on CAMEL-10671: PascalSchumacher commented on issue #2303: CAMEL-10671: Adding Camel example project for the Ceylon JVM language URL: https://github.com/apache/camel/pull/2303#issuecomment-386403576 I know nothing about Ceylon, but I guess the problem is that camel snapshots are in a custom maven repository: https://repository.apache.org/content/repositories/snapshots/ Seems like the only way to make Ceylon itself aware of this is adding a custom `settings.xml` (see: https://ceylon-lang.org/documentation/1.3/reference/repository/maven/). I think a better way to solve may be to import the maven dependencies as Ceylon modules with the `ceylon-maven-plugin` (see: https://github.com/ceylon/ceylon-maven-plugin#import-maven-dependencies-as-ceylon-modules). Maybe this can also be used to remove the `module.ceylon` manipulation with the `maven-ant-run-plugin`? What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > camel-example-celyon > > > Key: CAMEL-10671 > URL: https://issues.apache.org/jira/browse/CAMEL-10671 > Project: Camel > Issue Type: New Feature > Components: examples >Reporter: Claus Ibsen >Assignee: Willem Jiang >Priority: Minor > Fix For: 2.22.0 > > > We should have a little example of using camel with celyon. Its just to have > a maven project with celyon dependencies and compiler setup and some basic > celyon code that can run standalone with a camel route. > Take a look at the groovy or kotlin example which would be similar. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-10671) camel-example-celyon
[ https://issues.apache.org/jira/browse/CAMEL-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462936#comment-16462936 ] ASF GitHub Bot commented on CAMEL-10671: PascalSchumacher commented on issue #2303: CAMEL-10671: Adding Camel example project for the Ceylon JVM language URL: https://github.com/apache/camel/pull/2303#issuecomment-386403576 I know nothing about Ceylon, but I guess the problem is that camel snapshots are in a custom maven repository: https://repository.apache.org/content/repositories/snapshots/ Seems like the only way to make Ceylon itself aware of this is adding a custom `settings.xml` (see: https://ceylon-lang.org/documentation/1.3/reference/repository/maven/). I think a better way to solve may be to import the maven dependencies as Ceylon modules with the `ceylon-maven-plugin` (see: https://github.com/ceylon/ceylon-maven-plugin#import-maven-dependencies-as-ceylon-modules). Maybe this can also be used to remove the `module.ceylon` manipulation with the `maven-ant-run-plugin`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > camel-example-celyon > > > Key: CAMEL-10671 > URL: https://issues.apache.org/jira/browse/CAMEL-10671 > Project: Camel > Issue Type: New Feature > Components: examples >Reporter: Claus Ibsen >Assignee: Willem Jiang >Priority: Minor > Fix For: 2.22.0 > > > We should have a little example of using camel with celyon. Its just to have > a maven project with celyon dependencies and compiler setup and some basic > celyon code that can run standalone with a camel route. > Take a look at the groovy or kotlin example which would be similar. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462798#comment-16462798 ] ASF GitHub Bot commented on CAMEL-12383: onderson closed pull request #2315: CAMEL-12383 - changes regarding SB 2.0 upgrade URL: https://github.com/apache/camel/pull/2315 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/archetypes/camel-archetype-spring-boot/src/main/resources/archetype-resources/src/main/resources/application.properties b/archetypes/camel-archetype-spring-boot/src/main/resources/archetype-resources/src/main/resources/application.properties index 24b20c142d7..2c1eb8d01ba 100644 --- a/archetypes/camel-archetype-spring-boot/src/main/resources/archetype-resources/src/main/resources/application.properties +++ b/archetypes/camel-archetype-spring-boot/src/main/resources/archetype-resources/src/main/resources/application.properties @@ -34,8 +34,6 @@ timer.period = 2000 # expose actuator endpoint via HTTP management.endpoints.web.exposure.include=info,health,camelroutes -# all access to actuator endpoints without security -management.security.enabled = false # turn on actuator health check management.endpoint.health.enabled = true diff --git a/components/camel-spring-boot/src/test/resources/application.properties b/components/camel-spring-boot/src/test/resources/application.properties index 518bcd18cd3..4271cf9693d 100644 --- a/components/camel-spring-boot/src/test/resources/application.properties +++ b/components/camel-spring-boot/src/test/resources/application.properties @@ -15,7 +15,7 @@ ## limitations under the License. ## --- -spring.main.banner_mode=off +spring.main.banner-mode=off from=direct:test to=mock:test diff --git a/examples/camel-example-rabbitmq/src/main/resources/application.properties b/examples/camel-example-rabbitmq/src/main/resources/application.properties index cd4dc76e496..613e5f80f35 100644 --- a/examples/camel-example-rabbitmq/src/main/resources/application.properties +++ b/examples/camel-example-rabbitmq/src/main/resources/application.properties @@ -28,8 +28,6 @@ camel.springboot.name = SampleCamel # properties used in the Camel route and beans # -# all access to actuator endpoints without security -management.security.enabled = false # turn on actuator health check management.endpoint.health.enabled = true diff --git a/examples/camel-example-spring-boot-clustered-route-controller/cluster-node/src/main/resources/application.properties b/examples/camel-example-spring-boot-clustered-route-controller/cluster-node/src/main/resources/application.properties index 52314b288e9..fbaf9c14c33 100644 --- a/examples/camel-example-spring-boot-clustered-route-controller/cluster-node/src/main/resources/application.properties +++ b/examples/camel-example-spring-boot-clustered-route-controller/cluster-node/src/main/resources/application.properties @@ -28,7 +28,7 @@ management.endpoints.enabled-by-default = false management.endpoints.jmx.enabled = false management.endpoint.health.enabled = true -management.port = -1 +management.server.port = -1 node.id = ${random.uuid} diff --git a/examples/camel-example-spring-boot-health-checks/application/src/main/resources/application.properties b/examples/camel-example-spring-boot-health-checks/application/src/main/resources/application.properties index ae3be62954f..e22e0d2be0d 100644 --- a/examples/camel-example-spring-boot-health-checks/application/src/main/resources/application.properties +++ b/examples/camel-example-spring-boot-health-checks/application/src/main/resources/application.properties @@ -28,8 +28,6 @@ management.endpoint.mappings.enabled = true management.endpoint.health.enabled = true management.endpoint.camelhealthchecks.enabled = true -management.security.enabled = false - camel.springboot.name = SampleHealthChecks diff --git a/examples/camel-example-spring-boot-master/src/main/resources/application.properties b/examples/camel-example-spring-boot-master/src/main/resources/application.properties index 9f09fb45c42..26ee85da5ae 100644 --- a/examples/camel-example-spring-boot-master/src/main/resources/application.properties +++ b/examples/camel-example-spring-boot-master/src/main/resources/application.properties @@ -29,7 +29,7 @@ management.endpoints.enabled-by-default = false management.endpoints.jmx.enabled = false management.endpoint.health.enabled = true -management.port = -1 +management.server.port = -1 node.id = ${random.uuid}
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462799#comment-16462799 ] ASF GitHub Bot commented on CAMEL-12383: Github user onderson closed the pull request at: https://github.com/apache/camel/pull/2315 > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462800#comment-16462800 ] ASF GitHub Bot commented on CAMEL-12383: onderson commented on issue #2315: CAMEL-12383 - changes regarding SB 2.0 upgrade URL: https://github.com/apache/camel/pull/2315#issuecomment-386367574 Thanks @davsclaus This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Önder Sezgin resolved CAMEL-12383. -- Resolution: Fixed > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Önder Sezgin reassigned CAMEL-12383: Assignee: Önder Sezgin (was: Bennet Schulz) > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Önder Sezgin >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462766#comment-16462766 ] ASF GitHub Bot commented on CAMEL-12383: davsclaus commented on issue #2315: CAMEL-12383 - changes regarding SB 2.0 upgrade URL: https://github.com/apache/camel/pull/2315#issuecomment-386362216 Thanks @onderson looks good, you can merge and resolve the JIRA ticket This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Bennet Schulz >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-10671) camel-example-celyon
[ https://issues.apache.org/jira/browse/CAMEL-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462558#comment-16462558 ] ASF GitHub Bot commented on CAMEL-10671: PascalSchumacher commented on issue #2303: CAMEL-10671: Adding Camel example project for the Ceylon JVM language URL: https://github.com/apache/camel/pull/2303#issuecomment-386325380 For some reason this does not compile on builds.apache.org: ``` [INFO] ---< org.apache.camel.example:camel-example-ceylon > [INFO] Building Camel :: Example :: Ceylon 2.22.0-SNAPSHOT [655/768] ... [ERROR] Compilation error at (21,5) in /home/jenkins/jenkins-slave/workspace/Camel_master-CIGY56HHEDNGVJBWJRRHBZ64GKNJTCSYDKOPJS46W5IZTMAS3I2Q/examples/camel-example-ceylon/src/main/ceylon/org/apache/camel/example/module.ceylon:cannot find module artifact 'maven:org.apache.camel:camel-core-2.22.0-SNAPSHOT(.car|.jar)' - dependency tree: 'org.apache.camel.example/2.22.0-SNAPSHOT' -> 'org.apache.camel:camel-core/2.22.0-SNAPSHOT' [ERROR] Compilation error at (22,5) in /home/jenkins/jenkins-slave/workspace/Camel_master-CIGY56HHEDNGVJBWJRRHBZ64GKNJTCSYDKOPJS46W5IZTMAS3I2Q/examples/camel-example-ceylon/src/main/ceylon/org/apache/camel/example/module.ceylon:cannot find module artifact 'maven:org.apache.camel:camel-jetty-2.22.0-SNAPSHOT(.car|.jar)' - dependency tree: 'org.apache.camel.example/2.22.0-SNAPSHOT' -> 'org.apache.camel:camel-jetty/2.22.0-SNAPSHOT' ``` For details see: https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/264/consoleFull This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > camel-example-celyon > > > Key: CAMEL-10671 > URL: https://issues.apache.org/jira/browse/CAMEL-10671 > Project: Camel > Issue Type: New Feature > Components: examples >Reporter: Claus Ibsen >Assignee: Willem Jiang >Priority: Minor > Fix For: 2.22.0 > > > We should have a little example of using camel with celyon. Its just to have > a maven project with celyon dependencies and compiler setup and some basic > celyon code that can run standalone with a camel route. > Take a look at the groovy or kotlin example which would be similar. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-11257) Provide AS2 component to support Business Data Interchange Using HTTP
[ https://issues.apache.org/jira/browse/CAMEL-11257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462412#comment-16462412 ] William Collins commented on CAMEL-11257: - [~ancosen] thanks! I will fill in the rest of the documentation. > Provide AS2 component to support Business Data Interchange Using HTTP > - > > Key: CAMEL-11257 > URL: https://issues.apache.org/jira/browse/CAMEL-11257 > Project: Camel > Issue Type: New Feature >Affects Versions: 2.19.1 >Reporter: William Collins >Assignee: William Collins >Priority: Major > Fix For: 2.22.0 > > > AS2 Camel component should provide MIME-Based Secure Peer-to-Peer Business > Data Interchange Using HTTP as per RFC4120 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12481) Camel-Mongodb3: Add support for Change Streams feature
Andrea Cosentino created CAMEL-12481: Summary: Camel-Mongodb3: Add support for Change Streams feature Key: CAMEL-12481 URL: https://issues.apache.org/jira/browse/CAMEL-12481 Project: Camel Issue Type: New Feature Components: camel-mongodb3 Reporter: Andrea Cosentino https://docs.mongodb.com/manual/changeStreams/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12480) HttpOperationFailedException exposes password when using basic auth with user:password@host notation
Pascal Schumacher created CAMEL-12480: - Summary: HttpOperationFailedException exposes password when using basic auth with user:password@host notation Key: CAMEL-12480 URL: https://issues.apache.org/jira/browse/CAMEL-12480 Project: Camel Issue Type: Bug Components: camel-http-common Affects Versions: 2.21.0 Reporter: Pascal Schumacher Simplified route: {code} from(inUri) .toD("http4://user:password@host:port/path"); {code} When a HttpOperationFailedException occurs the message contains the unmasked password e.g. "HTTP operation failed invoking http://user:password@host:port/path ..." I guess Camel should mask the password. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-11186) Upgrade dropwizard metrics
[ https://issues.apache.org/jira/browse/CAMEL-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11186. - Resolution: Fixed Ah yeah lets resolve this > Upgrade dropwizard metrics > -- > > Key: CAMEL-11186 > URL: https://issues.apache.org/jira/browse/CAMEL-11186 > Project: Camel > Issue Type: Task > Components: camel-metrics >Reporter: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > There is a newer 3.2.x release and we are on 3.1.x. But it failed an test in > the spring boot integration tests. So we need to find out why. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-11186) Upgrade dropwizard metrics
[ https://issues.apache.org/jira/browse/CAMEL-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462293#comment-16462293 ] Pascal Schumacher commented on CAMEL-11186: --- Current master uses 3.2.6, so I guess this can be closed? > Upgrade dropwizard metrics > -- > > Key: CAMEL-11186 > URL: https://issues.apache.org/jira/browse/CAMEL-11186 > Project: Camel > Issue Type: Task > Components: camel-metrics >Reporter: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > There is a newer 3.2.x release and we are on 3.1.x. But it failed an test in > the spring boot integration tests. So we need to find out why. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462272#comment-16462272 ] ASF GitHub Bot commented on CAMEL-12383: onderson commented on a change in pull request #2315: CAMEL-12383 - changes regarding SB 2.0 upgrade URL: https://github.com/apache/camel/pull/2315#discussion_r185761264 ## File path: archetypes/camel-archetype-spring-boot/src/main/resources/archetype-resources/src/main/resources/application.properties ## @@ -35,7 +35,7 @@ timer.period = 2000 management.endpoints.web.exposure.include=info,health,camelroutes # all access to actuator endpoints without security -management.security.enabled = false +#management.security.enabled = false #is no longer customizable with SB 2.0 Review comment: considering support of former versions i just kept them commented. but i guess by 2.22.x we will drop and not dually support SB 1.X. so you are right. i will remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Bennet Schulz >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462268#comment-16462268 ] ASF GitHub Bot commented on CAMEL-12383: davsclaus commented on a change in pull request #2315: CAMEL-12383 - changes regarding SB 2.0 upgrade URL: https://github.com/apache/camel/pull/2315#discussion_r185760234 ## File path: archetypes/camel-archetype-spring-boot/src/main/resources/archetype-resources/src/main/resources/application.properties ## @@ -35,7 +35,7 @@ timer.period = 2000 management.endpoints.web.exposure.include=info,health,camelroutes # all access to actuator endpoints without security -management.security.enabled = false +#management.security.enabled = false #is no longer customizable with SB 2.0 Review comment: Should we maybe just delete all of this as its not possible with SB2 like this way? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Bennet Schulz >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462264#comment-16462264 ] ASF GitHub Bot commented on CAMEL-12383: onderson opened a new pull request #2315: CAMEL-12383 - changes regarding SB 2.0 upgrade URL: https://github.com/apache/camel/pull/2315 I guess there is no more remaining changes required considering SB 2 upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Bennet Schulz >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12383) Spring Boot 2 - Migrate application.properties to new names
[ https://issues.apache.org/jira/browse/CAMEL-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462265#comment-16462265 ] ASF GitHub Bot commented on CAMEL-12383: GitHub user onderson opened a pull request: https://github.com/apache/camel/pull/2315 CAMEL-12383 - changes regarding SB 2.0 upgrade I guess there is no more remaining changes required considering SB 2 upgrade. You can merge this pull request into a Git repository by running: $ git pull https://github.com/onderson/camel CAMEL-12383 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2315.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2315 commit c43790765b9dee4932d860c6ca3cefcbe96b51b7 Author: SezginDate: 2018-05-03T10:44:29Z CAMEL-12383 - changes regarding SB 2.0 upgrade > Spring Boot 2 - Migrate application.properties to new names > --- > > Key: CAMEL-12383 > URL: https://issues.apache.org/jira/browse/CAMEL-12383 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Bennet Schulz >Priority: Major > Fix For: 2.22.0 > > > Some of the properties in the application.properties | yaml file has new > names. We should migrate to use the newer names. > https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12478) camel-telegram - Allow use of custom keyboard
[ https://issues.apache.org/jira/browse/CAMEL-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-12478: Summary: camel-telegram - Allow use of custom keyboard (was: Allow use of custom keyboard) > camel-telegram - Allow use of custom keyboard > - > > Key: CAMEL-12478 > URL: https://issues.apache.org/jira/browse/CAMEL-12478 > Project: Camel > Issue Type: New Feature > Components: camel-telegram >Reporter: Willian Antunes >Priority: Major > Labels: features > Attachments: SNAG-0180.jpg > > > The component as we have nowadays does not support configuration of custom > keyboard, it only makes use of the standard one. > The method [sendMessage|https://core.telegram.org/bots/api#sendmessage] has > the field _reply_markup_ which allow the use of > [ReplyKeyboardMarkup|https://core.telegram.org/bots/api#replykeyboardmarkup] > to customize the standard keyboard. > Acceptance Criteria: > * Send message with custom keyboard to interact with the bot using its > buttons. > * Disable custom keyboard when is required during chat conversation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12442) rest-dsl - Rest producer should use RestConfiguration
[ https://issues.apache.org/jira/browse/CAMEL-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-12442. - Resolution: Fixed Assignee: Claus Ibsen Thanks for the PRs > rest-dsl - Rest producer should use RestConfiguration > - > > Key: CAMEL-12442 > URL: https://issues.apache.org/jira/browse/CAMEL-12442 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > The RestConfiguration have additional configuration for component level, > endpoint level which you may want to allow to configure for the rest-dsl > producer side. > Currently this is only supported on the consumer side. > To introduce this, requires an API change in the RestProducerFactory method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12442) rest-dsl - Rest producer should use RestConfiguration
[ https://issues.apache.org/jira/browse/CAMEL-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462064#comment-16462064 ] ASF GitHub Bot commented on CAMEL-12442: Github user davsclaus closed the pull request at: https://github.com/apache/camel/pull/2314 > rest-dsl - Rest producer should use RestConfiguration > - > > Key: CAMEL-12442 > URL: https://issues.apache.org/jira/browse/CAMEL-12442 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > The RestConfiguration have additional configuration for component level, > endpoint level which you may want to allow to configure for the rest-dsl > producer side. > Currently this is only supported on the consumer side. > To introduce this, requires an API change in the RestProducerFactory method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12442) rest-dsl - Rest producer should use RestConfiguration
[ https://issues.apache.org/jira/browse/CAMEL-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462063#comment-16462063 ] ASF GitHub Bot commented on CAMEL-12442: davsclaus closed pull request #2314: CAMEL-12442:rest-dsl - Rest producer should use RestConfiguration URL: https://github.com/apache/camel/pull/2314 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/components/camel-http/src/main/java/org/apache/camel/component/http/HttpComponent.java b/components/camel-http/src/main/java/org/apache/camel/component/http/HttpComponent.java index d0e93e2765f..39107cf4c44 100644 --- a/components/camel-http/src/main/java/org/apache/camel/component/http/HttpComponent.java +++ b/components/camel-http/src/main/java/org/apache/camel/component/http/HttpComponent.java @@ -312,6 +312,26 @@ public Producer createProducer(CamelContext camelContext, String host, if (!ObjectHelper.isEmpty(uriTemplate)) { url += "/" + uriTemplate; } + +RestConfiguration config = configuration; +if (config == null) { +config = camelContext.getRestConfiguration("http", true); +} + +Mapmap = new HashMap<>(); +// build query string, and append any endpoint configuration properties +if (config.getComponent() == null || config.getComponent().equals("http")) { +// setup endpoint options +if (config.getEndpointProperties() != null && !config.getEndpointProperties().isEmpty()) { +map.putAll(config.getEndpointProperties()); +} +} + +// get the endpoint +String query = URISupport.createQueryString(map); +if (!query.isEmpty()) { +url = url + "?" + query; +} HttpEndpoint endpoint = camelContext.getEndpoint(url, HttpEndpoint.class); if (parameters != null && !parameters.isEmpty()) { diff --git a/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java b/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java index 95bcb66041f..7444681a946 100644 --- a/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java +++ b/components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpComponent.java @@ -433,7 +433,26 @@ public Producer createProducer(CamelContext camelContext, String host, if (!ObjectHelper.isEmpty(uriTemplate)) { url += "/" + uriTemplate; } + +RestConfiguration config = configuration; +if (config == null) { +config = camelContext.getRestConfiguration("http4", true); +} +Map map = new HashMap<>(); +// build query string, and append any endpoint configuration properties +if (config.getComponent() == null || config.getComponent().equals("http4")) { +// setup endpoint options +if (config.getEndpointProperties() != null && !config.getEndpointProperties().isEmpty()) { +map.putAll(config.getEndpointProperties()); +} +} + +// get the endpoint +String query = URISupport.createQueryString(map); +if (!query.isEmpty()) { +url = url + "?" + query; +} HttpEndpoint endpoint = camelContext.getEndpoint(url, HttpEndpoint.class); if (parameters != null && !parameters.isEmpty()) { setProperties(camelContext, endpoint, parameters); diff --git a/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java b/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java index 28db0ab073d..bcac2518b14 100644 --- a/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java +++ b/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java @@ -430,6 +430,26 @@ public Producer createProducer(CamelContext camelContext, String host, if (!ObjectHelper.isEmpty(uriTemplate)) { url += "/" + uriTemplate; } + +RestConfiguration config = configuration; +if (config == null) { +config = camelContext.getRestConfiguration("netty4-http", true); +} + +Map map = new HashMap<>(); +// build query string, and append any endpoint configuration properties +if (config.getComponent() == null || config.getComponent().equals("netty4-http")) { +// setup endpoint options +
[jira] [Commented] (CAMEL-11257) Provide AS2 component to support Business Data Interchange Using HTTP
[ https://issues.apache.org/jira/browse/CAMEL-11257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462008#comment-16462008 ] ASF GitHub Bot commented on CAMEL-11257: oscerd commented on issue #2310: [CAMEL-11257] Fixed multipart parsing logic and updated tests URL: https://github.com/apache/camel/pull/2310#issuecomment-386203909 @punkhorn I'm unable to reproduce locally too. I added the first skeleton of the documentation here: https://github.com/apache/camel/blob/master/components/camel-as2/camel-as2-component/src/main/docs/as2-component.adoc You can start adding information and examples.. The endpoint options and component options are generated automatically on each build if something has changed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide AS2 component to support Business Data Interchange Using HTTP > - > > Key: CAMEL-11257 > URL: https://issues.apache.org/jira/browse/CAMEL-11257 > Project: Camel > Issue Type: New Feature >Affects Versions: 2.19.1 >Reporter: William Collins >Assignee: William Collins >Priority: Major > Fix For: 2.22.0 > > > AS2 Camel component should provide MIME-Based Secure Peer-to-Peer Business > Data Interchange Using HTTP as per RFC4120 -- This message was sent by Atlassian JIRA (v7.6.3#76005)