[jira] [Updated] (CAMEL-13045) Camel-Slack: The verifier must be able to validate webhook and token at the same time

2019-01-09 Thread Andrea Cosentino (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-13045:
-
Fix Version/s: 2.23.1
   2.24.0

> Camel-Slack: The verifier must be able to validate webhook and token at the 
> same time
> -
>
> Key: CAMEL-13045
> URL: https://issues.apache.org/jira/browse/CAMEL-13045
> Project: Camel
>  Issue Type: Bug
>  Components: camel-slack
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 3.0.0, 2.24.0, 2.23.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13045) Camel-Slack: The verifier must be able to validate webhook and token at the same time

2019-01-09 Thread Andrea Cosentino (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-13045.
--
Resolution: Fixed

> Camel-Slack: The verifier must be able to validate webhook and token at the 
> same time
> -
>
> Key: CAMEL-13045
> URL: https://issues.apache.org/jira/browse/CAMEL-13045
> Project: Camel
>  Issue Type: Bug
>  Components: camel-slack
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 3.0.0, 2.24.0, 2.23.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13045) Camel-Slack: The verifier must be able to validate webhook and token at the same time

2019-01-09 Thread Andrea Cosentino (JIRA)
Andrea Cosentino created CAMEL-13045:


 Summary: Camel-Slack: The verifier must be able to validate 
webhook and token at the same time
 Key: CAMEL-13045
 URL: https://issues.apache.org/jira/browse/CAMEL-13045
 Project: Camel
  Issue Type: Bug
  Components: camel-slack
Reporter: Andrea Cosentino
Assignee: Andrea Cosentino
 Fix For: 3.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (CAMEL-13026) camel-csv - Header written out on each message when marshalling

2019-01-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13026?focusedWorklogId=183315&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183315
 ]

ASF GitHub Bot logged work on CAMEL-13026:
--

Author: ASF GitHub Bot
Created on: 09/Jan/19 21:11
Start Date: 09/Jan/19 21:11
Worklog Time Spent: 10m 
  Work Description: ribeaud commented on pull request #2705: [CAMEL-13026] 
Add 'CsvMarshallerFactory' and corresponding tests
URL: https://github.com/apache/camel/pull/2705
 
 
   Hi @onderson. Here we are... Cheers,
   christian
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 183315)
Time Spent: 20m  (was: 10m)

> camel-csv - Header written out on each message when marshalling
> ---
>
> Key: CAMEL-13026
> URL: https://issues.apache.org/jira/browse/CAMEL-13026
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-csv
>Reporter: Christian Ribeaud
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When *CSV* marshalling, the header is written out on each message.
> Additionally, {{CsvMarshaller}} is so opaque, making it difficult for 
> customization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (CAMEL-13026) camel-csv - Header written out on each message when marshalling

2019-01-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13026?focusedWorklogId=183266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183266
 ]

ASF GitHub Bot logged work on CAMEL-13026:
--

Author: ASF GitHub Bot
Created on: 09/Jan/19 19:06
Start Date: 09/Jan/19 19:06
Worklog Time Spent: 10m 
  Work Description: ribeaud commented on pull request #2683: CAMEL-13026 - 
Header written out on each message when marshalling
URL: https://github.com/apache/camel/pull/2683
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 183266)
Time Spent: 10m
Remaining Estimate: 0h

> camel-csv - Header written out on each message when marshalling
> ---
>
> Key: CAMEL-13026
> URL: https://issues.apache.org/jira/browse/CAMEL-13026
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-csv
>Reporter: Christian Ribeaud
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When *CSV* marshalling, the header is written out on each message.
> Additionally, {{CsvMarshaller}} is so opaque, making it difficult for 
> customization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13044) Camel-AWS MQ: it is not possible to set Broker "Public accessibility" parameter using createBroker command

2019-01-09 Thread Andrea Cosentino (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738546#comment-16738546
 ] 

Andrea Cosentino commented on CAMEL-13044:
--

I'll try to fix this tomorrow. If you want a PR is welcome.

> Camel-AWS MQ: it is not possible to set Broker "Public accessibility" 
> parameter using createBroker command
> --
>
> Key: CAMEL-13044
> URL: https://issues.apache.org/jira/browse/CAMEL-13044
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.21.2, 2.23.0
>Reporter: Andrey Poltavtsev
>Assignee: Andrea Cosentino
>Priority: Major
>
> For now all MQ instances are created with "public accessibility" = false 
> using "createBroker" command. As result, created AWS Broker instance is not 
> accessible outside AWS environment. And there is no way to change it 
> (corresponding parameter in not propagated to AWS MQ client).
> It is necessary to add propagation of "publiclyAccessible" parameter to 
> "createBroker" operation:
> ...
> request.withPubliclyAccessible(publiclyAccessible);
> ...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CAMEL-13044) Camel-AWS MQ: it is not possible to set Broker "Public accessibility" parameter using createBroker command

2019-01-09 Thread Andrea Cosentino (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-13044:


Assignee: Andrea Cosentino

> Camel-AWS MQ: it is not possible to set Broker "Public accessibility" 
> parameter using createBroker command
> --
>
> Key: CAMEL-13044
> URL: https://issues.apache.org/jira/browse/CAMEL-13044
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.21.2, 2.23.0
>Reporter: Andrey Poltavtsev
>Assignee: Andrea Cosentino
>Priority: Major
>
> For now all MQ instances are created with "public accessibility" = false 
> using "createBroker" command. As result, created AWS Broker instance is not 
> accessible outside AWS environment. And there is no way to change it 
> (corresponding parameter in not propagated to AWS MQ client).
> It is necessary to add propagation of "publiclyAccessible" parameter to 
> "createBroker" operation:
> ...
> request.withPubliclyAccessible(publiclyAccessible);
> ...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-13044) Camel-AWS MQ: it is not possible to set Broker "Public accessibility" parameter using createBroker command

2019-01-09 Thread Andrey Poltavtsev (JIRA)
Andrey Poltavtsev created CAMEL-13044:
-

 Summary: Camel-AWS MQ: it is not possible to set Broker "Public 
accessibility" parameter using createBroker command
 Key: CAMEL-13044
 URL: https://issues.apache.org/jira/browse/CAMEL-13044
 Project: Camel
  Issue Type: Bug
  Components: camel-aws
Affects Versions: 2.23.0, 2.21.2
Reporter: Andrey Poltavtsev


For now all MQ instances are created with "public accessibility" = false using 
"createBroker" command. As result, created AWS Broker instance is not 
accessible outside AWS environment. And there is no way to change it 
(corresponding parameter in not propagated to AWS MQ client).

It is necessary to add propagation of "publiclyAccessible" parameter to 
"createBroker" operation:

...

request.withPubliclyAccessible(publiclyAccessible);

...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-13012) camel-olingo4 - AbstractFutureCallback generates NPE when response is a 401

2019-01-09 Thread Dmitry Volodin (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin updated CAMEL-13012:
---
Fix Version/s: 2.23.1
   2.24.0
   3.0.0
   2.22.3

> camel-olingo4 - AbstractFutureCallback generates NPE when response is a 401
> ---
>
> Key: CAMEL-13012
> URL: https://issues.apache.org/jira/browse/CAMEL-13012
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0, 2.22.2, 2.23.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
> Fix For: 2.22.3, 3.0.0, 2.24.0, 2.23.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The class 
> [AbstractFutureCallback|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/AbstractFutureCallback.java]
>  throws a NullPointerException when the server is secured with basic 
> authentication and the camel client fails to provide the correct credentials.
>  # Implement an odata server secured with basic authentication;
>  # Crate a camel route to access the odata server but do not specify the 
> correct authentication credentials;
>  # While fetching the Edm 
> [object|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java#L166]
>  from the endpoint proxy, an http client request is made using the provided 
> parameters and of course fails with a 401 error.
>  # The response is processed by 
> [AbstractFutureCallback|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/AbstractFutureCallback.java#L60]
>  but _responseContentType_ is null hence the NPE.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work started] (CAMEL-13012) camel-olingo4 - AbstractFutureCallback generates NPE when response is a 401

2019-01-09 Thread Dmitry Volodin (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on CAMEL-13012 started by Dmitry Volodin.
--
> camel-olingo4 - AbstractFutureCallback generates NPE when response is a 401
> ---
>
> Key: CAMEL-13012
> URL: https://issues.apache.org/jira/browse/CAMEL-13012
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0, 2.22.2, 2.23.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The class 
> [AbstractFutureCallback|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/AbstractFutureCallback.java]
>  throws a NullPointerException when the server is secured with basic 
> authentication and the camel client fails to provide the correct credentials.
>  # Implement an odata server secured with basic authentication;
>  # Crate a camel route to access the odata server but do not specify the 
> correct authentication credentials;
>  # While fetching the Edm 
> [object|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java#L166]
>  from the endpoint proxy, an http client request is made using the provided 
> parameters and of course fails with a 401 error.
>  # The response is processed by 
> [AbstractFutureCallback|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/AbstractFutureCallback.java#L60]
>  but _responseContentType_ is null hence the NPE.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (CAMEL-13012) camel-olingo4 - AbstractFutureCallback generates NPE when response is a 401

2019-01-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13012?focusedWorklogId=183060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183060
 ]

ASF GitHub Bot logged work on CAMEL-13012:
--

Author: ASF GitHub Bot
Created on: 09/Jan/19 13:13
Start Date: 09/Jan/19 13:13
Worklog Time Spent: 10m 
  Work Description: dmvolod commented on pull request #2702: CAMEL-13012: 
AbstractFutureCallback generates NPE when response is a 401
URL: https://github.com/apache/camel/pull/2702
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 183060)
Time Spent: 10m
Remaining Estimate: 0h

> camel-olingo4 - AbstractFutureCallback generates NPE when response is a 401
> ---
>
> Key: CAMEL-13012
> URL: https://issues.apache.org/jira/browse/CAMEL-13012
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.21.0, 2.22.2, 2.23.0
>Reporter: Paul Richardson
>Assignee: Dmitry Volodin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The class 
> [AbstractFutureCallback|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/AbstractFutureCallback.java]
>  throws a NullPointerException when the server is secured with basic 
> authentication and the camel client fails to provide the correct credentials.
>  # Implement an odata server secured with basic authentication;
>  # Crate a camel route to access the odata server but do not specify the 
> correct authentication credentials;
>  # While fetching the Edm 
> [object|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-component/src/main/java/org/apache/camel/component/olingo4/Olingo4Endpoint.java#L166]
>  from the endpoint proxy, an http client request is made using the provided 
> parameters and of course fails with a 401 error.
>  # The response is processed by 
> [AbstractFutureCallback|https://github.com/apache/camel/blob/master/components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/AbstractFutureCallback.java#L60]
>  but _responseContentType_ is null hence the NPE.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13003) RabbitMQ - Publisher confirms kills performance

2019-01-09 Thread Andrea Cosentino (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738144#comment-16738144
 ] 

Andrea Cosentino commented on CAMEL-13003:
--

I think it really worth a Pull Request. Sorry for the delay.

> RabbitMQ - Publisher confirms kills performance
> ---
>
> Key: CAMEL-13003
> URL: https://issues.apache.org/jira/browse/CAMEL-13003
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-rabbitmq
>Affects Versions: 2.23.0
>Reporter: Peter Billen
>Priority: Major
>
> Hi Camelers,
> Disclaimer: I'm fairly new to Camel, so please bear with me.
> I would like to discuss [https://github.com/apache/camel/pull/717] and 
> possibly propose an improvement.
> In the PR mentioned above, support for publisher confirms has been 
> implemented. The related documentation can be found on 
> [https://www.rabbitmq.com/confirms.html#publisher-confirms.]
> My thoughts is that the current implementation does not perform well. 
> Basically, it has a throughput of one message at a time. I'll try to explain.
>  * On 
> [https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java#L178,]
>  an exchange is retrieved. This contains a payload to be sent to the RabbitMQ 
> broker. The exchanges are retrieved one by one.
>  * On 
> [https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java#L288,]
>  we start with the publication to the broker.
>  * On 
> [https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQMessagePublisher.java#L130,]
>  the RabbitMQ API `channel.basicPublish()` is used to publish the payload.
>  * Assuming that publisher confirmation is enabled, we come in 
> [https://github.com/apache/camel/blob/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQMessagePublisher.java#L145.]
>  Here, we call the RabbitMQ API `channel.waitForConfirmsOrDie()`. This is a 
> blocking call. It waits until the broker has confirmed that the publication 
> has been correctly processed and enqueued. Since we just published one single 
> message, we await the confirmation of that one single message.
> I believe this means that our throughput is limited to one message at a time. 
> For each message sent to RabbitMQ, we have to await the confirmation.
> I believe it would be better to avoid using `channel.waitForConfirmsOrDie()` 
> and implement a `ConfirmListener` ourselves. See 
> [https://github.com/rabbitmq/rabbitmq-java-client/blob/master/src/main/java/com/rabbitmq/client/ConfirmListener.java.]
>  This way, we can continue publications of subsequent messages, while we 
> receive ACK's or NACK's of earlier publications.
> An implementation gotcha is the fact that upon broker restart/disconnection 
> the callback `ConfirmListener.nack()` will not be automatically called by the 
> RabbitMQ, as the RabbitMQ API does not keep track of the in-flight messages. 
> (In case you are wondering, `channel.waitForConfirmsOrDie()` is implemented 
> by counting the responses.) In other words, we will have to assume a NACK for 
> all in-flight messages when the connection was closed. This also means that 
> we have to keep track of all in-flight messages, together with the 
> corresponding `AsyncCallback`, at our end.
> We also might want to limit the number of in-flight messages between the 
> component and the broker.
> What do you think?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CAMEL-13033) Memory leak in ReactiveHelper class

2019-01-09 Thread Andrea Cosentino (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-13033:


Assignee: Guillaume Nodet

> Memory leak in ReactiveHelper class
> ---
>
> Key: CAMEL-13033
> URL: https://issues.apache.org/jira/browse/CAMEL-13033
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 3.0.0
>Reporter: fvaleri
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: Screenshot 2018-12-28 at 7.18.11 PM.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I was doing a performance test using the Splitter EIP and after reaching good 
> results with 2.23.0 release I tried the same test with 3.0.0-SNAPHOST 
> discovering a memory leak located in the ReactiveHelper class (back 
> LinkedList). It's at the routine engine level and a OOM error should be 
> triggered with every load test, but I can share my test if it's needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13033) Memory leak in ReactiveHelper class

2019-01-09 Thread Andrea Cosentino (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-13033.
--
Resolution: Fixed

> Memory leak in ReactiveHelper class
> ---
>
> Key: CAMEL-13033
> URL: https://issues.apache.org/jira/browse/CAMEL-13033
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 3.0.0
>Reporter: fvaleri
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: Screenshot 2018-12-28 at 7.18.11 PM.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I was doing a performance test using the Splitter EIP and after reaching good 
> results with 2.23.0 release I tried the same test with 3.0.0-SNAPHOST 
> discovering a memory leak located in the ReactiveHelper class (back 
> LinkedList). It's at the routine engine level and a OOM error should be 
> triggered with every load test, but I can share my test if it's needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13039) Deprecate/Remove Camel-YQL

2019-01-09 Thread Andrea Cosentino (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-13039.
--
Resolution: Fixed

> Deprecate/Remove Camel-YQL
> --
>
> Key: CAMEL-13039
> URL: https://issues.apache.org/jira/browse/CAMEL-13039
> Project: Camel
>  Issue Type: Task
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 3.0.0, 2.24.0
>
>
> I think we need to remove completely the component since it cannot work now.
> Because YQL is retired.
> [https://developer.yahoo.com/yql/]
> [~davsclaus] what do you think?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-13031) camel-core - test failure: org.apache.camel.impl.FileWatcherReloadStrategyTest.

2019-01-09 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738045#comment-16738045
 ] 

Claus Ibsen commented on CAMEL-13031:
-

It may be that the file system is slow to trigger events of file changes as it 
uses that new file watcher api from the jdk.

Try to use a higher timeout than the 20 sec in the tests to see if they run 
faster.


> camel-core - test failure: 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.
> ---
>
> Key: CAMEL-13031
> URL: https://issues.apache.org/jira/browse/CAMEL-13031
> Project: Camel
>  Issue Type: Test
>  Components: tests
>Reporter: Önder Sezgin
>Priority: Minor
>
> [INFO] Running org.apache.camel.impl.FileWatcherReloadStrategyTest
> [ERROR] Tests run: 7, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 
> 123.022 s <<< FAILURE! - in 
> org.apache.camel.impl.FileWatcherReloadStrategyTest
> [ERROR] 
> testUpdateXmlRoute(org.apache.camel.impl.FileWatcherReloadStrategyTest) Time 
> elapsed: 20.529 s <<< ERROR!
> org.awaitility.core.ConditionTimeoutException: Assertion condition defined as 
> a lambda expression in org.apache.camel.impl.FileWatcherReloadStrategyTest 
> expected:<1> but was:<0> within 20 seconds.
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.testUpdateXmlRoute(FileWatcherReloadStrategyTest.java:166)
> Caused by: java.lang.AssertionError: expected:<1> but was:<0>
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.lambda$testUpdateXmlRoute$1(FileWatcherReloadStrategyTest.java:166)
> [ERROR] testAddNewRoute(org.apache.camel.impl.FileWatcherReloadStrategyTest) 
> Time elapsed: 20.058 s <<< ERROR!
> org.awaitility.core.ConditionTimeoutException: Assertion condition defined as 
> a lambda expression in org.apache.camel.impl.FileWatcherReloadStrategyTest 
> expected:<1> but was:<0> within 20 seconds.
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.testAddNewRoute(FileWatcherReloadStrategyTest.java:71)
> Caused by: java.lang.AssertionError: expected:<1> but was:<0>
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.lambda$testAddNewRoute$0(FileWatcherReloadStrategyTest.java:71)
> [ERROR] 
> testUpdateXmlRoute(org.apache.camel.impl.FileWatcherReloadStrategyTest) Time 
> elapsed: 20.078 s <<< ERROR!
> org.awaitility.core.ConditionTimeoutException: Assertion condition defined as 
> a lambda expression in org.apache.camel.impl.FileWatcherReloadStrategyTest 
> expected:<1> but was:<0> within 20 seconds.
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.testUpdateXmlRoute(FileWatcherReloadStrategyTest.java:166)
> Caused by: java.lang.AssertionError: expected:<1> but was:<0>
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.lambda$testUpdateXmlRoute$1(FileWatcherReloadStrategyTest.java:166)
> [ERROR] testAddNewRoute(org.apache.camel.impl.FileWatcherReloadStrategyTest) 
> Time elapsed: 20.067 s <<< ERROR!
> org.awaitility.core.ConditionTimeoutException: Assertion condition defined as 
> a lambda expression in org.apache.camel.impl.FileWatcherReloadStrategyTest 
> expected:<1> but was:<0> within 20 seconds.
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.testAddNewRoute(FileWatcherReloadStrategyTest.java:71)
> Caused by: java.lang.AssertionError: expected:<1> but was:<0>
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.lambda$testAddNewRoute$0(FileWatcherReloadStrategyTest.java:71)
> [ERROR] 
> testUpdateXmlRoute(org.apache.camel.impl.FileWatcherReloadStrategyTest) Time 
> elapsed: 20.095 s <<< ERROR!
> org.awaitility.core.ConditionTimeoutException: Assertion condition defined as 
> a lambda expression in org.apache.camel.impl.FileWatcherReloadStrategyTest 
> expected:<1> but was:<0> within 20 seconds.
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.testUpdateXmlRoute(FileWatcherReloadStrategyTest.java:166)
> Caused by: java.lang.AssertionError: expected:<1> but was:<0>
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.lambda$testUpdateXmlRoute$1(FileWatcherReloadStrategyTest.java:166)
> [ERROR] testAddNewRoute(org.apache.camel.impl.FileWatcherReloadStrategyTest) 
> Time elapsed: 20.026 s <<< ERROR!
> org.awaitility.core.ConditionTimeoutException: Assertion condition defined as 
> a lambda expression in org.apache.camel.impl.FileWatcherReloadStrategyTest 
> expected:<1> but was:<0> within 20 seconds.
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.testAddNewRoute(FileWatcherReloadStrategyTest.java:71)
> Caused by: java.lang.AssertionError: expected:<1> but was:<0>
>  at 
> org.apache.camel.impl.FileWatcherReloadStrategyTest.lambda$testAddNewRoute$0(FileWatcherReloadStrategyTest.java:71)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] 
> org.apac

[jira] [Work logged] (CAMEL-13042) camel-core - File producer should by default not allow writing files to directories outside its starting directory

2019-01-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13042?focusedWorklogId=182961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-182961
 ]

ASF GitHub Bot logged work on CAMEL-13042:
--

Author: ASF GitHub Bot
Created on: 09/Jan/19 09:37
Start Date: 09/Jan/19 09:37
Worklog Time Spent: 10m 
  Work Description: davsclaus commented on pull request #2700: CAMEL-13042: 
File producer should by default only allow to write file…
URL: https://github.com/apache/camel/pull/2700
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 182961)
Time Spent: 20m  (was: 10m)

> camel-core - File producer should by default not allow writing files to 
> directories outside its starting directory
> --
>
> Key: CAMEL-13042
> URL: https://issues.apache.org/jira/browse/CAMEL-13042
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.23.0
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 3.0.0, 2.24.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For example
> {code:xml}
> 
> 
> ../../${file:name}
> 
> 
> {code}
> Can write the file outside the target/results folder. We should not allow 
> this by default to be more security friendly. 
> We should add a new option (maybe name it jailStartingDirectory or 
> allowWriteOutsideStartingDirectory) or some better name



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12605) Enhance the AS2 Component to send and receive encrypted AS2 messages

2019-01-09 Thread Andrea Cosentino (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738028#comment-16738028
 ] 

Andrea Cosentino commented on CAMEL-12605:
--

I just merged the last PR from William and I don't have test failures

> Enhance the AS2 Component to send and receive encrypted AS2 messages
> 
>
> Key: CAMEL-12605
> URL: https://issues.apache.org/jira/browse/CAMEL-12605
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.23.0
>Reporter: William Collins
>Assignee: William Collins
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Enhance the AS2 Component to support encrypted AS2 messages per RFC4130



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12605) Enhance the AS2 Component to send and receive encrypted AS2 messages

2019-01-09 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738025#comment-16738025
 ] 

Claus Ibsen commented on CAMEL-12605:
-

On master I have some unit test failures in camel-as2. I wonder if others have 
the same?

> Enhance the AS2 Component to send and receive encrypted AS2 messages
> 
>
> Key: CAMEL-12605
> URL: https://issues.apache.org/jira/browse/CAMEL-12605
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.23.0
>Reporter: William Collins
>Assignee: William Collins
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Enhance the AS2 Component to support encrypted AS2 messages per RFC4130



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-13042) camel-core - File producer should by default not allow writing files to directories outside its starting directory

2019-01-09 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-13042.
-
Resolution: Fixed

> camel-core - File producer should by default not allow writing files to 
> directories outside its starting directory
> --
>
> Key: CAMEL-13042
> URL: https://issues.apache.org/jira/browse/CAMEL-13042
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.23.0
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 3.0.0, 2.24.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For example
> {code:xml}
> 
> 
> ../../${file:name}
> 
> 
> {code}
> Can write the file outside the target/results folder. We should not allow 
> this by default to be more security friendly. 
> We should add a new option (maybe name it jailStartingDirectory or 
> allowWriteOutsideStartingDirectory) or some better name



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (CAMEL-12605) Enhance the AS2 Component to send and receive encrypted AS2 messages

2019-01-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12605?focusedWorklogId=182932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-182932
 ]

ASF GitHub Bot logged work on CAMEL-12605:
--

Author: ASF GitHub Bot
Created on: 09/Jan/19 08:21
Start Date: 09/Jan/19 08:21
Worklog Time Spent: 10m 
  Work Description: oscerd commented on pull request #2701: [CAMEL-12605] 
Modified AS2 consumer to return exception messages in r…
URL: https://github.com/apache/camel/pull/2701
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 182932)
Time Spent: 50m  (was: 40m)

> Enhance the AS2 Component to send and receive encrypted AS2 messages
> 
>
> Key: CAMEL-12605
> URL: https://issues.apache.org/jira/browse/CAMEL-12605
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.23.0
>Reporter: William Collins
>Assignee: William Collins
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Enhance the AS2 Component to support encrypted AS2 messages per RFC4130



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)