[jira] [Work logged] (CAMEL-14229) STOMP headers are missing in the Exchange

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14229?focusedWorklogId=351493=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351493
 ]

ASF GitHub Bot logged work on CAMEL-14229:
--

Author: ASF GitHub Bot
Created on: 30/Nov/19 05:36
Start Date: 30/Nov/19 05:36
Worklog Time Spent: 10m 
  Work Description: onlybytes commented on pull request #3369: CAMEL-14229: 
STOMP headers are missing in the Exchange
URL: https://github.com/apache/camel/pull/3369
 
 
   The response from the Exchange contains only Body. The STOMP headers are 
missing in the response.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 351493)
Remaining Estimate: 0h
Time Spent: 10m

> STOMP headers are missing in the Exchange
> -
>
> Key: CAMEL-14229
> URL: https://issues.apache.org/jira/browse/CAMEL-14229
> Project: Camel
>  Issue Type: Bug
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: Future
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The response from the Exchange contains only Body. The headers are missing in 
> the response.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (CAMEL-14234) Project generated with camel-archetype-spring-boot cannot be built

2019-11-29 Thread Jan Bednar (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Bednar resolved CAMEL-14234.

Fix Version/s: 3.1.0
   3.0.1
   Resolution: Fixed

> Project generated with camel-archetype-spring-boot cannot be built
> --
>
> Key: CAMEL-14234
> URL: https://issues.apache.org/jira/browse/CAMEL-14234
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jan Bednar
>Assignee: Jan Bednar
>Priority: Major
> Fix For: 3.0.1, 3.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As a workaround until new patch release users needs to replace in their 
> pom.xml
> {code:java}
> 
> 
>   org.apache.camel
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}
> with
> {code:java}
> 
> 
>   org.apache.camel.springboot
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (CAMEL-14234) Project generated with camel-archetype-spring-boot cannot be built

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14234?focusedWorklogId=351470=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351470
 ]

ASF GitHub Bot logged work on CAMEL-14234:
--

Author: ASF GitHub Bot
Created on: 30/Nov/19 00:48
Start Date: 30/Nov/19 00:48
Worklog Time Spent: 10m 
  Work Description: bedlaj commented on pull request #3368: CAMEL-14234: 
Fix BOM group id for camel-archetype-spring-boot
URL: https://github.com/apache/camel/pull/3368
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 351470)
Time Spent: 20m  (was: 10m)

> Project generated with camel-archetype-spring-boot cannot be built
> --
>
> Key: CAMEL-14234
> URL: https://issues.apache.org/jira/browse/CAMEL-14234
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jan Bednar
>Assignee: Jan Bednar
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As a workaround until new patch release users needs to replace in their 
> pom.xml
> {code:java}
> 
> 
>   org.apache.camel
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}
> with
> {code:java}
> 
> 
>   org.apache.camel.springboot
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (CAMEL-14234) Project generated with camel-archetype-spring-boot cannot be built

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14234?focusedWorklogId=351462=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351462
 ]

ASF GitHub Bot logged work on CAMEL-14234:
--

Author: ASF GitHub Bot
Created on: 30/Nov/19 00:26
Start Date: 30/Nov/19 00:26
Worklog Time Spent: 10m 
  Work Description: bedlaj commented on pull request #3368: CAMEL-14234: 
Fix BOM group id for camel-archetype-spring-boot
URL: https://github.com/apache/camel/pull/3368
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 351462)
Remaining Estimate: 0h
Time Spent: 10m

> Project generated with camel-archetype-spring-boot cannot be built
> --
>
> Key: CAMEL-14234
> URL: https://issues.apache.org/jira/browse/CAMEL-14234
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jan Bednar
>Assignee: Jan Bednar
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> As a workaround until new patch release users needs to replace in their 
> pom.xml
> {code:java}
> 
> 
>   org.apache.camel
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}
> with
> {code:java}
> 
> 
>   org.apache.camel.springboot
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CAMEL-14234) Project generated with camel-archetype-spring-boot cannot be built

2019-11-29 Thread Jan Bednar (Jira)
Jan Bednar created CAMEL-14234:
--

 Summary: Project generated with camel-archetype-spring-boot cannot 
be built
 Key: CAMEL-14234
 URL: https://issues.apache.org/jira/browse/CAMEL-14234
 Project: Camel
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Jan Bednar
Assignee: Jan Bednar


As a workaround until new patch release users needs to replace in their pom.xml
{code:java}


  org.apache.camel
  camel-spring-boot-dependencies
  3.0.0
  pom
  import

{code}
with
{code:java}


  org.apache.camel.springboot
  camel-spring-boot-dependencies
  3.0.0
  pom
  import

{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work started] (CAMEL-14234) Project generated with camel-archetype-spring-boot cannot be built

2019-11-29 Thread Jan Bednar (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on CAMEL-14234 started by Jan Bednar.
--
> Project generated with camel-archetype-spring-boot cannot be built
> --
>
> Key: CAMEL-14234
> URL: https://issues.apache.org/jira/browse/CAMEL-14234
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Jan Bednar
>Assignee: Jan Bednar
>Priority: Major
>
> As a workaround until new patch release users needs to replace in their 
> pom.xml
> {code:java}
> 
> 
>   org.apache.camel
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}
> with
> {code:java}
> 
> 
>   org.apache.camel.springboot
>   camel-spring-boot-dependencies
>   3.0.0
>   pom
>   import
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14233) camel-kafka - topic overriding not possible when using aggregation

2019-11-29 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CAMEL-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafał Gała updated CAMEL-14233:
---
Description: 
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
boolean allowHeader = true;

// when we do not bridge then detect if we try to send back to ourselves
// which we most likely do not want to do
if (headerTopic != null && 
endpoint.getConfiguration().isCircularTopicDetection()) {
Endpoint from = exchange.getFromEndpoint();
if (from instanceof KafkaEndpoint) {
String fromTopic = ((KafkaEndpoint) 
from).getConfiguration().getTopic();
allowHeader = !headerTopic.equals(fromTopic);
if (!allowHeader) {
log.debug("Circular topic detected from message header."
+ " Cannot send to same topic as the message comes 
from: {}"
+ ". Will use endpoint configured topic: {}", from, 
topic);
}
}
}
if (allowHeader && headerTopic != null) {
topic = headerTopic;
}
}

if (topic == null) {
// if topic property was not received from configuration or header 
parameters take it from the remaining URI
topic = URISupport.extractRemainderPath(new 
URI(endpoint.getEndpointUri()), true);
}

...

Object msg = exchange.getIn().getBody();

// is the message body a list or something that contains multiple values
Iterator iterator = null;
if (msg instanceof Iterable) {
iterator = ((Iterable) msg).iterator();
} else if (msg instanceof Iterator) {
iterator = (Iterator) msg;
}
if (iterator != null) {
final Iterator msgList = iterator;
{code}
The msgTopic variable below should be set from KafkaConstants.TOPIC header of 
next exchange from collection
{code}
final String msgTopic = topic;

return new Iterator() {
@Override
public boolean hasNext() {
return msgList.hasNext();
}

@Override
public ProducerRecord next() {

// must convert each entry of the iterator into the value 
according to the serializer
Object next = msgList.next();
Object value = tryConvertToSerializedType(exchange, next, 
endpoint.getConfiguration().getSerializerClass());

if (hasPartitionKey && hasMessageKey) {
return new ProducerRecord(msgTopic, partitionKey, null, 
key, value, propagatedHeaders);
} else if (hasMessageKey) {
return new ProducerRecord(msgTopic, null, null, key, value, 
propagatedHeaders);
} else {
return new ProducerRecord(msgTopic, null, null, null, 
value, propagatedHeaders);
}
}

@Override
public void remove() {
msgList.remove();
}
};
}

...
}

{code}
 

  was:
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
 

[jira] [Updated] (CAMEL-14233) camel-kafka - topic overriding not possible when using aggregation

2019-11-29 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CAMEL-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafał Gała updated CAMEL-14233:
---
Description: 
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
boolean allowHeader = true;

// when we do not bridge then detect if we try to send back to ourselves
// which we most likely do not want to do
if (headerTopic != null && 
endpoint.getConfiguration().isCircularTopicDetection()) {
Endpoint from = exchange.getFromEndpoint();
if (from instanceof KafkaEndpoint) {
String fromTopic = ((KafkaEndpoint) 
from).getConfiguration().getTopic();
allowHeader = !headerTopic.equals(fromTopic);
if (!allowHeader) {
log.debug("Circular topic detected from message header."
+ " Cannot send to same topic as the message comes 
from: {}"
+ ". Will use endpoint configured topic: {}", from, 
topic);
}
}
}
if (allowHeader && headerTopic != null) {
topic = headerTopic;
}
}

if (topic == null) {
// if topic property was not received from configuration or header 
parameters take it from the remaining URI
topic = URISupport.extractRemainderPath(new 
URI(endpoint.getEndpointUri()), true);
}

...

Object msg = exchange.getIn().getBody();

// is the message body a list or something that contains multiple values
Iterator iterator = null;
if (msg instanceof Iterable) {
iterator = ((Iterable) msg).iterator();
} else if (msg instanceof Iterator) {
iterator = (Iterator) msg;
}
if (iterator != null) {
final Iterator msgList = iterator;

final String msgTopic = topic;

return new Iterator() {
@Override
public boolean hasNext() {
return msgList.hasNext();
}

@Override
public ProducerRecord next() {

// must convert each entry of the iterator into the value 
according to the serializer
Object next = msgList.next();
Object value = tryConvertToSerializedType(exchange, next, 
endpoint.getConfiguration().getSerializerClass());

if (hasPartitionKey && hasMessageKey) {
return new ProducerRecord(msgTopic, partitionKey, null, 
key, value, propagatedHeaders);
} else if (hasMessageKey) {
return new ProducerRecord(msgTopic, null, null, key, value, 
propagatedHeaders);
} else {
return new ProducerRecord(msgTopic, null, null, null, 
value, propagatedHeaders);
}
}

@Override
public void remove() {
msgList.remove();
}
};
}

...
}

{code}
 

  was:
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
boolean allowHeader = true;

// when we do not bridge then detect if we try to send back to ourselves
 

[jira] [Updated] (CAMEL-14233) camel-kafka - topic overriding not possible when using aggregation

2019-11-29 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CAMEL-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafał Gała updated CAMEL-14233:
---
Description: 
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
boolean allowHeader = true;

// when we do not bridge then detect if we try to send back to ourselves
// which we most likely do not want to do
if (headerTopic != null && 
endpoint.getConfiguration().isCircularTopicDetection()) {
Endpoint from = exchange.getFromEndpoint();
if (from instanceof KafkaEndpoint) {
String fromTopic = ((KafkaEndpoint) 
from).getConfiguration().getTopic();
allowHeader = !headerTopic.equals(fromTopic);
if (!allowHeader) {
log.debug("Circular topic detected from message header."
+ " Cannot send to same topic as the message comes 
from: {}"
+ ". Will use endpoint configured topic: {}", from, 
topic);
}
}
}
if (allowHeader && headerTopic != null) {
topic = headerTopic;
}
}

if (topic == null) {
// if topic property was not received from configuration or header 
parameters take it from the remaining URI
topic = URISupport.extractRemainderPath(new 
URI(endpoint.getEndpointUri()), true);
}

...

Object msg = exchange.getIn().getBody();

// is the message body a list or something that contains multiple values
Iterator iterator = null;
if (msg instanceof Iterable) {
iterator = ((Iterable) msg).iterator();
} else if (msg instanceof Iterator) {
iterator = (Iterator) msg;
}
if (iterator != null) {
final Iterator msgList = iterator;

final String msgTopic = topic;

return new Iterator() {
@Override
public boolean hasNext() {
return msgList.hasNext();
}

@Override
public ProducerRecord next() {
{code}
Maybe this is a good place, to make 
{code{
// must convert each entry of the iterator into the value 
according to the serializer
Object next = msgList.next();
Object value = tryConvertToSerializedType(exchange, next, 
endpoint.getConfiguration().getSerializerClass());

if (hasPartitionKey && hasMessageKey) {
return new ProducerRecord(msgTopic, partitionKey, null, 
key, value, propagatedHeaders);
} else if (hasMessageKey) {
return new ProducerRecord(msgTopic, null, null, key, value, 
propagatedHeaders);
} else {
return new ProducerRecord(msgTopic, null, null, null, 
value, propagatedHeaders);
}
}

@Override
public void remove() {
msgList.remove();
}
};
}

...
}

{code}
 

  was:
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
boolean allowHeader = true;

// when we do not bridge 

[jira] [Updated] (CAMEL-14233) camel-kafka - topic overriding not possible when using aggregation

2019-11-29 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CAMEL-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafał Gała updated CAMEL-14233:
---
Description: 
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
boolean allowHeader = true;

// when we do not bridge then detect if we try to send back to ourselves
// which we most likely do not want to do
if (headerTopic != null && 
endpoint.getConfiguration().isCircularTopicDetection()) {
Endpoint from = exchange.getFromEndpoint();
if (from instanceof KafkaEndpoint) {
String fromTopic = ((KafkaEndpoint) 
from).getConfiguration().getTopic();
allowHeader = !headerTopic.equals(fromTopic);
if (!allowHeader) {
log.debug("Circular topic detected from message header."
+ " Cannot send to same topic as the message comes 
from: {}"
+ ". Will use endpoint configured topic: {}", from, 
topic);
}
}
}
if (allowHeader && headerTopic != null) {
topic = headerTopic;
}
}

if (topic == null) {
// if topic property was not received from configuration or header 
parameters take it from the remaining URI
topic = URISupport.extractRemainderPath(new 
URI(endpoint.getEndpointUri()), true);
}

...

Object msg = exchange.getIn().getBody();

// is the message body a list or something that contains multiple values
Iterator iterator = null;
if (msg instanceof Iterable) {
iterator = ((Iterable) msg).iterator();
} else if (msg instanceof Iterator) {
iterator = (Iterator) msg;
}
if (iterator != null) {
final Iterator msgList = iterator;

final String msgTopic = topic;

{code}
Here the topic should be taken from an aggregated Exchange KafkaConstants.TOPIC 
header (it may be different for each from the collection)
{code:java}
return new Iterator() {
@Override
public boolean hasNext() {
return msgList.hasNext();
}

@Override
public ProducerRecord next() {
{code}
Maybe this is a good place, to make 
{code{
// must convert each entry of the iterator into the value 
according to the serializer
Object next = msgList.next();
Object value = tryConvertToSerializedType(exchange, next, 
endpoint.getConfiguration().getSerializerClass());

if (hasPartitionKey && hasMessageKey) {
return new ProducerRecord(msgTopic, partitionKey, null, 
key, value, propagatedHeaders);
} else if (hasMessageKey) {
return new ProducerRecord(msgTopic, null, null, key, value, 
propagatedHeaders);
} else {
return new ProducerRecord(msgTopic, null, null, null, 
value, propagatedHeaders);
}
}

@Override
public void remove() {
msgList.remove();
}
};
}

...
}

{code}
 

  was:
When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {

[jira] [Created] (CAMEL-14233) camel-kafka - topic overriding not possible when using aggregation

2019-11-29 Thread Jira
Rafał Gała created CAMEL-14233:
--

 Summary: camel-kafka - topic overriding not possible when using 
aggregation
 Key: CAMEL-14233
 URL: https://issues.apache.org/jira/browse/CAMEL-14233
 Project: Camel
  Issue Type: Bug
  Components: camel-kafka
Affects Versions: 2.24.2
Reporter: Rafał Gała


When exchange aggregation is used, using GroupedExchangeAggregationStrategy for 
example:

 
{code:java}
from(..)
.process(some processor here that sets KafkaConstants.TOPIC header here)
.aggregate(new GroupedExchangeAggregationStrategy ())
.to(kafka:...)
{code}
it is not possible to override topic per exchange by using KafkaConstants.TOPIC 
header, because in *createRecord* of KafkaProducer class, the topic is chosen 
from header of aggregating Exchange which may not be set because it may have 
been set only on Exchanges that were aggregated. When creating ProducerRecord 
from Iterable, the topic should be chosen from header of each Exchange 
separately:
{code:java}
protected Iterator createRecorder(Exchange exchange) throws 
Exception {
String topic = endpoint.getConfiguration().getTopic();

if (!endpoint.getConfiguration().isBridgeEndpoint()) {
String headerTopic = exchange.getIn().getHeader(KafkaConstants.TOPIC, 
String.class);
boolean allowHeader = true;

// when we do not bridge then detect if we try to send back to ourselves
// which we most likely do not want to do
if (headerTopic != null && 
endpoint.getConfiguration().isCircularTopicDetection()) {
Endpoint from = exchange.getFromEndpoint();
if (from instanceof KafkaEndpoint) {
String fromTopic = ((KafkaEndpoint) 
from).getConfiguration().getTopic();
allowHeader = !headerTopic.equals(fromTopic);
if (!allowHeader) {
log.debug("Circular topic detected from message header."
+ " Cannot send to same topic as the message comes 
from: {}"
+ ". Will use endpoint configured topic: {}", from, 
topic);
}
}
}
if (allowHeader && headerTopic != null) {
topic = headerTopic;
}
}

if (topic == null) {
// if topic property was not received from configuration or header 
parameters take it from the remaining URI
topic = URISupport.extractRemainderPath(new 
URI(endpoint.getEndpointUri()), true);
}

...

Object msg = exchange.getIn().getBody();

// is the message body a list or something that contains multiple values
Iterator iterator = null;
if (msg instanceof Iterable) {
iterator = ((Iterable) msg).iterator();
} else if (msg instanceof Iterator) {
iterator = (Iterator) msg;
}
if (iterator != null) {
final Iterator msgList = iterator;

final String msgTopic = topic;

{code}
Here the topic should be taken from an aggregated Exchange KafkaConstants.TOPIC 
header (it may be different for each from the collection)
{code:java}
return new Iterator() {
@Override
public boolean hasNext() {
return msgList.hasNext();
}

@Override
public ProducerRecord next() {
// must convert each entry of the iterator into the value 
according to the serializer
Object next = msgList.next();
Object value = tryConvertToSerializedType(exchange, next, 
endpoint.getConfiguration().getSerializerClass());

if (hasPartitionKey && hasMessageKey) {
return new ProducerRecord(msgTopic, partitionKey, null, 
key, value, propagatedHeaders);
} else if (hasMessageKey) {
return new ProducerRecord(msgTopic, null, null, key, value, 
propagatedHeaders);
} else {
return new ProducerRecord(msgTopic, null, null, null, 
value, propagatedHeaders);
}
}

@Override
public void remove() {
msgList.remove();
}
};
}

...
}

{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (CAMEL-14231) Discussion forum link in Get in touch page is broken

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi resolved CAMEL-14231.
--
  Assignee: Omar Al-Safi
Resolution: Fixed

> Discussion forum link in Get in touch page is broken
> 
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>  Components: website
>Reporter: Heiko Braun
>Assignee: Omar Al-Safi
>Priority: Minor
>
> The [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads] link here 
> https://camel.apache.org/manual/latest/contributing.html#getting-in-touch is 
> broken



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14231) Discussion forum link in Get in touch page is broken

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi updated CAMEL-14231:
-
Priority: Minor  (was: Major)

> Discussion forum link in Get in touch page is broken
> 
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>  Components: website
>Reporter: Heiko Braun
>Priority: Minor
>
> The [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads] link here 
> https://camel.apache.org/manual/latest/contributing.html#getting-in-touch is 
> broken



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14231) Discussion forum link in Get in touch page is broken

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi updated CAMEL-14231:
-
Component/s: website

> Discussion forum link in Get in touch page is broken
> 
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>  Components: website
>Reporter: Heiko Braun
>Priority: Major
>
> The [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads] link here 
> https://camel.apache.org/manual/latest/contributing.html#getting-in-touch is 
> broken



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (CAMEL-14231) Discussion forum link in Get in touch page is broken

2019-11-29 Thread Omar Al-Safi (Jira)


[ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985151#comment-16985151
 ] 

Omar Al-Safi commented on CAMEL-14231:
--

Thanks, updated the issue description 

> Discussion forum link in Get in touch page is broken
> 
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>  Components: website
>Reporter: Heiko Braun
>Priority: Minor
>
> The [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads] link here 
> https://camel.apache.org/manual/latest/contributing.html#getting-in-touch is 
> broken



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14231) Discussion forum link in Get in touch page is broken

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi updated CAMEL-14231:
-
Description: The [https://camel.apache.org/discussion-forums.html 
|https://camel.apache.org/discussion-forums.htmlLeads] link here 
https://camel.apache.org/manual/latest/contributing.html#getting-in-touch is 
broken  (was: [https://camel.apache.org/discussion-forums.html 
|https://camel.apache.org/discussion-forums.htmlLeads])

> Discussion forum link in Get in touch page is broken
> 
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>Reporter: Heiko Braun
>Priority: Major
>
> The [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads] link here 
> https://camel.apache.org/manual/latest/contributing.html#getting-in-touch is 
> broken



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14231) Discussion forum link in Get in touch page is broken

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi updated CAMEL-14231:
-
Summary: Discussion forum link in Get in touch page is broken  (was: 
Discussion forum link 404)

> Discussion forum link in Get in touch page is broken
> 
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>Reporter: Heiko Braun
>Priority: Major
>
> [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (CAMEL-14231) Discussion forum link 404

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi reopened CAMEL-14231:
--

> Discussion forum link 404
> -
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>Reporter: Heiko Braun
>Priority: Major
>
> [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (CAMEL-14231) Discussion forum link 404

2019-11-29 Thread Heiko Braun (Jira)


[ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985136#comment-16985136
 ] 

Heiko Braun commented on CAMEL-14231:
-

Its taken from here: 
https://camel.apache.org/manual/latest/contributing.html#getting-in-touch

> Discussion forum link 404
> -
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>Reporter: Heiko Braun
>Priority: Major
>
> [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14232) camel-ftp: the sftp serverAliveInterval option documentation is not clear

2019-11-29 Thread Alex Dettinger (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Dettinger updated CAMEL-14232:
---
Summary: camel-ftp: the sftp serverAliveInterval option documentation is 
not clear  (was: camel-ftp: the sftpServerAlive option documentation is not 
clear)

> camel-ftp: the sftp serverAliveInterval option documentation is not clear
> -
>
> Key: CAMEL-14232
> URL: https://issues.apache.org/jira/browse/CAMEL-14232
> Project: Camel
>  Issue Type: Bug
>Reporter: Alex Dettinger
>Priority: Minor
>
> The documentation for the serverAliveInterval option is not clear:
> + What is the default value ? zero ?
> + The unit looks to be milliseconds and could be precised in the 
> documentation, link in the 
> [code|https://github.com/apache/camel/blob/master/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L294].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14232) camel-ftp: the sftpServerAlive option documentation is not clear

2019-11-29 Thread Alex Dettinger (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Dettinger updated CAMEL-14232:
---
Description: 
The documentation for the serverAliveInterval option is not clear:
+ What is the default value ? zero ?
+ The unit looks to be milliseconds and could be precised in the documentation, 
link in the 
[code|https://github.com/apache/camel/blob/master/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L294].


  was:
The documentation for the serverAliveInterval option is not clear:
+ What is the default value ? zero ?
+ The unit looks to be milliseconds and could be precised in the documentation, 
link in the 
[code|https://github.com/apache/camel/blob/master/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L294
].



> camel-ftp: the sftpServerAlive option documentation is not clear
> 
>
> Key: CAMEL-14232
> URL: https://issues.apache.org/jira/browse/CAMEL-14232
> Project: Camel
>  Issue Type: Bug
>Reporter: Alex Dettinger
>Priority: Major
>
> The documentation for the serverAliveInterval option is not clear:
> + What is the default value ? zero ?
> + The unit looks to be milliseconds and could be precised in the 
> documentation, link in the 
> [code|https://github.com/apache/camel/blob/master/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L294].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14232) camel-ftp: the sftpServerAlive option documentation is not clear

2019-11-29 Thread Alex Dettinger (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Dettinger updated CAMEL-14232:
---
Priority: Minor  (was: Major)

> camel-ftp: the sftpServerAlive option documentation is not clear
> 
>
> Key: CAMEL-14232
> URL: https://issues.apache.org/jira/browse/CAMEL-14232
> Project: Camel
>  Issue Type: Bug
>Reporter: Alex Dettinger
>Priority: Minor
>
> The documentation for the serverAliveInterval option is not clear:
> + What is the default value ? zero ?
> + The unit looks to be milliseconds and could be precised in the 
> documentation, link in the 
> [code|https://github.com/apache/camel/blob/master/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L294].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CAMEL-14232) camel-ftp: the sftpServerAlive option documentation is not clear

2019-11-29 Thread Alex Dettinger (Jira)
Alex Dettinger created CAMEL-14232:
--

 Summary: camel-ftp: the sftpServerAlive option documentation is 
not clear
 Key: CAMEL-14232
 URL: https://issues.apache.org/jira/browse/CAMEL-14232
 Project: Camel
  Issue Type: Bug
Reporter: Alex Dettinger


The documentation for the serverAliveInterval option is not clear:
+ What is the default value ? zero ?
+ The unit looks to be milliseconds and could be precised in the documentation, 
link in the 
[code|https://github.com/apache/camel/blob/master/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L294
].




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (CAMEL-14231) Discussion forum link 404

2019-11-29 Thread Omar Al-Safi (Jira)


[ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985110#comment-16985110
 ] 

Omar Al-Safi commented on CAMEL-14231:
--

Sorry forgot to ask, but from where did you get to this page?

> Discussion forum link 404
> -
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>Reporter: Heiko Braun
>Priority: Major
>
> [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (CAMEL-14231) Discussion forum link 404

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi closed CAMEL-14231.

Resolution: Invalid

> Discussion forum link 404
> -
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>Reporter: Heiko Braun
>Priority: Major
>
> [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (CAMEL-14231) Discussion forum link 404

2019-11-29 Thread Omar Al-Safi (Jira)


[ 
https://issues.apache.org/jira/browse/CAMEL-14231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985107#comment-16985107
 ] 

Omar Al-Safi commented on CAMEL-14231:
--

we have this page now: https://camel.apache.org/community/support/ and this 
page https://camel.apache.org/manual/latest/mailing-lists.html 

> Discussion forum link 404
> -
>
> Key: CAMEL-14231
> URL: https://issues.apache.org/jira/browse/CAMEL-14231
> Project: Camel
>  Issue Type: Bug
>Reporter: Heiko Braun
>Priority: Major
>
> [https://camel.apache.org/discussion-forums.html 
> |https://camel.apache.org/discussion-forums.htmlLeads]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CAMEL-14231) Discussion forum link 404

2019-11-29 Thread Heiko Braun (Jira)
Heiko Braun created CAMEL-14231:
---

 Summary: Discussion forum link 404
 Key: CAMEL-14231
 URL: https://issues.apache.org/jira/browse/CAMEL-14231
 Project: Camel
  Issue Type: Bug
Reporter: Heiko Braun


[https://camel.apache.org/discussion-forums.html 
|https://camel.apache.org/discussion-forums.htmlLeads]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (CAMEL-14230) Disable RC4 and MD5 TLS ciphersuites by default

2019-11-29 Thread Colm O hEigeartaigh (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh resolved CAMEL-14230.
-
Resolution: Fixed

> Disable RC4 and MD5 TLS ciphersuites by default
> ---
>
> Key: CAMEL-14230
> URL: https://issues.apache.org/jira/browse/CAMEL-14230
> Project: Camel
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
>Priority: Major
> Fix For: 3.0.1
>
>
> This task is to disable RC4 and MD5 TLS ciphersuites by default. They're 
> likely disabled by the JVM anyway so this should have no real impact.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CAMEL-14230) Disable RC4 and MD5 TLS ciphersuites by default

2019-11-29 Thread Colm O hEigeartaigh (Jira)
Colm O hEigeartaigh created CAMEL-14230:
---

 Summary: Disable RC4 and MD5 TLS ciphersuites by default
 Key: CAMEL-14230
 URL: https://issues.apache.org/jira/browse/CAMEL-14230
 Project: Camel
  Issue Type: Improvement
Reporter: Colm O hEigeartaigh
Assignee: Colm O hEigeartaigh
 Fix For: 3.0.1


This task is to disable RC4 and MD5 TLS ciphersuites by default. They're likely 
disabled by the JVM anyway so this should have no real impact.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (CAMEL-14221) Stomp Component has no option to set version

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi resolved CAMEL-14221.
--
Resolution: Fixed

> Stomp Component has no option to set version
> 
>
> Key: CAMEL-14221
> URL: https://issues.apache.org/jira/browse/CAMEL-14221
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: 3.0.1, 3.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
> class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
> method for version, the Camel-Stomp Component has not exposed that option to 
> be set by the users.
> Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
> changes to allow users to set version.
>  
> STOMP 1.2 has been available for years and most of the message brokers 
> support STOMP 1.2. In such scenarios it becomes a necessary feature for the 
> camel-stomp to include the support for STOMP 1.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14221) Stomp Component has no option to set version

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi updated CAMEL-14221:
-
Fix Version/s: 3.0.1

> Stomp Component has no option to set version
> 
>
> Key: CAMEL-14221
> URL: https://issues.apache.org/jira/browse/CAMEL-14221
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: 3.0.1, 3.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
> class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
> method for version, the Camel-Stomp Component has not exposed that option to 
> be set by the users.
> Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
> changes to allow users to set version.
>  
> STOMP 1.2 has been available for years and most of the message brokers 
> support STOMP 1.2. In such scenarios it becomes a necessary feature for the 
> camel-stomp to include the support for STOMP 1.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14221) Stomp Component has no option to set version

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi updated CAMEL-14221:
-
Fix Version/s: (was: Future)
   3.1.0

> Stomp Component has no option to set version
> 
>
> Key: CAMEL-14221
> URL: https://issues.apache.org/jira/browse/CAMEL-14221
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: 3.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
> class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
> method for version, the Camel-Stomp Component has not exposed that option to 
> be set by the users.
> Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
> changes to allow users to set version.
>  
> STOMP 1.2 has been available for years and most of the message brokers 
> support STOMP 1.2. In such scenarios it becomes a necessary feature for the 
> camel-stomp to include the support for STOMP 1.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (CAMEL-14221) Stomp Component has no option to set version

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14221?focusedWorklogId=351332=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351332
 ]

ASF GitHub Bot logged work on CAMEL-14221:
--

Author: ASF GitHub Bot
Created on: 29/Nov/19 12:39
Start Date: 29/Nov/19 12:39
Worklog Time Spent: 10m 
  Work Description: omarsmak commented on pull request #3367: CAMEL-14221: 
Stomp Component has no option to set version
URL: https://github.com/apache/camel/pull/3367
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 351332)
Time Spent: 20m  (was: 10m)

> Stomp Component has no option to set version
> 
>
> Key: CAMEL-14221
> URL: https://issues.apache.org/jira/browse/CAMEL-14221
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: Future
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
> class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
> method for version, the Camel-Stomp Component has not exposed that option to 
> be set by the users.
> Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
> changes to allow users to set version.
>  
> STOMP 1.2 has been available for years and most of the message brokers 
> support STOMP 1.2. In such scenarios it becomes a necessary feature for the 
> camel-stomp to include the support for STOMP 1.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CAMEL-14229) STOMP headers are missing in the Exchange

2019-11-29 Thread Mahesh (Jira)
Mahesh created CAMEL-14229:
--

 Summary: STOMP headers are missing in the Exchange
 Key: CAMEL-14229
 URL: https://issues.apache.org/jira/browse/CAMEL-14229
 Project: Camel
  Issue Type: Bug
  Components: camel-stomp
Affects Versions: 3.0.0.RC3
Reporter: Mahesh
 Fix For: Future


The response from the Exchange contains only Body. The headers are missing in 
the response.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (CAMEL-14221) Stomp Component has no option to set version

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14221?focusedWorklogId=351284=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351284
 ]

ASF GitHub Bot logged work on CAMEL-14221:
--

Author: ASF GitHub Bot
Created on: 29/Nov/19 10:22
Start Date: 29/Nov/19 10:22
Worklog Time Spent: 10m 
  Work Description: onlybytes commented on pull request #3367: CAMEL-14221: 
Stomp Component has no option to set version
URL: https://github.com/apache/camel/pull/3367
 
 
   The STOMP version is hardcoded in the org.fusesource.stomp.client.Stomp 
class. Though the org.fusesource.stomp.client.Stomp class has setter method for 
version, the Camel-Stomp Component has not exposed that option to be set by the 
users.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 351284)
Remaining Estimate: 0h
Time Spent: 10m

> Stomp Component has no option to set version
> 
>
> Key: CAMEL-14221
> URL: https://issues.apache.org/jira/browse/CAMEL-14221
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: Future
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
> class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
> method for version, the Camel-Stomp Component has not exposed that option to 
> be set by the users.
> Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
> changes to allow users to set version.
>  
> STOMP 1.2 has been available for years and most of the message brokers 
> support STOMP 1.2. In such scenarios it becomes a necessary feature for the 
> camel-stomp to include the support for STOMP 1.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (CAMEL-14228) camel-netty - Let netty calculate the default worker count

2019-11-29 Thread Claus Ibsen (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-14228.
-
Resolution: Fixed

> camel-netty - Let netty calculate the default worker count
> --
>
> Key: CAMEL-14228
> URL: https://issues.apache.org/jira/browse/CAMEL-14228
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.24.2, 3.0.0
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 3.0.1, 3.1.0
>
>
> We set it as cpu core x 2, which was what netty used to do. But lets just use 
> 0 and let netty figure it out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14228) camel-netty - Let netty calculate the default worker count

2019-11-29 Thread Claus Ibsen (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-14228:

Fix Version/s: (was: 2.25.0)

> camel-netty - Let netty calculate the default worker count
> --
>
> Key: CAMEL-14228
> URL: https://issues.apache.org/jira/browse/CAMEL-14228
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.24.2, 3.0.0
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 3.0.1, 3.1.0
>
>
> We set it as cpu core x 2, which was what netty used to do. But lets just use 
> 0 and let netty figure it out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CAMEL-14228) camel-netty - Let netty calculate the default worker count

2019-11-29 Thread Claus Ibsen (Jira)
Claus Ibsen created CAMEL-14228:
---

 Summary: camel-netty - Let netty calculate the default worker count
 Key: CAMEL-14228
 URL: https://issues.apache.org/jira/browse/CAMEL-14228
 Project: Camel
  Issue Type: Improvement
Affects Versions: 3.0.0, 2.24.2
Reporter: Claus Ibsen
Assignee: Claus Ibsen
 Fix For: 3.0.1, 2.25.0, 3.1.0


We set it as cpu core x 2, which was what netty used to do. But lets just use 0 
and let netty figure it out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (CAMEL-14223) EndpointBuilderFactory is not updated whenever `:camel-package:generate-endpoint-dsl` is executed

2019-11-29 Thread Omar Al-Safi (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Omar Al-Safi resolved CAMEL-14223.
--
Resolution: Fixed

> EndpointBuilderFactory is not updated whenever 
> `:camel-package:generate-endpoint-dsl` is executed
> -
>
> Key: CAMEL-14223
> URL: https://issues.apache.org/jira/browse/CAMEL-14223
> Project: Camel
>  Issue Type: Bug
>  Components: tooling
>Affects Versions: 3.0.0
>Reporter: Omar Al-Safi
>Assignee: Omar Al-Safi
>Priority: Minor
> Fix For: 3.0.1, 3.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> While I was trying out the endpoint DSL, I noticed whenever {{mvn clean 
> install :camel-package:generate-endpoint-dsl}} maven command is executed 
> under specific component, the corresponding DSL factory will be be created as 
> expected, however {{EndpointBuilderFactory}} interface won't be updated to 
> include the new generated DSL factory which as result, the generated factory 
> won't be exposed whenever camel-endpointdsl is imported



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14221) Stomp Component has no option to set version

2019-11-29 Thread Mahesh (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahesh updated CAMEL-14221:
---
Description: 
The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter method 
for version, the Camel-Stomp Component has not exposed that option to be set by 
the users.

Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
changes to allow users to set version.

 

STOMP 1.2 has been available for years and most of the message brokers support 
STOMP 1.2. In such scenarios it becomes a necessary feature for the camel-stomp 
to include the support for STOMP 1.2

  was:
The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
methods for version and custom headers, the Camel-Stomp Component has not 
exposed those options to be set by the users.

Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
changes to allow users to set version and custom headers.

 

STOMP 1.2 has been available for years and most of the message brokers support 
STOMP 1.2. In such scenarios it becomes a necessary feature for the camel-stomp 
to include the support for STOMP 1.2


> Stomp Component has no option to set version
> 
>
> Key: CAMEL-14221
> URL: https://issues.apache.org/jira/browse/CAMEL-14221
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: Future
>
>
> The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
> class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
> method for version, the Camel-Stomp Component has not exposed that option to 
> be set by the users.
> Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
> changes to allow users to set version.
>  
> STOMP 1.2 has been available for years and most of the message brokers 
> support STOMP 1.2. In such scenarios it becomes a necessary feature for the 
> camel-stomp to include the support for STOMP 1.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14221) Stomp Component has no option to set version

2019-11-29 Thread Mahesh (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahesh updated CAMEL-14221:
---
Summary: Stomp Component has no option to set version  (was: Stomp 
Component has no option to set version and custom headers)

> Stomp Component has no option to set version
> 
>
> Key: CAMEL-14221
> URL: https://issues.apache.org/jira/browse/CAMEL-14221
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-stomp
>Affects Versions: 3.0.0.RC3
>Reporter: Mahesh
>Priority: Major
> Fix For: Future
>
>
> The STOMP version is hardcoded in the {{org.fusesource.stomp.client.Stomp}} 
> class. Though the {{org.fusesource.stomp.client.Stomp}} class has setter 
> methods for version and custom headers, the Camel-Stomp Component has not 
> exposed those options to be set by the users.
> Looks like {{StompEndpoint}} and {{StompConfiguration}} classes would need 
> changes to allow users to set version and custom headers.
>  
> STOMP 1.2 has been available for years and most of the message brokers 
> support STOMP 1.2. In such scenarios it becomes a necessary feature for the 
> camel-stomp to include the support for STOMP 1.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (CAMEL-14223) EndpointBuilderFactory is not updated whenever `:camel-package:generate-endpoint-dsl` is executed

2019-11-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14223?focusedWorklogId=351265=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351265
 ]

ASF GitHub Bot logged work on CAMEL-14223:
--

Author: ASF GitHub Bot
Created on: 29/Nov/19 08:52
Start Date: 29/Nov/19 08:52
Worklog Time Spent: 10m 
  Work Description: omarsmak commented on pull request #3366: CAMEL-14223: 
Fix EndpointBuilderFactory is not updated whenever the maven build is executed
URL: https://github.com/apache/camel/pull/3366
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 351265)
Time Spent: 20m  (was: 10m)

> EndpointBuilderFactory is not updated whenever 
> `:camel-package:generate-endpoint-dsl` is executed
> -
>
> Key: CAMEL-14223
> URL: https://issues.apache.org/jira/browse/CAMEL-14223
> Project: Camel
>  Issue Type: Bug
>  Components: tooling
>Affects Versions: 3.0.0
>Reporter: Omar Al-Safi
>Assignee: Omar Al-Safi
>Priority: Minor
> Fix For: 3.0.1, 3.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> While I was trying out the endpoint DSL, I noticed whenever {{mvn clean 
> install :camel-package:generate-endpoint-dsl}} maven command is executed 
> under specific component, the corresponding DSL factory will be be created as 
> expected, however {{EndpointBuilderFactory}} interface won't be updated to 
> include the new generated DSL factory which as result, the generated factory 
> won't be exposed whenever camel-endpointdsl is imported



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14223) EndpointBuilderFactory is not updated whenever `:camel-package:generate-endpoint-dsl` is executed

2019-11-29 Thread Claus Ibsen (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-14223:

Fix Version/s: 3.0.1

> EndpointBuilderFactory is not updated whenever 
> `:camel-package:generate-endpoint-dsl` is executed
> -
>
> Key: CAMEL-14223
> URL: https://issues.apache.org/jira/browse/CAMEL-14223
> Project: Camel
>  Issue Type: Bug
>  Components: tooling
>Affects Versions: 3.0.0
>Reporter: Omar Al-Safi
>Assignee: Omar Al-Safi
>Priority: Minor
> Fix For: 3.0.1, 3.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> While I was trying out the endpoint DSL, I noticed whenever {{mvn clean 
> install :camel-package:generate-endpoint-dsl}} maven command is executed 
> under specific component, the corresponding DSL factory will be be created as 
> expected, however {{EndpointBuilderFactory}} interface won't be updated to 
> include the new generated DSL factory which as result, the generated factory 
> won't be exposed whenever camel-endpointdsl is imported



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CAMEL-14227) camel-rest-swagger - Add support for OpenApi 3.0 spec

2019-11-29 Thread Claus Ibsen (Jira)


 [ 
https://issues.apache.org/jira/browse/CAMEL-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-14227:

Fix Version/s: (was: 3.x)
   3.1.0

> camel-rest-swagger - Add support for OpenApi 3.0 spec
> -
>
> Key: CAMEL-14227
> URL: https://issues.apache.org/jira/browse/CAMEL-14227
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-swagger
>Affects Versions: 3.0.0
>Reporter: Freeman Yue Fang
>Assignee: Freeman Yue Fang
>Priority: Major
> Fix For: 3.1.0
>
>
> similarly as CAMEL-12619, but just the other way.
> We can add a new camel-rest-openapi component and use apicurio-data-module 
> which can support OpenApi 2 & 3 at the same time instead of using swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (CAMEL-13575) Use strings instead of boolean/integer/long in definition fields

2019-11-29 Thread Guillaume Nodet (Jira)


[ 
https://issues.apache.org/jira/browse/CAMEL-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984800#comment-16984800
 ] 

Guillaume Nodet commented on CAMEL-13575:
-

PR available at [https://github.com/apache/camel/pull/3365]

> Use strings instead of boolean/integer/long in definition fields
> 
>
> Key: CAMEL-13575
> URL: https://issues.apache.org/jira/browse/CAMEL-13575
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The main drawback of the current implementation is that placeholders can not 
> be used and the xml can't be validated.
> The drawback of using strings is that it will be less safe in the xml schema.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)