[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249266#comment-16249266 ] ASF GitHub Bot commented on CAMEL-11954: vrlgohel commented on issue #2088: CAMEL-11954: Renamed ha packages to cluster URL: https://github.com/apache/camel/pull/2088#issuecomment-343854980 Thanks Andrea! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > Attachments: CAMEL11954-Renamed-HA-packages-to-cluster.patch > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249185#comment-16249185 ] ASF GitHub Bot commented on CAMEL-11954: Github user oscerd closed the pull request at: https://github.com/apache/camel/pull/2088 > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > Attachments: CAMEL11954-Renamed-HA-packages-to-cluster.patch > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249183#comment-16249183 ] ASF GitHub Bot commented on CAMEL-11954: oscerd commented on issue #2088: CAMEL-11954: Renamed ha packages to cluster URL: https://github.com/apache/camel/pull/2088#issuecomment-343835438 The PR has been merged. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > Attachments: CAMEL11954-Renamed-HA-packages-to-cluster.patch > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247772#comment-16247772 ] ASF GitHub Bot commented on CAMEL-11954: vrlgohel commented on issue #2088: CAMEL-11954: Renamed ha packages to cluster URL: https://github.com/apache/camel/pull/2088#issuecomment-343528414 Guys, can anyone review the changes ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > Attachments: CAMEL11954-Renamed-HA-packages-to-cluster.patch > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245945#comment-16245945 ] ASF GitHub Bot commented on CAMEL-11954: vrlgohel opened a new pull request #2088: CAMEL-11954: Renamed ha packages to cluster URL: https://github.com/apache/camel/pull/2088 Issue: https://issues.apache.org/jira/browse/CAMEL-11954 Refactored the code to have 'cluster' instead of 'ha' packages. The components, spring-boot starters, camel examples, and the tests work fine. The branch is state is also fine :+1: Guys, can you let me know if any more changes are needed ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > Attachments: CAMEL11954-Renamed-HA-packages-to-cluster.patch > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245946#comment-16245946 ] ASF GitHub Bot commented on CAMEL-11954: GitHub user vrlgohel opened a pull request: https://github.com/apache/camel/pull/2088 CAMEL-11954: Renamed ha packages to cluster Issue: https://issues.apache.org/jira/browse/CAMEL-11954 Refactored the code to have 'cluster' instead of 'ha' packages. The components, spring-boot starters, camel examples, and the tests work fine. The branch is state is also fine :+1: Guys, can you let me know if any more changes are needed ? You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrlgohel/camel-1 CAMEL-11954 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2088.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2088 commit 3b22c5fcc0b51b5c7a244b4aa94db8d19a39b8a6 Author: Viral GohelDate: 2017-11-09T16:17:18Z CAMEL-11954: Renamed ha packages to cluster > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > Attachments: CAMEL11954-Renamed-HA-packages-to-cluster.patch > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245472#comment-16245472 ] ASF GitHub Bot commented on CAMEL-11954: Github user vrlgohel closed the pull request at: https://github.com/apache/camel/pull/2086 > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > Attachments: CAMEL11954-Renamed-HA-packages-to-cluster.patch > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242685#comment-16242685 ] ASF GitHub Bot commented on CAMEL-11954: onders86 commented on issue #2086: CAMEL-11954: Renamed HA packages to cluster URL: https://github.com/apache/camel/pull/2086#issuecomment-342591309 rebase and conflict resolution seems needed, since git gives warning already.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242361#comment-16242361 ] ASF GitHub Bot commented on CAMEL-11954: GitHub user vrlgohel opened a pull request: https://github.com/apache/camel/pull/2086 CAMEL-11954: Renamed HA packages to cluster Fix for issue: https://issues.apache.org/jira/browse/CAMEL-11954 Refactored 'ha' packages to cluster' in camel-core as well as other associated component. Changes to spring boot starter components. The tests and build of components work fine. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrlgohel/camel-1 CAMEL-11954 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2086 commit 22ff784565ee7d93685ca7dba78ed3ba32aa7448 Author: Viral GohelDate: 2017-11-06T16:26:16Z CAMEL-11954: Renamed HA packages to cluster > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242360#comment-16242360 ] ASF GitHub Bot commented on CAMEL-11954: vrlgohel opened a new pull request #2086: CAMEL-11954: Renamed HA packages to cluster URL: https://github.com/apache/camel/pull/2086 Fix for issue: https://issues.apache.org/jira/browse/CAMEL-11954 Refactored 'ha' packages to cluster' in camel-core as well as other associated component. Changes to spring boot starter components. The tests and build of components work fine. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235460#comment-16235460 ] Viral Gohel commented on CAMEL-11954: - Hi Luca, Thanks for your suggestions. I actually already modified the packages to 'clusterservices'. And yes, i will work on the other components to refactor this. > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel >Priority: Major > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235254#comment-16235254 ] Luca Burgazzoli commented on CAMEL-11954: - [~vrlgohel] clusterservices should be used only in jmx, for package the new name is cluster so org.apache.camel.ha --> org.apache.camel.custer and org.apache.camel.impl.ha --> org.apache.camel.impl.cluster please bear in mind that there are other 'ha' packages on component levels (i.e. camel-atomix, camel-consul, camel-zookeeper, camel-jgroups, camel-kubernetes and maybe others) and also in spring-boot starter packages. > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen >Assignee: Viral Gohel >Priority: Major > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225246#comment-16225246 ] Viral Gohel commented on CAMEL-11954: - I will take a look at this. Do we also rename the packages to say: org.apache.camel.ha to org.apache.camel.clusterservices and org.apache.camel.impl.ha to org.apache.camel.impl.clusterservices ? > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221994#comment-16221994 ] Luca Burgazzoli commented on CAMEL-11954: - Fine with me > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221965#comment-16221965 ] Claus Ibsen commented on CAMEL-11954: - Should we rename the source code ha package as well, I do like cluster more > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221955#comment-16221955 ] Claus Ibsen commented on CAMEL-11954: - Yeah they are better names. > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221923#comment-16221923 ] Luca Burgazzoli commented on CAMEL-11954: - I'd go with - routecontrollers - clusterservices > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221921#comment-16221921 ] Claus Ibsen commented on CAMEL-11954: - [~lb] any thoughts? Also we should rename routecontroller to routecontrollers so its like the others (with an ending s) And should ha -> cluster be -> clusters > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)