[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249637#comment-16249637 ] ASF GitHub Bot commented on CAMEL-11999: oscerd commented on issue #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087#issuecomment-343929732 I guess the message was for me. I already cherry picked and backported. Thanks @onders86 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > The Azure Storage Queue API may have changed unnoticed since the component > was incepted. > Currently it is broken in multiple places. > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249560#comment-16249560 ] ASF GitHub Bot commented on CAMEL-11999: onders86 commented on issue #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087#issuecomment-343921649 @davsclaus i guess i missed your message. I will cherry-pick. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > The Azure Storage Queue API may have changed unnoticed since the component > was incepted. > Currently it is broken in multiple places. > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247172#comment-16247172 ] ASF GitHub Bot commented on CAMEL-11999: oscerd closed pull request #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/components/camel-azure/pom.xml b/components/camel-azure/pom.xml index d8e94daca95..1e7c7aacdb1 100644 --- a/components/camel-azure/pom.xml +++ b/components/camel-azure/pom.xml @@ -62,6 +62,11 @@ camel-test-spring test + +org.slf4j +slf4j-log4j12 +test + diff --git a/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceComponent.java b/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceComponent.java index 42bd47df930..572989c6333 100644 --- a/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceComponent.java +++ b/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceComponent.java @@ -42,15 +42,20 @@ protected Endpoint createEndpoint(String uri, String remaining, Map2) { +if (parts == null || parts.length < 1) +throw new IllegalArgumentException("The account name must be specified."); + +QueueServiceOperations operation = configuration.getOperation(); +if (operation != null && operation != QueueServiceOperations.listQueues && parts.length < 2) +throw new IllegalArgumentException("The queue name must be specified."); + +if (parts.length > 2) throw new IllegalArgumentException("Only the account and queue names must be specified."); -} configuration.setAccountName(parts[0]); -configuration.setQueueName(parts[1]); + +if (parts.length > 1) +configuration.setQueueName(parts[1]); checkCredentials(configuration); diff --git a/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceConfiguration.java b/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceConfiguration.java index e85cd2c029f..699e013762c 100644 --- a/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceConfiguration.java +++ b/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceConfiguration.java @@ -16,11 +16,12 @@ */ package org.apache.camel.component.azure.queue; -import com.microsoft.azure.storage.queue.CloudQueue; import org.apache.camel.component.azure.common.AbstractConfiguration; import org.apache.camel.spi.UriParam; import org.apache.camel.spi.UriParams; +import com.microsoft.azure.storage.queue.CloudQueue; + @UriParams public class QueueServiceConfiguration extends AbstractConfiguration { diff --git a/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceUtil.java b/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceUtil.java index 6f094184cfd..9669dbe762c 100644 --- a/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceUtil.java +++ b/components/camel-azure/src/main/java/org/apache/camel/component/azure/queue/QueueServiceUtil.java @@ -31,19 +31,12 @@ private QueueServiceUtil() { } public static URI prepareStorageQueueUri(QueueServiceConfiguration cfg) { -return prepareStorageQueueUri(cfg, true); -} - -public static URI prepareStorageQueueUri(QueueServiceConfiguration cfg, boolean isForMessages) { StringBuilder uriBuilder = new StringBuilder(); uriBuilder.append("https://;) .append(cfg.getAccountName()) .append(QueueServiceConstants.SERVICE_URI_SEGMENT) -.append("/") -.append(cfg.getQueueName()); -if (isForMessages) { -uriBuilder.append("/messages"); -} +.append("/" + cfg.getQueueName()); + return URI.create(uriBuilder.toString()); } @@ -73,7 +66,9 @@ public static StorageCredentials getAccountCredentials(QueueServiceConfiguration public static void retrieveMessage(Exchange exchange,
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247173#comment-16247173 ] ASF GitHub Bot commented on CAMEL-11999: Github user oscerd closed the pull request at: https://github.com/apache/camel/pull/2087 > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > The Azure Storage Queue API may have changed unnoticed since the component > was incepted. > Currently it is broken in multiple places. > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247171#comment-16247171 ] ASF GitHub Bot commented on CAMEL-11999: oscerd commented on issue #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087#issuecomment-343404194 Thanks for the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > The Azure Storage Queue API may have changed unnoticed since the component > was incepted. > Currently it is broken in multiple places. > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247120#comment-16247120 ] ASF GitHub Bot commented on CAMEL-11999: davsclaus commented on issue #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087#issuecomment-343396880 Also seems like you need to fix checkstyle This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1 > > > The Azure Storage Queue API may have changed unnoticed since the component > was incepted. > Currently it is broken in multiple places. > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247117#comment-16247117 ] ASF GitHub Bot commented on CAMEL-11999: davsclaus commented on issue #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087#issuecomment-343395613 @onders86 +1 to backport This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1 > > > The Azure Storage Queue API may have changed unnoticed since the component > was incepted. > Currently it is broken in multiple places. > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247107#comment-16247107 ] ASF GitHub Bot commented on CAMEL-11999: oscerd commented on issue #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087#issuecomment-343392201 @davsclaus can we pull this one in 2.20.x before the 2.20.1 cut or do we have to wait? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1 > > > The Azure Storage Queue API may have changed unnoticed since the component > was incepted. > Currently it is broken in multiple places. > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245381#comment-16245381 ] ASF GitHub Bot commented on CAMEL-11999: tdiesler opened a new pull request #2087: [CAMEL-11999] Cannot create queue/message for Azure URL: https://github.com/apache/camel/pull/2087 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1 > > > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11999) Cannot create queue/message for Azure
[ https://issues.apache.org/jira/browse/CAMEL-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245382#comment-16245382 ] ASF GitHub Bot commented on CAMEL-11999: GitHub user tdiesler opened a pull request: https://github.com/apache/camel/pull/2087 [CAMEL-11999] Cannot create queue/message for Azure You can merge this pull request into a Git repository by running: $ git pull https://github.com/tdiesler/camel CAMEL-11999 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2087 commit 517be1c23e3b5a9c00182953357d921a34df6d2a Author: Thomas DieslerDate: 2017-11-09T05:55:27Z [CAMEL-11999] Cannot create queue/message for Azure > Cannot create queue/message for Azure > - > > Key: CAMEL-11999 > URL: https://issues.apache.org/jira/browse/CAMEL-11999 > Project: Camel > Issue Type: Bug > Components: camel-azure >Affects Versions: 2.20.0 >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1 > > > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/1819 -- This message was sent by Atlassian JIRA (v6.4.14#64029)