[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294259#comment-16294259 ] ASF GitHub Bot commented on CAMEL-12022: Github user davsclaus closed the pull request at: https://github.com/apache/camel/pull/2125 > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294257#comment-16294257 ] ASF GitHub Bot commented on CAMEL-12022: davsclaus commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-352275721 This has been merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294258#comment-16294258 ] ASF GitHub Bot commented on CAMEL-12022: davsclaus closed pull request #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/camel-core/src/main/docs/direct-component.adoc b/camel-core/src/main/docs/direct-component.adoc index 4c035b68196..6dea0bc8634 100644 --- a/camel-core/src/main/docs/direct-component.adoc +++ b/camel-core/src/main/docs/direct-component.adoc @@ -36,7 +36,7 @@ The Direct component supports 3 options which are listed below. [width="100%",cols="2,5,^1,2",options="header"] |=== | Name | Description | Default | Type -| *block* (producer) | If sending a message to a direct endpoint which has no active consumer then we can tell the producer to block and wait for the consumer to become active. | false | boolean +| *block* (producer) | If sending a message to a direct endpoint which has no active consumer then we can tell the producer to block and wait for the consumer to become active. | true | boolean | *timeout* (producer) | The timeout value to use if block is enabled. | 3 | long | *resolveProperty Placeholders* (advanced) | Whether the component should resolve property placeholders on itself when starting. Only properties which are of String type can use property placeholders. | true | boolean |=== @@ -70,7 +70,7 @@ with the following path and query parameters: | *bridgeErrorHandler* (consumer) | Allows for bridging the consumer to the Camel routing Error Handler which mean any exceptions occurred while the consumer is trying to pickup incoming messages or the likes will now be processed as a message and handled by the routing Error Handler. By default the consumer will use the org.apache.camel.spi.ExceptionHandler to deal with exceptions that will be logged at WARN/ERROR level and ignored. | false | boolean | *exceptionHandler* (consumer) | To let the consumer use a custom ExceptionHandler. Notice if the option bridgeErrorHandler is enabled then this options is not in use. By default the consumer will deal with exceptions that will be logged at WARN/ERROR level and ignored. | | ExceptionHandler | *exchangePattern* (consumer) | Sets the default exchange pattern when creating an exchange. | | ExchangePattern -| *block* (producer) | If sending a message to a direct endpoint which has no active consumer then we can tell the producer to block and wait for the consumer to become active. | false | boolean +| *block* (producer) | If sending a message to a direct endpoint which has no active consumer then we can tell the producer to block and wait for the consumer to become active. | true | boolean | *failIfNoConsumers* (producer) | Whether the producer should fail by throwing an exception when sending to a DIRECT endpoint with no active consumers. | false | boolean | *timeout* (producer) | The timeout value to use if block is enabled. | 3 | long | *synchronous* (advanced) | Sets whether synchronous processing should be strictly used or Camel is allowed to use asynchronous processing (if supported). | false | boolean diff --git a/camel-core/src/main/docs/direct-vm-component.adoc b/camel-core/src/main/docs/direct-vm-component.adoc index d6f7b213da6..77f5ace3ea9 100644 --- a/camel-core/src/main/docs/direct-vm-component.adoc +++ b/camel-core/src/main/docs/direct-vm-component.adoc @@ -47,7 +47,7 @@ The Direct VM component supports 5 options which are listed below. [width="100%",cols="2,5,^1,2",options="header"] |=== | Name | Description | Default | Type -| *block* (producer) | If sending a message to a direct endpoint which has no active consumer then we can tell the producer to block and wait for the consumer to become active. | false | boolean +| *block* (producer) | If sending a message to a direct endpoint which has no active consumer then we can tell the producer to block and wait for the consumer to become active. | true | boolean | *timeout* (producer) | The timeout value to use if block is enabled. | 3 | long | *headerFilterStrategy* (advanced) | Sets a HeaderFilterStrategy that will only be applied on producer endpoints (on both directions: request and response). Default value: none. | | HeaderFilterStrategy | *propagateProperties* (advanced) | Whether to propagate or not properties from the producer side to the consumer side and vice versa. Default value: true. | true | boolean @@ -83,7 +83,7 @@ with the following path and query parameters: | *bridgeErrorHandler*
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294251#comment-16294251 ] Claus Ibsen commented on CAMEL-12022: - Some tests in camel-quartz / camel-quarz2 was depending on the old behavior so I have fixed those. > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292227#comment-16292227 ] Ramu kakarla commented on CAMEL-12022: --- Hello Claus, I don't have ACL rights to edit the WIKI page. Could you do the favours > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292154#comment-16292154 ] Claus Ibsen commented on CAMEL-12022: - Yes it is > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291909#comment-16291909 ] Ramu kakarla commented on CAMEL-12022: --- Hi Claus, is this link [Camel 2.21.0 Release|https://cwiki.apache.org/confluence/display/CAMEL/Camel+2.21.0+Release] needs to be updated ? > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290854#comment-16290854 ] Claus Ibsen commented on CAMEL-12022: - Make sure to update the release notes as its a change of behaviour http://camel.apache.org/camel-2210-release.html > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290843#comment-16290843 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-351713686 ok, I'll merge ASAP This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290838#comment-16290838 ] ASF GitHub Bot commented on CAMEL-12022: ramu11 commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-351712983 Yup tested This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290834#comment-16290834 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-351712248 @ramu11 did you test on camel-spring too? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290833#comment-16290833 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-351711442 If you are ok with this, we can merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290832#comment-16290832 ] ASF GitHub Bot commented on CAMEL-12022: davsclaus commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-351710150 The option on the component level allows to configure this globally, eg to turn of block etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289068#comment-16289068 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-351352587 @davsclaus can you give a look here too? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285464#comment-16285464 ] ASF GitHub Bot commented on CAMEL-12022: ramu11 commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-350610458 @davsclaus , Could you please review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278183#comment-16278183 ] ASF GitHub Bot commented on CAMEL-12022: ramu11 commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-349230340 Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278073#comment-16278073 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-349207267 Yes, it must be added This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277827#comment-16277827 ] ASF GitHub Bot commented on CAMEL-12022: ramu11 commented on issue #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#issuecomment-349157852 @davsclaus ,@oscerd ,please let me know whether Default value should be added to metadata This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274146#comment-16274146 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on a change in pull request #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#discussion_r154297956 ## File path: camel-core/src/main/java/org/apache/camel/component/directvm/DirectVmEndpoint.java ## @@ -40,7 +40,7 @@ private String name; @UriParam(label = "producer") -private boolean block; +private boolean block = true; Review comment: Add DefaultValue in Metadata This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274147#comment-16274147 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on a change in pull request #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#discussion_r154297847 ## File path: camel-core/src/main/java/org/apache/camel/component/direct/DirectEndpoint.java ## @@ -44,7 +44,7 @@ private String name; @UriParam(label = "producer") -private boolean block; +private boolean block = true; Review comment: Add defaultValue in Metadata This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274148#comment-16274148 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on a change in pull request #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#discussion_r154297784 ## File path: camel-core/src/main/java/org/apache/camel/component/direct/DirectComponent.java ## @@ -36,7 +36,7 @@ // on DefaultCamelContext private final Mapconsumers = new HashMap (); @Metadata(label = "producer") -private boolean block; +private boolean block = true; Review comment: Add defaultValue in Metadata This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274149#comment-16274149 ] ASF GitHub Bot commented on CAMEL-12022: oscerd commented on a change in pull request #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125#discussion_r154297911 ## File path: camel-core/src/main/java/org/apache/camel/component/directvm/DirectVmComponent.java ## @@ -40,7 +40,7 @@ // on DefaultCamelContext private static final ConcurrentMapCONSUMERS = new ConcurrentHashMap (); @Metadata(label = "producer") -private boolean block; +private boolean block = true; Review comment: Add defaultValue in Metadata This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274139#comment-16274139 ] ASF GitHub Bot commented on CAMEL-12022: GitHub user ramu11 opened a pull request: https://github.com/apache/camel/pull/2125 "CAMEL-12022:direct component - Let the producer able to block and wa… git commit -a "CAMEL-12022:direct component - Let the producer able to block and wait for consumers to be started" You can merge this pull request into a Git repository by running: $ git pull https://github.com/ramu11/camel master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2125 commit dd43d077e893ad136ebb54f23720ed7c585710ea Author: RamuDate: 2017-12-01T09:05:37Z "CAMEL-12022:direct component - Let the producer able to block and wait for consumers to be started" > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274138#comment-16274138 ] ASF GitHub Bot commented on CAMEL-12022: ramu11 opened a new pull request #2125: "CAMEL-12022:direct component - Let the producer able to block and wa… URL: https://github.com/apache/camel/pull/2125 git commit -a "CAMEL-12022:direct component - Let the producer able to block and wait for consumers to be started" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272386#comment-16272386 ] Ramu kakarla commented on CAMEL-12022: --- Yes claus, I am almost done. Some of the test classes are getting failed .I am working on the same > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270713#comment-16270713 ] Claus Ibsen commented on CAMEL-12022: - So we have the logic already, it can be as simple as turning on block by default, then it will also block during startup and runtime, which is a bit safter than failing with a no consumer exception. > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264053#comment-16264053 ] Ramu kakarla commented on CAMEL-12022: --- Thanks Claus,I will raise PR > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263012#comment-16263012 ] Claus Ibsen commented on CAMEL-12022: - Yeah it starts to make more sense to have it blocking with timeout by default - that mitigates any slim chance during startup and with those no consumers exceptions. Doing this only during startup is what this ticket was about, but it could make sense to keep this behaviour at runtime as well to make it similar. In the odd chance someone uses the old behaviors then they can set block=false to use old way. > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-12022) direct component - Let the producer able to block and wait for consumers to be started
[ https://issues.apache.org/jira/browse/CAMEL-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262740#comment-16262740 ] Ramu kakarla commented on CAMEL-12022: --- Hello Claus, I do see 2 classes 1.DirectProducer.java (without timeout) 2.DirectBlockingProducer (with timeout) If no consumer is available producer should wait till consumer avaialble (with some default time) If we implement this timeout in Directproducer. then there will be no diff b/w DirectProducer.java and DirectBlockingProducer instead we can use DirectBlockingProducer . {code:java} public Producer createProducer() throws Exception { if (block) { return new DirectBlockingProducer(this); } else { return new DirectProducer(this); } } {code} > direct component - Let the producer able to block and wait for consumers to > be started > -- > > Key: CAMEL-12022 > URL: https://issues.apache.org/jira/browse/CAMEL-12022 > Project: Camel > Issue Type: Improvement > Components: camel-core >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > Similar to what direct-vm component can do. We should let the direct producer > detect that if there is no consumer yet, then it can wait until its ready > (with timeout) during starting routes. > This can avoid the slim chance during route startup that you get a > DirectConsumerNotAvailableException -- This message was sent by Atlassian JIRA (v6.4.14#64029)