[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[
https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056748#comment-17056748
]
Zoran Regvart commented on CAMEL-13888:
---
[~roshni] I agree, I think we should not force opening in a new window (tab),
users can easily do that themselves if needed. What the issue here is, or
should be, about is the security implications of linking to external sites
without {{rel="noopener,nofollow,noreferrer"}}. See [this blog
post|https://mathiasbynens.github.io/rel-noopener/] for details. My comment
above is how we can add this to the Hugo generated content, we also need a
solution on how to do this for the Antora rendered content.
> New web site: open foreign links in new window (tab)
>
>
> Key: CAMEL-13888
> URL: https://issues.apache.org/jira/browse/CAMEL-13888
> Project: Camel
> Issue Type: Sub-task
> Components: website
>Reporter: Dmitry Volodin
>Priority: Minor
> Labels: help-wanted
>
> It can be discussing, but would be nice to open all foreign links as new
> windows (tabs) for better usability while working with site, as some foreign
> resources not working correctly with return back to the original site page.
> Thank you.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056659#comment-17056659 ] Favour Theophilus ori commented on CAMEL-13888: --- I have fixed this & sent a PR: [https://github.com/apache/camel-website/pull/189] > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056332#comment-17056332 ] Roshni Prajapati commented on CAMEL-13888: -- [~zregvart] Hi sir, I would like to raise a point that even if we rectify this issue, how will a user know that the link automatically opens up to a new tab. User is accustomed to open the links by ctrl+'click' so resolving this issue won't be of much help until user experiences the change. Well, thinking of the issue i came up with a solution too. On hovering over the foreign links that are ought to be opened in a new tab, a hyperlink icon( [https://encrypted-tbn0.gstatic.com/images?q=tbn%3AANd9GcTDwswQEkx2fqzO8pA6x0GkgSoR2NzEKU2Mo7Qy4JBKYuvkKUj5] ) may pop up over mouse pointer. Viewing the icon user will have an idea of the link. I'm an outreachy applicant trying to understand and improve the user experience and interaction on the website. Looking forward to contribute as a designer. Thanks > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053314#comment-17053314 ] Ifeanyichukwu Nwabuokei commented on CAMEL-13888: - Hello [~zregvart] I am an Outreachy applicant, I would like to work on this task. > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053211#comment-17053211 ] Zoran Regvart commented on CAMEL-13888: --- Hi all, just in case you haven't already received this information on how to contribute I'll enclose it in here first, I'll try to address your individual comments next. We much appreciate your interest and willingness to contribute, I don't think it makes much sense for all of you to work on the same issue. There's also no need to have a competition on who gets to contribute first, we have plenty of other issues (outlined below) that you can help with. Since most of you are interested in participating in the Outreachy program, and help with the website, please have a look at some issues in that area via this search: https://issues.apache.org/jira/issues/?jql=project%20%3D%20CAMEL%20AND%20status%20%3D%20Open%20AND%20component%20%3D%20website And feel free to propose new ideas by creating new issues around the website. For those wondering how to get started contributing to the website. Make sure have a [GitHub account|https://github.com/join], read how you can [get started|https://help.github.com/en/github/getting-started-with-github], and [create a pull request|https://help.github.com/en/github/collaborating-with-issues-and-pull-requests]. Have a look at the [README.md|https://github.com/apache/camel-website/blob/master/README.md] in the website project on how to build and how to preview your changes on your own computer. I'll try to address the questions in you comments here, for future conversations please do subscribe to the developer's mailing list and send emails there, discussions on the Jira issues can get a bit out of control and it's not that easy to follow the conversation here. The following text includes information on how to reach us, and get started: First of all, thank you for having an interest in contributing to Apache Camel. Here are some guidelines on how to best approach the Apache Camel community and how to best apply yourself. 1. Communication Apache Camel is an Apache Software Foundation project, all communication is done in the open on the project mailing lists. You can read more on the reasoning behind this to get a better understanding of: https://www.apache.org/foundation/mailinglists.html All communication is subject to the ASF Code of Conduct, which you can read here: https://www.apache.org/foundation/policies/conduct.html For questions and guidance around contributing subscribe to the developer's mailing list by sending an e-mail to dev-subscr...@camel.apache.org. We can also be reached on the Gitter chat at https://gitter.im/apache/apache-camel/. We track issues using ASF Jira located at: https://issues.apache.org/jira/browse/CAMEL Where we maintain a list of issues that are easy to get started with, so you can familiarize yourself with the process and get your first contribution in: https://issues.apache.org/jira/issues/?filter=12348073 And some areas that we are actively looking for help on: https://issues.apache.org/jira/issues/?filter=12348074 When you're ready to contribute create a Pull request to one of the Camel projects you can find under the Apache organization on GitHub: https://github.com/apache?q=camel Expect that your Pull request will receive a review and that you will need to respond and correspond to that via comments at GitHub. 2. Getting started Read the "Contributing to Apache Camel" document on the Camel website: https://camel.apache.org/manual/latest/contributing.html Identify areas you can contribute first. You don't have to be an expert in an area, the Apache Camel developers are available to offer help and guidance. Introduce yourself on the developer's mailing list (see above), tell us what area of work or problem you wish to address in Camel. Create a draft of your solution, this can be simple 1-2 sentences on the change you wish to make. Try to be as specific as you can: include a short description of your intent, what you tried and what didn't work, or what you need help with. The best way of approaching the developers is by describing what you would like to work on and asking specific questions on how to get started. We'll do our best to guide you and help you make your contribution. We also participate in Google Summer of Code and Outreachy programs, for information about those look at those program websites. If you wish to participate in either of those follow the guidelines and schedule set by those programs. If you're unsure please reach out via official communication channels of those programs, or ask on the developer's mailing list for help. 3. Your first contribution Make sure you followed the steps and guidelines outlined above. For bigger changes, make sure that you have discussed on the developer's mailing list
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053148#comment-17053148 ] JyotiAttri commented on CAMEL-13888: Hi, my name is Jyoti Attri and I 'm Outreachy applicant for May 2020. I am interested to work on this issue. Please help me to get started. > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053146#comment-17053146 ] ONYIA UKAMAKA CHINOYELUM commented on CAMEL-13888: -- Hi, I am an Outreachy applicant for 2020, Zoran Regvart sir, I need your guidance on how to start my contribution. Thanks. > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052537#comment-17052537 ] Prerna Singh commented on CAMEL-13888: -- Hi, I am interested to work on this issue. I am an outreachy applicant 2020. Please Help me get started > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052506#comment-17052506 ] Prerna commented on CAMEL-13888: Hi, I am an Outreachy Applicant for May 2020. Would like to learn and work on this task. I want to see if i can be of any help here. > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052474#comment-17052474 ] Sabina Barbhuiya commented on CAMEL-13888: -- I am an Outreachy applicant for May 2020. I would like to work on your project. Can I please work on this issue, if it's still available? > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052424#comment-17052424 ] Aashna Jena commented on CAMEL-13888: - I came across this issue on Apache's Outreachy landing page. Can anybody help me on how to get started? I was able to build and run the website locally. > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > Labels: help-wanted > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916142#comment-16916142 ] Zoran Regvart commented on CAMEL-13888: --- [~dmvolod] help with this that would be very welcome :) > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915670#comment-16915670 ] Dmitry Volodin commented on CAMEL-13888: Thanks for response [~zregvart] Do you need help with foreign links in the adoc files? But the foreign links on the site, not inside the documentation would be nice to have. > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[
https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914251#comment-16914251
]
Zoran Regvart commented on CAMEL-13888:
---
For Hugo generated content we can add this to the
[config.toml|https://github.com/apache/camel-website/blob/master/config.toml]:
{code:yaml}
[blackfriday]
hrefTargetBlank = true
nofollowLinks = true
noreferrerLinks = true
{code}
Which also adds {{nofollow}}, {{noopener}} for {{target="_blank"}} is [on by
default|https://html.spec.whatwg.org/multipage/links.html#opener-processing-model].
For Asciidoc rendered content (user manual, component reference), we need to
change the markup of external links:
{code:none}
http://example.com[Example link^,opts=nofollow,noreferrer]
{code}
> New web site: open foreign links in new window (tab)
>
>
> Key: CAMEL-13888
> URL: https://issues.apache.org/jira/browse/CAMEL-13888
> Project: Camel
> Issue Type: Sub-task
> Components: website
>Reporter: Dmitry Volodin
>Priority: Minor
>
> It can be discussing, but would be nice to open all foreign links as new
> windows (tabs) for better usability while working with site, as some foreign
> resources not working correctly with return back to the original site page.
> Thank you.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[
https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912006#comment-16912006
]
Zoran Regvart commented on CAMEL-13888:
---
I really have no idea, is this a common practice? I mostly CTRL+click on links
to get them in a new tab. I'm not sure how we would do this, I guess for
Asciidoc content we could write an Asciidoctor extension, for Hugo bits perhaps
there's a setting we could use.
If we do this then we definitely would also need to add {{rel="noopener
noreferrer"}} to anchor tags to prevent any security issues.
> New web site: open foreign links in new window (tab)
>
>
> Key: CAMEL-13888
> URL: https://issues.apache.org/jira/browse/CAMEL-13888
> Project: Camel
> Issue Type: Sub-task
> Components: website
>Reporter: Dmitry Volodin
>Priority: Minor
>
> It can be discussing, but would be nice to open all foreign links as new
> windows (tabs) for better usability while working with site, as some foreign
> resources not working correctly with return back to the original site page.
> Thank you.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (CAMEL-13888) New web site: open foreign links in new window (tab)
[ https://issues.apache.org/jira/browse/CAMEL-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911981#comment-16911981 ] Dmitry Volodin commented on CAMEL-13888: [~zregvart], what do you think about this changes? > New web site: open foreign links in new window (tab) > > > Key: CAMEL-13888 > URL: https://issues.apache.org/jira/browse/CAMEL-13888 > Project: Camel > Issue Type: Sub-task > Components: website >Reporter: Dmitry Volodin >Priority: Minor > > It can be discussing, but would be nice to open all foreign links as new > windows (tabs) for better usability while working with site, as some foreign > resources not working correctly with return back to the original site page. > Thank you. -- This message was sent by Atlassian Jira (v8.3.2#803003)
