[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031608#comment-17031608 ] Claus Ibsen commented on CAMEL-14503: - There is the new generate-component plugin to use, and then you need to add the src/generated to the JAR via that other plugin. But its in the PR for camel-k-runtime. > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Assignee: Claus Ibsen >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031562#comment-17031562 ] Luca Burgazzoli commented on CAMEL-14503: - yeah I have a branch with the fixes https://github.com/lburgazzoli/apache-camel-k-runtime/tree/github-227 or better, till yesterday :) > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031559#comment-17031559 ] Claus Ibsen commented on CAMEL-14503: - Okay hacked the maven plugin and can now generate the metadata, then knative component has a missing javadoc on the component level. And when testing it fails as it thinks there is a type converter it should load. Looking into that > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031534#comment-17031534 ] Luca Burgazzoli commented on CAMEL-14503: - Well, I did some work some weeks ago to make it possible, for sure they will not be part of the aggregate class that exposes all the methods but you should be able to use it through static imports > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031529#comment-17031529 ] Claus Ibsen commented on CAMEL-14503: - Its not on the radar for now to have endpoint or component dsl for 3rd party components. The camel-knative should be move here when its stable. > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031519#comment-17031519 ] Luca Burgazzoli commented on CAMEL-14503: - yes there is a component in camel-k named camel-knative. I think that we should not prevent external components to generate and endpointdsl, componentdsl, maybe camel-core should include a resource that lists common properties > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031514#comment-17031514 ] Claus Ibsen commented on CAMEL-14503: - Luca btw where do you use this plugin? Do we have a nice place to try it? Isnt there a component in camel-k-runtime ? > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031513#comment-17031513 ] Claus Ibsen commented on CAMEL-14503: - Okay we now have that generate-component goal instead, we can then use it to turn on a flag on the endpoint mojo so it knows its not camel itself, and can act differently. For those standard options we could copy over the javadoc description instead of loading from source, then we dont need any trick to find the camel-core source code (eg to download -sources JAR) > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031508#comment-17031508 ] Claus Ibsen commented on CAMEL-14503: - There is now a new plugin goal named "generate-component" that 3rd party component developers should use. > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031502#comment-17031502 ] Claus Ibsen commented on CAMEL-14503: - We may want to create a new mojo that 3rd party can use, as it cannot do endpointdsl, componentdsl, and other bits. But should just do - PackageJandexMojo - TypeConverterLoaderGeneratorMojo - EndpointSchemaGeneratorMojo - PrepareComponentMojo - ValidateComponentMojo > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031500#comment-17031500 ] Claus Ibsen commented on CAMEL-14503: - A component inheirts some options that are on default endpoint which the plugin then cannot find > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031438#comment-17031438 ] Luca Burgazzoli commented on CAMEL-14503: - Not sure if camel-core is really needed maybe we just need to assume that if we do not faind camel-core we are not in the camel repo so we should follow a different path > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031436#comment-17031436 ] Claus Ibsen commented on CAMEL-14503: - There is some code here in 2.x that finds camel-core JAR from classpath and can load resources from within https://github.com/apache/camel/blob/camel-2.x/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PackageDataFormatMojo.java#L140 We would need to do something like this for 3rd party > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031433#comment-17031433 ] Claus Ibsen commented on CAMEL-14503: - Ah yeah then you need to find camel-core from via classpath / jarurl. We do that in some of the other maven tools > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-14503) camel-package-maven-plugin:generate fails with NPE for component outside the camel source tree
[ https://issues.apache.org/jira/browse/CAMEL-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031030#comment-17031030 ] Luca Burgazzoli commented on CAMEL-14503: - /cc [~gnodet] > camel-package-maven-plugin:generate fails with NPE for component outside the > camel source tree > -- > > Key: CAMEL-14503 > URL: https://issues.apache.org/jira/browse/CAMEL-14503 > Project: Camel > Issue Type: Bug > Components: tooling >Reporter: Luca Burgazzoli >Priority: Major > Fix For: 3.1.0 > > > The mojo camel-package-maven-plugin:generate assumes that components are all > belonging to the camel source tree so when it is applied to external > components, it fails with NPE here: > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java#L1230-L1231 -- This message was sent by Atlassian Jira (v8.3.4#803005)
