[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[ https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180810#comment-16180810 ] Önder Sezgin commented on CAMEL-7621: - Should be fine now. > camel-bindy - Two new properties to StringFormat through DataField: > toUppercase and mapToASCII > -- > > Key: CAMEL-7621 > URL: https://issues.apache.org/jira/browse/CAMEL-7621 > Project: Camel > Issue Type: New Feature > Components: camel-bindy >Reporter: Bruno Fontana >Assignee: Önder Sezgin >Priority: Minor > Fix For: 2.20.0 > > Attachments: > Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch > > > We faced many times the need of converting string fields to uppercase and get > rid of non-ASCII characters when interacting, using fixed-length files, with > COBOL banking cores. > So we decided to patch our own version of camel-bindy to add two new > properties to DataField annotation: > toUpperCase= which converts, if its a String type field, content > to uppercase. > mapToASCII= which maps, if its a String type field, content to > 7-bit ASCII character mapping. Extended characters are currently mapped like > this > ä,â,á,à -> a (same for all vowels) > ß -> b > ç -> c > ñ -> n > Conversion uses a lookup table so it could be easily extended to other chars. > This conversion only applies when marshalling. This feature has proven very > useful to us when interacting with banking cores and one that repeatedly has > to be recoded or reused. We love the annotation-driven model of bindy so > decided to patch our own version and submit the patch hoping it would be as > useful to others as it is to us. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[ https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180807#comment-16180807 ] ASF GitHub Bot commented on CAMEL-7621: --- Github user onders86 closed the pull request at: https://github.com/apache/camel/pull/1954 > camel-bindy - Two new properties to StringFormat through DataField: > toUppercase and mapToASCII > -- > > Key: CAMEL-7621 > URL: https://issues.apache.org/jira/browse/CAMEL-7621 > Project: Camel > Issue Type: New Feature > Components: camel-bindy >Reporter: Bruno Fontana >Assignee: Önder Sezgin >Priority: Minor > Fix For: 2.20.0 > > Attachments: > Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch > > > We faced many times the need of converting string fields to uppercase and get > rid of non-ASCII characters when interacting, using fixed-length files, with > COBOL banking cores. > So we decided to patch our own version of camel-bindy to add two new > properties to DataField annotation: > toUpperCase= which converts, if its a String type field, content > to uppercase. > mapToASCII= which maps, if its a String type field, content to > 7-bit ASCII character mapping. Extended characters are currently mapped like > this > ä,â,á,à -> a (same for all vowels) > ß -> b > ç -> c > ñ -> n > Conversion uses a lookup table so it could be easily extended to other chars. > This conversion only applies when marshalling. This feature has proven very > useful to us when interacting with banking cores and one that repeatedly has > to be recoded or reused. We love the annotation-driven model of bindy so > decided to patch our own version and submit the patch hoping it would be as > useful to others as it is to us. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[ https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180781#comment-16180781 ] ASF GitHub Bot commented on CAMEL-7621: --- GitHub user onders86 reopened a pull request: https://github.com/apache/camel/pull/1954 CAMEL-7621 - new(named as method)data field annotation added as des… …cribed in the issue as the following https://issues.apache.org/jira/browse/CAMEL-7621?focusedCommentId=16023475&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16023475 You can merge this pull request into a Git repository by running: $ git pull https://github.com/onders86/camel CAMEL-7621 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1954.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1954 commit fbbef4bf725860f856d1ed2c0c252fbb7a2e947a Author: onders86 Date: 2017-09-24T16:40:21Z CAMEL-7621 - new(named as function)data field annotation added as described in the issue as the following https://issues.apache.org/jira/browse/CAMEL-7621?focusedCommentId=16023475&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16023475 Renaming package name > camel-bindy - Two new properties to StringFormat through DataField: > toUppercase and mapToASCII > -- > > Key: CAMEL-7621 > URL: https://issues.apache.org/jira/browse/CAMEL-7621 > Project: Camel > Issue Type: New Feature > Components: camel-bindy >Reporter: Bruno Fontana >Assignee: Önder Sezgin >Priority: Minor > Fix For: 2.20.0 > > Attachments: > Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch > > > We faced many times the need of converting string fields to uppercase and get > rid of non-ASCII characters when interacting, using fixed-length files, with > COBOL banking cores. > So we decided to patch our own version of camel-bindy to add two new > properties to DataField annotation: > toUpperCase= which converts, if its a String type field, content > to uppercase. > mapToASCII= which maps, if its a String type field, content to > 7-bit ASCII character mapping. Extended characters are currently mapped like > this > ä,â,á,à -> a (same for all vowels) > ß -> b > ç -> c > ñ -> n > Conversion uses a lookup table so it could be easily extended to other chars. > This conversion only applies when marshalling. This feature has proven very > useful to us when interacting with banking cores and one that repeatedly has > to be recoded or reused. We love the annotation-driven model of bindy so > decided to patch our own version and submit the patch hoping it would be as > useful to others as it is to us. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[ https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180699#comment-16180699 ] Önder Sezgin commented on CAMEL-7621: - will have a look. spring context xmls seem got lost while squashing.. will fix it soon. > camel-bindy - Two new properties to StringFormat through DataField: > toUppercase and mapToASCII > -- > > Key: CAMEL-7621 > URL: https://issues.apache.org/jira/browse/CAMEL-7621 > Project: Camel > Issue Type: New Feature > Components: camel-bindy >Reporter: Bruno Fontana >Assignee: Önder Sezgin >Priority: Minor > Fix For: 2.20.0 > > Attachments: > Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch > > > We faced many times the need of converting string fields to uppercase and get > rid of non-ASCII characters when interacting, using fixed-length files, with > COBOL banking cores. > So we decided to patch our own version of camel-bindy to add two new > properties to DataField annotation: > toUpperCase= which converts, if its a String type field, content > to uppercase. > mapToASCII= which maps, if its a String type field, content to > 7-bit ASCII character mapping. Extended characters are currently mapped like > this > ä,â,á,à -> a (same for all vowels) > ß -> b > ç -> c > ñ -> n > Conversion uses a lookup table so it could be easily extended to other chars. > This conversion only applies when marshalling. This feature has proven very > useful to us when interacting with banking cores and one that repeatedly has > to be recoded or reused. We love the annotation-driven model of bindy so > decided to patch our own version and submit the patch hoping it would be as > useful to others as it is to us. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[ https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180690#comment-16180690 ] Claus Ibsen commented on CAMEL-7621: Onder, do you get unit test failure on camel-bindy as well, there is a single test that fails now BindySimpleFixedLengthUnmarshallClassMethodTest > camel-bindy - Two new properties to StringFormat through DataField: > toUppercase and mapToASCII > -- > > Key: CAMEL-7621 > URL: https://issues.apache.org/jira/browse/CAMEL-7621 > Project: Camel > Issue Type: New Feature > Components: camel-bindy >Reporter: Bruno Fontana >Assignee: Önder Sezgin >Priority: Minor > Fix For: 2.20.0 > > Attachments: > Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch > > > We faced many times the need of converting string fields to uppercase and get > rid of non-ASCII characters when interacting, using fixed-length files, with > COBOL banking cores. > So we decided to patch our own version of camel-bindy to add two new > properties to DataField annotation: > toUpperCase= which converts, if its a String type field, content > to uppercase. > mapToASCII= which maps, if its a String type field, content to > 7-bit ASCII character mapping. Extended characters are currently mapped like > this > ä,â,á,à -> a (same for all vowels) > ß -> b > ç -> c > ñ -> n > Conversion uses a lookup table so it could be easily extended to other chars. > This conversion only applies when marshalling. This feature has proven very > useful to us when interacting with banking cores and one that repeatedly has > to be recoded or reused. We love the annotation-driven model of bindy so > decided to patch our own version and submit the patch hoping it would be as > useful to others as it is to us. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[ https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180384#comment-16180384 ] ASF GitHub Bot commented on CAMEL-7621: --- Github user onders86 closed the pull request at: https://github.com/apache/camel/pull/1954 > camel-bindy - Two new properties to StringFormat through DataField: > toUppercase and mapToASCII > -- > > Key: CAMEL-7621 > URL: https://issues.apache.org/jira/browse/CAMEL-7621 > Project: Camel > Issue Type: New Feature > Components: camel-bindy >Reporter: Bruno Fontana >Assignee: Önder Sezgin >Priority: Minor > Attachments: > Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch > > > We faced many times the need of converting string fields to uppercase and get > rid of non-ASCII characters when interacting, using fixed-length files, with > COBOL banking cores. > So we decided to patch our own version of camel-bindy to add two new > properties to DataField annotation: > toUpperCase= which converts, if its a String type field, content > to uppercase. > mapToASCII= which maps, if its a String type field, content to > 7-bit ASCII character mapping. Extended characters are currently mapped like > this > ä,â,á,à -> a (same for all vowels) > ß -> b > ç -> c > ñ -> n > Conversion uses a lookup table so it could be easily extended to other chars. > This conversion only applies when marshalling. This feature has proven very > useful to us when interacting with banking cores and one that repeatedly has > to be recoded or reused. We love the annotation-driven model of bindy so > decided to patch our own version and submit the patch hoping it would be as > useful to others as it is to us. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[ https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178273#comment-16178273 ] ASF GitHub Bot commented on CAMEL-7621: --- GitHub user onders86 opened a pull request: https://github.com/apache/camel/pull/1954 CAMEL-7621 - new(named as function)data field annotation added as des… …cribed in the issue as the following https://issues.apache.org/jira/browse/CAMEL-7621?focusedCommentId=16023475&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16023475 You can merge this pull request into a Git repository by running: $ git pull https://github.com/onders86/camel CAMEL-7621 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1954.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1954 commit a56b1ca5661f896dc6df5013c570491e2ea43991 Author: onders86 Date: 2017-09-24T16:40:21Z CAMEL-7621 - new(named as function)data field annotation added as described in the issue as the following https://issues.apache.org/jira/browse/CAMEL-7621?focusedCommentId=16023475&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16023475 > camel-bindy - Two new properties to StringFormat through DataField: > toUppercase and mapToASCII > -- > > Key: CAMEL-7621 > URL: https://issues.apache.org/jira/browse/CAMEL-7621 > Project: Camel > Issue Type: New Feature > Components: camel-bindy >Reporter: Bruno Fontana >Assignee: Önder Sezgin >Priority: Minor > Attachments: > Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch > > > We faced many times the need of converting string fields to uppercase and get > rid of non-ASCII characters when interacting, using fixed-length files, with > COBOL banking cores. > So we decided to patch our own version of camel-bindy to add two new > properties to DataField annotation: > toUpperCase= which converts, if its a String type field, content > to uppercase. > mapToASCII= which maps, if its a String type field, content to > 7-bit ASCII character mapping. Extended characters are currently mapped like > this > ä,â,á,à -> a (same for all vowels) > ß -> b > ç -> c > ñ -> n > Conversion uses a lookup table so it could be easily extended to other chars. > This conversion only applies when marshalling. This feature has proven very > useful to us when interacting with banking cores and one that repeatedly has > to be recoded or reused. We love the annotation-driven model of bindy so > decided to patch our own version and submit the patch hoping it would be as > useful to others as it is to us. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-7621) camel-bindy - Two new properties to StringFormat through DataField: toUppercase and mapToASCII
[
https://issues.apache.org/jira/browse/CAMEL-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023475#comment-16023475
]
onder sezgin commented on CAMEL-7621:
-
it seems [~anoordover] implemented factory pattern through
https://issues.apache.org/jira/browse/CAMEL-9954
which is very nice.
patch does not seem applicable and even if it would be applicable, i'd like to
imagine such an implementation for DataField like
{code}
@DataField(pos = 14, length = 5, align = "L", function="toUpperCase")
private String lastName;
{code}
and function plays with the data field as injected through function's method.
I guess this may be an limited implementation because such annonation attribute
and its value as method name
may be for calling methods with no parameter. and maybe in future method's with
arguements would be provided.
or maybe with such SPI custom method binding would be provided. Not sure for
now how it can be done..
what do you think about it?
> camel-bindy - Two new properties to StringFormat through DataField:
> toUppercase and mapToASCII
> --
>
> Key: CAMEL-7621
> URL: https://issues.apache.org/jira/browse/CAMEL-7621
> Project: Camel
> Issue Type: New Feature
> Components: camel-bindy
>Reporter: Bruno Fontana
>Priority: Minor
> Attachments:
> Adding-properties-to-mapToASCII-and-to-convert-to-Up.patch
>
>
> We faced many times the need of converting string fields to uppercase and get
> rid of non-ASCII characters when interacting, using fixed-length files, with
> COBOL banking cores.
> So we decided to patch our own version of camel-bindy to add two new
> properties to DataField annotation:
> toUpperCase= which converts, if its a String type field, content
> to uppercase.
> mapToASCII= which maps, if its a String type field, content to
> 7-bit ASCII character mapping. Extended characters are currently mapped like
> this
> ä,â,á,à -> a (same for all vowels)
> ß -> b
> ç -> c
> ñ -> n
> Conversion uses a lookup table so it could be easily extended to other chars.
> This conversion only applies when marshalling. This feature has proven very
> useful to us when interacting with banking cores and one that repeatedly has
> to be recoded or reused. We love the annotation-driven model of bindy so
> decided to patch our own version and submit the patch hoping it would be as
> useful to others as it is to us.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
