[jira] [Commented] (CAMEL-8002) determineAlphabet only considers GSM 3.38 or UCS2
[ https://issues.apache.org/jira/browse/CAMEL-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305407#comment-15305407 ] Claus Ibsen commented on CAMEL-8002: We have just upgraded to jsmpp 2.2.x. Wonder if you have time to look at this again? > determineAlphabet only considers GSM 3.38 or UCS2 > - > > Key: CAMEL-8002 > URL: https://issues.apache.org/jira/browse/CAMEL-8002 > Project: Camel > Issue Type: Bug > Components: camel-smpp >Affects Versions: 2.12.2 > Environment: n/a >Reporter: Daniel Pocock > > SmppSmCommand.determineAlphabet(Message) tries to work out which SMPP > alphabet code is suitable for encoding the message text. > It checks if GSM 3.38 can represent all the characters in the message and if > not it just uses UCS2 (UTF-16). > This is less than optimal. Many messages using European languages can not be > encoded in GSM 3.38 but they can be coded in Latin1, which is also supported > by SMPP (data_coding / alphabet numeric code for Latin1 is 3) > The jSMPP library (Alphabet.java) does not currently know about the alphabet > code 3. > I proposed a patch for jSMPP and if it is accepted then camel-smpp should be > updated to use it. I already started writing a patch against camel-smpp. > Here is the jSMPP patch: > https://github.com/uudashr/jsmpp/pull/39 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8002) determineAlphabet only considers GSM 3.38 or UCS2
[ https://issues.apache.org/jira/browse/CAMEL-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633594#comment-14633594 ] ASF GitHub Bot commented on CAMEL-8002: --- Github user dpocock closed the pull request at: https://github.com/apache/camel/pull/317 determineAlphabet only considers GSM 3.38 or UCS2 - Key: CAMEL-8002 URL: https://issues.apache.org/jira/browse/CAMEL-8002 Project: Camel Issue Type: Bug Components: camel-smpp Affects Versions: 2.12.2 Environment: n/a Reporter: Daniel Pocock SmppSmCommand.determineAlphabet(Message) tries to work out which SMPP alphabet code is suitable for encoding the message text. It checks if GSM 3.38 can represent all the characters in the message and if not it just uses UCS2 (UTF-16). This is less than optimal. Many messages using European languages can not be encoded in GSM 3.38 but they can be coded in Latin1, which is also supported by SMPP (data_coding / alphabet numeric code for Latin1 is 3) The jSMPP library (Alphabet.java) does not currently know about the alphabet code 3. I proposed a patch for jSMPP and if it is accepted then camel-smpp should be updated to use it. I already started writing a patch against camel-smpp. Here is the jSMPP patch: https://github.com/uudashr/jsmpp/pull/39 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8002) determineAlphabet only considers GSM 3.38 or UCS2
[ https://issues.apache.org/jira/browse/CAMEL-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321923#comment-14321923 ] Claus Ibsen commented on CAMEL-8002: Can we get a status of all those smpp tickets and PR and patches? determineAlphabet only considers GSM 3.38 or UCS2 - Key: CAMEL-8002 URL: https://issues.apache.org/jira/browse/CAMEL-8002 Project: Camel Issue Type: Bug Components: camel-smpp Affects Versions: 2.12.2 Environment: n/a Reporter: Daniel Pocock SmppSmCommand.determineAlphabet(Message) tries to work out which SMPP alphabet code is suitable for encoding the message text. It checks if GSM 3.38 can represent all the characters in the message and if not it just uses UCS2 (UTF-16). This is less than optimal. Many messages using European languages can not be encoded in GSM 3.38 but they can be coded in Latin1, which is also supported by SMPP (data_coding / alphabet numeric code for Latin1 is 3) The jSMPP library (Alphabet.java) does not currently know about the alphabet code 3. I proposed a patch for jSMPP and if it is accepted then camel-smpp should be updated to use it. I already started writing a patch against camel-smpp. Here is the jSMPP patch: https://github.com/uudashr/jsmpp/pull/39 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8002) determineAlphabet only considers GSM 3.38 or UCS2
[ https://issues.apache.org/jira/browse/CAMEL-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322040#comment-14322040 ] Daniel Pocock commented on CAMEL-8002: -- As noted earlier, this is still work-in-progress. I just had a quick look over the code and it appears valid but may need further testing. Some of my other un-merged changes depend on updating the jSMPP 2.2.x (CAMEL-8219) but that is not a blocker for this issue. A resolution of this issue will make it easier for people to use SMPP without having to think about encoding issues. At present, people have to think about encoding issues before giving their message to camel-smpp. determineAlphabet only considers GSM 3.38 or UCS2 - Key: CAMEL-8002 URL: https://issues.apache.org/jira/browse/CAMEL-8002 Project: Camel Issue Type: Bug Components: camel-smpp Affects Versions: 2.12.2 Environment: n/a Reporter: Daniel Pocock SmppSmCommand.determineAlphabet(Message) tries to work out which SMPP alphabet code is suitable for encoding the message text. It checks if GSM 3.38 can represent all the characters in the message and if not it just uses UCS2 (UTF-16). This is less than optimal. Many messages using European languages can not be encoded in GSM 3.38 but they can be coded in Latin1, which is also supported by SMPP (data_coding / alphabet numeric code for Latin1 is 3) The jSMPP library (Alphabet.java) does not currently know about the alphabet code 3. I proposed a patch for jSMPP and if it is accepted then camel-smpp should be updated to use it. I already started writing a patch against camel-smpp. Here is the jSMPP patch: https://github.com/uudashr/jsmpp/pull/39 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8002) determineAlphabet only considers GSM 3.38 or UCS2
[ https://issues.apache.org/jira/browse/CAMEL-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322062#comment-14322062 ] Daniel Pocock commented on CAMEL-8002: -- Actually, part of the branch / pull request for this work does depend on the changes to Alphabet.java in jSMPP 2.2.x determineAlphabet only considers GSM 3.38 or UCS2 - Key: CAMEL-8002 URL: https://issues.apache.org/jira/browse/CAMEL-8002 Project: Camel Issue Type: Bug Components: camel-smpp Affects Versions: 2.12.2 Environment: n/a Reporter: Daniel Pocock SmppSmCommand.determineAlphabet(Message) tries to work out which SMPP alphabet code is suitable for encoding the message text. It checks if GSM 3.38 can represent all the characters in the message and if not it just uses UCS2 (UTF-16). This is less than optimal. Many messages using European languages can not be encoded in GSM 3.38 but they can be coded in Latin1, which is also supported by SMPP (data_coding / alphabet numeric code for Latin1 is 3) The jSMPP library (Alphabet.java) does not currently know about the alphabet code 3. I proposed a patch for jSMPP and if it is accepted then camel-smpp should be updated to use it. I already started writing a patch against camel-smpp. Here is the jSMPP patch: https://github.com/uudashr/jsmpp/pull/39 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8002) determineAlphabet only considers GSM 3.38 or UCS2
[ https://issues.apache.org/jira/browse/CAMEL-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200354#comment-14200354 ] ASF GitHub Bot commented on CAMEL-8002: --- GitHub user dpocock opened a pull request: https://github.com/apache/camel/pull/317 (work in progress) fix for CAMEL-8002, support for Latin1 coded SMS over SMPP Please discuss through the Jira issue: https://issues.apache.org/jira/browse/CAMEL-8002 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpocock/camel dpocock-smpp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #317 commit 1c4e4e9aa0f59af6136b1cd7fa4eee7da38eacdc Author: Daniel Pocock dan...@pocock.pro Date: 2014-11-05T15:49:58Z Use UCS2 encoding if UCS2 alphabet specified commit be729adb020ff9bc2c660ea6a916a68cd503a7b9 Author: Daniel Pocock dan...@pocock.pro Date: 2014-11-05T16:56:35Z SmppUtils.isGsm0338Encodeable() expects Latin1 input, only use it if encoding is Latin1 or ASCII commit b0fa26afe21718a39c759ba13b0309da9034e3c6 Author: Daniel Pocock dan...@pocock.pro Date: 2014-11-06T15:50:12Z Begin fixing CAMEL-8002, depends on pull req. 39 in jsmpp determineAlphabet only considers GSM 3.38 or UCS2 - Key: CAMEL-8002 URL: https://issues.apache.org/jira/browse/CAMEL-8002 Project: Camel Issue Type: Bug Components: camel-smpp Affects Versions: 2.12.2 Environment: n/a Reporter: Daniel Pocock SmppSmCommand.determineAlphabet(Message) tries to work out which SMPP alphabet code is suitable for encoding the message text. It checks if GSM 3.38 can represent all the characters in the message and if not it just uses UCS2 (UTF-16). This is less than optimal. Many messages using European languages can not be encoded in GSM 3.38 but they can be coded in Latin1, which is also supported by SMPP (data_coding / alphabet numeric code for Latin1 is 3) The jSMPP library (Alphabet.java) does not currently know about the alphabet code 3. I proposed a patch for jSMPP and if it is accepted then camel-smpp should be updated to use it. I already started writing a patch against camel-smpp. Here is the jSMPP patch: https://github.com/uudashr/jsmpp/pull/39 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
