[jira] [Commented] (CAMEL-9119) XSLT errors should not be ignored

2015-09-16 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747376#comment-14747376
 ] 

Claus Ibsen commented on CAMEL-9119:


This causes side-effects - looking into reverting this

> XSLT errors should not be ignored
> -
>
> Key: CAMEL-9119
> URL: https://issues.apache.org/jira/browse/CAMEL-9119
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.14.3
> Environment: ServiceMix 5.4.1
>Reporter: metatech
>Assignee: Claus Ibsen
> Fix For: 2.16.0, 2.15.4
>
> Attachments: camel_xslt_errors_thrown.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Since CAMEL-4396, XSLT exceptions are not logged anymore on System.err.
> Unfortunately, the XsltErrorHandler which was introduced does not behave as 
> the default ErrorHandler which logs on System.err and re-throws exceptions 
> (my mistake). 
> The XsltErrorHandler should re-throw exceptions for ERROR or FATAL, otherwise 
> they are ignored and the service is allowed to start, although the XSLT 
> transformation is not successfully started.
> Here is a small patch that fixes that.
> The test "XsltTestErrorListenerTest" is still successful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-9119) XSLT errors should not be ignored

2015-09-16 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14768889#comment-14768889
 ] 

Claus Ibsen commented on CAMEL-9119:


Okay seems it was another ticket that had a knock-on effect on this. JDK vs 
Saxon behaves different and report different errors etc.

> XSLT errors should not be ignored
> -
>
> Key: CAMEL-9119
> URL: https://issues.apache.org/jira/browse/CAMEL-9119
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.14.3
> Environment: ServiceMix 5.4.1
>Reporter: metatech
>Assignee: Claus Ibsen
> Fix For: 2.16.0, 2.15.4
>
> Attachments: camel_xslt_errors_thrown.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Since CAMEL-4396, XSLT exceptions are not logged anymore on System.err.
> Unfortunately, the XsltErrorHandler which was introduced does not behave as 
> the default ErrorHandler which logs on System.err and re-throws exceptions 
> (my mistake). 
> The XsltErrorHandler should re-throw exceptions for ERROR or FATAL, otherwise 
> they are ignored and the service is allowed to start, although the XSLT 
> transformation is not successfully started.
> Here is a small patch that fixes that.
> The test "XsltTestErrorListenerTest" is still successful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)