[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4959/



---


[jira] [Created] (CARBONDATA-2490) Even Bad records action is FORCE , SDK writer failed with ClassCastException

2018-05-17 Thread Rahul Kumar (JIRA)
Rahul Kumar created CARBONDATA-2490:
---

 Summary: Even Bad records action is FORCE , SDK writer failed with 
ClassCastException
 Key: CARBONDATA-2490
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2490
 Project: CarbonData
  Issue Type: Bug
Reporter: Rahul Kumar
Assignee: Rahul Kumar


Test Step : 

def myStruct(): Unit = {

 val myaSchema=
 """
 {
| "namespace": "com.apache.schema",
| "type": "record",
| "name": "StudentActivity",
| "fields": [
| {
| "name": "id",
| "type": "int"
| },
| {
 | "name": "name",
 | "type": "string"
 | },
 | {
 | "name": "age",
 | "type": "double"
 | },
 |
| {
| "name": "course_details",
| "type": {
| "name": "Activity",
| "type": "record",
| "fields": [
| {
| "name": "course_id",
| "type": "int"
| }
| ]
| }
| },
| {
| "name":"teachers",
| "type":
| {
| "type":"array",
| "items": "string"
|
| }
| },
| {
 | "name":"salary",
 | "type":
 | {
 | "type":"array",
 | "items": "double"
 |
 | }
 | }
 |
| ]
| }
 """.stripMargin

 var json = "{\"id\": 101,\"name\": \"babu\",\"age\": 12.1,\"course_details\": 
" +
 "\{\"course_id\": 11},\"teachers\": [\"PK\", \"DK\", \"MK\", 
\"SK\"],\"salary\": " +
 "[12.12,25.12,65]}"


 val nn = new org.apache.avro.Schema.Parser().parse(myaSchema)
 val converter = new JsonAvroConverter
 var record = converter
 .convertToGenericDataRecord(json.getBytes(CharEncoding.UTF_8), nn)
 val fields = new Array[Field](6)
 fields(0) = new Field("id", DataTypes.INT)
 fields(1) = new Field("name", DataTypes.INT)
 fields(2) = new Field("age", DataTypes.DOUBLE)
 // fields[1] = new Field("age", DataTypes.INT);
 val fld = new java.util.ArrayList[StructField]
 fld.add(new StructField("course_id", DataTypes.INT))
 fields(3) = new Field("course_details", "struct", fld)

 val arr = new java.util.ArrayList[StructField]
 arr.add(new StructField("teachers",DataTypes.STRING))

 fields(4) = new Field("teachers", "array",arr)

 val arr1 = new java.util.ArrayList[StructField]
 arr1.add(new StructField("salary",DataTypes.DOUBLE))

 fields(5) = new Field("salary", "array",arr)

 import scala.collection.JavaConverters._
 var options = Map("bad_records_action" -> "FORCE").asJava
 try {
 val writer = CarbonWriter.builder.withSchema(new 
Schema(fields)).sortBy(Array("name","id"))
 
.outputPath("D:/Hadoop/carbon_1_3/sdk/carbon_c1/").isTransactionalTable(false).withLoadOptions(options).buildWriterForAvroInput

 for(i <-0 to 100){
 val json1 = "{\"id\": 101,\"name\": \"babu\",\"age\": 12.1,\"course_details\": 
" +
 "\{\"course_id\": 11},\"teachers\": [\"PK\", \"DK\", \"MK\", 
\"SK\"],\"salary\": " +
 "[12.12,25.12,"+i+"]}";
 val record1 = converter
 .convertToGenericDataRecord(json1.getBytes(CharEncoding.UTF_8), nn)
 writer.write(record1)
 }

 json = "{\"id\": 501,\"name\": \"babu\",\"age\": 12.1,\"course_details\": " +
 "\{\"course_id\": 11},\"teachers\": [\"PK\", \"DK\", \"MK\", 
\"SK\",\"\",\"null\"],\"salary\": " +
 "[12.12,25.12]}";
 record = converter
 .convertToGenericDataRecord(json.getBytes(CharEncoding.UTF_8), nn)
 writer.write(record)


 writer.close()
 }
 catch {
 case e: Exception => {
 e.printStackTrace()
 }
 }


 }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2310: [CARBONDATA-2484][LUCENE]Refactor distributab...

2018-05-17 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2310#discussion_r188869927
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datamap;
+
+import java.io.IOException;
+import java.lang.reflect.Constructor;
+import java.util.List;
+
+import org.apache.carbondata.common.logging.LogService;
+import org.apache.carbondata.common.logging.LogServiceFactory;
+import org.apache.carbondata.core.datamap.dev.expr.DataMapExprWrapper;
+import org.apache.carbondata.core.indexstore.ExtendedBlocklet;
+import org.apache.carbondata.core.indexstore.PartitionSpec;
+import 
org.apache.carbondata.core.indexstore.blockletindex.BlockletDataMapFactory;
+import org.apache.carbondata.core.metadata.schema.table.CarbonTable;
+import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf;
+import org.apache.carbondata.core.statusmanager.SegmentStatusManager;
+import org.apache.carbondata.core.util.ObjectSerializationUtil;
+
+import org.apache.hadoop.conf.Configuration;
+
+public class DataMapUtil {
+
+  private static final String DATA_MAP_DSTR = 
"mapreduce.input.carboninputformat.datamapdstr";
+
+  private static final LogService LOGGER =
+  LogServiceFactory.getLogService(DataMapUtil.class.getName());
+
+  /**
+   * This method set DataMapJob if configured
+   *
+   * @param conf
+   * @throws IOException
+   */
+  public static void setDataMapJobIfConfigured(Configuration conf) throws 
IOException {
+String className = "org.apache.carbondata.spark.rdd.SparkDataMapJob";
+setDataMapJob(conf, createDataMapJob(className));
+  }
+
+  /**
+   * Creates instance for the DataMap Job class
+   *
+   * @param className
+   * @return
+   */
+  public static Object createDataMapJob(String className) {
+try {
+  return 
Class.forName(className).getDeclaredConstructors()[0].newInstance();
+} catch (Exception e) {
+  LOGGER.error(e);
+  return null;
+}
+  }
+
+  public static void setDataMapJob(Configuration configuration, Object 
dataMapJob)
+  throws IOException {
+if (dataMapJob != null) {
+  String toString = 
ObjectSerializationUtil.convertObjectToString(dataMapJob);
+  configuration.set(DATA_MAP_DSTR, toString);
+}
+  }
+
+  public static DataMapJob getDataMapJob(Configuration configuration) 
throws IOException {
+String jobString = configuration.get(DATA_MAP_DSTR);
+if (jobString != null) {
+  return (DataMapJob) 
ObjectSerializationUtil.convertStringToObject(jobString);
+}
+return null;
+  }
+
+  public static void executeDataMapJobForClearingDataMaps(CarbonTable 
carbonTable)
+  throws IOException {
+String dataMapJobClassName = 
"org.apache.carbondata.spark.rdd.SparkDataMapJob";
+DataMapJob dataMapJob = (DataMapJob) 
createDataMapJob(dataMapJobClassName);
+String className = 
"org.apache.carbondata.core.datamap.DistributableDataMapFormat";
+SegmentStatusManager ssm = new 
SegmentStatusManager(carbonTable.getAbsoluteTableIdentifier());
+List validSegments = 
ssm.getValidAndInvalidSegments().getValidSegments();
+DataMapExprWrapper dataMapExprWrapper = null;
+if 
(DataMapStoreManager.getInstance().getAllDataMap(carbonTable).size() > 0) {
+  DataMapChooser dataMapChooser = new DataMapChooser(carbonTable);
+  dataMapExprWrapper = 
dataMapChooser.getAllDataMapsForClear(carbonTable);
+} else {
+  return;
+}
+DistributableDataMapFormat dataMapFormat =
--- End diff --

no, if there are no datamaps present, it will return


---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5930/



---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4775/



---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4960/



---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread dhatchayani
Github user dhatchayani commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Retest this please


---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5932/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4777/



---


[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-17 Thread gvramana
Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2313#discussion_r12558
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/dictionary/generator/IncrementalColumnDictionaryGenerator.java
 ---
@@ -89,15 +89,19 @@ public 
IncrementalColumnDictionaryGenerator(CarbonDimension dimension, int maxVa
   }
 
   @Override public Integer getKey(String value) {
-return incrementalCache.get(value);
+synchronized (lock) {
--- End diff --

This lock is not required


---


[GitHub] carbondata pull request #2304: [CARBONDATA-2477]Fixed No dictionary Complex ...

2018-05-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2304#discussion_r15269
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
 ---
@@ -202,9 +249,36 @@ private static ColumnPage 
getLVBytesColumnPage(TableSpec.ColumnSpec columnSpec,
 lvEncodedOffset = 0;
 for (int i = 0; i < numRows; i++) {
   length = rowLength.get(i);
-  page.putBytes(i, lvEncodedBytes, lvEncodedOffset + 4, length);
-  lvEncodedOffset += 4 + length;
+  page.putBytes(i, lvEncodedBytes, lvEncodedOffset + lvLength, length);
+  lvEncodedOffset += lvLength + length;
 }
+return page;
+  }
+
+  private static ColumnPage 
getComplexParentBytesColumnPage(TableSpec.ColumnSpec columnSpec,
--- End diff --

Check and remove if not required


---


[GitHub] carbondata pull request #2304: [CARBONDATA-2477]Fixed No dictionary Complex ...

2018-05-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2304#discussion_r15431
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
 ---
@@ -353,6 +427,32 @@ public double getDouble(int rowId) {
 return data;
   }
 
+  @Override public byte[] getComplexChildrenLVFlattenedBytePage() throws 
IOException {
+// output LV encoded byte array
+int offset = 0;
+byte[] data = new byte[totalLength + pageSize * 2];
+for (int rowId = 0; rowId < pageSize; rowId++) {
+  short length = (short) (rowOffset[rowId + 1] - rowOffset[rowId]);
+  ByteUtil.setShort(data, offset, length);
+  copyBytes(rowId, data, offset + 2, length);
+  offset += 2 + length;
+}
+return data;
+  }
+
+  @Override
+  public byte[] getComplexParentFlattenedBytePage() throws IOException {
--- End diff --

Check and remove if not required


---


[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2306
  
LGTM


---


[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2246
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4961/



---


[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2246
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5931/



---


[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2246
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4776/



---


[GitHub] carbondata pull request #2310: [CARBONDATA-2484][LUCENE]Refactor distributab...

2018-05-17 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2310#discussion_r19978
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datamap;
+
+import java.io.IOException;
+import java.lang.reflect.Constructor;
+import java.util.List;
+
+import org.apache.carbondata.common.logging.LogService;
+import org.apache.carbondata.common.logging.LogServiceFactory;
+import org.apache.carbondata.core.datamap.dev.expr.DataMapExprWrapper;
+import org.apache.carbondata.core.indexstore.ExtendedBlocklet;
+import org.apache.carbondata.core.indexstore.PartitionSpec;
+import 
org.apache.carbondata.core.indexstore.blockletindex.BlockletDataMapFactory;
+import org.apache.carbondata.core.metadata.schema.table.CarbonTable;
+import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf;
+import org.apache.carbondata.core.statusmanager.SegmentStatusManager;
+import org.apache.carbondata.core.util.ObjectSerializationUtil;
+
+import org.apache.hadoop.conf.Configuration;
+
+public class DataMapUtil {
+
+  private static final String DATA_MAP_DSTR = 
"mapreduce.input.carboninputformat.datamapdstr";
+
+  private static final LogService LOGGER =
+  LogServiceFactory.getLogService(DataMapUtil.class.getName());
+
+  /**
+   * This method set DataMapJob if configured
+   *
+   * @param conf
+   * @throws IOException
+   */
+  public static void setDataMapJobIfConfigured(Configuration conf) throws 
IOException {
+String className = "org.apache.carbondata.spark.rdd.SparkDataMapJob";
+setDataMapJob(conf, createDataMapJob(className));
+  }
+
+  /**
+   * Creates instance for the DataMap Job class
+   *
+   * @param className
+   * @return
+   */
+  public static Object createDataMapJob(String className) {
--- End diff --

this will be called from CarbonInputFormatUtil in function 
setDataMapJobIfConfigured, so we can keep it public


---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5933/



---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4778/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4962/



---


[GitHub] carbondata issue #2235: [CARBONDATA-2465] Improve the carbondata file reliab...

2018-05-17 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2235
  
LGTM


---


[GitHub] carbondata issue #2235: [CARBONDATA-2465] Improve the carbondata file reliab...

2018-05-17 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2235
  
The changes are OK, better to correct the title of commit


---


[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-17 Thread gvramana
Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2313#discussion_r188906834
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
 ---
@@ -282,12 +282,15 @@ private void readIndexFile(CarbonFile indexFile) 
throws IOException {
 DataInputStream dataInputStream =
 FileFactory.getDataInputStream(indexFilePath, 
FileFactory.getFileType(indexFilePath));
 byte[] bytes = new byte[(int) indexFile.getSize()];
-dataInputStream.readFully(bytes);
-carbonIndexMap.put(indexFile.getName(), bytes);
-carbonIndexMapWithFullPath.put(
-indexFile.getParentFile().getAbsolutePath() + 
CarbonCommonConstants.FILE_SEPARATOR
-+ indexFile.getName(), bytes);
-dataInputStream.close();
+try {
--- End diff --

Finally should have only close


---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5935/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4780/



---


[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2246
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5934/



---


[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2246
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4779/



---


[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2246
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4963/



---


[GitHub] carbondata issue #2235: [CARBONDATA-2465] Improve the carbondata file reliab...

2018-05-17 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2235
  
LGTM


---


[GitHub] carbondata issue #2304: [CARBONDATA-2477]Fixed No dictionary Complex type wi...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2304
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4781/



---


[GitHub] carbondata issue #2304: [CARBONDATA-2477]Fixed No dictionary Complex type wi...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2304
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5936/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5937/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4782/



---


[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2246
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4964/



---


[GitHub] carbondata pull request #2314: [CarbonData-2309][DataLoad] Add strategy to g...

2018-05-17 Thread ndwangsen
GitHub user ndwangsen opened a pull request:

https://github.com/apache/carbondata/pull/2314

[CarbonData-2309][DataLoad] Add strategy to generate bigger carbondata 
files in case of small amo…

In some scenario, the input amount of loading data is small, but carbondata 
still distribute them to each executors (nodes) to do local-sort, thus 
resulting to small carbondata files generated by each executor. 

In  some extreme conditions, if the cluster is big enough or if the amount 
of data is small enough, the carbondata file contains only one blocklet or page.

I  think a new strategy should be introduced to solve the above problem.

The new strategy should:

be able to control the minimum amount of input data for each node
ignore data locality otherwise it may always choose a small portion of 
particular nodes

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
   NO
 - [ ] Any backward compatibility impacted?
   NO
 - [ ] Document update required?
   YES
 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
   YES
- How it is tested? Please attach test report.
  Tested in local
- Is it a performance related change? Please attach the performance 
test report.mac
  After this PR, performance is as we expected
- Any additional information to help reviewers in testing this 
change.
  NO
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
  NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ndwangsen/incubator-carbondata load_min

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2314


commit 987921ef4d1c16e01b5c46384b8b1c356e3abe8a
Author: ndwangsen 
Date:   2018-05-17T09:26:00Z

Add strategy to generate bigger carbondata files in case of small amount of 
input data




---


[GitHub] carbondata pull request #2314: [CARBONDATA-2309][DataLoad] Add strategy to g...

2018-05-17 Thread ndwangsen
GitHub user ndwangsen reopened a pull request:

https://github.com/apache/carbondata/pull/2314

[CARBONDATA-2309][DataLoad] Add strategy to generate bigger carbondata 
files in case of small amo…

In some scenario, the input amount of loading data is small, but carbondata 
still distribute them to each executors (nodes) to do local-sort, thus 
resulting to small carbondata files generated by each executor. 

In  some extreme conditions, if the cluster is big enough or if the amount 
of data is small enough, the carbondata file contains only one blocklet or page.

I  think a new strategy should be introduced to solve the above problem.

The new strategy should:

be able to control the minimum amount of input data for each node
ignore data locality otherwise it may always choose a small portion of 
particular nodes

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
   NO
 - [ ] Any backward compatibility impacted?
   NO
 - [ ] Document update required?
   YES
 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
   YES
- How it is tested? Please attach test report.
  Tested in local
- Is it a performance related change? Please attach the performance 
test report.mac
  After this PR, performance is as we expected
- Any additional information to help reviewers in testing this 
change.
  NO
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
  NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ndwangsen/incubator-carbondata load_min

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2314


commit 987921ef4d1c16e01b5c46384b8b1c356e3abe8a
Author: ndwangsen 
Date:   2018-05-17T09:26:00Z

Add strategy to generate bigger carbondata files in case of small amount of 
input data




---


[GitHub] carbondata pull request #2314: [CARBONDATA-2309][DataLoad] Add strategy to g...

2018-05-17 Thread ndwangsen
Github user ndwangsen closed the pull request at:

https://github.com/apache/carbondata/pull/2314


---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5938/



---


[GitHub] carbondata issue #2314: [CARBONDATA-2309][DataLoad] Add strategy to generate...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2314
  
Can one of the admins verify this patch?


---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4783/



---


[GitHub] carbondata issue #2314: [CARBONDATA-2309][DataLoad] Add strategy to generate...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2314
  
Can one of the admins verify this patch?


---


[GitHub] carbondata issue #2314: [CARBONDATA-2309][DataLoad] Add strategy to generate...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2314
  
Can one of the admins verify this patch?


---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4965/



---


[GitHub] carbondata issue #2235: [CARBONDATA-2465] Improve the carbondata file reliab...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2235
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5939/



---


[GitHub] carbondata issue #2235: [CARBONDATA-2465] Improve the carbondata file reliab...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2235
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4784/



---


[GitHub] carbondata pull request #2315: [WIP] added validation for null avro type

2018-05-17 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/carbondata/pull/2315

[WIP] added validation for null avro type

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/carbondata null_avro

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2315


commit f239a321fc101aa4adcbfc1bcd5ec486a7c3c5a8
Author: kunal642 
Date:   2018-05-17T13:09:26Z

added validation for null avro type




---


[GitHub] carbondata issue #2308: [CARBONDATA-2481]Adding SDV Testcases for SDKwriter

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2308
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5940/



---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread dhatchayani
Github user dhatchayani commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
retest this please


---


[GitHub] carbondata issue #2304: [CARBONDATA-2477]Fixed No dictionary Complex type wi...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2304
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4966/



---


[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...

2018-05-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2306


---


[jira] [Resolved] (CARBONDATA-2479) Multiple issue in sdk writer and external table flow

2018-05-17 Thread Ravindra Pesala (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala resolved CARBONDATA-2479.
-
   Resolution: Fixed
 Assignee: Ajantha Bhat
Fix Version/s: 1.4.0

> Multiple issue in sdk writer and external table flow
> 
>
> Key: CARBONDATA-2479
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2479
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Ajantha Bhat
>Assignee: Ajantha Bhat
>Priority: Major
> Fix For: 1.4.0
>
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
>     Multiple issues:
>     fixed external table path display
>     fixed default value for array in AVRO
>     fixed NPE when delete folder before the second select query
>     fixed primetive time stamp sdk load Issue fix
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2308: [CARBONDATA-2481]Adding SDV Testcases for SDKwriter

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2308
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4785/



---


[GitHub] carbondata issue #2304: [CARBONDATA-2477]Fixed No dictionary Complex type wi...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2304
  
LGTM


---


[GitHub] carbondata pull request #2304: [CARBONDATA-2477]Fixed No dictionary Complex ...

2018-05-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2304


---


[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-17 Thread gvramana
Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2313#discussion_r188960024
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java 
---
@@ -152,14 +152,15 @@ public synchronized boolean isMemoryAvailable() {
 return memoryUsed > totalMemory;
   }
 
-  public long getUsableMemory() {
+  public synchronized long getUsableMemory() {
--- End diff --

Not required Lock


---



[jira] [Resolved] (CARBONDATA-2477) No dictionary Complex type with double/date/decimal data type table creation is failing

2018-05-17 Thread Ravindra Pesala (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala resolved CARBONDATA-2477.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> No dictionary Complex type with double/date/decimal data type table creation 
> is failing
> ---
>
> Key: CARBONDATA-2477
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2477
> Project: CarbonData
>  Issue Type: Bug
>Reporter: kumar vishal
>Assignee: kumar vishal
>Priority: Major
> Fix For: 1.4.0
>
>  Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> Problem: SDK create table with No Dictionary complex type is failing when 
> complex type child contain double/date/decimal data type
>  Solution: In complex type validation , it is not allowing 
> double/date/decimal data , need to remove the same
> Changed no dictionary complex type storage format, instead of storing length 
> in int , now storing in short to reduce storage space



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-17 Thread gvramana
Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2313#discussion_r188965798
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/datatype/ArrayType.java 
---
@@ -31,6 +31,31 @@ public boolean isComplexType() {
 return true;
   }
 
+  @Override
+  public boolean equals(Object obj) {
+if (this == obj) {
+  return true;
+}
+if (obj == null) {
+  return false;
+}
+if (!(obj instanceof ArrayType)) {
+  return false;
+}
+if (!this.getName().equalsIgnoreCase(((ArrayType) obj).getName())) {
--- End diff --

Equals and hash should be implemented for all datatypes.Each required to 
have different logic
1) Nestedtype, should also include childType.equals.
2) Decimal type should consider precision, scala  etc.


---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5941/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4967/



---


[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-17 Thread gvramana
Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2313#discussion_r188969041
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalType.java
 ---
@@ -44,4 +44,35 @@ public int getScale() {
   public void setScale(int scale) {
 this.scale = scale;
   }
+
+  @Override
+  public boolean equals(Object obj) {
+if (this == obj) {
+  return true;
+}
+if (obj == null) {
+  return false;
+}
+if (!(obj instanceof DecimalType)) {
+  return false;
+}
+if (!this.getName().equalsIgnoreCase(((DecimalType) obj).getName())) {
+  return false;
+}
+if (this.precision != ((DecimalType) obj).precision) {
+  return false;
+}
+if (this.scale != ((DecimalType) obj).scale) {
+  return false;
+}
+return true;
+  }
+
+  @Override
+  public int hashCode() {
+final int prime = 31;
+int result = 1;
+result = prime * result + getName().hashCode();
--- End diff --

should include precision.hash and scala.hash


---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4786/



---


[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-17 Thread gvramana
Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2313#discussion_r188972300
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/reader/CarbonDictionaryMetadataReaderImpl.java
 ---
@@ -128,6 +131,9 @@ public CarbonDictionaryMetadataReaderImpl(
 break;
   }
 }
+if (null == dictionaryChunkMeta) {
+  throw new IOException("Last dictionary chunk does not exist");
--- End diff --

Message should be "Matching dictionary chunk for offset not found"


---


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4787/



---


[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2246#discussion_r188972807
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java
 ---
@@ -175,6 +175,18 @@ public DiskBasedDMSchemaStorageProvider(String 
storePath) {
 }
   }
 
+  private void checkAndReloadDataMapSchemasWithoutNewFile() throws 
IOException {
--- End diff --

It is duplicated to below method, just pass boolean to handle in below 
method instead of duplicating it


---


[GitHub] carbondata pull request #2235: [CARBONDATA-2465] Improve the carbondata file...

2018-05-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2235


---


[jira] [Resolved] (CARBONDATA-2465) Improve the carbondata file reliability in data load when direct hdfs write is enabled

2018-05-17 Thread Kunal Kapoor (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kunal Kapoor resolved CARBONDATA-2465.
--
   Resolution: Fixed
Fix Version/s: 1.4.0

> Improve the carbondata file reliability in data load when direct hdfs write 
> is enabled
> --
>
> Key: CARBONDATA-2465
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2465
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Kanaka Kumar Avvaru
>Assignee: Kanaka Kumar Avvaru
>Priority: Major
> Fix For: 1.4.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> At present if we enable direct write on HDFS, file is written with 
> replication of 1. As the setReplication is asyn operation, it can cause data 
> loss if any DN is down before NN finishes the replication.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5944/



---


[GitHub] carbondata issue #2299: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-17 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue:

https://github.com/apache/carbondata/pull/2299
  
@ravipesala : please review


---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4968/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4789/



---


[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-17 Thread gvramana
Github user gvramana commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2313#discussion_r188992675
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
 ---
@@ -98,9 +98,11 @@ private void ifDefaultValueMatchesFilter() {
 } else if (!msrColEvalutorInfoList.isEmpty() && 
!isMeasurePresentInCurrentBlock[0]) {
   CarbonMeasure measure = 
this.msrColEvalutorInfoList.get(0).getMeasure();
   byte[] defaultValue = measure.getDefaultValue();
+  SerializableComparator comparatorTmp =
--- End diff --

if comparator is null then can create tmpComparator.


---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5945/



---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4969/



---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5943/



---


[GitHub] carbondata pull request #2316: [WIP] Removed method to accept carbon schema ...

2018-05-17 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/carbondata/pull/2316

[WIP] Removed method to accept carbon schema in avro writer

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/carbondata avro_carbon_changes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2316


commit 0bec8317c2bda90267dd9ff4fee13f4d40333957
Author: kunal642 
Date:   2018-05-17T15:30:50Z

removed method to accept carbon schema in avro writer




---


[GitHub] carbondata pull request #2315: [WIP] added validation for null avro type

2018-05-17 Thread kunal642
Github user kunal642 closed the pull request at:

https://github.com/apache/carbondata/pull/2315


---


[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2295
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4788/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5947/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4791/



---


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4790/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4792/



---


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5946/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5948/



---


[GitHub] carbondata issue #2235: [CARBONDATA-2465] Improve the carbondata file reliab...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2235
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4970/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5949/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4793/



---


[GitHub] carbondata issue #2308: [CARBONDATA-2481]Adding SDV Testcases for SDKwriter

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2308
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4971/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5950/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4972/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4794/



---


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4973/



---


[GitHub] carbondata issue #2310: [CARBONDATA-2484][LUCENE]Refactor distributable code...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2310
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4974/



---


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4975/



---


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4976/



---


[GitHub] carbondata issue #2315: [WIP] added validation for null avro type

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2315
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4977/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5951/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4795/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4978/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4979/



---


[GitHub] carbondata issue #2316: [WIP] Removed method to accept carbon schema in avro...

2018-05-17 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2316
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4980/



---


  1   2   >