[GitHub] carbondata issue #2628: WIP: Support zstd as column compressor in final stor...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2628 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6610/ ---
[GitHub] carbondata issue #2628: WIP: Support zstd as column compressor in final stor...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2628 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7886/ ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2620 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6608/ ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2620 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7884/ ---
[GitHub] carbondata issue #2628: WIP: Support zstd as column compressor in final stor...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2628 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6247/ ---
[GitHub] carbondata issue #2628: WIP: Support zstd as column compressor in final stor...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2628 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6246/ ---
[GitHub] carbondata issue #2628: WIP: Support zstd as column compressor in final stor...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2628 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6609/ ---
[GitHub] carbondata issue #2628: WIP: Support zstd as column compressor in final stor...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2628 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7885/ ---
[GitHub] carbondata pull request #2628: WIP: Support zstd as column compressor in fin...
GitHub user xuchuanyin opened a pull request: https://github.com/apache/carbondata/pull/2628 WIP: Support zstd as column compressor in final store 1. add zstd compressor for compressing column data 2. add zstd support in thrift 3. legacy store is not considered in this commit Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuchuanyin/carbondata 0810_support_zstd_compressor_final_store Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2628.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2628 commit c19c90852feaf33eaaca93a2bfdb3783c40159af Author: xuchuanyin Date: 2018-08-10T14:02:57Z Support zstd as column compressor in final store 1. add zstd compressor for compressing column data 2. add zstd support in thrift 3. legacy store is not considered in this commit ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2620 retest this please ---
[GitHub] carbondata issue #2619: [CARBONDATA-2819] Fixed cannot drop preagg datamap o...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2619 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6607/ ---
[GitHub] carbondata issue #2619: [CARBONDATA-2819] Fixed cannot drop preagg datamap o...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2619 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7883/ ---
[GitHub] carbondata issue #2619: [CARBONDATA-2819] Fixed cannot drop preagg datamap o...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2619 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6245/ ---
[GitHub] carbondata issue #2619: [CARBONDATA-2819] Fixed cannot drop preagg datamap o...
Github user Sssan520 commented on the issue: https://github.com/apache/carbondata/pull/2619 retest this please ---
[GitHub] carbondata pull request #2619: [CARBONDATA-2819] Fixed cannot drop preagg da...
Github user Sssan520 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2619#discussion_r209208751 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDropDataMapCommand.scala --- @@ -114,12 +114,6 @@ case class CarbonDropDataMapCommand( LOGGER.audit(s"Deleting datamap [$dataMapName] under table [$tableName]") // drop index datamap on the main table -if (mainTable != null && --- End diff -- when drop preagg datamap , should delete the datamap schema file and main tableinfo schema info. ---
[GitHub] carbondata issue #2623: [CARBONDATA-2844] add sk ak to file factory on creat...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2623 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6604/ ---
[GitHub] carbondata pull request #2619: [CARBONDATA-2819] Fixed cannot drop preagg da...
Github user Sssan520 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2619#discussion_r209206775
--- Diff:
integration/spark2/src/main/java/org/apache/carbondata/datamap/PreAggregateDataMapProvider.java
---
@@ -77,13 +79,15 @@ private void validateDmProperty(DataMapSchema
dataMapSchema)
}
@Override
- public void cleanMeta() {
+ public void cleanMeta() throws IOException {
+DataMapSchema dataMapSchema = getDataMapSchema();
dropTableCommand = new CarbonDropTableCommand(
true,
new Some<>(dbName),
tableName,
true);
dropTableCommand.processMetadata(sparkSession);
+
DataMapStoreManager.getInstance().dropDataMapSchema(dataMapSchema.getDataMapName());
--- End diff --
when create a mv datamap, will create a datamap scheme file and register a
datamap catalog; then when drop the mv datamap,will delete the datamap schema
file and unregister the datamap catalog.
---
[GitHub] carbondata issue #2623: [CARBONDATA-2844] add sk ak to file factory on creat...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2623 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7881/ ---
[GitHub] carbondata pull request #2619: [CARBONDATA-2819] Fixed cannot drop preagg da...
Github user Sssan520 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2619#discussion_r209205953
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/PreAggregateDataMapExample.scala
---
@@ -175,7 +175,7 @@ object PreAggregateDataMapExample {
// create pre-aggregate table by datamap
spark.sql("""
- CREATE datamap preagg_avg on table personTable using 'preaggregate'
as
+ CREATE datamap preagg_avg_dm on table personTable using
'preaggregate' as
--- End diff --
As datamap name is a global, there is already the same datamap name before.
---
[GitHub] carbondata issue #2619: [CARBONDATA-2819] Fixed cannot drop preagg datamap o...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2619 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6244/ ---
[GitHub] carbondata issue #2619: [CARBONDATA-2819] Fixed cannot drop preagg datamap o...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2619 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7882/ ---
[GitHub] carbondata issue #2619: [CARBONDATA-2819] Fixed cannot drop preagg datamap o...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2619 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6605/ ---
[GitHub] carbondata issue #2623: [CARBONDATA-2844] add sk ak to file factory on creat...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2623 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6243/ ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2620 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6603/ ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2620 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7880/ ---
[GitHub] carbondata issue #2624: [CARBONDATA-2845][BloomDataMap] Merge bloom index fi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2624 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6601/ ---
[GitHub] carbondata issue #2624: [CARBONDATA-2845][BloomDataMap] Merge bloom index fi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2624 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7878/ ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2620 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6242/ ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2620 retest this please ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2620 @chenliang613, please take a look. ---
[GitHub] carbondata issue #2620: [CARBONDATA-2839] Add custom compaction example
Github user Xaprice commented on the issue: https://github.com/apache/carbondata/pull/2620 retest this please ---
