[GitHub] carbondata issue #3043: Carbondata 3213
Github user iture123 commented on the issue: https://github.com/apache/carbondata/pull/3043 find /data/carbondata -name "*.java" | xargs grep -Lr "Licensed to the Apache Software Foundation" | xargs sed -e '1 r license.java' -e '1N' -i By this command,I add the license. ---
[GitHub] carbondata issue #3043: Carbondata 3213
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3043 Can one of the admins verify this patch? ---
[GitHub] carbondata pull request #3043: Carbondata 3213
GitHub user iture123 opened a pull request: https://github.com/apache/carbondata/pull/3043 Carbondata 3213 Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [N] Any interfaces changed? - [N] Any backward compatibility impacted? - [N] Document update required? - [N] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ N] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. for 3 md files and 2 java files add license. You can merge this pull request into a Git repository by running: $ git pull https://github.com/iture123/carbondata CARBONDATA-3213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3043.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3043 commit 136e2316e248011b066aec6502484669afc23086 Author: iture <1011699225@...> Date: 2019-01-01T07:08:41Z [CARBONDATA-3213]add license for java commit d25818f6a91aeb56d5d6e0778e750146bc299198 Author: iture <1011699225@...> Date: 2019-01-01T07:16:12Z Merge branch 'master' of https://github.com/apache/carbondata into CARBONDATA-3213 commit a629a7414b17405f89448b109f7f2d22c2c33ba5 Author: iture <1011699225@...> Date: 2019-01-01T07:31:15Z [CARBONDATA-3213]add license for md ---
[jira] [Resolved] (CARBONDATA-3209) Remove unused import
[ https://issues.apache.org/jira/browse/CARBONDATA-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3209. - Resolution: Resolved > Remove unused import > > > Key: CARBONDATA-3209 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3209 > Project: CarbonData > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: xubo245 >Assignee: EdisonWang >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Remove unused import,for example: > {code:java} > import java.io.File > import org.apache.commons.lang3.StringUtils > import scala.util.Random > import org.apache.spark.SparkEnv > {code} > in org.apache.spark.sql.execution.datasources.SparkCarbonTableFormat。 > There are some unused import in > org.apache.carbondata.spark.util.GlobalDictionaryUtil,org.apache.carbondata.core.util.DataTypeUtilTest。 > Please find other unused import in other class -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #3038: [CARBONDATA-3209] Remove unused import
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3038 ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 @WangGuangxin Thank you for working on it. ---
[GitHub] carbondata issue #3042: There are some spell error in CarbonData
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3042 @WangQingNa 1. Please optimize this titleï¼ for example: [CARBONDATA-3206] Fix some spell errors in CarbonData. 2. Please finish the checklist 3.Please fix the CI errors. ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/3038 LGTM ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 LGTM ---
[GitHub] carbondata issue #3042: There are some spell error in CarbonData
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3042 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10354/ ---
[GitHub] carbondata issue #3042: There are some spell error in CarbonData
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3042 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2100/ ---
[GitHub] carbondata issue #3042: There are some spell error in CarbonData
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3042 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2305/ ---
[GitHub] carbondata pull request #3042: There are some spell error in CarbonData
GitHub user WangQingNa opened a pull request: https://github.com/apache/carbondata/pull/3042 There are some spell error in CarbonData numberofColumnPerIO => numberOfColumnPerIO iexpectedMinSizePerNode => expectedMinSizePerNodeInt parentname => parentName nullformat => nullFormat Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangQingNa/carbondata wangqingna01 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3042.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3042 commit d5b38794c4f25c9968b6a86d2284238a2f19617f Author: WangQingNa Date: 2019-01-01T02:19:13Z numberofColumnPerIOString. => numberOfColumnPerIOString numberofColumnPerIO => numberOfColumnPerIO iexpectedMinSizePerNode => expectedMinSizePerNodeInt parentname => parentName nullformat => nullFormat ---
[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:
Github user WangQingNa closed the pull request at: https://github.com/apache/carbondata/pull/3040 ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import
Github user WangGuangxin commented on the issue: https://github.com/apache/carbondata/pull/3038 > @WangGuangxin Please optimize the title: [CARBONDATA-3209] Remove unused import Done ---
[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2304/ ---
[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10353/ ---
[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10352/ ---
[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2099/ ---
[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2303/ ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2302/ ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10351/ ---
[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2098/ ---
[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...
Github user xiaohui0318 commented on the issue: https://github.com/apache/carbondata/pull/3032 fix already.tks ---
[GitHub] carbondata issue #3040: There are some spell error in CarbonData:
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10350/ ---
[GitHub] carbondata issue #3040: There are some spell error in CarbonData:
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2301/ ---
[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596104 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -59,13 +64,13 @@ object CarbonSparkUtil { table) } - /** - * return's the formatted column comment if column comment is present else empty("") - * - * @param carbonColumn - * @return - */ - def getColumnComment(carbonColumn: CarbonColumn): String = { + /** +* return's the formatted column comment if column comment is present else empty("") +* +* @param carbonColumn the column of carbonTable +* @return string +*/ + def getColumnComment (carbonColumn: CarbonColumn): String = { --- End diff -- remove blank before '(' ---
[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/3032 please remove blank before '(' ---
[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596094 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -28,11 +29,15 @@ import org.apache.carbondata.core.metadata.schema.table.{CarbonTable, TableInfo} import org.apache.carbondata.core.metadata.schema.table.column.{CarbonColumn, ColumnSchema} import org.apache.carbondata.core.util.CarbonUtil -case class TransformHolder(rdd: Any, mataData: CarbonMetaData) +case class TransformHolder (rdd: Any, mataData: CarbonMetaData) + + /** + * carbon spark common methods + */ object CarbonSparkUtil { - def createSparkMeta(carbonTable: CarbonTable): CarbonMetaData = { + def createSparkMeta (carbonTable: CarbonTable): CarbonMetaData = { --- End diff -- remove blank before '(' ---
[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596067 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -28,11 +29,15 @@ import org.apache.carbondata.core.metadata.schema.table.{CarbonTable, TableInfo} import org.apache.carbondata.core.metadata.schema.table.column.{CarbonColumn, ColumnSchema} import org.apache.carbondata.core.util.CarbonUtil -case class TransformHolder(rdd: Any, mataData: CarbonMetaData) +case class TransformHolder (rdd: Any, mataData: CarbonMetaData) --- End diff -- remove blank before '(' ---
[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596100 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -50,7 +55,7 @@ object CarbonSparkUtil { CarbonUtil.hasAggregationDataMap(carbonTable)) } - def createCarbonRelation(tableInfo: TableInfo, tablePath: String): CarbonRelation = { + def createCarbonRelation (tableInfo: TableInfo, tablePath: String): CarbonRelation = { --- End diff -- remove blank before '(' ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2097/ ---
[GitHub] carbondata pull request #3037: [CARBONDATA-3190] Open example module code st...
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3037#discussion_r244593712 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/CarbonReaderExample.java --- @@ -33,127 +29,129 @@ import org.apache.carbondata.sdk.file.Field; import org.apache.carbondata.sdk.file.Schema; +import org.apache.commons.io.FileUtils; --- End diff -- No, org.apache.carbondata is in front of this. ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 add to whitelist ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 @WangGuangxin Please optimize the title: [CARBONDATA-3209] Remove unused import ---
[GitHub] carbondata issue #3040: There are some spell error in CarbonData:
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2096/ ---
[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592133 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/NonDictionaryFieldConverterImpl.java --- @@ -34,21 +34,21 @@ private int index; - private String nullformat; --- End diff -- Please search in the whole project and optimize it. ---
[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592098 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java --- @@ -43,7 +43,7 @@ /** * @return - columns parent name */ - String getParentname(); --- End diff -- Please search in the whole project and optimize it. ---
[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592034 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -55,7 +55,7 @@ /** * parent column name */ - private String parentname; --- End diff -- Please search in the whole project and optimize it. ---
[GitHub] carbondata issue #3040: There are some spell error in CarbonData:
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3040 @WangQingNa Please optimize the title and finish the checklist in the content of this PR. ---
[GitHub] carbondata issue #3040: There are some spell error in CarbonData:
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3040 add to whitelist ---
[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/3037 just one comment, others LGTM. ---
[GitHub] carbondata pull request #3037: [CARBONDATA-3190] Open example module code st...
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3037#discussion_r244585940 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/CarbonReaderExample.java --- @@ -33,127 +29,129 @@ import org.apache.carbondata.sdk.file.Field; import org.apache.carbondata.sdk.file.Schema; +import org.apache.commons.io.FileUtils; --- End diff -- this line need to place in front of packege 'org.apache.carbondata', right? ---
[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2300/ ---
[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10349/ ---
[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2095/ ---
[jira] [Created] (CARBONDATA-3218) Schema is not refreshing in presto which is changed in spark carbon.
Ravindra Pesala created CARBONDATA-3218: --- Summary: Schema is not refreshing in presto which is changed in spark carbon. Key: CARBONDATA-3218 URL: https://issues.apache.org/jira/browse/CARBONDATA-3218 Project: CarbonData Issue Type: New Feature Reporter: Ravindra Pesala Schema which is updated in spark is not reflecting in presto. which results in wrong query result in presto. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #3041: [WIP] Fix schema refresh and wrong query resu...
GitHub user ravipesala opened a pull request: https://github.com/apache/carbondata/pull/3041 [WIP] Fix schema refresh and wrong query result issues in presto. Problem: Schema which is updated in spark is not reflecting in presto. which results in wrong query result in presto. Solution: Update the schema in presto whenever the schema changed in spark. And also override the putNulls method in all presto readers to work for null data scenarios. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ravipesala/incubator-carbondata presto-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3041.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3041 commit de54ec7faa1365e044f7b34971135c52efa00255 Author: ravipesala Date: 2018-12-31T11:50:24Z Fix schema refresh issues in presto. ---
[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:
GitHub user WangQingNa opened a pull request: https://github.com/apache/carbondata/pull/3040 There are some spell error in CarbonData: parentname => parentName nullformat => nullFormat Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangQingNa/carbondata WangQingNa Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3040.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3040 commit cababb284ac6f7eb2b99bd1c3f7fab0dc7bc8e80 Author: wangqingna Date: 2018-12-31T10:49:34Z There are some spell error in CarbonData: parentname => parentName nullformat => nullFormat ---
[GitHub] carbondata issue #3040: There are some spell error in CarbonData:
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Can one of the admins verify this patch? ---
[GitHub] carbondata issue #3039: [CARBONDATA-3217] Optimize implicit filter expressio...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3039 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2299/ ---
[GitHub] carbondata issue #3039: [CARBONDATA-3217] Optimize implicit filter expressio...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3039 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10348/ ---
[GitHub] carbondata issue #3039: [CARBONDATA-3217] Optimize implicit filter expressio...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3039 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2094/ ---
[jira] [Created] (CARBONDATA-3217) Optimize implicit filter expression performance by removing extra serialization
Manish Gupta created CARBONDATA-3217: Summary: Optimize implicit filter expression performance by removing extra serialization Key: CARBONDATA-3217 URL: https://issues.apache.org/jira/browse/CARBONDATA-3217 Project: CarbonData Issue Type: Bug Reporter: Manish Gupta # Currently all the filter values are getting serialized for all the tasks which is increasing the schedular delay thereby impacting the query performance. # For each task 2 times deserialization is taking place in the executor side which is not required. 1 time is suficient -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #3039: [WIP] Optimize implicit filter expression per...
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/3039 [WIP] Optimize implicit filter expression performance by removing extra serialization Fixed performance issue for Implicit filter column 1. Removed serialization all the implicit filter values in each task. Instead serialized values only for the blocks going to particular task 2. Removed 2 times deserialization of implicit filter values in executor for each task. 1 time is sufficient Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manishgupta88/carbondata implicit_column_filter_serialization Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3039.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3039 commit 73390e08aad788698dd9f12e3513a4a4814afd73 Author: manishgupta88 Date: 2018-12-27T09:48:07Z Fixed performance issue for Implicit filter column 1. Removed serialization all the implicit filter values in each task. Instead serialized values only for the blocks going to particular task 2. Removed 2 times deserialization of implicit filter values in executor for each task. 1 time is sufficient ---
[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Can one of the admins verify this patch? ---
[GitHub] carbondata pull request #3038: [CARBONDATA-3209]remove unused import
GitHub user WangGuangxin opened a pull request: https://github.com/apache/carbondata/pull/3038 [CARBONDATA-3209]remove unused import Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangGuangxin/carbondata carbondata-3209 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3038.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3038 commit ebf870f50c605706cc309c8868b0b8b5e9dcbffe Author: wangguangxin.cn Date: 2018-12-31T08:23:38Z remove unused import ---