[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-498947605 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11715/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-498929872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3448/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK
ajantha-bhat commented on a change in pull request #3254: [CARBONDATA-3411] Fix
clear datamaps logs an exception in SDK
URL: https://github.com/apache/carbondata/pull/3254#discussion_r290572277
##
File path:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
##
@@ -511,44 +511,41 @@ public void clearDataMaps(AbsoluteTableIdentifier
identifier) {
*/
public void clearDataMaps(AbsoluteTableIdentifier identifier, boolean
launchJob) {
String tableUniqueName =
identifier.getCarbonTableIdentifier().getTableUniqueName();
-CarbonTable carbonTable = getCarbonTable(identifier);
-if (launchJob && CarbonProperties.getInstance()
-.isDistributedPruningEnabled(identifier.getDatabaseName(),
identifier.getTableName())) {
+if (launchJob) {
+ String jobClassName;
+ if (CarbonProperties.getInstance()
+ .isDistributedPruningEnabled(identifier.getDatabaseName(),
identifier.getTableName())) {
+jobClassName = DataMapUtil.DISTRIBUTED_JOB_NAME;
+ } else {
+jobClassName = DataMapUtil.EMBEDDED_JOB_NAME;
+ }
+ // carbon table need to lookup only if launch job is set.
+ CarbonTable carbonTable = getCarbonTable(identifier);
if (null != carbonTable) {
try {
- DataMapUtil.executeClearDataMapJob(carbonTable,
DataMapUtil.DISTRIBUTED_JOB_NAME);
+ DataMapUtil.executeClearDataMapJob(carbonTable, jobClassName);
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256#issuecomment-498722296 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11714/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables
CarbonDataQA commented on issue #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables URL: https://github.com/apache/carbondata/pull/3255#issuecomment-498713586 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3648/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256#issuecomment-498710274 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3650/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables
CarbonDataQA commented on issue #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables URL: https://github.com/apache/carbondata/pull/3255#issuecomment-498693688 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11712/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3245: [CARBONDATA-3398] Handled show cache for index server and MV
CarbonDataQA commented on issue #3245: [CARBONDATA-3398] Handled show cache for index server and MV URL: https://github.com/apache/carbondata/pull/3245#issuecomment-498693554 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11713/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3245: [CARBONDATA-3398] Handled show cache for index server and MV
CarbonDataQA commented on issue #3245: [CARBONDATA-3398] Handled show cache for index server and MV URL: https://github.com/apache/carbondata/pull/3245#issuecomment-498687425 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3649/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256#issuecomment-498683981 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3447/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
ajantha-bhat commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256#issuecomment-498676362 @kumarvishal09 : please check This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat opened a new pull request #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
ajantha-bhat opened a new pull request #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256 problem : io.netty out of direct memory exception in arrow integration cause: In ArrowConverter, allocator is not closed solution: close the allocator in arrowConverter. Also handle the problems in test utility API Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? NA - [ ] Any backward compatibility impacted? NA - [ ] Document update required? NA - [ ] Testing done done. Updated UT. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (CARBONDATA-3413) Arrow allocators gives OutOfMemory error when test with hugedata
Ajantha Bhat created CARBONDATA-3413: Summary: Arrow allocators gives OutOfMemory error when test with hugedata Key: CARBONDATA-3413 URL: https://issues.apache.org/jira/browse/CARBONDATA-3413 Project: CarbonData Issue Type: Bug Reporter: Ajantha Bhat Arrow allocators gives OutOfMemory error when test with hugedata problem: OOM exception when in arrow with huge data cause: In ArrowConverter, allocator is not closed solution: close the allocator in arrowConverter. Also handle the problems in test utility API -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [carbondata] CarbonDataQA commented on issue #3245: [CARBONDATA-3398] Handled show cache for index server and MV
CarbonDataQA commented on issue #3245: [CARBONDATA-3398] Handled show cache for index server and MV URL: https://github.com/apache/carbondata/pull/3245#issuecomment-498662183 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3446/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables
CarbonDataQA commented on issue #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables URL: https://github.com/apache/carbondata/pull/3255#issuecomment-498661556 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3445/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on a change in pull request #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK
xubo245 commented on a change in pull request #3254: [CARBONDATA-3411] Fix
clear datamaps logs an exception in SDK
URL: https://github.com/apache/carbondata/pull/3254#discussion_r290274854
##
File path:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
##
@@ -511,44 +511,41 @@ public void clearDataMaps(AbsoluteTableIdentifier
identifier) {
*/
public void clearDataMaps(AbsoluteTableIdentifier identifier, boolean
launchJob) {
String tableUniqueName =
identifier.getCarbonTableIdentifier().getTableUniqueName();
-CarbonTable carbonTable = getCarbonTable(identifier);
-if (launchJob && CarbonProperties.getInstance()
-.isDistributedPruningEnabled(identifier.getDatabaseName(),
identifier.getTableName())) {
+if (launchJob) {
+ String jobClassName;
+ if (CarbonProperties.getInstance()
+ .isDistributedPruningEnabled(identifier.getDatabaseName(),
identifier.getTableName())) {
+jobClassName = DataMapUtil.DISTRIBUTED_JOB_NAME;
+ } else {
+jobClassName = DataMapUtil.EMBEDDED_JOB_NAME;
+ }
+ // carbon table need to lookup only if launch job is set.
+ CarbonTable carbonTable = getCarbonTable(identifier);
if (null != carbonTable) {
try {
- DataMapUtil.executeClearDataMapJob(carbonTable,
DataMapUtil.DISTRIBUTED_JOB_NAME);
+ DataMapUtil.executeClearDataMapJob(carbonTable, jobClassName);
Review comment:
Only when null != carbonTable, it will use jobClassName. So can you move
`
String jobClassName;
.isDistributedPruningEnabled(identifier.getDatabaseName(),
identifier.getTableName())) { if (CarbonProperties.getInstance()
.isDistributedPruningEnabled(identifier.getDatabaseName(),
identifier.getTableName())) {
jobClassName = DataMapUtil.DISTRIBUTED_JOB_NAME;
} else {
jobClassName = DataMapUtil.EMBEDDED_JOB_NAME;
}
`
into null != carbonTable?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 opened a new pull request #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables
kunal642 opened a new pull request #3255: [CARBONDATA-3412] Empty results are displayed for non-transactional tables URL: https://github.com/apache/carbondata/pull/3255 **Solution:** Added a check for nonTransactional table when generating the read committed scope. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (CARBONDATA-3412) For Non-transactional tables empty results are displayed with index server enabled
Kunal Kapoor created CARBONDATA-3412: Summary: For Non-transactional tables empty results are displayed with index server enabled Key: CARBONDATA-3412 URL: https://issues.apache.org/jira/browse/CARBONDATA-3412 Project: CarbonData Issue Type: Bug Reporter: Kunal Kapoor Assignee: Kunal Kapoor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-498569102 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3647/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-498561931 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11711/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-498533689 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3444/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
