[GitHub] [carbondata] CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256#issuecomment-500712231 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3694/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500711046 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3696/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] Indhumathi27 opened a new pull request #3274: [CARBONDATA-3398] Fix drop metacache on table having mv datamap
Indhumathi27 opened a new pull request #3274: [CARBONDATA-3398] Fix drop metacache on table having mv datamap URL: https://github.com/apache/carbondata/pull/3274 This PR dependent on [PR-3245](https://github.com/apache/carbondata/pull/3245) Fixed drop metacache on table having mv datamap - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [x] Testing done - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500709632 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3493/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500709391 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11763/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500698791 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3492/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
CarbonDataQA commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256#issuecomment-500696445 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3490/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
CarbonDataQA commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500696151 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3491/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3260: [HOTFIX] Fix compatibility issue with page size
CarbonDataQA commented on issue #3260: [HOTFIX] Fix compatibility issue with page size URL: https://github.com/apache/carbondata/pull/3260#issuecomment-500696150 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3489/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration
ajantha-bhat commented on issue #3256: [CARBONDATA-3413] Fix io.netty out of direct memory exception in arrow integration URL: https://github.com/apache/carbondata/pull/3256#issuecomment-500693954 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500694072 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3260: [HOTFIX] Fix compatibility issue with page size
ajantha-bhat commented on issue #3260: [HOTFIX] Fix compatibility issue with page size URL: https://github.com/apache/carbondata/pull/3260#issuecomment-500693938 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (CARBONDATA-3414) when Insert into partition table fails exception doesn't print reason.
[ https://issues.apache.org/jira/browse/CARBONDATA-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-3414: - Description: problem: when Insert into partition table fails, exception doesn't print reason. cause: Exception was caught , but error message was not from that exception. solution: throw the exception directly Steps to reproduce: # Open multiple spark beeline (say 10) # Create a carbon table with partition # Insert overwrite to carbon table from all the 10 beeline concurrently # some insert overwrite will be success and some will fail due to non-availability of lock even after retry. # For the failed insert into sql, Exception is just "DataLoadFailure: " no error reason is printed. Need to print the valid error reason for the failure. was: problem: when Insert into partition table fails, exception doesn't print reason. cause: Exception was caught , but error message was not from that exception. solution: throw the exception directly Steps to reproduce: # Open multiple spark beeline (say 10) # Create a carbon table with partition # Insert overwrite to carbon table from all the 10 beeline concurrently # some insert overwrite will be success and some will fail due to availability of lock even after retry. # For the failed insert into sql, Exception is just "DataLoadFailure: " no error reason is printed. Need to print the valid error reason for the failure. > when Insert into partition table fails exception doesn't print reason. > -- > > Key: CARBONDATA-3414 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3414 > Project: CarbonData > Issue Type: Bug >Reporter: Ajantha Bhat >Priority: Minor > > problem: when Insert into partition table fails, exception doesn't print > reason. > cause: Exception was caught , but error message was not from that exception. > solution: throw the exception directly > > Steps to reproduce: > # Open multiple spark beeline (say 10) > # Create a carbon table with partition > # Insert overwrite to carbon table from all the 10 beeline concurrently > # some insert overwrite will be success and some will fail due to > non-availability of lock even after retry. > # For the failed insert into sql, Exception is just "DataLoadFailure: " no > error reason is printed. > Need to print the valid error reason for the failure. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [carbondata] ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500692380  @xubo245 : updated the steps to reproduce in JIRA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (CARBONDATA-3414) when Insert into partition table fails exception doesn't print reason.
[ https://issues.apache.org/jira/browse/CARBONDATA-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-3414: - Description: problem: when Insert into partition table fails, exception doesn't print reason. cause: Exception was caught , but error message was not from that exception. solution: throw the exception directly Steps to reproduce: # Open multiple spark beeline (say 10) # Create a carbon table with partition # Insert overwrite to carbon table from all the 10 beeline concurrently # some insert overwrite will be success and some will fail due to availability of lock even after retry. # For the failed insert into sql, Exception is just "DataLoadFailure: " no error reason is printed. Need to print the valid error reason for the failure. was: problem: when Insert into partition table fails, exception doesn't print reason. cause: Exception was caught , but error message was not from that exception. solution: throw the exception directly > when Insert into partition table fails exception doesn't print reason. > -- > > Key: CARBONDATA-3414 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3414 > Project: CarbonData > Issue Type: Bug >Reporter: Ajantha Bhat >Priority: Minor > > problem: when Insert into partition table fails, exception doesn't print > reason. > cause: Exception was caught , but error message was not from that exception. > solution: throw the exception directly > > Steps to reproduce: > # Open multiple spark beeline (say 10) > # Create a carbon table with partition > # Insert overwrite to carbon table from all the 10 beeline concurrently > # some insert overwrite will be success and some will fail due to > availability of lock even after retry. > # For the failed insert into sql, Exception is just "DataLoadFailure: " no > error reason is printed. > Need to print the valid error reason for the failure. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500686340 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3691/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL
CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL URL: https://github.com/apache/carbondata/pull/3209#issuecomment-500683522 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11758/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL
CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL URL: https://github.com/apache/carbondata/pull/3209#issuecomment-500683524 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3692/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500683521 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11757/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
xubo245 commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500674847 Please list how to reproduce this issue of CARBONDATA-3414 in details. Please list test step, test code, and expected output. even though tested manually. We should know how to verify the fixed result whatever test case or not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500666427 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3488/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jack86596 commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
jack86596 commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500658676 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500655697 @xubo: It's a non functional (concurrent scenario insert overwrite), cannot know which insert fails in concurrent. Hence we will not know which statement to intercept exception. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column
CarbonDataQA commented on issue #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column URL: https://github.com/apache/carbondata/pull/3272#issuecomment-500567347 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11752/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null.
CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null. URL: https://github.com/apache/carbondata/pull/3273#issuecomment-500566803 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11755/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null.
CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null. URL: https://github.com/apache/carbondata/pull/3273#issuecomment-500566229 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11756/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null.
CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null. URL: https://github.com/apache/carbondata/pull/3273#issuecomment-500544763 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3690/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column
CarbonDataQA commented on issue #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column URL: https://github.com/apache/carbondata/pull/3272#issuecomment-500537924 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3687/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null.
CarbonDataQA commented on issue #3273: [CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null. URL: https://github.com/apache/carbondata/pull/3273#issuecomment-500533922 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3487/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL
CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL URL: https://github.com/apache/carbondata/pull/3209#issuecomment-500526155 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11753/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3074: [CARBONDATA-3250] Optimize hive doc
CarbonDataQA commented on issue #3074: [CARBONDATA-3250] Optimize hive doc URL: https://github.com/apache/carbondata/pull/3074#issuecomment-500519228 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11754/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3074: [CARBONDATA-3250] Optimize hive doc
CarbonDataQA commented on issue #3074: [CARBONDATA-3250] Optimize hive doc URL: https://github.com/apache/carbondata/pull/3074#issuecomment-500508507 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3689/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL
CarbonDataQA commented on issue #3209: [CARBONDATA-3373] Optimize scenes with in numbers in SQL URL: https://github.com/apache/carbondata/pull/3209#issuecomment-500506877 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3688/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 opened a new pull request #3273: [CARBONDATA-3363] Fix the IllegalArgumentException when using filter and result is null.
xubo245 opened a new pull request #3273: [CARBONDATA-3363] Fix the IllegalArgumentException when using filter and result is null. URL: https://github.com/apache/carbondata/pull/3273 This PR fixs the IllegalArgumentException when using filter and result is null. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? No - [ ] Any backward compatibility impacted? No - [ ] Document update required? No - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. Yes,added - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 closed pull request #3195: [WIP][CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null
xubo245 closed pull request #3195: [WIP][CARBONDATA-3342] Fix the IllegalArgumentException when using filter and result is null URL: https://github.com/apache/carbondata/pull/3195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3074: [CARBONDATA-3250] Optimize hive doc
CarbonDataQA commented on issue #3074: [CARBONDATA-3250] Optimize hive doc URL: https://github.com/apache/carbondata/pull/3074#issuecomment-500485411 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3485/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3251: [CARBONDATA-3408] CarbonSession partition support binary data type
xubo245 commented on issue #3251: [CARBONDATA-3408] CarbonSession partition support binary data type URL: https://github.com/apache/carbondata/pull/3251#issuecomment-500482319 @kumarvishal09 @KanakaKumar @ravipesala Please handle this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3074: [CARBONDATA-3250] Optimize hive doc
xubo245 commented on issue #3074: [CARBONDATA-3250] Optimize hive doc URL: https://github.com/apache/carbondata/pull/3074#issuecomment-500481860 @KanakaKumar @kumarvishal09 @ravipesala @QiangCai @jackylk Please review it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3181: [CARBONDATA-3356] Support decimal for json schema and Provide better exception for users to solve problem when carbonData DataSource read SDK fi
xubo245 commented on issue #3181: [CARBONDATA-3356] Support decimal for json schema and Provide better exception for users to solve problem when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-500481993 @akashrn5 @KanakaKumar @kumarvishal09 @ravipesala @QiangCai @jackylk Please review it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3074: [CARBONDATA-3250] Optimize hive doc
xubo245 commented on issue #3074: [CARBONDATA-3250] Optimize hive doc URL: https://github.com/apache/carbondata/pull/3074#issuecomment-500481623 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column
CarbonDataQA commented on issue #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column URL: https://github.com/apache/carbondata/pull/3272#issuecomment-500481637 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3484/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
xubo245 commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500480955 Can you add some test cases for CARBONDATA-3414? @ajantha-bhat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3084: [CARBONDATA-3258] Add more test case for mv datamap
asfgit closed pull request #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
xubo245 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500479920 @qiuchenjian Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
xubo245 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500478860 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 opened a new pull request #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column
xubo245 opened a new pull request #3272: [CARBONDATA-3424] Carbon should throw proper exception when Select query with average function for substring of binary column URL: https://github.com/apache/carbondata/pull/3272 Carbon should throw proper exception when Select query with average function for substring of binary column Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? NO - [ ] Any backward compatibility impacted? No - [ ] Document update required? No - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. Yes - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. JIRA-3336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (CARBONDATA-3424) There are improper exception when query with avg(substr(binary data type)).
xubo245 created CARBONDATA-3424:
---
Summary: There are improper exception when query with
avg(substr(binary data type)).
Key: CARBONDATA-3424
URL: https://issues.apache.org/jira/browse/CARBONDATA-3424
Project: CarbonData
Issue Type: Bug
Reporter: xubo245
Assignee: xubo245
Code:
{code:java}
CREATE TABLE uniqdata (CUST_ID int,CUST_NAME binary,ACTIVE_EMUI_VERSION string,
DOB timestamp, DOJ timestamp, BIGINT_COLUMN1 bigint,BIGINT_COLUMN2
bigint,DECIMAL_COLUMN1 decimal(30,10), DECIMAL_COLUMN2
decimal(36,10),Double_COLUMN1 double, Double_COLUMN2 double,INTEGER_COLUMN1
int) STORED BY 'org.apache.carbondata.format'
TBLPROPERTIES('table_blocksize'='2000');
LOAD DATA inpath 'hdfs://hacluster/chetan/2000_UniqData.csv' into table
uniqdata OPTIONS('DELIMITER'=','
,'QUOTECHAR'='"','BAD_RECORDS_ACTION'='FORCE','FILEHEADER'='CUST_ID,CUST_NAME,ACTIVE_EMUI_VERSION,DOB,DOJ,BIGINT_COLUMN1,BIGINT_COLUMN2,DECIMAL_COLUMN1,DECIMAL_COLUMN2,Double_COLUMN1,Double_COLUMN2,INTEGER_COLUMN1');
Select query with average function for substring of binary column is executed.
select
max(substr(CUST_NAME,1,2)),min(substr(CUST_NAME,1,2)),avg(substr(CUST_NAME,1,2)),count(substr(CUST_NAME,1,2)),sum(substr(CUST_NAME,1,2)),variance(substr(CUST_NAME,1,2))
from uniqdata where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1
=1233720368578 or DECIMAL_COLUMN1 = 12345678901.123458 or Double_COLUMN1 =
1.12345674897976E10 or INTEGER_COLUMN1 IS NULL limit 10;
select
max(substring(CUST_NAME,1,2)),min(substring(CUST_NAME,1,2)),avg(substring(CUST_NAME,1,2)),count(substring(CUST_NAME,1,2)),sum(substring(CUST_NAME,1,2)),variance(substring(CUST_NAME,1,2))
from uniqdata where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1
=1233720368578 or DECIMAL_COLUMN1 = 12345678901.123458 or Double_COLUMN1 =
1.12345674897976E10 or INTEGER_COLUMN1 IS NULL limit 10;
{code}
Improper exception:
{code:java}
"Invalid call to name on unresolved object, tree:
unresolvedalias(avg(substring(CUST_NAME#73, 1, 2)), None)" did not contain
"cannot resolve 'avg(substring(uniqdata.`CUST_NAME`, 1, 2))' due to data type
mismatch: function average requires numeric types, not BinaryType"
ScalaTestFailureLocation:
org.apache.carbondata.integration.spark.testsuite.binary.TestBinaryDataType$$anonfun$27
at (TestBinaryDataType.scala:1410)
org.scalatest.exceptions.TestFailedException: "Invalid call to name on
unresolved object, tree: unresolvedalias(avg(substring(CUST_NAME#73, 1, 2)),
None)" did not contain "cannot resolve 'avg(substring(uniqdata.`CUST_NAME`, 1,
2))' due to data type mismatch: function average requires numeric types, not
BinaryType"
at
org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
at
org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
at
org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)
at
org.apache.carbondata.integration.spark.testsuite.binary.TestBinaryDataType$$anonfun$27.apply$mcV$sp(TestBinaryDataType.scala:1410)
at
org.apache.carbondata.integration.spark.testsuite.binary.TestBinaryDataType$$anonfun$27.apply(TestBinaryDataType.scala:1352)
at
org.apache.carbondata.integration.spark.testsuite.binary.TestBinaryDataType$$anonfun$27.apply(TestBinaryDataType.scala:1352)
at
org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
at org.scalatest.Transformer.apply(Transformer.scala:22)
at org.scalatest.Transformer.apply(Transformer.scala:20)
at org.scalatest.FunSuiteLike$$anon$1.apply(FunSuiteLike.scala:166)
at
org.apache.spark.sql.test.util.CarbonFunSuite.withFixture(CarbonFunSuite.scala:41)
at
org.scalatest.FunSuiteLike$class.invokeWithFixture$1(FunSuiteLike.scala:163)
at
org.scalatest.FunSuiteLike$$anonfun$runTest$1.apply(FunSuiteLike.scala:175)
at
org.scalatest.FunSuiteLike$$anonfun$runTest$1.apply(FunSuiteLike.scala:175)
at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
at org.scalatest.FunSuiteLike$class.runTest(FunSuiteLike.scala:175)
at org.scalatest.FunSuite.runTest(FunSuite.scala:1555)
at
org.scalatest.FunSuiteLike$$anonfun$runTests$1.apply(FunSuiteLike.scala:208)
at
org.scalatest.FunSuiteLike$$anonfun$runTests$1.apply(FunSuiteLike.scala:208)
at
org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:413)
at
org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:401)
at scala.collection.immutable.List.foreach(List.scala:381)
at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
at
org.scalatest.SuperEngi
[GitHub] [carbondata] CarbonDataQA commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
CarbonDataQA commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500467852 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11751/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
CarbonDataQA commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500460686 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3686/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
CarbonDataQA commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500435361 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3483/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500432190 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3685/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] qiuchenjian commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
qiuchenjian commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500426610 @Indhumathi27 done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK
ajantha-bhat commented on issue #3254: [CARBONDATA-3411] [CARBONDATA-3414] Fix clear datamaps logs an exception in SDK URL: https://github.com/apache/carbondata/pull/3254#issuecomment-500417679 @xubo245 : tested manually This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
Indhumathi27 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500408443 @qiuchenjian please squash commits to single commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception
CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception URL: https://github.com/apache/carbondata/pull/3268#issuecomment-500405282 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3683/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500402742 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11747/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500397750 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11750/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception
CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception URL: https://github.com/apache/carbondata/pull/3268#issuecomment-500389746 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11748/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type
xubo245 commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type URL: https://github.com/apache/carbondata/pull/3271#issuecomment-500388826 @KanakaKumar @brijoobopanna Please review it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500378631 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3682/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500378460 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3482/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] NamanRastogi commented on issue #3266: [CARBONDATA-3420] Concurrent Datamap Creation is not synchronised across different sessions
NamanRastogi commented on issue #3266: [CARBONDATA-3420] Concurrent Datamap Creation is not synchronised across different sessions URL: https://github.com/apache/carbondata/pull/3266#issuecomment-500374989 @ravipesala No, this error is not reproducible for MV. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
Indhumathi27 commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500370108 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type
CarbonDataQA commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type URL: https://github.com/apache/carbondata/pull/3271#issuecomment-500368278 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11745/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ravipesala commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
ravipesala commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500366289 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500365673 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11749/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
CarbonDataQA commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500365303 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3481/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type
CarbonDataQA commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type URL: https://github.com/apache/carbondata/pull/3271#issuecomment-500364857 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3681/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object
CarbonDataQA commented on issue #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object URL: https://github.com/apache/carbondata/pull/3270#issuecomment-500364870 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3679/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception
CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception URL: https://github.com/apache/carbondata/pull/3268#issuecomment-500363126 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3480/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500362610 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3479/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object
CarbonDataQA commented on issue #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object URL: https://github.com/apache/carbondata/pull/3270#issuecomment-500351146 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11743/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
Indhumathi27 commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#discussion_r291929100 ## File path: docs/ddl-of-carbondata.md ## @@ -811,6 +811,7 @@ Users can specify which columns to include and exclude for local dictionary gene new SORT_COLUMNS. UNSET is not supported, but it can set SORT_COLUMNS to empty string instead of using UNSET. + NOTE: SORT_SCOPE should not be NO_SORT, when set SORT_COLUMNS to empty Review comment: This scenario, first user creates a table with sort_scope='local_sort' and then set sort_columns=empty, using alter set tableproperties, which is not allowed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
Indhumathi27 commented on issue #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#issuecomment-500349272 @ravipesala changed the document.. Please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ravipesala commented on issue #3266: [CARBONDATA-3420] Concurrent Datamap Creation is not synchronised across different sessions
ravipesala commented on issue #3266: [CARBONDATA-3420] Concurrent Datamap Creation is not synchronised across different sessions URL: https://github.com/apache/carbondata/pull/3266#issuecomment-500346393 @NamanRastogi This is only for pre-aggregate? what about MV? Is MV working? If it is for pre-aggregate only then why we need to fix it as it is going to be replaced by MV. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type
CarbonDataQA commented on issue #3271: [CARBONDATA-3423] Validate dictionary for binary data type URL: https://github.com/apache/carbondata/pull/3271#issuecomment-500346033 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3478/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
Indhumathi27 commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#discussion_r291929100 ## File path: docs/ddl-of-carbondata.md ## @@ -811,6 +811,7 @@ Users can specify which columns to include and exclude for local dictionary gene new SORT_COLUMNS. UNSET is not supported, but it can set SORT_COLUMNS to empty string instead of using UNSET. + NOTE: SORT_SCOPE should not be NO_SORT, when set SORT_COLUMNS to empty Review comment: This scenario, first user creates a table with sort_scope='no_sort' and then set sort_columns=empty, using alter set tableproperties, which is not allowed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
Indhumathi27 commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#discussion_r291929100 ## File path: docs/ddl-of-carbondata.md ## @@ -811,6 +811,7 @@ Users can specify which columns to include and exclude for local dictionary gene new SORT_COLUMNS. UNSET is not supported, but it can set SORT_COLUMNS to empty string instead of using UNSET. + NOTE: SORT_SCOPE should not be NO_SORT, when set SORT_COLUMNS to empty Review comment: This scenario, first user creates a table with sort_scope='local_sort' and then set sort_columns=empty, using alter set tableproperties, which is not allowed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ravipesala commented on issue #3265: [CARBONDATA-3419] Desc Formatted not showing Range Column
ravipesala commented on issue #3265: [CARBONDATA-3419] Desc Formatted not showing Range Column URL: https://github.com/apache/carbondata/pull/3265#issuecomment-500340741 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ravipesala commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
ravipesala commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's URL: https://github.com/apache/carbondata/pull/3264#discussion_r291927577 ## File path: docs/ddl-of-carbondata.md ## @@ -811,6 +811,7 @@ Users can specify which columns to include and exclude for local dictionary gene new SORT_COLUMNS. UNSET is not supported, but it can set SORT_COLUMNS to empty string instead of using UNSET. + NOTE: SORT_SCOPE should not be NO_SORT, when set SORT_COLUMNS to empty Review comment: when `SORT_COLUMNS` is empty, there is no significance to `SORT_SCOPE`. By default, it becomes `NO_SORT` always. So if we need to add validation we should not allow `SORT_SCOPE` at all in case of empty SORT_COLUMNS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3181: [CARBONDATA-3356] Support decimal for json schema and Provide better exception for users to solve problem when carbonData DataSource read S
ajantha-bhat commented on issue #3181: [CARBONDATA-3356] Support decimal for json schema and Provide better exception for users to solve problem when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-500339149 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] xubo245 opened a new pull request #3271: [CARBONDATA-3423] Validate dictionary for binary data type
xubo245 opened a new pull request #3271: [CARBONDATA-3423] Validate dictionary for binary data type URL: https://github.com/apache/carbondata/pull/3271 it will throw exception if dictionary_include has binary column, it will not throw exception if DICTIONARY_EXCLUDE has binary column optimize Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? No - [ ] Any backward compatibility impacted? No - [ ] Document update required? yes - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. yes - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] kumarvishal09 commented on issue #3253: [CARBONDATA-3410] Add UDF, Hex/Base64 SQL functions for binary
kumarvishal09 commented on issue #3253: [CARBONDATA-3410] Add UDF, Hex/Base64 SQL functions for binary URL: https://github.com/apache/carbondata/pull/3253#issuecomment-500335429 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] kumarvishal09 commented on issue #3251: [CARBONDATA-3408] CarbonSession partition support binary data type
kumarvishal09 commented on issue #3251: [CARBONDATA-3408] CarbonSession partition support binary data type URL: https://github.com/apache/carbondata/pull/3251#issuecomment-500334334 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception
CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception URL: https://github.com/apache/carbondata/pull/3268#issuecomment-500329241 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11742/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object
CarbonDataQA commented on issue #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object URL: https://github.com/apache/carbondata/pull/3270#issuecomment-500329186 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3476/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception
CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception URL: https://github.com/apache/carbondata/pull/3268#issuecomment-500329120 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3678/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500327480 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11744/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500326836 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3680/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
CarbonDataQA commented on issue #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269#issuecomment-500326891 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3477/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception
CarbonDataQA commented on issue #3268: [CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception URL: https://github.com/apache/carbondata/pull/3268#issuecomment-500326532 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3475/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (CARBONDATA-3423) Validate dictionary for binary data type
xubo245 created CARBONDATA-3423: --- Summary: Validate dictionary for binary data type Key: CARBONDATA-3423 URL: https://issues.apache.org/jira/browse/CARBONDATA-3423 Project: CarbonData Issue Type: Sub-task Reporter: xubo245 Assignee: xubo245 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [carbondata] lamber-ken opened a new pull request #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object
lamber-ken opened a new pull request #3270: [CARBONDATA-3422] fix missing
complex dimensions when prepare the data from raw object
URL: https://github.com/apache/carbondata/pull/3270
This pr aim to fix missing complex dimensions when prepare the data from raw
object and add test case for this.
When use compact command for streaming table which contains complex column
like array, it'll thow `ArrayIndexOutOfBoundsException`.
Compact command
```
ALTER TABLE streaming1.stream_table_filter_complex COMPACT 'close_streaming'
```
Stackstrace
```
java.lang.ArrayIndexOutOfBoundsException: 9
at
org.apache.carbondata.processing.loading.sort.SortStepRowHandler.packNoSortFieldsToBytes(SortStepRowHandler.java:808)
at
org.apache.carbondata.processing.loading.sort.SortStepRowHandler.writeRawRowAsIntermediateSortTempRowToOutputStream(SortStepRowHandler.java:481)
at
org.apache.carbondata.processing.sort.sortdata.SortDataRows.writeDataToFile(SortDataRows.java:244)
at
org.apache.carbondata.processing.sort.sortdata.SortDataRows.startSorting(SortDataRows.java:222)
at
org.apache.carbondata.processing.merger.CompactionResultSortProcessor.processResult(CompactionResultSortProcessor.java:257)
at
org.apache.carbondata.processing.merger.CompactionResultSortProcessor.execute(CompactionResultSortProcessor.java:175)
at
org.apache.carbondata.spark.rdd.StreamHandoffRDD.internalCompute(StreamHandoffRDD.scala:123)
at org.apache.carbondata.spark.rdd.CarbonRDD.compute(CarbonRDD.scala:82)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:87)
at org.apache.spark.scheduler.Task.run(Task.scala:108)
```
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed? NO
- [x] Any backward compatibility impacted? NO
- [x] Document update required? NO
- [x] Testing done YES
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA. OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
akashrn5 commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap URL: https://github.com/apache/carbondata/pull/3084#issuecomment-500318266 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3251: [CARBONDATA-3408] CarbonSession partition support binary data type
ajantha-bhat commented on issue #3251: [CARBONDATA-3408] CarbonSession partition support binary data type URL: https://github.com/apache/carbondata/pull/3251#issuecomment-500315158 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3084: [CARBONDATA-3258] Add more test case for mv datamap
akashrn5 commented on a change in pull request #3084: [CARBONDATA-3258] Add
more test case for mv datamap
URL: https://github.com/apache/carbondata/pull/3084#discussion_r291872684
##
File path:
datamap/mv/core/src/test/scala/org/apache/carbondata/mv/rewrite/MVInvalidTestCase.scala
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.mv.rewrite
+
+import org.apache.spark.sql.test.util.QueryTest
+import org.scalatest.BeforeAndAfterAll
+
+class MVInvalidTestCase extends QueryTest with BeforeAndAfterAll {
Review comment:
since there are no many test cases, i suggest to add in one class as
validation tests,which covers exception also as exception is nothing but
validation only
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jack86596 opened a new pull request #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating.
jack86596 opened a new pull request #3269: [CARBONDATA-3266] Remove redundant warn messages when carbon session is creating. URL: https://github.com/apache/carbondata/pull/3269 ### Problem: 1. For some configurations, if customer not set the value for it, when creating carbon session, validateAndLoadDefaultProperties will print WARN message and then set the value to default. It is redundant, no need print the message, just set to default value directly. ### Solution: No need to validate properties when properties' value are not set. Use default value directly. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Covered by existed test cases. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
