[GitHub] [carbondata] CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted 
rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-523117375
 
 
   Build Success with Spark 2.3.2, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/339/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted 
rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-523114843
 
 
   Build Success with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/341/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted 
rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-523087098
 
 
   Build Success with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/344/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] zzcclp commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
zzcclp commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows 
count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-523080623
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 commented on issue #3342: [CARBONDATA-3493] Initialize Profiler in CarbonEnv

2019-08-20 Thread GitBox
akashrn5 commented on issue #3342: [CARBONDATA-3493] Initialize Profiler in 
CarbonEnv
URL: https://github.com/apache/carbondata/pull/3342#issuecomment-522976393
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (CARBONDATA-3495) Insert into Array or Struct of Binary data type fails with Carbon & SparkFileFormat

2019-08-20 Thread Indhumathi Muthumurugesh (Jira)
Indhumathi Muthumurugesh created CARBONDATA-3495:


 Summary: Insert into Array or Struct of Binary data type fails 
with Carbon & SparkFileFormat
 Key: CARBONDATA-3495
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3495
 Project: CarbonData
  Issue Type: Bug
Reporter: Indhumathi Muthumurugesh






--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (CARBONDATA-3401) Fix the java sdk create wrong carbondata filename

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala updated CARBONDATA-3401:

Fix Version/s: (was: 1.6.0)

> Fix the java sdk create wrong carbondata filename 
> --
>
> Key: CARBONDATA-3401
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3401
> Project: CarbonData
>  Issue Type: Bug
>  Components: data-load, other
>Affects Versions: 1.5.3
>Reporter: lamber-ken
>Priority: Major
> Attachments: fix_the_java_sdk_create_wrong_carbondata_filename.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> When use sdk to write carbondata files, use +System.nanoTime()+ assign to the 
> start timestamp and use +System.nanoTime()+ assign to taskNo currently.
> There are two bug here, first +System.nanoTime()+ is different from 
> +System.currentTimeMillis()+, it can only be used to measure elapsed time and 
> is not related to any other notion of system or wall-clock time. Second, the 
> carbondata file name written by sdk was different from written by spark.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (CARBONDATA-3388) Optimize the way to acquire project or root path

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala updated CARBONDATA-3388:

Fix Version/s: (was: 1.6.0)

> Optimize the way to acquire project or root path 
> -
>
> Key: CARBONDATA-3388
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3388
> Project: CarbonData
>  Issue Type: Improvement
>  Components: core, examples, spark-integration
>Affects Versions: 1.5.3
>Reporter: lamber-ken
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> For now, to acquire the root path of project path was called by
> {code:java}
> val rootPath = new File(this.getClass.getResource("/").getPath  + 
> "../../../..").getCanonicalPath
> {code}
> we can use a simpler approach to optimize
> {code:java}
> System.getProperty("user.dir")
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (CARBONDATA-3383) fix thrift version conflict bug in examples module

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala updated CARBONDATA-3383:

Fix Version/s: (was: 1.6.0)

> fix thrift version conflict bug in examples module
> --
>
> Key: CARBONDATA-3383
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3383
> Project: CarbonData
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 1.5.3
>Reporter: lamber-ken
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Thrift version conflict in examples module, in example module needs 
> +carbondata-hive+ and
> +carbondata-store-sdk,+ one version is 0.9.3 another is 0.9.2. This cause NPE 
> when use +carbondata-sdk+ write demo data.
>  
> Detail stackstrace
> {code:java}
> java.lang.NullPointerException
>     at 
> org.apache.thrift.protocol.TCompactProtocol.writeString(TCompactProtocol.java:356)
>     at 
> org.apache.carbondata.format.FileFooter3$FileFooter3StandardScheme.write(FileFooter3.java:1053)
>     at 
> org.apache.carbondata.format.FileFooter3$FileFooter3StandardScheme.write(FileFooter3.java:877)
>     at org.apache.carbondata.format.FileFooter3.write(FileFooter3.java:768)
>     at 
> org.apache.carbondata.core.util.CarbonUtil.getByteArray(CarbonUtil.java:1444)
>     at 
> org.apache.carbondata.processing.store.writer.v3.CarbonFactDataWriterImplV3.writeFooterToFile(CarbonFactDataWriterImplV3.java:122)
>     at 
> org.apache.carbondata.processing.store.writer.v3.CarbonFactDataWriterImplV3.writeFooter(CarbonFactDataWriterImplV3.java:415)
>     at 
> org.apache.carbondata.processing.store.CarbonFactDataHandlerColumnar.closeHandler(CarbonFactDataHandlerColumnar.java:502)
>     at 
> org.apache.carbondata.processing.loading.steps.CarbonRowDataWriterProcessorStepImpl.processingComplete(CarbonRowDataWriterProcessorStepImpl.java:234)
>     at 
> org.apache.carbondata.processing.loading.steps.CarbonRowDataWriterProcessorStepImpl.finish(CarbonRowDataWriterProcessorStepImpl.java:212)
>     at 
> org.apache.carbondata.processing.loading.steps.CarbonRowDataWriterProcessorStepImpl.doExecute(CarbonRowDataWriterProcessorStepImpl.java:179)
>     at 
> org.apache.carbondata.processing.loading.steps.CarbonRowDataWriterProcessorStepImpl.execute(CarbonRowDataWriterProcessorStepImpl.java:133)
>     at 
> org.apache.carbondata.processing.loading.DataLoadExecutor.execute(DataLoadExecutor.java:52)
>     at 
> org.apache.carbondata.hadoop.api.CarbonTableOutputFormat$1.run(CarbonTableOutputFormat.java:274)
>     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>     at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (CARBONDATA-3380) Fix missing appName and AnalysisException bug in DirectSQLExample

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala resolved CARBONDATA-3380.
-
Resolution: Fixed

> Fix missing appName and AnalysisException bug in DirectSQLExample 
> --
>
> Key: CARBONDATA-3380
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3380
> Project: CarbonData
>  Issue Type: Bug
>  Components: build, spark-integration
>Affects Versions: 1.5.3
>Reporter: lamber-ken
>Priority: Major
> Fix For: 1.6.0
>
>  Time Spent: 10h 10m
>  Remaining Estimate: 0h
>
> Fix two bug in +DirectSQLExample+
>  # fix missing +appName+ which is writing the carbondata files.
>  # fix +AnalysisException+ bug because of +carbonfile+



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (CARBONDATA-3484) Unable to read data from carbontable , after sucessfull writing in same or new carbonsession

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala updated CARBONDATA-3484:

Fix Version/s: (was: 1.6.0)

> Unable to read data from carbontable , after sucessfull writing in same or 
> new carbonsession
> 
>
> Key: CARBONDATA-3484
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3484
> Project: CarbonData
>  Issue Type: Bug
>  Components: data-query
>Affects Versions: 1.6.0
> Environment: ubuntu
>Reporter: anshul
>Priority: Critical
>  Labels: newbie
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I have read a csv from my local system and write it as carbontable on s3 
> location using s3n
>   public static void main(String args[]) {
>     String colNames = "";
>     SparkSession spark = null;
>     SparkSession carbon = null;
>     String storeLocation = "s3n://accesskey:secretkey@bucketnames3";
>     SparkConf config = new SparkConf();
>     config.setMaster("local[2]");
>     config.set("javax.jdo.option.ConnectionDriverName", 
> "org.postgresql.Driver");
>     config.set("javax.jdo.option.ConnectionPassword", "postgres");
>     config.set("javax.jdo.option.ConnectionUserName", "postgres");
>     config.set("hive.exec.dynamic.partition.mode", "nonstrict");
>     config.set("hive.exec.dynamic.partition", "true");
>     config.set("hive.exec.max.dynamic.partitions", "2556");
>     config.set("hive.exec.max.dynamic.partitions.pernode", "2556");
>     config.set("carbon.number.of.cores.while.loading", "1");
>     config.set("carbon.sort.temp.compressor", "SNAPPY");
>     config.set("carbon.sort.size", "5000");
>     config.set("carbon.sort.file.write.buffer.size", "500");
>     config.set("carbon.merge.sort.prefetch", "false");
>     config.set("carbon.sort.intermediate.files.limit", "10");
>     config.set("enable.unsafe.sort", "true");
>     config.set("spark.kryo.unsafe", "true");
>     config.set("hive.metastore.uris", "thrift://localhost:9083");
>     spark = 
> SparkSession.builder().appName("CarbonDataReader").config(config).enableHiveSupport().getOrCreate();
>     carbon = 
> CarbonSession.CarbonBuilder(spark.builder()).getOrCreateCarbonSession(storeLocation,
>     "jdbc:postgresql://localhost:5432/carbonmetastore");
>     carbon.sparkContext().hadoopConfiguration().set("fs.s3n.impl", 
> "org.apache.hadoop.fs.s3native.NativeS3FileSystem");
>     
> carbon.sparkContext().hadoopConfiguration().set("fs.s3n.awsAccessKeyId", 
> "");
>     
> carbon.sparkContext().hadoopConfiguration().set("fs.s3n.awsSecretAccessKey", 
> "xxx");
>     
>     Dataset ds = carbon.read().format("carbondata").option("header", 
> "true").option("inferSchema", "true")
>     .csv("/home/anshul.jain/Downloads/datasets/EMP_Age.csv");
>     ds.registerTempTable("temp_emp_age_test");
>     carbon.sql("describe formatted emp_age_test").show(100, false);
>     DataFrameWriter dfw = 
> ds.write().format(MaterializedViewConstants.CARBONFORMAT).option(MetadataConstants.TABLE_NAME,
>  "emp_age_test")
>     .option("bad_records_logger_enable", false);
>     dfw.mode(SaveMode.Overwrite).save();
>  
> carbon.sql("select * from emp_age_test").show();
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (CARBONDATA-3370) fix missing version of maven-duplicate-finder-plugin

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala updated CARBONDATA-3370:

Fix Version/s: (was: 1.6.0)
   1.6.1

> fix missing version of maven-duplicate-finder-plugin
> 
>
> Key: CARBONDATA-3370
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3370
> Project: CarbonData
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 1.5.3
>Reporter: lamber-ken
>Priority: Critical
> Fix For: 1.6.1
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> fix missing version of maven-duplicate-finder-plugin in pom file



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (CARBONDATA-3494) Nullpointer exception in case of drop table

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala resolved CARBONDATA-3494.
-
Fix Version/s: 1.6.1
   Resolution: Fixed

> Nullpointer exception in case of drop table
> ---
>
> Key: CARBONDATA-3494
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3494
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Major
> Fix For: 1.6.1
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Drop table is failing with nullpointer in below scenario with datamap
> This issue will happen once the PR #3339 is merged, because with that PR 
> refresh table happens correctly and then this fails.
> CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED 
> BY 'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
> CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 
> 'bloomfilter' DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 
> 'BLOOM_SIZE'='64', 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
> DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
> 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> drop table if exists datamap_test_1;



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [carbondata] asfgit closed pull request #3359: [CARBONDATA-3494]Fix NullPointerException in drop table and Correct the document formatting

2019-08-20 Thread GitBox
asfgit closed pull request #3359: [CARBONDATA-3494]Fix NullPointerException in 
drop table and Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] ravipesala commented on issue #3359: [CARBONDATA-3494]Fix NullPointerException in drop table and Correct the document formatting

2019-08-20 Thread GitBox
ravipesala commented on issue #3359: [CARBONDATA-3494]Fix NullPointerException 
in drop table and Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359#issuecomment-522960558
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (CARBONDATA-3480) Remove Modified MDT and make relation refresh only when schema file is modified.

2019-08-20 Thread Ravindra Pesala (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala resolved CARBONDATA-3480.
-
Fix Version/s: 1.6.1
   Resolution: Fixed

> Remove Modified MDT and make relation refresh only when schema file is 
> modified.
> 
>
> Key: CARBONDATA-3480
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3480
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Kunal Kapoor
>Assignee: Kunal Kapoor
>Priority: Major
> Fix For: 1.6.1
>
>  Time Spent: 16h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [carbondata] asfgit closed pull request #3339: [CARBONDATA-3480] Fixed unnecessary refresh for table by removing modified mdt file

2019-08-20 Thread GitBox
asfgit closed pull request #3339: [CARBONDATA-3480] Fixed unnecessary refresh 
for table by removing modified mdt file
URL: https://github.com/apache/carbondata/pull/3339
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] ravipesala commented on issue #3339: [CARBONDATA-3480] Fixed unnecessary refresh for table by removing modified mdt file

2019-08-20 Thread GitBox
ravipesala commented on issue #3339: [CARBONDATA-3480] Fixed unnecessary 
refresh for table by removing modified mdt file
URL: https://github.com/apache/carbondata/pull/3339#issuecomment-522957130
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3359: [CARBONDATA-3494]Fix NullPointerException in drop table and Correct the document formatting

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3359: [CARBONDATA-3494]Fix 
NullPointerException in drop table and Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359#issuecomment-522948139
 
 
   Build Success with Spark 2.3.2, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/338/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3359: [CARBONDATA-3494]Fix NullPointerException in drop table and Correct the document formatting

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3359: [CARBONDATA-3494]Fix 
NullPointerException in drop table and Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359#issuecomment-522945758
 
 
   Build Success with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/340/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3359: [CARBONDATA-3494]Fix NullPointerException in drop table and Correct the document formatting

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3359: [CARBONDATA-3494]Fix 
NullPointerException in drop table and Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359#issuecomment-522917948
 
 
   Build Success with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/343/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] zzcclp edited a comment on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
zzcclp edited a comment on issue #3357: [CARBONDATA-3491] Return 
updated/deleted rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522904374
 
 
   @jackylk @ravipesala @sraghunandan @kevinjmh  Please help to review, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kevinjmh removed a comment on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
kevinjmh removed a comment on issue #3357: [CARBONDATA-3491] Return 
updated/deleted rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522908413
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kevinjmh commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
kevinjmh commented on issue #3357: [CARBONDATA-3491] Return updated/deleted 
rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522908413
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] zzcclp commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
zzcclp commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows 
count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522904374
 
 
   @jackylk @ravipesala @sraghunandan Please help to review, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted 
rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522899133
 
 
   Build Success with Spark 2.3.2, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/336/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] zzcclp commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
zzcclp commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows 
count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522898431
 
 
   > @zzcclp
   > Great, I pull the latest one and compile for spark 2.1.0, delete and 
update runs well too
   
   @kevinjmh Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3357: [CARBONDATA-3491] Return updated/deleted 
rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522896945
 
 
   Build Success with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/338/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (CARBONDATA-3494) Nullpointer exception in case of drop table

2019-08-20 Thread Akash R Nilugal (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash R Nilugal updated CARBONDATA-3494:

Description: 
Drop table is failing with nullpointer in below scenario with datamap

This issue will happen once the PR #3339 is merged, because with that PR 
refresh table happens correctly and then this fails.

CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED BY 
'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
drop table if exists datamap_test_1;


  was:
Drop table is failing with nullpointer in below scenario with datamap



CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED BY 
'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
drop table if exists datamap_test_1;



> Nullpointer exception in case of drop table
> ---
>
> Key: CARBONDATA-3494
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3494
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Major
>
> Drop table is failing with nullpointer in below scenario with datamap
> This issue will happen once the PR #3339 is merged, because with that PR 
> refresh table happens correctly and then this fails.
> CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED 
> BY 'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
> CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 
> 'bloomfilter' DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 
> 'BLOOM_SIZE'='64', 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
> DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
> 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> drop table if exists datamap_test_1;



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [carbondata] kevinjmh commented on issue #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

2019-08-20 Thread GitBox
kevinjmh commented on issue #3357: [CARBONDATA-3491] Return updated/deleted 
rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#issuecomment-522885308
 
 
   @zzcclp 
   Great, I pull the latest one and compile for spark 2.1.0, delete and update 
runs well too


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (CARBONDATA-3494) Nullpointer exception in case of drop table

2019-08-20 Thread Akash R Nilugal (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash R Nilugal updated CARBONDATA-3494:

Description: 
Drop table is failing with nullpointer in below scenario with datamap



CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED BY 
'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
drop table if exists datamap_test_1;


  was:
Drop table is failing with nullpointer in below scenario with datamap



CREATE TABLE datamap_test (id int,name string,salary float,dob date)STORED BY 
'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id','table_page_size_inmb'='1');
CREATE DATAMAP dm_datamap_test2 ON TABLE datamap_test USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
show datamap on table datamap_test;
CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED BY 
'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
show datamap on table datamap_test_1;
LOAD DATA INPATH 'hdfs://hacluster/chetan/datamap_test.csv' into table 
datamap_test_1 OPTIONS('DELIMITER'=',', 
'QUOTECHAR'='"','BAD_RECORDS_ACTION'='FORCE','FILEHEADER'='id,name,salary,dob');
explain select * from datamap_test_1 where name='NAME1';
explain select * from datamap_test_1 where id=1;
select * from datamap_test_1 where dob='1988-01-12';
drop table if exists datamap_test;
drop table if exists datamap_test_1;



> Nullpointer exception in case of drop table
> ---
>
> Key: CARBONDATA-3494
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3494
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Major
>
> Drop table is failing with nullpointer in below scenario with datamap
> CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED 
> BY 'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
> CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 
> 'bloomfilter' DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 
> 'BLOOM_SIZE'='64', 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
> DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
> 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> drop table if exists datamap_test_1;



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (CARBONDATA-3494) Nullpointer exception in case of drop table

2019-08-20 Thread Akash R Nilugal (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash R Nilugal updated CARBONDATA-3494:

Description: 
Drop table is failing with nullpointer in below scenario with datamap



CREATE TABLE datamap_test (id int,name string,salary float,dob date)STORED BY 
'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id','table_page_size_inmb'='1');
CREATE DATAMAP dm_datamap_test2 ON TABLE datamap_test USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
show datamap on table datamap_test;
CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED BY 
'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
show datamap on table datamap_test_1;
LOAD DATA INPATH 'hdfs://hacluster/chetan/datamap_test.csv' into table 
datamap_test_1 OPTIONS('DELIMITER'=',', 
'QUOTECHAR'='"','BAD_RECORDS_ACTION'='FORCE','FILEHEADER'='id,name,salary,dob');
explain select * from datamap_test_1 where name='NAME1';
explain select * from datamap_test_1 where id=1;
select * from datamap_test_1 where dob='1988-01-12';
drop table if exists datamap_test;
drop table if exists datamap_test_1;


  was:
Drop table is failing with nullpointer in below scenario with datamap




> Nullpointer exception in case of drop table
> ---
>
> Key: CARBONDATA-3494
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3494
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Major
>
> Drop table is failing with nullpointer in below scenario with datamap
> CREATE TABLE datamap_test (id int,name string,salary float,dob date)STORED BY 
> 'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id','table_page_size_inmb'='1');
> CREATE DATAMAP dm_datamap_test2 ON TABLE datamap_test USING 'bloomfilter' 
> DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 'BLOOM_SIZE'='64', 
> 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> show datamap on table datamap_test;
> CREATE TABLE datamap_test_1 (id int,name string,salary float,dob date)STORED 
> BY 'carbondata' TBLPROPERTIES('SORT_COLUMNS'='id');
> CREATE DATAMAP dm_datamap_test_1_2 ON TABLE datamap_test_1 USING 
> 'bloomfilter' DMPROPERTIES ('INDEX_COLUMNS' = 'salary,name', 
> 'BLOOM_SIZE'='64', 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> CREATE DATAMAP dm_datamap_test3 ON TABLE datamap_test_1 USING 'bloomfilter' 
> DMPROPERTIES ('INDEX_COLUMNS' = 'dob', 'BLOOM_SIZE'='64', 
> 'BLOOM_FPP'='0.1', 'BLOOM_COMPRESS'='true');
> show datamap on table datamap_test_1;
> LOAD DATA INPATH 'hdfs://hacluster/chetan/datamap_test.csv' into table 
> datamap_test_1 OPTIONS('DELIMITER'=',', 
> 'QUOTECHAR'='"','BAD_RECORDS_ACTION'='FORCE','FILEHEADER'='id,name,salary,dob');
> explain select * from datamap_test_1 where name='NAME1';
> explain select * from datamap_test_1 where id=1;
> select * from datamap_test_1 where dob='1988-01-12';
> drop table if exists datamap_test;
> drop table if exists datamap_test_1;



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [carbondata] CarbonDataQA commented on issue #3359: [HOTFIX]Correct the document formatting

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3359: [HOTFIX]Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359#issuecomment-522883705
 
 
   Build Failed  with Spark 2.3.2, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/337/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (CARBONDATA-3494) Nullpointer exception in case of drop table

2019-08-20 Thread Akash R Nilugal (Jira)
Akash R Nilugal created CARBONDATA-3494:
---

 Summary: Nullpointer exception in case of drop table
 Key: CARBONDATA-3494
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3494
 Project: CarbonData
  Issue Type: Bug
Reporter: Akash R Nilugal
Assignee: Akash R Nilugal


Drop table is failing with nullpointer in below scenario with datamap





--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [carbondata] CarbonDataQA commented on issue #3359: [HOTFIX]Correct the document formatting

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3359: [HOTFIX]Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359#issuecomment-522882855
 
 
   Build Failed  with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/342/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA commented on issue #3359: [HOTFIX]Correct the document formatting

2019-08-20 Thread GitBox
CarbonDataQA commented on issue #3359: [HOTFIX]Correct the document formatting
URL: https://github.com/apache/carbondata/pull/3359#issuecomment-522882535
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/339/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services