[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549698146 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/748/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549697448 Build Failed with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/757/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment
CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment URL: https://github.com/apache/carbondata/pull/3426#issuecomment-549697208 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/747/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549696601 Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/749/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3433: [CARBONDATA-3570] Change task number to jobid+taskid for FileFormat
jackylk commented on a change in pull request #3433: [CARBONDATA-3570] Change
task number to jobid+taskid for FileFormat
URL: https://github.com/apache/carbondata/pull/3433#discussion_r34248
##
File path:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala
##
@@ -154,8 +154,11 @@ class SparkCarbonFileFormat extends FileFormat
path
}
context.getConfiguration.set("carbon.outputformat.writepath",
updatedPath)
+// "jobid"+"x"+"taskid", task retry should have same task number
context.getConfiguration.set("carbon.outputformat.taskno",
- UUID.randomUUID().toString.replace("-", ""))
+ context.getTaskAttemptID.getJobID.getJtIdentifier +
+ context.getTaskAttemptID.getJobID.getId
+ + 'x' + context.getTaskAttemptID.getTaskID.getId)
Review comment:
Why using `x` in between? Can we follow the same naming convention as
carbondata table?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] lamber-ken edited a comment on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
lamber-ken edited a comment on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549695540 > @lamber-ken thanks for your contribution. Is this PR fix all @override style issue? Can you change the style check to error level so that we can catch it if any not fixed? right, this pr fix all `@Overrider` annotation location. I changed the level to error and build success at my local env. If the ci build failed, I will check it. here is the commit, https://github.com/apache/carbondata/pull/3434/commits/ce414fd633034fb136be85c07fc09c750fa8f2b3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] lamber-ken edited a comment on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
lamber-ken edited a comment on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549695540 > @lamber-ken thanks for your contribution. Is this PR fix all @override style issue? Can you change the style check to error level so that we can catch it if any not fixed? right, this pr fix all `@Overrider` annotation location. I changed the level to error. here is the commit, https://github.com/apache/carbondata/pull/3434/commits/ce414fd633034fb136be85c07fc09c750fa8f2b3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549695974 Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/755/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3400: Fix query on bloom in case of multiple data files in one segment
jackylk commented on issue #3400: Fix query on bloom in case of multiple data files in one segment URL: https://github.com/apache/carbondata/pull/3400#issuecomment-549695989 Can you add a testcase to reproduce this issue, I tried query using bloom filter on multiple data files in one segment in local machine, and it seems fine. @shivamasn This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] lamber-ken commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
lamber-ken commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549695540 > @lamber-ken thanks for your contribution. Is this PR fix all @override style issue? Can you change the style check to error level so that we can catch it if any not fixed? right, this pr fix all `@Overrider` annotation location. I changed the level to error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3433: [CARBONDATA-3570] Change task number to jobid+taskid for FileFormat
ajantha-bhat commented on issue #3433: [CARBONDATA-3570] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433#issuecomment-549694586 @kumarvishal09 : done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
jackylk commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549694179 @lamber-ken thanks for your contribution. Is this PR fix all @Override style issue? Can you change the style check to error level so that we can catch it if any not fixed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (CARBONDATA-3570) Incase of file format, task retry is having different task number, so file name is becoming different
Ajantha Bhat created CARBONDATA-3570: Summary: Incase of file format, task retry is having different task number, so file name is becoming different Key: CARBONDATA-3570 URL: https://issues.apache.org/jira/browse/CARBONDATA-3570 Project: CarbonData Issue Type: Bug Reporter: Ajantha Bhat Assignee: Ajantha Bhat problem : Incase of file format, task retry is having different task number, so file name is becoming different cause : Everytime in executor, UUID is used to generate task number for carbondata file name. so if previous task has copied few files insted of all files and it got crashed. New task will create new file instead of overwriting existing file solution: make task number in file name same for task retry by using taskid + job number -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560]
Fixed issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r342406601
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##
@@ -92,6 +92,24 @@ case class CarbonAddLoadCommand(
val segmentPath = options.getOrElse(
"path", throw new UnsupportedOperationException("PATH is manadatory"))
+val allSegments =
SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+// If a path is already added then we should block the adding of the same
path again.
+if (allSegments.exists(a =>
+ a.getPath != null && a.getPath.equalsIgnoreCase(segmentPath)
+)) {
+ throw new AnalysisException(s"Cannot add the segment. This path is
already in use by " +
+ s"another segment.")
+}
+
+val format = options.getOrElse("format", "carbondata")
+val isCarbonFormat = format.equalsIgnoreCase("carbondata") ||
format.equalsIgnoreCase("carbon")
+
+// If in the given location no carbon files are found then we can throw an
exception
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560]
Fixed issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r342406568
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##
@@ -92,6 +92,24 @@ case class CarbonAddLoadCommand(
val segmentPath = options.getOrElse(
"path", throw new UnsupportedOperationException("PATH is manadatory"))
+val allSegments =
SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+// If a path is already added then we should block the adding of the same
path again.
+if (allSegments.exists(a =>
+ a.getPath != null && a.getPath.equalsIgnoreCase(segmentPath)
+)) {
+ throw new AnalysisException(s"Cannot add the segment. This path is
already in use by " +
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added
validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r342405068
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
##
@@ -276,7 +276,20 @@ case class CarbonAlterTableCompactionCommand(
val isCompactionTriggerByDDl = true
val segmentIds: Option[List[String]] = if (compactionType ==
CompactionType.CUSTOM &&
alterTableModel.customSegmentIds.isDefined) {
- alterTableModel.customSegmentIds
+ val ids = alterTableModel.customSegmentIds
+ if (ids != None) {
+val loadMetadataDetails =
carbonLoadModel.getLoadMetadataDetails.asScala
+for (oneLoad <- loadMetadataDetails) {
Review comment:
Try best not to use `for` loop in Scala.
You can first filter out the load by matching the id and check whether it is
carbon format
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added
validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r342405277
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
##
@@ -276,7 +276,20 @@ case class CarbonAlterTableCompactionCommand(
val isCompactionTriggerByDDl = true
val segmentIds: Option[List[String]] = if (compactionType ==
CompactionType.CUSTOM &&
alterTableModel.customSegmentIds.isDefined) {
- alterTableModel.customSegmentIds
+ val ids = alterTableModel.customSegmentIds
+ if (ids != None) {
+val loadMetadataDetails =
carbonLoadModel.getLoadMetadataDetails.asScala
+for (oneLoad <- loadMetadataDetails) {
+ for (id <- ids.head) {
+// Other Segment format cannot be compacted
+if (oneLoad.getLoadName.equalsIgnoreCase(id) &&
+!oneLoad.getFileFormat.equals(FileFormat.COLUMNAR_V3)) {
+ throw new AnalysisException("Custom compaction should not have
other format segments")
Review comment:
```suggestion
throw new AnalysisException("Custom compaction does not
support $format format segment")
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added
validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r342403995
##
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##
@@ -120,9 +120,16 @@ object CarbonStore {
(-1L, -1L)
}
} else {
-// for batch segment, we can get the data size from table status
file directly
-(if (load.getDataSize == null) -1L else load.getDataSize.toLong,
- if (load.getIndexSize == null) -1L else load.getIndexSize.toLong)
+// If the added segment is other than carbon segment then we can
only display the
+// data size and not index size and for batch segment, we can get
the data size
+// from table status file directly
+if (!load.getFileFormat.equals(FileFormat.COLUMNAR_V3) &&
+!load.getFileFormat.equals(FileFormat.ROW_V1)) {
+ (if (load.getIndexSize == null) -1L else
load.getIndexSize.toLong, -1L)
Review comment:
and please add testcase to check data size and index size by `show segment`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added
validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r342403849
##
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##
@@ -120,9 +120,16 @@ object CarbonStore {
(-1L, -1L)
}
} else {
-// for batch segment, we can get the data size from table status
file directly
-(if (load.getDataSize == null) -1L else load.getDataSize.toLong,
- if (load.getIndexSize == null) -1L else load.getIndexSize.toLong)
+// If the added segment is other than carbon segment then we can
only display the
+// data size and not index size and for batch segment, we can get
the data size
+// from table status file directly
+if (!load.getFileFormat.equals(FileFormat.COLUMNAR_V3) &&
+!load.getFileFormat.equals(FileFormat.ROW_V1)) {
+ (if (load.getIndexSize == null) -1L else
load.getIndexSize.toLong, -1L)
Review comment:
but here you are getting index size also from table status file, and not
getting the data size
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added
validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r342403701
##
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##
@@ -120,9 +120,16 @@ object CarbonStore {
(-1L, -1L)
}
} else {
-// for batch segment, we can get the data size from table status
file directly
-(if (load.getDataSize == null) -1L else load.getDataSize.toLong,
- if (load.getIndexSize == null) -1L else load.getIndexSize.toLong)
+// If the added segment is other than carbon segment then we can
only display the
+// data size and not index size and for batch segment, we can get
the data size
Review comment:
```suggestion
// data size and not index size, we can get the data size
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
jackylk commented on a change in pull request #3432: [CARBONDATA-3567] Added
validation for compacting mixed format segments
URL: https://github.com/apache/carbondata/pull/3432#discussion_r342402861
##
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##
@@ -120,9 +120,16 @@ object CarbonStore {
(-1L, -1L)
}
} else {
-// for batch segment, we can get the data size from table status
file directly
-(if (load.getDataSize == null) -1L else load.getDataSize.toLong,
- if (load.getIndexSize == null) -1L else load.getIndexSize.toLong)
+// If the added segment is other than carbon segment then we can
only display the
+// data size and not index size and for batch segment, we can get
the data size
+// from table status file directly
+if (!load.getFileFormat.equals(FileFormat.COLUMNAR_V3) &&
Review comment:
please add a utility function in FileFormat to check whether it is carbon
format
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (CARBONDATA-3542) Support Map data type reading through Hive
[ https://issues.apache.org/jira/browse/CARBONDATA-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3542. -- Fix Version/s: 2.0.0 Resolution: Fixed > Support Map data type reading through Hive > -- > > Key: CARBONDATA-3542 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3542 > Project: CarbonData > Issue Type: Improvement >Reporter: dhatchayani >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 5h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] jackylk commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
jackylk commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549686543 please modify PR description, please tell what is the current behavior before fix and what is the new behavior This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3407: [CARBONDATA-3542] Support Map data type reading through Hive
asfgit closed pull request #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
jackylk commented on a change in pull request #3426: [CARBONDATA-3560] Fixed
issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r342401597
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##
@@ -92,6 +92,23 @@ case class CarbonAddLoadCommand(
val segmentPath = options.getOrElse(
"path", throw new UnsupportedOperationException("PATH is manadatory"))
+val allSegments =
SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+// If a path is already added then we should block the adding of the same
path again.
+allSegments.exists { a =>
+ a.getPath != null && a.getPath.equalsIgnoreCase(segmentPath)
+ throw new AnalysisException(s"Cannot add the segment. This path is
already in use by " +
+ s"another segment.")
+}
+
+val format = options.getOrElse("format", "carbondata")
+val isCarbonFormat = format.equalsIgnoreCase("carbondata") ||
format.equalsIgnoreCase("carbon")
+
+// If in the given location no carbon files are found then we can throw an
exception
+if (isCarbonFormat &&
SegmentFileStore.getListOfCarbonIndexFiles(segmentPath).isEmpty) {
Review comment:
If we need to check this, better to check weather index file and data file
are matching:
1. If it has merge index file, all data file should be present in merge
index file
2. otherwise, one index file for one data file should present
please move this validation to another function and invoke it here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
jackylk commented on a change in pull request #3426: [CARBONDATA-3560] Fixed
issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r342401041
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##
@@ -92,6 +92,24 @@ case class CarbonAddLoadCommand(
val segmentPath = options.getOrElse(
"path", throw new UnsupportedOperationException("PATH is manadatory"))
+val allSegments =
SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+// If a path is already added then we should block the adding of the same
path again.
+if (allSegments.exists(a =>
+ a.getPath != null && a.getPath.equalsIgnoreCase(segmentPath)
+)) {
+ throw new AnalysisException(s"Cannot add the segment. This path is
already in use by " +
+ s"another segment.")
+}
+
+val format = options.getOrElse("format", "carbondata")
+val isCarbonFormat = format.equalsIgnoreCase("carbondata") ||
format.equalsIgnoreCase("carbon")
+
+// If in the given location no carbon files are found then we can throw an
exception
Review comment:
```suggestion
// If in the given location no carbon index files are found then we
should throw an exception
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
jackylk commented on a change in pull request #3426: [CARBONDATA-3560] Fixed
issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r342400922
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##
@@ -92,6 +92,24 @@ case class CarbonAddLoadCommand(
val segmentPath = options.getOrElse(
"path", throw new UnsupportedOperationException("PATH is manadatory"))
+val allSegments =
SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+// If a path is already added then we should block the adding of the same
path again.
+if (allSegments.exists(a =>
+ a.getPath != null && a.getPath.equalsIgnoreCase(segmentPath)
+)) {
+ throw new AnalysisException(s"Cannot add the segment. This path is
already in use by " +
Review comment:
change message to `path already exists in table status file, can not add
same segment path repeatedly: $path`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (CARBONDATA-3569) spark ui open exception
tianyou created CARBONDATA-3569: --- Summary: spark ui open exception Key: CARBONDATA-3569 URL: https://issues.apache.org/jira/browse/CARBONDATA-3569 Project: CarbonData Issue Type: Improvement Components: build Affects Versions: 1.6.1 Reporter: tianyou Spark 2.3.2 jars contains related packages of javax, and the carbondata package references another javax, which causes an exception in sparkui. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549683534 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/752/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549683007 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/750/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment
CarbonDataQA commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment URL: https://github.com/apache/carbondata/pull/3427#issuecomment-549682676 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/751/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment
CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment URL: https://github.com/apache/carbondata/pull/3426#issuecomment-549682057 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/746/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549681498 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/750/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-54968 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/749/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] manishnalla1994 commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
manishnalla1994 commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549671059 @ravipesala Please check and review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560]
Fixed issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r342388739
##
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##
@@ -92,6 +92,23 @@ case class CarbonAddLoadCommand(
val segmentPath = options.getOrElse(
"path", throw new UnsupportedOperationException("PATH is manadatory"))
+val allSegments =
SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+// If a path is already added then we should block the adding of the same
path again.
+allSegments.exists { a =>
+ a.getPath != null && a.getPath.equalsIgnoreCase(segmentPath)
+ throw new AnalysisException(s"Cannot add the segment. This path is
already in use by " +
+ s"another segment.")
+}
+
+val format = options.getOrElse("format", "carbondata")
+val isCarbonFormat = format.equalsIgnoreCase("carbondata") ||
format.equalsIgnoreCase("carbon")
+
+// If in the given location no carbon files are found then we can throw an
exception
+if (isCarbonFormat &&
SegmentFileStore.getListOfCarbonIndexFiles(segmentPath).isEmpty) {
Review comment:
@ravipesala Here we are just checking the presence of carbon files present
in the current folder location and as there was a 'isCarbonFormat' below so I
just shifted it above and used it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment
CarbonDataQA commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment URL: https://github.com/apache/carbondata/pull/3427#issuecomment-549667295 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/745/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549666406 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/744/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule
CarbonDataQA commented on issue #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override annotation location rule URL: https://github.com/apache/carbondata/pull/3434#issuecomment-549666427 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/742/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] kumarvishal09 commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat
kumarvishal09 commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433#issuecomment-549666042 @ajantha-bhat pls change the wip This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] kumarvishal09 commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
kumarvishal09 commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549665806 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] brijoobopanna commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
brijoobopanna commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549652032 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] lamber-ken opened a new pull request #3434: [CARBONDATA-3568] optimize java code checkstyle for @Override rule
lamber-ken opened a new pull request #3434: [CARBONDATA-3568] optimize java
code checkstyle for @Override rule
URL: https://github.com/apache/carbondata/pull/3434
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed? NO
- [x] Any backward compatibility impacted? NO
- [x] Document update required? NO
- [x] Testing done YES
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA. NO
`@Override` should at one line in java code file. for a bad example
```
@Override public int hashCode() {
int result = order;
result = 31 * result + (dataMap != null ? dataMap.hashCode() : 0);
return result;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ajantha-bhat edited a comment on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat
ajantha-bhat edited a comment on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433#issuecomment-549620409 @ravipesala @QiangCai please check This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat
ajantha-bhat commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433#issuecomment-549620409 @ravipesala@caiqing please check This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549565545 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/748/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549561935 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/749/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549549091 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/741/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549512038 Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/747/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549511831 Build Failed with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/748/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549476129 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/746/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549475943 Build Failed with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/747/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat
CarbonDataQA commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433#issuecomment-549464526 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/746/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549463225 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/745/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549462658 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/745/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat
CarbonDataQA commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433#issuecomment-549461215 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/744/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549447950 Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/739/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat
CarbonDataQA commented on issue #3433: [WIP] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433#issuecomment-549428478 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/737/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549428366 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/738/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549423868 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/743/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549418244 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/733/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549416944 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/744/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment
CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment URL: https://github.com/apache/carbondata/pull/3426#issuecomment-549416082 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/742/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549415460 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/737/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549414527 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/739/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549414052 Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/736/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat opened a new pull request #3433: [WIP] Change task number to jobid+taskid for FileFormat
ajantha-bhat opened a new pull request #3433: [WIP] Change task number to jobid+taskid for FileFormat URL: https://github.com/apache/carbondata/pull/3433 [WIP] Incase of file format, task retry is having different task number, so file name is becoming different. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement
CarbonDataQA commented on issue #3375: [CARBONDATA-3512]Index Server Enhancement URL: https://github.com/apache/carbondata/pull/3375#issuecomment-549381307 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/736/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (CARBONDATA-3568) optimize java code checkstyle for @Override rule
[
https://issues.apache.org/jira/browse/CARBONDATA-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966689#comment-16966689
]
lamber-ken commented on CARBONDATA-3568:
hi, [~rabikumar.kc], you are welcome. May be it's better that you can work for
other checkstyle rules, like
* AvoidStarImport
* LeftCurly
* SimplifyBooleanExpression
* EmptyLineSeparator
* WhitespaceAfter
* NoWhitespaceAfter
* NoWhitespaceBefore
* OperatorWrap
you can follow these steps to contribute to Carbondata project.
[http://carbondata.apache.org/how-to-contribute-to-apache-carbondata.html]
> optimize java code checkstyle for @Override rule
>
>
> Key: CARBONDATA-3568
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3568
> Project: CarbonData
> Issue Type: Improvement
> Components: core, flink-integration, hadoop-integration,
> presto-integration
>Affects Versions: 1.6.1
>Reporter: lamber-ken
>Priority: Major
> Fix For: 2.0.0
>
>
> @Override should at one line in java code file. for a bad example
> {code:java}
> @Override public int hashCode() {
> int result = order;
> result = 31 * result + (dataMap != null ? dataMap.hashCode() : 0);
> return result;
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (CARBONDATA-3525) Support MV for timeseries and Auto datamap load
[ https://issues.apache.org/jira/browse/CARBONDATA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal updated CARBONDATA-3525: Attachment: Time_series_v3.pdf > Support MV for timeseries and Auto datamap load > --- > > Key: CARBONDATA-3525 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3525 > Project: CarbonData > Issue Type: Bug >Reporter: Akash R Nilugal >Assignee: Akash R Nilugal >Priority: Major > Attachments: Time_series_v2.pdf, Time_series_v3.pdf > > > Timeseries data are simply measurements or events that are tracked,monitored, > downsampled, and aggregated over time.Basicallytimeseries data analysis helps > in analyzing or monitoring theaggregated data over period of time to take > better decision forbusiness.So since carbondata supports olap datamap like > preaggregate, MV and since time series is of atmost importance,we can > supporttimeseries for carbondata over MV datamap model. > Currentlycarbondata supports timeseries on preaggregate > datamap, but its an alpha feature and there are so many limitations when we > compare and analyze the existing timeseries database or projects which > supportstime series like apache druid or influxdb. So, in this feature we can > support timeseriesby avoiding the limitations in the current system. After > doing the analysis on the current existing timeseries database like influxdb, > and the apache druid,i have prepared a solution/design document. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CARBONDATA-3525) Support MV for timeseries and Auto datamap load
[ https://issues.apache.org/jira/browse/CARBONDATA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal updated CARBONDATA-3525: Attachment: (was: Time_series_v3.pdf) > Support MV for timeseries and Auto datamap load > --- > > Key: CARBONDATA-3525 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3525 > Project: CarbonData > Issue Type: Bug >Reporter: Akash R Nilugal >Assignee: Akash R Nilugal >Priority: Major > Attachments: Time_series_v2.pdf, Time_series_v3.pdf > > > Timeseries data are simply measurements or events that are tracked,monitored, > downsampled, and aggregated over time.Basicallytimeseries data analysis helps > in analyzing or monitoring theaggregated data over period of time to take > better decision forbusiness.So since carbondata supports olap datamap like > preaggregate, MV and since time series is of atmost importance,we can > supporttimeseries for carbondata over MV datamap model. > Currentlycarbondata supports timeseries on preaggregate > datamap, but its an alpha feature and there are so many limitations when we > compare and analyze the existing timeseries database or projects which > supportstime series like apache druid or influxdb. So, in this feature we can > support timeseriesby avoiding the limitations in the current system. After > doing the analysis on the current existing timeseries database like influxdb, > and the apache druid,i have prepared a solution/design document. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549365636 Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/742/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549365202 Build Failed with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/743/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
CarbonDataQA commented on issue #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432#issuecomment-549355615 Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/735/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549353575 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/741/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
CarbonDataQA commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549353161 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/741/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment
CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment URL: https://github.com/apache/carbondata/pull/3426#issuecomment-549352537 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/740/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (CARBONDATA-3568) optimize java code checkstyle for @Override rule
[
https://issues.apache.org/jira/browse/CARBONDATA-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966646#comment-16966646
]
Rabi Kumar K C commented on CARBONDATA-3568:
Hi [~lamber-ken] I am new to Carbondata and would like to contribute starting
with this ticket if it's okay with you. I have already subscribed to dev
mailing list for carbondata but it seems that I can't assign ticket to myself.
I would very much appreciate your help here if I can be added to contributor
list.
> optimize java code checkstyle for @Override rule
>
>
> Key: CARBONDATA-3568
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3568
> Project: CarbonData
> Issue Type: Improvement
> Components: core, flink-integration, hadoop-integration,
> presto-integration
>Affects Versions: 1.6.1
>Reporter: lamber-ken
>Priority: Major
> Fix For: 2.0.0
>
>
> @Override should at one line in java code file. for a bad example
> {code:java}
> @Override public int hashCode() {
> int result = order;
> result = 31 * result + (dataMap != null ? dataMap.hashCode() : 0);
> return result;
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (CARBONDATA-3568) optimize java code checkstyle for @Override rule
lamber-ken created CARBONDATA-3568:
--
Summary: optimize java code checkstyle for @Override rule
Key: CARBONDATA-3568
URL: https://issues.apache.org/jira/browse/CARBONDATA-3568
Project: CarbonData
Issue Type: Improvement
Components: core, flink-integration, hadoop-integration,
presto-integration
Affects Versions: 1.6.1
Reporter: lamber-ken
Fix For: 2.0.0
@Override should at one line in java code file. for a bad example
{code:java}
@Override public int hashCode() {
int result = order;
result = 31 * result + (dataMap != null ? dataMap.hashCode() : 0);
return result;
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [carbondata] manishnalla1994 opened a new pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments
manishnalla1994 opened a new pull request #3432: [CARBONDATA-3567] Added validation for compacting mixed format segments URL: https://github.com/apache/carbondata/pull/3432 1) Custom compaction with segment ids containing mixed format segments blocked. 2) Data-size and Index-size correctly displayed during show segments for external segments. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (CARBONDATA-3567) Added segment datasize and indexsize not correct and added mixed format segment compaction not correct
MANISH NALLA created CARBONDATA-3567: Summary: Added segment datasize and indexsize not correct and added mixed format segment compaction not correct Key: CARBONDATA-3567 URL: https://issues.apache.org/jira/browse/CARBONDATA-3567 Project: CarbonData Issue Type: Bug Reporter: MANISH NALLA -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment
CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment URL: https://github.com/apache/carbondata/pull/3426#issuecomment-549328150 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/734/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] manishnalla1994 commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment
manishnalla1994 commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment URL: https://github.com/apache/carbondata/pull/3427#issuecomment-549324115 @ravipesala when we add the same column then the column id will be different, so it wont match in our case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (CARBONDATA-3556) Add testcases for Insert into Complex data type of all Primitive types with 2 levels
[ https://issues.apache.org/jira/browse/CARBONDATA-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3556. - Fix Version/s: 2.0.0 Resolution: Fixed > Add testcases for Insert into Complex data type of all Primitive types with 2 > levels > > > Key: CARBONDATA-3556 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3556 > Project: CarbonData > Issue Type: Test >Reporter: Indhumathi Muthumurugesh >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Add testcases for Insert into Complex data type of all Primitive types with 2 > levels with CarbonSession and SparkFileFormat > Complex Data Type include, > # Struct > # Array > # Map -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] asfgit closed pull request #3384: [CARBONDATA-3556] Added testcases for Insert into Complex data type of all Primitive types with 2 levels
asfgit closed pull request #3384: [CARBONDATA-3556] Added testcases for Insert into Complex data type of all Primitive types with 2 levels URL: https://github.com/apache/carbondata/pull/3384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive
ajantha-bhat commented on issue #3407: [CARBONDATA-3542] Support Map data type reading through Hive URL: https://github.com/apache/carbondata/pull/3407#issuecomment-549316611 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549308262 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/740/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule
akashrn5 commented on issue #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule URL: https://github.com/apache/carbondata/pull/3429#issuecomment-549275221 @lamber-ken , since this PR also related to checkstyle, can you please map CARBONDATA-3563 to this PR and close CARBONDATA-3564 by mentioning in comment that it is mapped to other jira. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549275028 Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/732/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule
akashrn5 commented on a change in pull request #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule URL: https://github.com/apache/carbondata/pull/3429#discussion_r341954838 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -491,7 +491,7 @@ public static boolean updateSegmentFile(CarbonTable carbonTable, String segmentI LOGGER.error( "Not able to acquire the lock for Table status updation for table path " + tablePath); } - ; + Review comment: this new line is not required, please remove This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (CARBONDATA-3564) optimize java code checkstyle for EmptyStatement rule
[
https://issues.apache.org/jira/browse/CARBONDATA-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-3564.
--
Resolution: Fixed
> optimize java code checkstyle for EmptyStatement rule
> -
>
> Key: CARBONDATA-3564
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3564
> Project: CarbonData
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.6.0
>Reporter: lamber-ken
>Priority: Minor
> Fix For: 2.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Detects empty statements (standalone \{@code ";"} semicolon).
> Empty statements often introduce bugs that are hard to spot
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [carbondata] asfgit closed pull request #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule
asfgit closed pull request #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule URL: https://github.com/apache/carbondata/pull/3429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment
CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment URL: https://github.com/apache/carbondata/pull/3426#issuecomment-549258153 Build Failed with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/738/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule
jackylk commented on issue #3429: [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule URL: https://github.com/apache/carbondata/pull/3429#issuecomment-549257880 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment
CarbonDataQA commented on issue #3426: [CARBONDATA-3560] Fixed issues for Add Segment URL: https://github.com/apache/carbondata/pull/3426#issuecomment-549257944 Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/737/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (CARBONDATA-3563) optimize java code checkstyle for RedundantImport rule
[ https://issues.apache.org/jira/browse/CARBONDATA-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-3563. -- Resolution: Fixed > optimize java code checkstyle for RedundantImport rule > -- > > Key: CARBONDATA-3563 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3563 > Project: CarbonData > Issue Type: Improvement > Components: core, hadoop-integration >Affects Versions: 1.6.0 >Reporter: lamber-ken >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Checks for redundant import statements. An import statement is considered > redundant if: > * It is a duplicate of another import. > * The class non-statically imported is from the java.lang package, e.g. > importing java.lang.String. > * The class non-statically imported is from the same package as the current > package. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] asfgit closed pull request #3428: [CARBONDATA-3563] optimize java code checkstyle for RedundantImport rule
asfgit closed pull request #3428: [CARBONDATA-3563] optimize java code checkstyle for RedundantImport rule URL: https://github.com/apache/carbondata/pull/3428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3428: [CARBONDATA-3563] optimize java code checkstyle for RedundantImport rule
jackylk commented on issue #3428: [CARBONDATA-3563] optimize java code checkstyle for RedundantImport rule URL: https://github.com/apache/carbondata/pull/3428#issuecomment-549257365 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] ravipesala commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment
ravipesala commented on issue #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment URL: https://github.com/apache/carbondata/pull/3427#issuecomment-549253664 @manishnalla1994 I think this fix might induce new issues in alter table , like drop column and add back the column with the same name might not work as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table
CarbonDataQA commented on issue #3431: [CARBONDATA-3566] Support add segment for partition table URL: https://github.com/apache/carbondata/pull/3431#issuecomment-549252567 Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/731/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
