[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-742337441


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3372/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-742330700


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5134/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (CARBONDATA-4079) Queries with Date range are taking time

2020-12-09 Thread suyash yadav (Jira)

[ 
https://issues.apache.org/jira/browse/CARBONDATA-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247041#comment-17247041
 ] 

suyash yadav commented on CARBONDATA-4079:
--

Below are the complete background of the issue.

 

We created two tables named as fact_10days_data_ts and tags_final and below are 
the description of these two tables.

 

*Spark.sql("desc extended fact_timestamp_global").show(100,false)*

col_name |data_type 
   |comment|
+-+-+---+
|ts   |timestamp
    |null   |
|metric   |string   
    |null   |
|tags_id  |string   
    |null   |
|value    |double   
    |null   |
|ts2  |timestamp
    |null   |
| | 
    |   |
|## Detailed Table Information| 
    |   |
|Database |default  
    |   |
|Table    |fact_timestamp_global
    |   |
|Owner    |root 
    |   |
|Created  |Wed Dec 09 19:31:48 MYT 2020 
    |   |
|Location 
|hdfs://10.212.5.2:7200/Data/default/fact_timestamp_global|   |
|External |false
    |   |
|Transactional    |true 
    |   |
|Streaming    |false
    |   |
|Table Block Size |1024 MB  
    |   |
|Table Blocklet Size  |64 MB
    |   |
|Comment  | 
    |   |
|Bad Record Path  | 
    |   |
|Min Input Per Node Per Load  |0.0B 
    |   |
| | 
    |   |
|## Index Information | 
    |   |
|Sort Scope   |global_sort  
    |   |
|Sort Columns |ts, metric   
    |   |
|Inverted Index Columns   | 
    |   |
|Cached Min/Max Index Columns |All columns  
    |   |
|Min/Max Index Cache Level    |BLOCK
    |   |
|Table page size in mb    | 
    |   |
| | 
    |   |
|## Encoding Information  | 
    |   |
|Local Dictionary Enabled |true 
    |   |
|Local Dictionary Threshold   |1
    |   |
|Local Dictionary Include |metric,tags_id   
    |   |
| | 
    |   |
|## Compaction Information    | 
    |   |
|MAJOR_COMPACTION_SIZE    |1024 
    |   |
|AUTO_LOAD_MERGE  |false
    |   |
|COMPACTION_LEVEL_THRESHOLD   |4,3  
    |   |
|COMPACTION_PRESERVE_SEGMENTS |0
    |   |
|ALLOWED_COMPACTION_DAYS  |0
    |   |
| | 
    |   |
|## Partition Information | 
    |   |
|Partition Type   |NATIVE_HIVE  
    |   |
|Partition Columns    |ts2:TIMESTAMP  

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-09 Thread GitBox


Indhumathi27 commented on a change in pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#discussion_r539876147



##
File path: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/FileMergeSortComparator.java
##
@@ -78,49 +83,43 @@ public int compare(IntermediateSortTempRow rowA, 
IntermediateSortTempRow rowB) {
 int nonDictIndex = 0;
 int noDicTypeIdx = 0;
 int schemaRowIdx = 0;
-int sortIndex = 0;
 
-for (Map.Entry> schemaEntry : 
sortColumnSchemaOrderMap.entrySet()) {
-  boolean isSortColumn = schemaEntry.getValue().get(0);
-  boolean isDictColumn = schemaEntry.getValue().get(1);
-  if (isSortColumn) {
-if (isSortColumnNoDictionary[sortIndex++]) {
-  if (DataTypeUtil.isPrimitiveColumn(noDictDataTypes[noDicTypeIdx])) {
-// use data types based comparator for the no dictionary measure 
columns
-SerializableComparator comparator =
-org.apache.carbondata.core.util.comparator.Comparator
-.getComparator(noDictDataTypes[noDicTypeIdx]);
-int difference = comparator
-
.compare(rowA.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]],
-
rowB.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]]);
-schemaRowIdx++;
-if (difference != 0) {
-  return difference;
-}
-  } else {
-byte[] byteArr1 = (byte[]) rowA.getNoDictSortDims()[nonDictIndex];
-byte[] byteArr2 = (byte[]) rowB.getNoDictSortDims()[nonDictIndex];
-
-int difference = 
ByteUtil.UnsafeComparer.INSTANCE.compareTo(byteArr1, byteArr2);
-if (difference != 0) {
-  return difference;
-}
+for (boolean isNoDictionary : isSortColumnNoDictionary) {

Review comment:
   yes. Removed it





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] kunal642 commented on a change in pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


kunal642 commented on a change in pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#discussion_r539864844



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/segmentreading/TestSegmentReading.scala
##
@@ -420,4 +421,40 @@ class TestSegmentReading extends QueryTest with 
BeforeAndAfterAll {
 
 sql("set spark.sql.adaptive.enabled=false")
   }
+
+  test("Read marked for delete segments") {
+sql("drop table if exists carbonTable")
+sql(
+  "create table carbonTable(a string, b int, c string) stored as 
carbondata tblproperties" +
+  "('carbon.clean.file.force.allowed' = true)")
+sql("insert into carbonTable values ('k',1,'k'), ('k',1,'b')")
+sql("insert into carbonTable values ('a',2,'a')")
+sql("insert into carbonTable values ('b',2,'b'),('b',2,'b')")
+sql("insert into carbonTable values ('c',2,'c')")
+
+sql("delete from table carbonTable where segment.id in (0,3)")
+sql("set carbon.input.segments.default.carbonTable = 0,2,3")
+sql("show segments for table carbonTable").show()

Review comment:
   please remove this 

##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/segmentreading/TestSegmentReading.scala
##
@@ -420,4 +421,40 @@ class TestSegmentReading extends QueryTest with 
BeforeAndAfterAll {
 
 sql("set spark.sql.adaptive.enabled=false")
   }
+
+  test("Read marked for delete segments") {
+sql("drop table if exists carbonTable")
+sql(
+  "create table carbonTable(a string, b int, c string) stored as 
carbondata tblproperties" +
+  "('carbon.clean.file.force.allowed' = true)")
+sql("insert into carbonTable values ('k',1,'k'), ('k',1,'b')")
+sql("insert into carbonTable values ('a',2,'a')")
+sql("insert into carbonTable values ('b',2,'b'),('b',2,'b')")
+sql("insert into carbonTable values ('c',2,'c')")
+
+sql("delete from table carbonTable where segment.id in (0,3)")
+sql("set carbon.input.segments.default.carbonTable = 0,2,3")
+sql("show segments for table carbonTable").show()
+
+checkAnswer(sql("select count(*) from carbonTable"), Seq(Row(2)))
+
+  }
+
+  test("Test compacted segments") {
+sql("drop table if exists carbonTable")
+sql(
+  "create table carbonTable(a string, b int, c string) stored as 
carbondata tblproperties" +
+  "('carbon.clean.file.force.allowed' = true)")
+sql("insert into carbonTable values ('k',1,'k'), ('k',1,'b')")
+sql("insert into carbonTable values ('a',2,'a')")
+sql("insert into carbonTable values ('b',2,'b'),('b',2,'b')")
+sql("insert into carbonTable values ('c',2,'c')")
+sql("alter table carbonTable compact 'major'")
+
+sql("set carbon.input.segments.default.carbonTable = 0,1,2,3,0.1")
+sql("show segments for table carbonTable").show()

Review comment:
   please remove this





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] kunal642 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


kunal642 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742258819


   @akashrn5 Please check whether this fix will be ok for SI and MV.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] kunal642 commented on a change in pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator

2020-12-09 Thread GitBox


kunal642 commented on a change in pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#discussion_r539852924



##
File path: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/FileMergeSortComparator.java
##
@@ -78,49 +83,43 @@ public int compare(IntermediateSortTempRow rowA, 
IntermediateSortTempRow rowB) {
 int nonDictIndex = 0;
 int noDicTypeIdx = 0;
 int schemaRowIdx = 0;
-int sortIndex = 0;
 
-for (Map.Entry> schemaEntry : 
sortColumnSchemaOrderMap.entrySet()) {
-  boolean isSortColumn = schemaEntry.getValue().get(0);
-  boolean isDictColumn = schemaEntry.getValue().get(1);
-  if (isSortColumn) {
-if (isSortColumnNoDictionary[sortIndex++]) {
-  if (DataTypeUtil.isPrimitiveColumn(noDictDataTypes[noDicTypeIdx])) {
-// use data types based comparator for the no dictionary measure 
columns
-SerializableComparator comparator =
-org.apache.carbondata.core.util.comparator.Comparator
-.getComparator(noDictDataTypes[noDicTypeIdx]);
-int difference = comparator
-
.compare(rowA.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]],
-
rowB.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]]);
-schemaRowIdx++;
-if (difference != 0) {
-  return difference;
-}
-  } else {
-byte[] byteArr1 = (byte[]) rowA.getNoDictSortDims()[nonDictIndex];
-byte[] byteArr2 = (byte[]) rowB.getNoDictSortDims()[nonDictIndex];
-
-int difference = 
ByteUtil.UnsafeComparer.INSTANCE.compareTo(byteArr1, byteArr2);
-if (difference != 0) {
-  return difference;
-}
+for (boolean isNoDictionary : isSortColumnNoDictionary) {

Review comment:
   i think now "isSortColumnNoDictionary" is not needed as dict and noDict 
Order mappings are kept separately. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

2020-12-09 Thread GitBox


Indhumathi27 commented on a change in pull request #4042:
URL: https://github.com/apache/carbondata/pull/4042#discussion_r539851556



##
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##
@@ -916,6 +930,19 @@ object AlterTableUtil {
 }
   }
 }
+// should not be present in index tables
+val indexTables = CarbonIndexUtil.getSecondaryIndexes(carbonTable)

Review comment:
   Instead of getting from index table, can directly get the index Column 
names from carbonTable.getIndexesMap.get(IndexType.SI.getIndexProviderName) -> 
CarbonCommonConstants.INDEX_COLUMNS

##
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##
@@ -450,14 +451,27 @@ object AlterTableUtil {
   // validate long string columns
   val longStringColumns = 
lowerCasePropertiesMap.get("long_string_columns");
   if (longStringColumns.isDefined) {
-validateLongStringColumns(longStringColumns.get, carbonTable)
+validateLongStringColumns(longStringColumns.get, carbonTable, 
sparkSession)
 // update schema for long string columns
 updateSchemaForLongStringColumns(thriftTable, longStringColumns.get)
   } else if (propKeys.exists(_.equalsIgnoreCase("long_string_columns") && 
!set)) {
 if (tblPropertiesMap.exists(prop => 
prop._1.equalsIgnoreCase("long_string_columns"))) {
   updateSchemaForLongStringColumns(thriftTable, "")
 }
   }
+  // validate set for streaming table
+  val streamingOption = lowerCasePropertiesMap.get("streaming")
+  if (streamingOption.isDefined && set) {
+if (carbonTable.isIndexTable) {
+  throw new UnsupportedOperationException("Set streaming table is " +
+"not allowed for index table.")

Review comment:
   ```suggestion
   "not allowed on the index table.")
   ```

##
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##
@@ -916,6 +930,19 @@ object AlterTableUtil {
 }
   }
 }
+// should not be present in index tables
+val indexTables = CarbonIndexUtil.getSecondaryIndexes(carbonTable)
+if (!indexTables.isEmpty) {
+  indexTables.asScala.map(indexTable => {
+CarbonEnv.getCarbonTable(Some(carbonTable.getDatabaseName), 
indexTable)(sparkSession)
+  .getCreateOrderColumn.asScala.map(column => {
+  if (longStringCols.contains(column.getColName)) {
+throw new MalformedCarbonCommandException(s"col 
${column.getColName} is " +

Review comment:
   Can change to, "Cannot Alter column 'b' to Long_string_column, as the 
column exists in a secondary index with name `indexTable`.  LONG_STRING_COLUMNS 
is not allowed on secondary index."





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Zhangshunyu closed pull request #4040: [WIP][CI TEST]

2020-12-09 Thread GitBox


Zhangshunyu closed pull request #4040:
URL: https://github.com/apache/carbondata/pull/4040


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742082179


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3371/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742081476


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5133/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akkio-97 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


akkio-97 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742016131


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742011060


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5132/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (CARBONDATA-4079) Queries with Date range are taking time

2020-12-09 Thread suyash yadav (Jira)
suyash yadav created CARBONDATA-4079:


 Summary: Queries with Date range are taking time
 Key: CARBONDATA-4079
 URL: https://issues.apache.org/jira/browse/CARBONDATA-4079
 Project: CarbonData
  Issue Type: Improvement
  Components: data-query
Affects Versions: 2.1.0
Reporter: suyash yadav


Hi Team,

We are doing a POC to understand how can we improve performance of the query 
fired against table created in apache carbondata.

Below is the sample query:

 

*spark.sql("select ts,resource,metric,value from fact_timestamp_global left 
join tags_10_Days_test on fact_timestamp_global.tags_id= tags_10_Days_test.id 
where metric in ('Outbound Utilization (percent)','Inbound Utilization 
(percent)') and resource='10.212.7.98_if:<0001>' and  ts between '2020-09-21 
00:00:00' and '2020-09-21 12:55:55' group by 
ts,resource,metric,value").show(1,false)*

As you can see above query contains the date range filter.We have noticed that 
due to this date range filter the query time is coming around 15 seconds which 
is not proving useful as we have to bring down the query execution time to 3 to 
4 seconds.

Could you please review above query and suggest a better way of framing the 
above query specially the date range filter which can be  helpful to get the 
desired query execution time?

 

In case you need more details then please do let me know. 

 

Regards

Suyash Yadav



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-741820892


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3368/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-741818543


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5130/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akkio-97 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


akkio-97 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-741815756


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-741809268


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5129/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-741807884


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3367/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4042:
URL: https://github.com/apache/carbondata/pull/4042#issuecomment-741758732


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3364/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4037:
URL: https://github.com/apache/carbondata/pull/4037#issuecomment-741755469


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5128/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4037:
URL: https://github.com/apache/carbondata/pull/4037#issuecomment-741754949


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3366/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4042:
URL: https://github.com/apache/carbondata/pull/4042#issuecomment-741747065


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5126/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-741712233


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3362/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050#issuecomment-741709860


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5124/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] nihal0107 closed pull request #4023: [CARBONDATA-4059] added testcase for custom compaction, compression and range column for SI table

2020-12-09 Thread GitBox


nihal0107 closed pull request #4023:
URL: https://github.com/apache/carbondata/pull/4023


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] nihal0107 closed pull request #4041: [CARBONDATA-4068] handled set long string on MT for column on which SI is already created.

2020-12-09 Thread GitBox


nihal0107 closed pull request #4041:
URL: https://github.com/apache/carbondata/pull/4041


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] handled set streaming for SI table or table having SI.

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4042:
URL: https://github.com/apache/carbondata/pull/4042#issuecomment-741694403


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5125/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akkio-97 opened a new pull request #4050: [WIP] select count marked for delete segments

2020-12-09 Thread GitBox


akkio-97 opened a new pull request #4050:
URL: https://github.com/apache/carbondata/pull/4050


### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [WIP] support prestosql 333

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-741640343


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3361/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [WIP] support prestosql 333

2020-12-09 Thread GitBox


CarbonDataQA2 commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-741638542


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5123/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org