[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-759274885


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5307/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (CARBONDATA-4106) Compaction is not working properly

2021-01-12 Thread suyash yadav (Jira)
suyash yadav created CARBONDATA-4106:


 Summary: Compaction is not working properly
 Key: CARBONDATA-4106
 URL: https://issues.apache.org/jira/browse/CARBONDATA-4106
 Project: CarbonData
  Issue Type: Improvement
  Components: core
Affects Versions: 2.0.1
 Environment: Apache spark 2.4.5, carbonData 2.0.1
Reporter: suyash yadav
 Fix For: 2.0.1
 Attachments: describe_fact_probe_1

Hi Team,

We are using apache carbondata 2.0.1 for one of our POC and we observed that we 
are not getting proper benifit from using compaction (Both majour and minor).

Please find below details for the issue we are facing:

*Name of the table used*:  fact_365_1_probe_1

+*Number of rows:*
+
select count(*) from fact_365_1_probe_1
 ++
 |count(1)|
 ++
 |76963753|

*Sample data from the table:*
==

+---+--++--+-+---+
 | ts| metric| tags_id| value| epoch| ts2|
 
+---+--++--+-+---+
 |2021-01-07 
21:05:00|Probe.Duplicate.Poll.Count|c8dead9b-87ae-46ae-8703-bc2b7bfba5d4|39.611356797970274|1610033757768|2021-01-07
 00:00:00|
 |2021-01-07 
23:50:00|Probe.Duplicate.Poll.Count|62351ef2-f2ce-49d1-a2fd-a0d1e5f6a1b9| 
72.70658115131307|1610043742516|2021-01-07 00:00:00|
 
[^describe_fact_probe_1]
 
I have attached  the describe output which will show you the other details of 
the table.

The size of the table is 3.24 GB and even after running minor or majour 
compaction the size remain almost the same.

So we re not getting any benifit by running the compaction.Could you please 
review the shared details and help us in identifying if we are missing 
something here or is there any bug?


Also we need answer to the following questions about carbondata storate:

1. In case of decimal values, how the storage behaves like if i have one row 
with 20 digits after decimal and second row has only 5 digits  after decimal so 
how and what would be the difference in the storage taken.



2. My second question is , if i have two tables and one of the table has same 
values for 100 rows and other table has different values for 100 rows so how 
carbon will behave as far as the storage is concerned in this scenario. WHich 
table will take less storage or both will take same storage.

3.Also for string datatype could you please describe what is the storage 
defined for string datatype.
 






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4070:
URL: https://github.com/apache/carbondata/pull/4070#issuecomment-759239290


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5306/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4070:
URL: https://github.com/apache/carbondata/pull/4070#issuecomment-759238242


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3546/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


ajantha-bhat commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-759234811







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-759233536


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3545/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-759232601


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5305/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-12 Thread GitBox


VenuReddy2103 commented on a change in pull request #4073:
URL: https://github.com/apache/carbondata/pull/4073#discussion_r556262687



##
File path: 
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala
##
@@ -325,4 +326,22 @@ class PrestoTestUsingSparkStore
 
   }
 
+  test("Test decimal unscaled converter") {
+prestoServer
+  .execute(
+"create table presto_spark_db.array_decimal(salary 
array(decimal(20,3)) ) with" +
+"(format='CARBON') ")
+copyStoreContents("array_decimal")
+val result: List[Map[String, Any]] = prestoServer
+  .executeQuery("SELECT * FROM presto_spark_db.array_decimal")
+assert(result.size == 1)
+for (i <- 0 to 0) {

Review comment:
   result size is only 1. Suggest to remove this redundant loop if not 
required.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-759197966


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3544/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#issuecomment-759197719


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5304/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-12 Thread GitBox


VenuReddy2103 commented on a change in pull request #4073:
URL: https://github.com/apache/carbondata/pull/4073#discussion_r556248112



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/SparkStoreCreatorForPresto.scala
##
@@ -365,6 +365,15 @@ class SparkStoreCreatorForPresto extends QueryTest with 
BeforeAndAfterAll{
 sql(s"""LOAD DATA LOCAL INPATH '$resourcesPath/IUD/dest.csv' INTO TABLE 
streaming_table""")
   }
 
+  test("Test decimal unscaled converter") {
+sql("drop table if exists array_decimal")
+sql(
+  "CREATE TABLE IF NOT EXISTS array_decimal (salary array) 
STORED AS " +
+  "carbondata"
+)
+sql("insert into array_decimal select array(922.580, 3.435) ")

Review comment:
   Didn't drop this table in `afterAll()` like other testcases do ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-12 Thread GitBox


VenuReddy2103 commented on a change in pull request #4073:
URL: https://github.com/apache/carbondata/pull/4073#discussion_r556246909



##
File path: 
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java
##
@@ -348,6 +368,32 @@ public void fillVector(Object valuesToBeConverted, int 
size,
 vector.putDecimal(i, value, precision);
   }
 }
+  } else if (valuesToBeConverted instanceof byte[]) {

Review comment:
   Shall we avoid this code and reuse ? Same as above.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

2021-01-12 Thread GitBox


VenuReddy2103 commented on a change in pull request #4073:
URL: https://github.com/apache/carbondata/pull/4073#discussion_r556246616



##
File path: 
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java
##
@@ -328,9 +328,29 @@ public BigDecimal getDecimal(Object valueToBeConverted) {
 public void fillVector(Object valuesToBeConverted, int size,
 ColumnVectorInfo vectorInfo, BitSet nullBitSet, DataType pageType) {
   CarbonColumnVector vector = getCarbonColumnVector(vectorInfo, 
nullBitSet);
-  //TODO handle complex child
-  int precision = vectorInfo.measure.getMeasure().getPrecision();
-  int newMeasureScale = vectorInfo.measure.getMeasure().getScale();
+  int precision;

Review comment:
   These changes seem to be same as in`DecimalIntConverter.fillVector()`. 
Shall we reuse it instead of duplicating same logic again here ? Probably 
`DecimalUnscaledConverter` can extend `DecimalIntConverter` and overide 
fillVector like below ?
   
   > public void fillVector(Object valuesToBeConverted, int size, 
ColumnVectorInfo vectorInfo, BitSet nullBitSet, DataType pageType) {
 if (valuesToBeConverted instanceof byte[][]) {
   ...
 } else {
   super.fillVector(valuesToBeConverted, size, vectorInfo, nullBitSet, 
pageType);
 }
   }





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


ajantha-bhat commented on a change in pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#discussion_r556232882



##
File path: 
integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbonDataMetaData.java
##
@@ -73,18 +74,27 @@
   private MapredCarbonOutputCommitter carbonOutputCommitter;
   private JobContextImpl jobContext;
 
-  public CarbonDataMetaData(SemiTransactionalHiveMetastore metastore,
-  HdfsEnvironment hdfsEnvironment, HivePartitionManager partitionManager, 
DateTimeZone timeZone,
-  boolean allowCorruptWritesForTesting, boolean 
writesToNonManagedTablesEnabled,
-  boolean createsOfNonManagedTablesEnabled, TypeManager typeManager,
+  public CarbonDataMetaData(
+  CatalogName catalogName,
+  SemiTransactionalHiveMetastore metastore,
+  HdfsEnvironment hdfsEnvironment,
+  HivePartitionManager partitionManager,
+  DateTimeZone timeZone,
+  boolean allowCorruptWritesForTesting,
+  boolean writesToNonManagedTablesEnabled,
+  boolean createsOfNonManagedTablesEnabled,
+  boolean translateHiveViews, TypeManager typeManager,
   LocationService locationService,
-  io.airlift.json.JsonCodec partitionUpdateCodec,
-  TypeTranslator typeTranslator, String prestoVersion,
-  HiveStatisticsProvider hiveStatisticsProvider, AccessControlMetadata 
accessControlMetadata) {
-super(metastore, hdfsEnvironment, partitionManager, timeZone, 
allowCorruptWritesForTesting,
-true, createsOfNonManagedTablesEnabled, typeManager,
-locationService, partitionUpdateCodec, typeTranslator, prestoVersion,
-hiveStatisticsProvider, accessControlMetadata);
+  JsonCodec partitionUpdateCodec,
+  TypeTranslator typeTranslator,
+  String prestoVersion,
+  HiveStatisticsProvider hiveStatisticsProvider,
+  AccessControlMetadata accessControlMetadata) {
+super(catalogName, metastore, hdfsEnvironment, partitionManager, timeZone,
+allowCorruptWritesForTesting, writesToNonManagedTablesEnabled,

Review comment:
   I reverted back to writesToNonManagedTablesEnabled instead of hardcoded 
true value as cluster test is passed after reverting also.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


ajantha-bhat commented on a change in pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#discussion_r556232657



##
File path: 
integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbonMetadataFactory.java
##
@@ -18,37 +18,43 @@
 package org.apache.carbondata.presto;
 
 import java.util.Objects;
+import java.util.Optional;
 import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
 
 import com.google.inject.Inject;
 import io.airlift.concurrent.BoundedExecutor;
 import io.airlift.json.JsonCodec;
 import io.airlift.log.Logger;
-import io.prestosql.plugin.hive.ForHive;
+import io.airlift.units.Duration;
+import io.prestosql.plugin.base.CatalogName;
+import io.prestosql.plugin.hive.ForHiveTransactionHeartbeats;
 import io.prestosql.plugin.hive.HdfsEnvironment;
 import io.prestosql.plugin.hive.HiveConfig;
-import io.prestosql.plugin.hive.HiveMetadata;
 import io.prestosql.plugin.hive.HiveMetadataFactory;
+import io.prestosql.plugin.hive.HiveMetastoreClosure;
 import io.prestosql.plugin.hive.HivePartitionManager;
 import io.prestosql.plugin.hive.LocationService;
 import io.prestosql.plugin.hive.NodeVersion;
 import io.prestosql.plugin.hive.PartitionUpdate;
+import io.prestosql.plugin.hive.TransactionalMetadata;
 import io.prestosql.plugin.hive.TypeTranslator;
-import io.prestosql.plugin.hive.metastore.CachingHiveMetastore;
 import io.prestosql.plugin.hive.metastore.HiveMetastore;
 import io.prestosql.plugin.hive.metastore.SemiTransactionalHiveMetastore;
 import io.prestosql.plugin.hive.security.AccessControlMetadataFactory;
 import io.prestosql.plugin.hive.statistics.MetastoreHiveStatisticsProvider;
 import io.prestosql.spi.type.TypeManager;
 import org.joda.time.DateTimeZone;
 
+import static 
io.prestosql.plugin.hive.metastore.cache.CachingHiveMetastore.memoizeMetastore;
+
 public class CarbonMetadataFactory extends HiveMetadataFactory {
 
   private static final Logger log = Logger.get(HiveMetadataFactory.class);
   private final boolean allowCorruptWritesForTesting;
   private final boolean skipDeletionForAlter;
   private final boolean skipTargetCleanupOnRollback;
-  private final boolean writesToNonManagedTablesEnabled = true;
+  private final boolean writesToNonManagedTablesEnabled;

Review comment:
   yes, cluster it works fine without hardcoding 
writesToNonManagedTablesEnabled = true





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

2021-01-12 Thread GitBox


ajantha-bhat commented on a change in pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#discussion_r556215178



##
File path: 
integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbonDataMetaData.java
##
@@ -73,18 +74,27 @@
   private MapredCarbonOutputCommitter carbonOutputCommitter;
   private JobContextImpl jobContext;
 
-  public CarbonDataMetaData(SemiTransactionalHiveMetastore metastore,
-  HdfsEnvironment hdfsEnvironment, HivePartitionManager partitionManager, 
DateTimeZone timeZone,
-  boolean allowCorruptWritesForTesting, boolean 
writesToNonManagedTablesEnabled,
-  boolean createsOfNonManagedTablesEnabled, TypeManager typeManager,
+  public CarbonDataMetaData(
+  CatalogName catalogName,
+  SemiTransactionalHiveMetastore metastore,
+  HdfsEnvironment hdfsEnvironment,
+  HivePartitionManager partitionManager,
+  DateTimeZone timeZone,
+  boolean allowCorruptWritesForTesting,
+  boolean writesToNonManagedTablesEnabled,
+  boolean createsOfNonManagedTablesEnabled,
+  boolean translateHiveViews, TypeManager typeManager,
   LocationService locationService,
-  io.airlift.json.JsonCodec partitionUpdateCodec,
-  TypeTranslator typeTranslator, String prestoVersion,
-  HiveStatisticsProvider hiveStatisticsProvider, AccessControlMetadata 
accessControlMetadata) {
-super(metastore, hdfsEnvironment, partitionManager, timeZone, 
allowCorruptWritesForTesting,
-true, createsOfNonManagedTablesEnabled, typeManager,
-locationService, partitionUpdateCodec, typeTranslator, prestoVersion,
-hiveStatisticsProvider, accessControlMetadata);
+  JsonCodec partitionUpdateCodec,
+  TypeTranslator typeTranslator,
+  String prestoVersion,
+  HiveStatisticsProvider hiveStatisticsProvider,
+  AccessControlMetadata accessControlMetadata) {
+super(catalogName, metastore, hdfsEnvironment, partitionManager, timeZone,
+allowCorruptWritesForTesting, writesToNonManagedTablesEnabled,

Review comment:
   Insert has passed now.
   
   presto:aj333> select * from t1;
name
   --
aj
ab
   (2 rows)
   
   Query 20210113_015933_5_6sfgc, FINISHED, 1 node
   Splits: 18 total, 18 done (100.00%)
   0:04 [2 rows, 22B] [0 rows/s, 5B/s]
   
   presto:aj333> insert into t1 values('junk');
   INSERT: 1 row
   
   Query 20210113_015940_6_6sfgc, FINISHED, 1 node
   Splits: 35 total, 35 done (100.00%)
   0:04 [0 rows, 0B] [0 rows/s, 0B/s]
   
   presto:aj333> select * from t1;
name
   --
junk
aj
ab
   (3 rows)
   
   Query 20210113_015951_7_6sfgc, FINISHED, 1 node
   Splits: 19 total, 19 done (100.00%)
   0:00 [3 rows, 35B] [11 rows/s, 137B/s]
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [WIP] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4076:
URL: https://github.com/apache/carbondata/pull/4076#issuecomment-758578862


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3543/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [WIP] Added mvExists property for MV fact table and added lock while touchMDTFile

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4076:
URL: https://github.com/apache/carbondata/pull/4076#issuecomment-758577309


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5303/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4075: [CARBONDATA-4105]Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4075:
URL: https://github.com/apache/carbondata/pull/4075#issuecomment-758565119


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3542/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4075: [CARBONDATA-4105]Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4075:
URL: https://github.com/apache/carbondata/pull/4075#issuecomment-758564733


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5302/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4072: [WIP] Clean files phase2

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4072:
URL: https://github.com/apache/carbondata/pull/4072#issuecomment-758545921


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3540/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4072: [WIP] Clean files phase2

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4072:
URL: https://github.com/apache/carbondata/pull/4072#issuecomment-758540797


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5300/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Karan980 commented on pull request #4075: [CARBONDATA-4105]Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-12 Thread GitBox


Karan980 commented on pull request #4075:
URL: https://github.com/apache/carbondata/pull/4075#issuecomment-758510889


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [WIP] Added mvExists property in MV fact table and lock while touchMDTFile

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4076:
URL: https://github.com/apache/carbondata/pull/4076#issuecomment-758502714


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5301/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [WIP] Added mvExists property in MV fact table and lock while touchMDTFile

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4076:
URL: https://github.com/apache/carbondata/pull/4076#issuecomment-758502058


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3541/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 opened a new pull request #4076: [WIP] Added mvExists property in MV fact table and lock while touchMDTFile

2021-01-12 Thread GitBox


Indhumathi27 opened a new pull request #4076:
URL: https://github.com/apache/carbondata/pull/4076


### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4075: [CARBONDATA-4105]Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4075:
URL: https://github.com/apache/carbondata/pull/4075#issuecomment-758497035


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3538/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4075: [CARBONDATA-4105]Select * query fails after a SDK written segment is added by alter table add segment query.

2021-01-12 Thread GitBox


CarbonDataQA2 commented on pull request #4075:
URL: https://github.com/apache/carbondata/pull/4075#issuecomment-758496406


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5298/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org