Kejian-Li commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495712828
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/DDLHelper.scala
##########
@@ -230,14 +231,22 @@ object DDLHelper {
.toLowerCase,
values,
isColumnRename)
+ var newColumnComment: Option[String] = Option.empty
+ if (changeColumnCommand.newColumn.metadata != null &&
+
changeColumnCommand.newColumn.metadata.contains(CarbonCommonConstants.COLUMN_COMMENT))
{
+ newColumnComment = Some(changeColumnCommand.
+ newColumn.metadata.getString(CarbonCommonConstants.COLUMN_COMMENT))
+ }
Review comment:
there is already a varibale "newColumn" that can be used above, or it
is better to make "changeColumnCommand.newColumn.metadata" as a variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
