[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700697188


   
   
   
   
   > @Kejian-Li i can just see the test file changes and no source file changes 
for the issue which you described. So im confused what exactly or how exactly 
the problem is solved. can you please explain?
   
   My idea and implementation is not considerable, so I just removed the 
relative code concurrency
   
   > @Kejian-Li i can just see the test file changes and no source file changes 
for the issue which you described. So im confused what exactly or how exactly 
the problem is solved. can you please explain?
   
   My idea and implementation is not considerable, I will explain this later.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456


   @ajantha-bhat @akashrn5 please help review this PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699871798


   > better to focus on the topic in this PR.
   
   Got it, I will follow your suggestion



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699796397


   @QiangCai please help review this PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-27 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699751466


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-27 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699594833


   @Zhangshunyu please help review this PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-26 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699578575


   > Consider a scenario that the user want to insert data and then update the 
table, the dml commands are sent one by one in time series, but the 2nd(update) 
cmd is sent by another driver and start to execute while the 1st(insert) is 
still running, therefore the concurrency scenario described in this PR appears.
   > If we allow update table who has segment with status 'INSERT_INPROGRESS', 
the 2nd cmd(update) will execute successfully and the data inserted by the 1st 
cmd would not updated by the 2nd cmd.
   > In this case, the result may not be what the user expected.
   
   you are right



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-25 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-698910832


   > Consider a scenario that the user want to insert data and then update the 
table, the dml commands are sent one by one in time series, but the 2nd(update) 
cmd is sent by another driver and start to execute while the 1st(insert) is 
still running, therefore the concurrency scenario described in this PR appears.
   > If we allow update table who has segment with status 'INSERT_INPROGRESS', 
the 2nd cmd(update) will execute successfully and the data inserted by the 1st 
cmd would not updated by the 2nd cmd.
   > In this case, the result may not be what the user expected.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-25 Thread GitBox 


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-698910832


   > Consider a scenario that the user want to insert data and then update the 
table, the dml commands are sent one by one in time series, but the 2nd(update) 
cmd is sent by another driver and start to execute while the 1st(insert) is 
still running, therefore the concurrency scenario described in this PR appears.
   > If we allow update table who has segment with status 'INSERT_INPROGRESS', 
the 2nd cmd(update) will execute successfully and the data inserted by the 1st 
cmd would not updated by the 2nd cmd.
   > In this case, the result may not be what the user expected.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org